6da1dfb7 | 09-Jan-2020 |
Nishad Kamdar <nishadkamdar@gmail.com> |
slimbus: Use the correct style for SPDX License Identifier
This patch corrects the SPDX License Identifier style in header file related to SLIMbus driver. For C header files Documentation/process/li
slimbus: Use the correct style for SPDX License Identifier
This patch corrects the SPDX License Identifier style in header file related to SLIMbus driver. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used).
Changes made by using a script provided by Joe Perches here: https://lkml.org/lkml/2019/2/7/46.
Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Link: https://lore.kernel.org/r/20200109103148.5612-4-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
fcaf3d93 | 18-Aug-2019 |
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
slimbus: fix slim_tid_txn()
fix below issue reported by coccicheck ./drivers/slimbus/slimbus.h:440:3-46: duplicated argument to && or ||
Looks like this was a typo, SLIM_MSG_MC_REQUEST_CHANGE_VALUE
slimbus: fix slim_tid_txn()
fix below issue reported by coccicheck ./drivers/slimbus/slimbus.h:440:3-46: duplicated argument to && or ||
Looks like this was a typo, SLIM_MSG_MC_REQUEST_CHANGE_VALUE is command which requires transaction ID, so fix it, this also fix the warning.
Reported-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Link: https://lore.kernel.org/r/20190818093902.29993-3-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
1a044213 | 20-Jun-2019 |
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
slimbus: core: generate uevent for non-dt only
Rely on MODULE_ALIAS() for automatic kernel module loading, rather than basing it on the OF compatible. This ensures that drivers without of_device_id
slimbus: core: generate uevent for non-dt only
Rely on MODULE_ALIAS() for automatic kernel module loading, rather than basing it on the OF compatible. This ensures that drivers without of_device_id table, such as wcd9335, will be automatically loaded.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> [bjorn: Added commit message] Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
8147760d | 14-Jan-2019 |
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
slimbus: core: add missing spin_lock_init on txn_lock
Add missing spin lock intialization this also fixes the spinlock bad magic warning.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@lin
slimbus: core: add missing spin_lock_init on txn_lock
Add missing spin lock intialization this also fixes the spinlock bad magic warning.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
380c6246 | 14-Jan-2019 |
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
slimbus: core: use slim_device_update_status() to update status
use slim_device_update_status() instead of directly calling the device_status() callback. Move slim_device_update_status() before prob
slimbus: core: use slim_device_update_status() to update status
use slim_device_update_status() instead of directly calling the device_status() callback. Move slim_device_update_status() before probe to avoid forward declaration too.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
cfb32101 | 14-Jan-2019 |
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
slimbus: core: do not call device_status under a lock
Calling device_status callback under a lock would prevent drivers to do any slimbus trasactions which would invoke this lock like get_laddr(). R
slimbus: core: do not call device_status under a lock
Calling device_status callback under a lock would prevent drivers to do any slimbus trasactions which would invoke this lock like get_laddr(). Remove this unnecessary lock!
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
649ad116 | 30-Nov-2018 |
Colin Ian King <colin.king@canonical.com> |
slimbus: ngd: fix spelling mistake "exeeds" -> "exceeds"
There is a spelling mistake in a dev_err message, fix this.
Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Srinivas
slimbus: ngd: fix spelling mistake "exeeds" -> "exceeds"
There is a spelling mistake in a dev_err message, fix this.
Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
5323ac51 | 12-Nov-2018 |
Niklas Cassel <niklas.cassel@linaro.org> |
slimbus: ngd: QCOM_QMI_HELPERS has to be selected
QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is to select it, not depend upon it.
Because of this change, we now also need to depend o
slimbus: ngd: QCOM_QMI_HELPERS has to be selected
QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is to select it, not depend upon it.
Because of this change, we now also need to depend on the same Kconfigs as QCOM_QMI_HELPERS depends on.
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
9e663f48 | 16-Sep-2018 |
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
slimbus: core: add support to uevent
This patch adds support to uevent to help automatic module loading.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroa
slimbus: core: add support to uevent
This patch adds support to uevent to help automatic module loading.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
8f3d5fcd | 16-Sep-2018 |
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
slimbus: core: update device status in probe
device status update can be racy with probe in some cases, so make sure it take lock during the probe. Also after probe the device is expected to be read
slimbus: core: update device status in probe
device status update can be racy with probe in some cases, so make sure it take lock during the probe. Also after probe the device is expected to be ready for communications, so make sure that a logical address can be assigned to it after probe. If it fails to do so then probe defer such instances.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
14a649d3 | 16-Sep-2018 |
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
slimbus: core: match device tree based devices correctly
device_id for device tree based devices come from dt compatible string, such drivers need not provide non dt style device id table.
Match th
slimbus: core: match device tree based devices correctly
device_id for device tree based devices come from dt compatible string, such drivers need not provide non dt style device id table.
Match those device using compatible strings.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
0e321f19 | 16-Sep-2018 |
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
slimbus: ngd: validate logical address assigned by remote
Validate logical address assigned by remote, in failure cases this value is all zeors.
Signed-off-by: Srinivas Kandagatla <srinivas.kandaga
slimbus: ngd: validate logical address assigned by remote
Validate logical address assigned by remote, in failure cases this value is all zeors.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
94fe5f2b | 16-Sep-2018 |
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
silmbus: ngd: register controller after power up.
Register slimbus controller only after finishing powerup sequnce so that we do not endup in situation where core starts sending transactions before
silmbus: ngd: register controller after power up.
Register slimbus controller only after finishing powerup sequnce so that we do not endup in situation where core starts sending transactions before the controller is ready.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
9652e6aa | 16-Sep-2018 |
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
slimbus: ngd: return proper error code instead of zero
It looks like there is a typo in probe return. Fix it.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg
slimbus: ngd: return proper error code instead of zero
It looks like there is a typo in probe return. Fix it.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|