.gitignore: prefix local generated files with a slashThe pattern prefixed with '/' matches files in the same directory,but not ones in sub-directories.Signed-off-by: Masahiro Yamada <masahiroy@k
.gitignore: prefix local generated files with a slashThe pattern prefixed with '/' matches files in the same directory,but not ones in sub-directories.Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>Acked-by: Miguel Ojeda <ojeda@kernel.org>Acked-by: Rob Herring <robh@kernel.org>Acked-by: Andra Paraschiv <andraprs@amazon.com>Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>Acked-by: Gabriel Krisman Bertazi <krisman@collabora.com>
show more ...
kbuild: introduce hostprogs-always-y and userprogs-always-yTo build host programs, you need to add the program names to 'hostprogs'to use the necessary build rule, but it is not enough to build th
kbuild: introduce hostprogs-always-y and userprogs-always-yTo build host programs, you need to add the program names to 'hostprogs'to use the necessary build rule, but it is not enough to build thembecause there is no dependency.There are two types of host programs: built as the prerequisite ofanother (e.g. gen_crc32table in lib/Makefile), or always built whenKbuild visits the Makefile (e.g. genksyms in scripts/genksyms/Makefile).The latter is typical in Makefiles under scripts/, which contains hostprograms globally used during the kernel build. To build them, you needto add them to both 'hostprogs' and 'always-y'.This commit adds hostprogs-always-y as a shorthand.The same applies to user programs. net/bpfilter/Makefile buildsbpfilter_umh on demand, hence always-y is unneeded. In contrast,programs under samples/ are added to both 'userprogs' and 'always-y'so they are always built when Kbuild visits the Makefiles.userprogs-always-y works as a shorthand.Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
samples: connector: build sample program for target architectureThis userspace program includes UAPI headers exported to usr/include/.'make headers' always works for the target architecture (i.e.
samples: connector: build sample program for target architectureThis userspace program includes UAPI headers exported to usr/include/.'make headers' always works for the target architecture (i.e. the samearchitecture as the kernel), so the sample program should be built forthe target as well. Kbuild now supports 'userprogs' for that.$(CC) can always compile cn_text.o since it is the kenrel-space code,but building ucon requires libc.I guarded it by: always-$(CONFIG_CC_CAN_LINK) := $(userprogs)Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>Acked-by: Sam Ravnborg <sam@ravnborg.org>
.gitignore: add SPDX License IdentifierAdd SPDX License Identifier to all .gitignore files.Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfou
.gitignore: add SPDX License IdentifierAdd SPDX License Identifier to all .gitignore files.Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kbuild: rename hostprogs-y/always to hostprogs/always-yIn old days, the "host-progs" syntax was used for specifying hostprograms. It was renamed to the current "hostprogs-y" in 2004.It is typica
kbuild: rename hostprogs-y/always to hostprogs/always-yIn old days, the "host-progs" syntax was used for specifying hostprograms. It was renamed to the current "hostprogs-y" in 2004.It is typically useful in scripts/Makefile because it allows Kbuild toselectively compile host programs based on the kernel configuration.This commit renames like follows: always -> always-y hostprogs-y -> hostprogsSo, scripts/Makefile will look like this: always-$(CONFIG_BUILD_BIN2C) += ... always-$(CONFIG_KALLSYMS) += ... ... hostprogs := $(always-y) $(always-m)I think this makes more sense because a host program is always a hostprogram, irrespective of the kernel configuration. We want to specifywhich ones to compile by CONFIG options, so always-y will be handier.The "always", "hostprogs-y", "hostprogs-m" will be kept for backwardcompatibility for a while.Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of th
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program if not write to the free software foundation inc 59 temple place suite 330 boston ma 02111 1307 usaextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 1334 file(s).Signed-off-by: Thomas Gleixner <tglx@linutronix.de>Reviewed-by: Allison Randal <allison@lohutok.net>Reviewed-by: Richard Fontana <rfontana@redhat.com>Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190527070033.113240726@linutronix.deSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kbuild: announce removal of SUBDIRS if usedSUBDIRS has been kept as a backward compatibility sincecommit ("[PATCH] kbuild: external module support") in 2002.We do not need multiple ways to do th
kbuild: announce removal of SUBDIRS if usedSUBDIRS has been kept as a backward compatibility sincecommit ("[PATCH] kbuild: external module support") in 2002.We do not need multiple ways to do the same thing, so I will removeSUBDIRS after the Linux 5.3 release. I cleaned up in-tree code, andupdated the document so that nobody would try to use it.Meanwhile, display the following warning if SUBDIRS is used.Makefile:189: ================= WARNING ================Makefile:190: 'SUBDIRS' will be removed after Linux 5.3Makefile:191: Please use 'M=' or 'KBUILD_EXTMOD' insteadMakefile:192: ==========================================Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>Acked-by: Boris Brezillon <boris.brezillon@bootlin.com> # for scx200_docflash.cAcked-by: Guenter Roeck <linux@roeck-us.net> # for scx200_wdt.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine
License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>Reviewed-by: Thomas Gleixner <tglx@linutronix.de>Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
samples: Convert timers to use timer_setup()In preparation for unconditionally passing the struct timer_list pointer toall timer callbacks, switch to using the new timer_setup() and from_timer()t
samples: Convert timers to use timer_setup()In preparation for unconditionally passing the struct timer_list pointer toall timer callbacks, switch to using the new timer_setup() and from_timer()to pass the timer pointer explicitly.Signed-off-by: Kees Cook <keescook@chromium.org>Signed-off-by: Jonathan Corbet <corbet@lwn.net>
make use of make variable CURDIR instead of calling pwdmake already provides the current working directory in a variable, so makeuse of it instead of forking a shell. Also replace usage of PWD by
make use of make variable CURDIR instead of calling pwdmake already provides the current working directory in a variable, so makeuse of it instead of forking a shell. Also replace usage of PWD byCURDIR. PWD is provided by most shells, but not all, so this makes thebuild system more robust.Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>Signed-off-by: Michal Marek <mmarek@suse.com>
samples: connector: from Documentation to samples directoryA small bug with the new autoksyms support showed that there aretwo kernel modules in the Documentation directory that qualifyas samples
samples: connector: from Documentation to samples directoryA small bug with the new autoksyms support showed that there aretwo kernel modules in the Documentation directory that qualifyas samples, while all other samples are in the samples/ directory.This patch was originally meant as a workaround for that bug, butit has now been solved in a different way. However, I still thinkit makes sense as a cleanup to consolidate all sample code inone place.Signed-off-by: Arnd Bergmann <arnd@arndb.de>Signed-off-by: Jonathan Corbet <corbet@lwn.net>