c1dc0a1d | 18-Sep-2023 |
Alexey Kardashevskiy <aik@ozlabs.ru> |
pseries: Update SLOF firmware image
It's been a while. This fixes compile warning, typos and a bug with virtio-serial being used after it was shutdown at "quiesce".
The full changelog is here:
Ale
pseries: Update SLOF firmware image
It's been a while. This fixes compile warning, typos and a bug with virtio-serial being used after it was shutdown at "quiesce".
The full changelog is here:
Alexey Kardashevskiy (2): Remove ?PICK version: update to 20230918
Jordan Niethe (1): virtio-serial: Do not close stdout on quiesce
Kautuk Consul (1): virtio-serial: Make read and write methods report failure
Thomas Huth (10): lib/libnet/ipv6: Silence compiler warning from Clang Fix typos in the board-qemu folder Fix typos in the lib/libnet folder Fix typos in the remaining lib folders Fix typos in the slof folder Fix typos in the board-js2x folder Fix typos in the llfw folder Fix typos in the board-js2x folder Fix typos in the clients folder Fix remaining typos in various folders
Compiled with gcc-12.1.0-nolibc
Tested with (sorry, no KVM):
/home/aik/b/q-slof/qemu-system-ppc64 \ -nodefaults \ -chardev stdio,id=STDIO0,signal=off,mux=on \ -device spapr-vty,id=svty0,reg=0x71000110,chardev=STDIO0 \ -mon id=MON0,chardev=STDIO0,mode=readline \ -nographic \ -vga none \ -m 2G \ -kernel /home/aik/t/vml4150le \ -initrd /home/aik/t/le.cpio \ -machine pseries,cap-cfpc=broken,cap-sbbc=broken,cap-ibs=broken,cap-ccf-assist=off \ -bios pc-bios/slof.bin \ -trace events=/home/aik/qemu_trace_events \ -d guest_errors \ -chardev socket,id=SOCKET0,server=on,wait=off,path=qemu.mon.604650 \ -mon chardev=SOCKET0,mode=control \ -name 604650,debug-threads=on
[ npiggin: Also tested with KVM, including with virtio-console. ]
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
show more ...
|
35ed01ba | 26-Sep-2023 |
Fabiano Rosas <farosas@suse.de> |
optionrom: Remove build-id section
Our linker script for optionroms specifies only the placement of the .text section, leaving the linker free to place the remaining sections at arbitrary places in
optionrom: Remove build-id section
Our linker script for optionroms specifies only the placement of the .text section, leaving the linker free to place the remaining sections at arbitrary places in the file.
Since at least binutils 2.39, the .note.gnu.build-id section is now being placed at the start of the file, which causes label addresses to be shifted. For linuxboot_dma.bin that means that the PnP header (among others) will not be found when determining the type of ROM at optionrom_setup():
(0x1c is the label _pnph, where the magic "PnP" is)
$ xxd /usr/share/qemu/linuxboot_dma.bin | grep "PnP" 00000010: 0000 0000 0000 0000 0000 1c00 2450 6e50 ............$PnP
$ xxd pc-bios/optionrom/linuxboot_dma.bin | grep "PnP" 00000010: 0000 0000 0000 0000 0000 4c00 2450 6e50 ............$PnP ^bad
Using a freshly built linuxboot_dma.bin ROM results in a broken boot:
SeaBIOS (version rel-1.16.2-0-gea1b7a073390-prebuilt.qemu.org) Booting from Hard Disk... Boot failed: could not read the boot disk
Booting from Floppy... Boot failed: could not read the boot disk
No bootable device.
We're not using the build-id section, so pass the --build-id=none option to the linker to remove it entirely.
Note: In theory, this same issue could happen with any other section. The ideal solution would be to have all unused sections discarded in the linker script. However that would be a larger change, specially for the pvh rom which uses the .bss and COMMON sections so I'm addressing only the immediate issue here.
Reported-by: Vasiliy Ulyanov <vulyanov@suse.de> Signed-off-by: Fabiano Rosas <farosas@suse.de> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-ID: <20230926192502.15986-1-farosas@suse.de> Cc: stable@vger.kernel.org Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
show more ...
|