use PDI constants for ObjectMapper

PDI already defines the constants we need here, use those instead of
duplicating.

Tested: Inspection only.

Change-Id: I86ad46a4aac757aa7b377b1e1709088a1e457102
S

use PDI constants for ObjectMapper

PDI already defines the constants we need here, use those instead of
duplicating.

Tested: Inspection only.

Change-Id: I86ad46a4aac757aa7b377b1e1709088a1e457102
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

nvidia-oem: Implement GetRedfishServiceUUID

This command is used by BIOS before creating SMBIOS record
type 42. BIOS gets USBDescription information from BMC.

Note:
The implementation in this PR is

nvidia-oem: Implement GetRedfishServiceUUID

This command is used by BIOS before creating SMBIOS record
type 42. BIOS gets USBDescription information from BMC.

Note:
The implementation in this PR is for
RedfishServiceUUID.
The support for other device descriptors will be added in
upcoming PRs.

Design Document for RHI:
[1] https://gerrit.openbmc.org/c/openbmc/docs/+/79327

Redfish Host Interface specification:
[2] https://www.dmtf.org/sites/default/files/standards/documents/DSP0270_1.3.0.pdf

Tested:
Tested on gb200nvl-obmc platform:
root@gb200nvl-obmc:~# ipmitool raw 0x3c 0x34
1b 78 70 31 20 74 e1 4e 98 13 6b 22 a7 34 7a d0

[3] root@gb200nvl-obmc:~# find / -type f -name "bmcweb_persistent_data.json" 2>/dev/null
/home/root/bmcweb_persistent_data.json
[4] /run/initramfs/rw/cow/home/root/bmcweb_persistent_data.json

Change-Id: Ibfd1b1aa654ad4f523362ca973fd2c6c6b0f18c3
Signed-off-by: Prithvi Pai <ppai@nvidia.com>

show more ...

ipmi_net_fns will be removed in the future

Since ipmi_net_fns has been replaced by NetFn in api-types.hpp, this
commit is marked and removed on December 31, 2025.

Change-Id: I059f96e4fc18f638df6050

ipmi_net_fns will be removed in the future

Since ipmi_net_fns has been replaced by NetFn in api-types.hpp, this
commit is marked and removed on December 31, 2025.

Change-Id: I059f96e4fc18f638df6050c8a28b75dfec44d3fa
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

clang-tidy: fix some warnings

Resolve the following:
```
sys_info_param.cpp:12:11: style: Variable 'callback' can be declared as reference to const [constVariableReference]
auto& callback = iter

clang-tidy: fix some warnings

Resolve the following:
```
sys_info_param.cpp:12:11: style: Variable 'callback' can be declared as reference to const [constVariableReference]
auto& callback = iterator->second;
^
include/ipmid/sessionhelper.hpp:49:31: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
sessionIdString = sessionIdString.substr(0, pos);
^
include/ipmid/sessionhelper.hpp:36:14: style: The scope of the variable 'tempSessionHandle' can be reduced. [variableScope]
uint16_t tempSessionHandle = 0;
^
include/ipmid/sessionhelper.hpp:77:47: performance: Function parameter 'objectPath' should be passed by const reference. [passedByValue]
bool isSessionObjectMatched(const std::string objectPath,
^
include/ipmid/sessionhelper.hpp:50:31: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
sessionIdString = sessionIdString.substr(0, pos);
^
transport/serialbridge/test/serial_unittest.cpp:21:13: style: The scope of the variable 'c' can be reduced. [variableScope]
uint8_t c;
^
```

Change-Id: I5a34fc50a95c33367e8b5d67dcb94c46b8def94a
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

Remove deprecated methods

These methods are no longer used and have been marked as `deprecated`
until 2025-03-30 [1]. This commit removes these methods.

[1]: https://github.com/openbmc/phosphor-hos

Remove deprecated methods

These methods are no longer used and have been marked as `deprecated`
until 2025-03-30 [1]. This commit removes these methods.

[1]: https://github.com/openbmc/phosphor-host-ipmid/commit/3c1e28e45f7e0b2d5961cd9d2627a5db926dcef9

Change-Id: I47cb37484b29c27250aa6bb3ceafe9b7176dd34d
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

api: remove ipmid_get_sd_event_connection

The ipmid_get_sd_event_connection method is no longer used, this
commit removes it.

Change-Id: I6b2fae45407a9d175321f8107c83c1955ac63373
Signed-off-by: Geo

api: remove ipmid_get_sd_event_connection

The ipmid_get_sd_event_connection method is no longer used, this
commit removes it.

Change-Id: I6b2fae45407a9d175321f8107c83c1955ac63373
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

api: remove IPMI_CC_LEN

IPMI_CC_LEN is no longer used, this commit removes it.

Change-Id: I5656dbcf4d177c08607792deb1683610c50d8b8b
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

SBMR Get/Send Boot Progress Code support

Implement IPMI commands for boot progress codes by following
DEN0069E_SBMR_2.1. Add configure option `arm-sbmr` to enable
SBMR IPMI commands. Boot progress c

SBMR Get/Send Boot Progress Code support

Implement IPMI commands for boot progress codes by following
DEN0069E_SBMR_2.1. Add configure option `arm-sbmr` to enable
SBMR IPMI commands. Boot progress code will update to Redfish
BootProgress property.

1. Send boot progress code (NetFn 0x2C, Command 0x2)
2. Get boot progress code (NetFn 0x2C, Command 0x3)

Test:

1. Send boot progress code
$> ipmitool raw 0x2C 0x02 0xAE 0x1 0x00 0x00 0x00 \
0x01 0x10 0x01 0x02 0x00
ae

2. Get boot progress code
$> ipmitool raw 0x2C 0x3 0xAE
ae 01 00 00 00 01 10 01 02 00

3. Redfish BootProgess LastState - /redfish/v1/Systems/system
{
...
"BootProgress": {
"LastState": "PCIResourceConfigStarted",
"LastStateTime": "2024-11-14T19:14:22.432272+00:00"
}
}

Signed-off-by: John Chung <john.chung@arm.com>
Change-Id: I58e6e322006039fceb8d4212c4f9f6a4b4f9e225

show more ...

Added asynchronous callDbusMethod

This path added two callDbusMethod methods, one without method return
value (default return ec), and the other with method return value.

Change-Id: I16503fe24adc0f

Added asynchronous callDbusMethod

This path added two callDbusMethod methods, one without method return
value (default return ec), and the other with method return value.

Change-Id: I16503fe24adc0f3896a861972751d532b6361ef9
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

Fix include path for message.hpp

This resolves the below compilation error related to the missing
message.hpp file during full build.

'''
usr/include/ipmid/message/pack.hpp:18:10: fatal error: incl

Fix include path for message.hpp

This resolves the below compilation error related to the missing
message.hpp file during full build.

'''
usr/include/ipmid/message/pack.hpp:18:10: fatal error: include/ipmid/message.hpp:
No such file or directory
'''

Updated the include directive to use the correct relative path for
message.hpp

Change-Id: Ice8a60a7030448ce75f0fa255ded9117beb1a71f
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: fix use of undeclared identifier error

This commit resolves the clang-diagnostic-error related to
missing identifiers by ensuring all necessary header files
are included in the same sour

clang-tidy: fix use of undeclared identifier error

This commit resolves the clang-diagnostic-error related to
missing identifiers by ensuring all necessary header files
are included in the same source file.

Also Correct undeclared identifier 'cmdWildcard' to
'ipmi::cmdWildcard'

Change-Id: Ic818af97557c7bc74b7fc9478315fe181a9a4cfc
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

clang-tidy: Replace NULL with nullptr

Replaced all instances of NULL with nullptr to improve type safety
and clarity, as nullptr is the modern C++ standard for null pointers.

Tested: Build verified

Change-Id: Ia40d9435ab57651ec6d13d5408cf69130043fa79
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ic23653be3ed404980fd0e723d9ed8354e2b32579
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ic23653be3ed404980fd0e723d9ed8354e2b32579
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

app: remove IPMI_CMD_WILDCARD

cmdWildcard is already declared in api-types.hpp, this commit remove
IPMI_CMD_WILDCARD in app.hpp.

Change-Id: Ic1d944f012022e702a1e5a0aef7a039249684fa2
Signed-off-by:

app: remove IPMI_CMD_WILDCARD

cmdWildcard is already declared in api-types.hpp, this commit remove
IPMI_CMD_WILDCARD in app.hpp.

Change-Id: Ic1d944f012022e702a1e5a0aef7a039249684fa2
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

Revert "drop sdevents hack"

This reverts commit d2dd5bc2eddc73504734112c0d6f745202b1b3a0.

The commit was inadvertently merged upstream.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-I

Revert "drop sdevents hack"

This reverts commit d2dd5bc2eddc73504734112c0d6f745202b1b3a0.

The commit was inadvertently merged upstream.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icf03e2ca476271b4606500846593e36fe326f3c5

show more ...

drop sdevents hack

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I04833cc2a39c032a4d9c29079ee92fdf24c89245

sensorhandler: Support NonRecoverable in getSensorThresholds method

There are actually three types of threshold interfaces (Warning,
Critical, and NonRecoverable). This patch supports the NonRecover

sensorhandler: Support NonRecoverable in getSensorThresholds method

There are actually three types of threshold interfaces (Warning,
Critical, and NonRecoverable). This patch supports the NonRecoverable
interface in the getSensorThresholds method.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ie9a7ff44b4e58702c5522a308d8128fcfb1161ef

show more ...

ipmid: switch to lg2

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I838587b2d564f3c00b78ce37e175d7e8ace51142

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I01547e98d27910919e09ebf7907c86292a6c825d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

utils: Unused methods are marked as deprecated

The getAllAncestors and deleteAllDbusObjects methods in utils.hpp are
not used and are not used in the reops. This commit marks these
methods as deprec

utils: Unused methods are marked as deprecated

The getAllAncestors and deleteAllDbusObjects methods in utils.hpp are
not used and are not used in the reops. This commit marks these
methods as deprecated marked for removal after 2025-03-30 unless
disputed.

Tested: ipmitool works fine with this patch.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Icd53a9effc53c12b5db05b90b75c3addf6c02d5b

show more ...

utils: Add the getSubTree method

The purpose of this patch is to prevent other methods from calling
ObjectMapper's `GetSubTree` property, but to obtain the correct the
objectTree values by calling t

utils: Add the getSubTree method

The purpose of this patch is to prevent other methods from calling
ObjectMapper's `GetSubTree` property, but to obtain the correct the
objectTree values by calling the standard the getSubTree method.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ia719f92ca31fa75f83a7ffd07fdcb680bd4243b0

show more ...

Update terminology used within repo

Update the terms to more inclusive language. This change if only for
variables used in the repo.

Change-Id: I5151c9c2efab707b5dbc707e55333a3cb8c4e32b
Signed-off-

Update terminology used within repo

Update the terms to more inclusive language. This change if only for
variables used in the repo.

Change-Id: I5151c9c2efab707b5dbc707e55333a3cb8c4e32b
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

unpack: Support std::span as package arguments

Change-Id: Iae594c0d1b10e96dd4fd1a83cdf60c0757f9f3bd
Signed-off-by: Willy Tu <wltu@google.com>

types: Support allocator rebinding

Avoid build failures with libc++ like:
include/c++/v1/vector:407:19: error: static assertion failed due to requirement 'is_same<ipmi::SecureAllocator<unsigned char

types: Support allocator rebinding

Avoid build failures with libc++ like:
include/c++/v1/vector:407:19: error: static assertion failed due to requirement 'is_same<ipmi::SecureAllocator<unsigned char>, std::allocator<unsigned char>>::value': [allocator.requirements] states that rebinding an allocator to the same type should result in the original allocator
407 | static_assert(is_same<allocator_type, __rebind_alloc<__alloc_traits, value_type> >::value,

Change-Id: I6f9637e2177669dce3509243135135a1b73fa9fe
Signed-off-by: Peter Foley <pefoley@google.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ic5fd073faa7391d3f0b37787d6a9c7688c9a3253
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...