| 93aa983e | 07-Nov-2025 |
Alexander Hansen <alexander.hansen@9elements.com> |
use PDI constants for ObjectMapper
PDI already defines the constants we need here, use those instead of duplicating.
Tested: Inspection only.
Change-Id: I86ad46a4aac757aa7b377b1e1709088a1e457102 S
use PDI constants for ObjectMapper
PDI already defines the constants we need here, use those instead of duplicating.
Tested: Inspection only.
Change-Id: I86ad46a4aac757aa7b377b1e1709088a1e457102 Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>
show more ...
|
| 42247d2c | 18-Aug-2025 |
George Liu <liuxiwei@ieisystem.com> |
sensorhanlder: Struct properties use camelCase
Change-Id: Ib76451f5b967ad342875bf000e8ce20599d35a1e Signed-off-by: George Liu <liuxiwei@ieisystem.com> |
| c7a4da5e | 19-Aug-2025 |
George Liu <liuxiwei@ieisystem.com> |
sdr: Use registerHandler instead of ipmi_register_callback
Since ipmi_register_callback declared in api.h has been gradually deprecated, this submission is to use registerHandler instead of ipmi_reg
sdr: Use registerHandler instead of ipmi_register_callback
Since ipmi_register_callback declared in api.h has been gradually deprecated, this submission is to use registerHandler instead of ipmi_register_callback.
Change-Id: I0adfcd6c0e41daafe2d81918a527925997f96585 Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
| c1e7b5c3 | 01-Sep-2025 |
Prithvi Pai <ppai@nvidia.com> |
nvidia-oem: Implement GetRedfishServiceUUID
This command is used by BIOS before creating SMBIOS record type 42. BIOS gets USBDescription information from BMC.
Note: The implementation in this PR is
nvidia-oem: Implement GetRedfishServiceUUID
This command is used by BIOS before creating SMBIOS record type 42. BIOS gets USBDescription information from BMC.
Note: The implementation in this PR is for RedfishServiceUUID. The support for other device descriptors will be added in upcoming PRs.
Design Document for RHI: [1] https://gerrit.openbmc.org/c/openbmc/docs/+/79327
Redfish Host Interface specification: [2] https://www.dmtf.org/sites/default/files/standards/documents/DSP0270_1.3.0.pdf
Tested: Tested on gb200nvl-obmc platform: root@gb200nvl-obmc:~# ipmitool raw 0x3c 0x34 1b 78 70 31 20 74 e1 4e 98 13 6b 22 a7 34 7a d0
[3] root@gb200nvl-obmc:~# find / -type f -name "bmcweb_persistent_data.json" 2>/dev/null /home/root/bmcweb_persistent_data.json [4] /run/initramfs/rw/cow/home/root/bmcweb_persistent_data.json
Change-Id: Ibfd1b1aa654ad4f523362ca973fd2c6c6b0f18c3 Signed-off-by: Prithvi Pai <ppai@nvidia.com>
show more ...
|
| c024b39d | 21-Aug-2025 |
George Liu <liuxiwei@ieisystem.com> |
Replace boost starts_with/ends_with with std::string
C++20 introduces std::string::starts_with and std::string::ends_with, which provide standard, efficient, and header-light ways to check string pr
Replace boost starts_with/ends_with with std::string
C++20 introduces std::string::starts_with and std::string::ends_with, which provide standard, efficient, and header-light ways to check string prefixes and suffixes. Replacing boost::algorithm::starts_with and boost::algorithm::ends_with reduces Boost dependencies, simplifies includes, and improves compilation performance.
Change-Id: I611ccb49a174dcd5433c1001cf1750907dd023ac Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
| e58eb308 | 02-Jul-2025 |
George Liu <liuxiwei@ieisystem.com> |
ipmi_net_fns will be removed in the future
Since ipmi_net_fns has been replaced by NetFn in api-types.hpp, this commit is marked and removed on December 31, 2025.
Change-Id: I059f96e4fc18f638df6050
ipmi_net_fns will be removed in the future
Since ipmi_net_fns has been replaced by NetFn in api-types.hpp, this commit is marked and removed on December 31, 2025.
Change-Id: I059f96e4fc18f638df6050c8a28b75dfec44d3fa Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
| 23c868c5 | 03-Jul-2025 |
George Liu <liuxiwei@ieisystem.com> |
remove ipmi_ret_t
Since ipmi_ret_t declared in api.h has been gradually deprecated, this submission will use ipmi::Cc in api.hpp instead.
Change-Id: I0f6ad7a6ffe7d35f76145acff04e8e0ae4d45685 Signed
remove ipmi_ret_t
Since ipmi_ret_t declared in api.h has been gradually deprecated, this submission will use ipmi::Cc in api.hpp instead.
Change-Id: I0f6ad7a6ffe7d35f76145acff04e8e0ae4d45685 Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
| 041b3758 | 14-Jul-2025 |
Haicheng Zhang <zhanghch05@ieisystem.com> |
sdr: Convert std::cerr to lg2
Change-Id: Ided5ac23f9b5a93e09928b324a5fc95ba689e874 Signed-off-by: Haicheng Zhang <zhanghch05@ieisystem.com> |
| c0d01c87 | 08-Jul-2025 |
George Liu <liuxiwei@ieisystem.com> |
clang-tidy: fix some warnings
Resolve the following: ``` sys_info_param.cpp:12:11: style: Variable 'callback' can be declared as reference to const [constVariableReference] auto& callback = iter
clang-tidy: fix some warnings
Resolve the following: ``` sys_info_param.cpp:12:11: style: Variable 'callback' can be declared as reference to const [constVariableReference] auto& callback = iterator->second; ^ include/ipmid/sessionhelper.hpp:49:31: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] sessionIdString = sessionIdString.substr(0, pos); ^ include/ipmid/sessionhelper.hpp:36:14: style: The scope of the variable 'tempSessionHandle' can be reduced. [variableScope] uint16_t tempSessionHandle = 0; ^ include/ipmid/sessionhelper.hpp:77:47: performance: Function parameter 'objectPath' should be passed by const reference. [passedByValue] bool isSessionObjectMatched(const std::string objectPath, ^ include/ipmid/sessionhelper.hpp:50:31: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] sessionIdString = sessionIdString.substr(0, pos); ^ transport/serialbridge/test/serial_unittest.cpp:21:13: style: The scope of the variable 'c' can be reduced. [variableScope] uint8_t c; ^ ```
Change-Id: I5a34fc50a95c33367e8b5d67dcb94c46b8def94a Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
| 99556a1f | 03-Jul-2025 |
George Liu <liuxiwei@ieisystem.com> |
Remove deprecated methods
These methods are no longer used and have been marked as `deprecated` until 2025-03-30 [1]. This commit removes these methods.
[1]: https://github.com/openbmc/phosphor-hos
Remove deprecated methods
These methods are no longer used and have been marked as `deprecated` until 2025-03-30 [1]. This commit removes these methods.
[1]: https://github.com/openbmc/phosphor-host-ipmid/commit/3c1e28e45f7e0b2d5961cd9d2627a5db926dcef9
Change-Id: I47cb37484b29c27250aa6bb3ceafe9b7176dd34d Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
| f2807ede | 03-Apr-2025 |
George Liu <liuxiwei@ieisystem.com> |
dbus-sdr: update attribute naming rules
update sensor command names to use `Lower Camel Case`.
Change-Id: I1c21591e8dccee62f41841f2889bda205c2a5e8b Signed-off-by: George Liu <liuxiwei@ieisystem.com> |
| 535fc0c9 | 02-Apr-2025 |
George Liu <liuxiwei@ieisystem.com> |
api: remove ipmid_get_sd_event_connection
The ipmid_get_sd_event_connection method is no longer used, this commit removes it.
Change-Id: I6b2fae45407a9d175321f8107c83c1955ac63373 Signed-off-by: Geo
api: remove ipmid_get_sd_event_connection
The ipmid_get_sd_event_connection method is no longer used, this commit removes it.
Change-Id: I6b2fae45407a9d175321f8107c83c1955ac63373 Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
| 9cd353b0 | 02-Apr-2025 |
George Liu <liuxiwei@ieisystem.com> |
api: remove IPMI_CC_LEN
IPMI_CC_LEN is no longer used, this commit removes it.
Change-Id: I5656dbcf4d177c08607792deb1683610c50d8b8b Signed-off-by: George Liu <liuxiwei@ieisystem.com> |
| 0a3f40b9 | 22-Jan-2025 |
John Chung <john.chung@arm.com> |
SBMR Get/Send Boot Progress Code support
Implement IPMI commands for boot progress codes by following DEN0069E_SBMR_2.1. Add configure option `arm-sbmr` to enable SBMR IPMI commands. Boot progress c
SBMR Get/Send Boot Progress Code support
Implement IPMI commands for boot progress codes by following DEN0069E_SBMR_2.1. Add configure option `arm-sbmr` to enable SBMR IPMI commands. Boot progress code will update to Redfish BootProgress property.
1. Send boot progress code (NetFn 0x2C, Command 0x2) 2. Get boot progress code (NetFn 0x2C, Command 0x3)
Test:
1. Send boot progress code $> ipmitool raw 0x2C 0x02 0xAE 0x1 0x00 0x00 0x00 \ 0x01 0x10 0x01 0x02 0x00 ae
2. Get boot progress code $> ipmitool raw 0x2C 0x3 0xAE ae 01 00 00 00 01 10 01 02 00
3. Redfish BootProgess LastState - /redfish/v1/Systems/system { ... "BootProgress": { "LastState": "PCIResourceConfigStarted", "LastStateTime": "2024-11-14T19:14:22.432272+00:00" } }
Signed-off-by: John Chung <john.chung@arm.com> Change-Id: I58e6e322006039fceb8d4212c4f9f6a4b4f9e225
show more ...
|
| de1420dc | 03-Mar-2025 |
George Liu <liuxiwei@ieisystem.com> |
Added asynchronous callDbusMethod
This path added two callDbusMethod methods, one without method return value (default return ec), and the other with method return value.
Change-Id: I16503fe24adc0f
Added asynchronous callDbusMethod
This path added two callDbusMethod methods, one without method return value (default return ec), and the other with method return value.
Change-Id: I16503fe24adc0f3896a861972751d532b6361ef9 Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
| 9706bc8d | 17-Mar-2025 |
Jayanth Othayoth <ojayanth@gmail.com> |
Fix include path for message.hpp
This resolves the below compilation error related to the missing message.hpp file during full build.
''' usr/include/ipmid/message/pack.hpp:18:10: fatal error: incl
Fix include path for message.hpp
This resolves the below compilation error related to the missing message.hpp file during full build.
''' usr/include/ipmid/message/pack.hpp:18:10: fatal error: include/ipmid/message.hpp: No such file or directory '''
Updated the include directive to use the correct relative path for message.hpp
Change-Id: Ice8a60a7030448ce75f0fa255ded9117beb1a71f Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
| a8205ff6 | 07-Mar-2025 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: fix use of undeclared identifier error
This commit resolves the clang-diagnostic-error related to missing identifiers by ensuring all necessary header files are included in the same sour
clang-tidy: fix use of undeclared identifier error
This commit resolves the clang-diagnostic-error related to missing identifiers by ensuring all necessary header files are included in the same source file.
Also Correct undeclared identifier 'cmdWildcard' to 'ipmi::cmdWildcard'
Change-Id: Ic818af97557c7bc74b7fc9478315fe181a9a4cfc Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
| a6fb32d8 | 15-Dec-2024 |
Jayanth Othayoth <ojayanth@gmail.com> |
clang-tidy: Replace NULL with nullptr
Replaced all instances of NULL with nullptr to improve type safety and clarity, as nullptr is the modern C++ standard for null pointers.
Tested: Build verified
clang-tidy: Replace NULL with nullptr
Replaced all instances of NULL with nullptr to improve type safety and clarity, as nullptr is the modern C++ standard for null pointers.
Tested: Build verified
Change-Id: Ia40d9435ab57651ec6d13d5408cf69130043fa79 Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
show more ...
|
| 69b4c281 | 03-Mar-2025 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: Ic23653be3ed404980fd0e723d9ed8354e2b32579 Signed-off-by: Patrick Williams <p
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: Ic23653be3ed404980fd0e723d9ed8354e2b32579 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| c6837ed7 | 05-Dec-2024 |
George Liu <liuxiwei@ieisystem.com> |
app: remove IPMI_CMD_WILDCARD
cmdWildcard is already declared in api-types.hpp, this commit remove IPMI_CMD_WILDCARD in app.hpp.
Change-Id: Ic1d944f012022e702a1e5a0aef7a039249684fa2 Signed-off-by:
app: remove IPMI_CMD_WILDCARD
cmdWildcard is already declared in api-types.hpp, this commit remove IPMI_CMD_WILDCARD in app.hpp.
Change-Id: Ic1d944f012022e702a1e5a0aef7a039249684fa2 Signed-off-by: George Liu <liuxiwei@ieisystem.com>
show more ...
|
| 62ce1594 | 03-Feb-2025 |
Patrick Williams <patrick@stwcx.xyz> |
meson: reformat with meson formatter
Apply the `meson format` results.
Change-Id: I1dbf4ae74d383552995432add3d2f548eb844ee5 Signed-off-by: Patrick Williams <patrick@stwcx.xyz> |
| 3b301a3a | 03-Feb-2025 |
Patrick Williams <patrick@stwcx.xyz> |
Revert "drop sdevents hack"
This reverts commit d2dd5bc2eddc73504734112c0d6f745202b1b3a0.
The commit was inadvertently merged upstream.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-I
Revert "drop sdevents hack"
This reverts commit d2dd5bc2eddc73504734112c0d6f745202b1b3a0.
The commit was inadvertently merged upstream.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Icf03e2ca476271b4606500846593e36fe326f3c5
show more ...
|
| d2dd5bc2 | 10-Jun-2024 |
Patrick Williams <patrick@stwcx.xyz> |
drop sdevents hack
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I04833cc2a39c032a4d9c29079ee92fdf24c89245 |
| 402024a8 | 16-Jul-2024 |
George Liu <liuxiwei@ieisystem.com> |
sensorhandler: Support NonRecoverable in getSensorThresholds method
There are actually three types of threshold interfaces (Warning, Critical, and NonRecoverable). This patch supports the NonRecover
sensorhandler: Support NonRecoverable in getSensorThresholds method
There are actually three types of threshold interfaces (Warning, Critical, and NonRecoverable). This patch supports the NonRecoverable interface in the getSensorThresholds method.
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: Ie9a7ff44b4e58702c5522a308d8128fcfb1161ef
show more ...
|
| b4b40918 | 17-Jul-2024 |
George Liu <liuxiwei@ieisystem.com> |
ipmid: switch to lg2
Signed-off-by: George Liu <liuxiwei@ieisystem.com> Change-Id: I838587b2d564f3c00b78ce37e175d7e8ace51142 |