test - OpenGrok history log for /openbmc/phosphor-pid-control/test

Revision	Date	Author	Comments (<<< Hide modified files) (Show modified files >>>)
1f802f5e	08-Feb-2019	James Feist <james.feist@linux.intel.com>	Move all variant usage to std This just a style change, remove variant_ns in favor of std. Tested-by: it built Change-Id: Id5a075e8b73a7724cbc5153fb7dfcf369e79c483 Signed-off-by: James Feist <jame Move all variant usage to std This just a style change, remove variant_ns in favor of std. Tested-by: it built Change-Id: Id5a075e8b73a7724cbc5153fb7dfcf369e79c483 Signed-off-by: James Feist <james.feist@linux.intel.com> show more ... /openbmc/phosphor-pid-control/dbus/dbusconfiguration.cpp /openbmc/phosphor-pid-control/dbus/dbuspassive.cpp /openbmc/phosphor-pid-control/dbus/dbuswrite.cpp /openbmc/phosphor-pid-control/dbus/util.cpp /openbmc/phosphor-pid-control/ipmi/manualcmds.cpp /openbmc/phosphor-pid-control/sensors/sensor.hpp /openbmc/phosphor-pid-control/setsensor.cpp dbus_passive_unittest.cpp
572c43da	31-Jan-2019	James Feist <james.feist@linux.intel.com>	Add Hysteresis to pid controllers Add hysteresis to pid controllers to lower pwm changes. It is defaulted to 0 so it should be transparent to any controller that choses not to implement it. This is Add Hysteresis to pid controllers Add hysteresis to pid controllers to lower pwm changes. It is defaulted to 0 so it should be transparent to any controller that choses not to implement it. This is the same pattern used by the stepwise controller. Tested-by: Unit tests passed Change-Id: Ib47114285b0017258b7f77eaf067d310f95a0c60 Signed-off-by: James Feist <james.feist@linux.intel.com> show more ... /openbmc/phosphor-pid-control/MAINTAINERS /openbmc/phosphor-pid-control/README.md /openbmc/phosphor-pid-control/configure.ac /openbmc/phosphor-pid-control/dbus/dbusconfiguration.cpp /openbmc/phosphor-pid-control/dbus/dbuspassive.cpp /openbmc/phosphor-pid-control/dbus/dbuswrite.cpp /openbmc/phosphor-pid-control/ipmi/manualcmds.cpp /openbmc/phosphor-pid-control/main.cpp /openbmc/phosphor-pid-control/pid/ec/pid.hpp /openbmc/phosphor-pid-control/pid/fancontroller.cpp /openbmc/phosphor-pid-control/pid/pidcontroller.cpp /openbmc/phosphor-pid-control/pid/pidcontroller.hpp /openbmc/phosphor-pid-control/pid/util.cpp /openbmc/phosphor-pid-control/scripts/writepid.mako.cpp /openbmc/phosphor-pid-control/sensors/manager.hpp /openbmc/phosphor-pid-control/setsensor.cpp pid_thermalcontroller_unittest.cpp
4cf39861	06-Dec-2018	Patrick Venture <venture@google.com>	test: add phosphor-logging to test make The tests now require phosphor-logging to be included as a library. Change-Id: Ie85d7bc9f6ff687f80064c2a499e934f7bcf2616 Signed-off-by: Patrick Venture <vent test: add phosphor-logging to test make The tests now require phosphor-logging to be included as a library. Change-Id: Ie85d7bc9f6ff687f80064c2a499e934f7bcf2616 Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/configure.ac /openbmc/phosphor-pid-control/dbus/dbusconfiguration.cpp /openbmc/phosphor-pid-control/main.cpp /openbmc/phosphor-pid-control/pid/builder.cpp /openbmc/phosphor-pid-control/pid/thermalcontroller.cpp /openbmc/phosphor-pid-control/pid/thermalcontroller.hpp Makefile.am
734f9535	15-Nov-2018	James Feist <james.feist@linux.intel.com>	Allow multiple inputs to thermal and stepwise controllers Use std::max to determine which input value to apply. Also start throwing when inputs are empty as otherwise there will be a nullptr derefer Allow multiple inputs to thermal and stepwise controllers Use std::max to determine which input value to apply. Also start throwing when inputs are empty as otherwise there will be a nullptr dereference. Tested-by: Added multiple inputs and application no longer segfaults and verifed max was being used. Also added unit tests. Change-Id: I7c8eda45b99247b8e92e629f036c9a46c98d9fe2 Signed-off-by: James Feist <james.feist@linux.intel.com> show more ... /openbmc/phosphor-pid-control/dbus/dbuspassive.cpp /openbmc/phosphor-pid-control/dbus/util.cpp /openbmc/phosphor-pid-control/errors/exception.hpp /openbmc/phosphor-pid-control/pid/builder.cpp /openbmc/phosphor-pid-control/pid/stepwisecontroller.cpp /openbmc/phosphor-pid-control/pid/thermalcontroller.cpp /openbmc/phosphor-pid-control/pid/thermalcontroller.hpp pid_thermalcontroller_unittest.cpp
5f59c0fd	11-Nov-2018	Patrick Venture <venture@google.com>	Move all floats to doubles The code was developed initially around a pid loop implemented using floats. Therefore, the code was converting back and forth between double for sensor values as inputs Move all floats to doubles The code was developed initially around a pid loop implemented using floats. Therefore, the code was converting back and forth between double for sensor values as inputs and outputs from this PID loop. Change-Id: I2d2919e1165103040729c9f16bb84fde3dd6b81b Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/Makefile.am /openbmc/phosphor-pid-control/conf.hpp /openbmc/phosphor-pid-control/configure.ac /openbmc/phosphor-pid-control/dbus/dbusconfiguration.cpp /openbmc/phosphor-pid-control/dbus/dbuswrite.cpp /openbmc/phosphor-pid-control/dbus/util.cpp /openbmc/phosphor-pid-control/dbus/util.hpp /openbmc/phosphor-pid-control/main.cpp /openbmc/phosphor-pid-control/pid/builderconfig.cpp /openbmc/phosphor-pid-control/pid/controller.hpp /openbmc/phosphor-pid-control/pid/ec/pid.cpp /openbmc/phosphor-pid-control/pid/ec/pid.hpp /openbmc/phosphor-pid-control/pid/ec/stepwise.cpp /openbmc/phosphor-pid-control/pid/ec/stepwise.hpp /openbmc/phosphor-pid-control/pid/fancontroller.cpp /openbmc/phosphor-pid-control/pid/fancontroller.hpp /openbmc/phosphor-pid-control/pid/pidcontroller.cpp /openbmc/phosphor-pid-control/pid/pidcontroller.hpp /openbmc/phosphor-pid-control/pid/stepwisecontroller.cpp /openbmc/phosphor-pid-control/pid/stepwisecontroller.hpp /openbmc/phosphor-pid-control/pid/thermalcontroller.cpp /openbmc/phosphor-pid-control/pid/thermalcontroller.hpp /openbmc/phosphor-pid-control/pid/zone.cpp /openbmc/phosphor-pid-control/pid/zone.hpp /openbmc/phosphor-pid-control/scripts/pid-example.txt /openbmc/phosphor-pid-control/scripts/writepid.mako.cpp /openbmc/phosphor-pid-control/scripts/writesensor.mako.cpp /openbmc/phosphor-pid-control/scripts/writezone.mako.cpp /openbmc/phosphor-pid-control/scripts/zone-example.txt /openbmc/phosphor-pid-control/sensors/builder.cpp /openbmc/phosphor-pid-control/sensors/manager.cpp /openbmc/phosphor-pid-control/sensors/manager.hpp /openbmc/phosphor-pid-control/setsensor.cpp /openbmc/phosphor-pid-control/sysfs/sysfswrite.cpp controller_mock.hpp pid_fancontroller_unittest.cpp pid_stepwisecontroller_unittest.cpp pid_thermalcontroller_unittest.cpp pid_zone_unittest.cpp zone_mock.hpp /openbmc/phosphor-pid-control/threads/busthread.cpp /openbmc/phosphor-pid-control/threads/busthread.hpp
e6a7a2eb	30-Oct-2018	Patrick Venture <venture@google.com>	style: s/getMinThermalRpmSetPt/getMinThermalRPMSetpoint/g Rename method per openbmc style guide. Change-Id: Ia861028452020ccefd463415093b5fb11f929ea4 Signed-off-by: Patrick Venture <venture@google. style: s/getMinThermalRpmSetPt/getMinThermalRPMSetpoint/g Rename method per openbmc style guide. Change-Id: Ia861028452020ccefd463415093b5fb11f929ea4 Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/pid/zone.cpp /openbmc/phosphor-pid-control/pid/zone.hpp pid_zone_unittest.cpp
2d8e7851	30-Oct-2018	Patrick Venture <venture@google.com>	performance: fixup missing const reference in zone Zone::getSensor is passed directly to the Sensor Manager getSensor which takes the parameter by reference. Make it use an explicit const reference performance: fixup missing const reference in zone Zone::getSensor is passed directly to the Sensor Manager getSensor which takes the parameter by reference. Make it use an explicit const reference at both layers. Change-Id: I4895ea2935d20b73b88d33972e44b9ac557cd988 Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/pid/zone.cpp /openbmc/phosphor-pid-control/pid/zone.hpp /openbmc/phosphor-pid-control/sensors/host.hpp zone_mock.hpp
0bbeaf84	30-Oct-2018	Patrick Venture <venture@google.com>	style: s/getZoneId/getZoneID/g Acronyms are meant to be in the same case within their part of the camel case name. Change-Id: I9e55d4419617a35b0f3a85f3d55543c8fc9bd76f Signed-off-by: Patrick Ventur style: s/getZoneId/getZoneID/g Acronyms are meant to be in the same case within their part of the camel case name. Change-Id: I9e55d4419617a35b0f3a85f3d55543c8fc9bd76f Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/dbus/dbuswrite.cpp /openbmc/phosphor-pid-control/dbus/dbuswrite.hpp /openbmc/phosphor-pid-control/errors/exception.hpp /openbmc/phosphor-pid-control/pid/builder.cpp /openbmc/phosphor-pid-control/pid/zone.cpp /openbmc/phosphor-pid-control/pid/zone.hpp /openbmc/phosphor-pid-control/sensors/builder.cpp pid_zone_unittest.cpp
f8cb4644	30-Oct-2018	Patrick Venture <venture@google.com>	dbus: passive: move exception checking into factory Move the exception checking into the factory to remove possibility of exception during construction. Change-Id: I22922f23247c0579ee2a3411b5c8cede dbus: passive: move exception checking into factory Move the exception checking into the factory to remove possibility of exception during construction. Change-Id: I22922f23247c0579ee2a3411b5c8cede44fe324c Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/dbus/dbuspassive.cpp /openbmc/phosphor-pid-control/dbus/dbuspassive.hpp /openbmc/phosphor-pid-control/dbus/util.cpp /openbmc/phosphor-pid-control/dbus/util.hpp /openbmc/phosphor-pid-control/pid/pidcontroller.hpp /openbmc/phosphor-pid-control/pid/stepwisecontroller.hpp dbus_passive_unittest.cpp
7af157b1	30-Oct-2018	Patrick Venture <venture@google.com>	style: function names should be lower camel Fix function names to be lower camel. Change-Id: I145e1f4c03d7740bc1525dcffbdce2f78fd61075 Signed-off-by: Patrick Venture <venture@google.com> /openbmc/phosphor-pid-control/dbus/dbuspassive.cpp /openbmc/phosphor-pid-control/dbus/dbuspassive.hpp /openbmc/phosphor-pid-control/dbus/dbuswrite.hpp /openbmc/phosphor-pid-control/dbus/util.cpp /openbmc/phosphor-pid-control/dbus/util.hpp /openbmc/phosphor-pid-control/ipmi/manualcmds.cpp /openbmc/phosphor-pid-control/main.cpp /openbmc/phosphor-pid-control/pid/builder.cpp /openbmc/phosphor-pid-control/pid/builder.hpp /openbmc/phosphor-pid-control/pid/builderconfig.cpp /openbmc/phosphor-pid-control/pid/builderconfig.hpp /openbmc/phosphor-pid-control/pid/fancontroller.cpp /openbmc/phosphor-pid-control/pid/pidthread.cpp /openbmc/phosphor-pid-control/pid/pidthread.hpp /openbmc/phosphor-pid-control/pid/thermalcontroller.cpp /openbmc/phosphor-pid-control/pid/util.cpp /openbmc/phosphor-pid-control/pid/util.hpp /openbmc/phosphor-pid-control/sensors/builder.cpp /openbmc/phosphor-pid-control/sensors/builder.hpp /openbmc/phosphor-pid-control/sensors/builderconfig.cpp /openbmc/phosphor-pid-control/sensors/builderconfig.hpp dbus_passive_unittest.cpp util_unittest.cpp /openbmc/phosphor-pid-control/util.cpp /openbmc/phosphor-pid-control/util.hpp
563a356f	30-Oct-2018	Patrick Venture <venture@google.com>	style: member functions should be lower camel Rename member functions to be lower camel instead of snake case. Change-Id: Ib227fd3dadb6d9607290277205223a4324cd4ce5 Signed-off-by: Patrick Venture <v style: member functions should be lower camel Rename member functions to be lower camel instead of snake case. Change-Id: Ib227fd3dadb6d9607290277205223a4324cd4ce5 Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/conf.hpp /openbmc/phosphor-pid-control/dbus/dbusactiveread.cpp /openbmc/phosphor-pid-control/dbus/dbusconfiguration.cpp /openbmc/phosphor-pid-control/dbus/dbuspassive.cpp /openbmc/phosphor-pid-control/dbus/dbuspassive.hpp /openbmc/phosphor-pid-control/dbus/dbuswrite.hpp /openbmc/phosphor-pid-control/dbus/util.cpp /openbmc/phosphor-pid-control/dbus/util.hpp /openbmc/phosphor-pid-control/experiments/drive.cpp /openbmc/phosphor-pid-control/ipmi/manualcmds.cpp /openbmc/phosphor-pid-control/main.cpp /openbmc/phosphor-pid-control/pid/builder.cpp /openbmc/phosphor-pid-control/pid/builder.hpp /openbmc/phosphor-pid-control/pid/builderconfig.cpp /openbmc/phosphor-pid-control/pid/controller.hpp /openbmc/phosphor-pid-control/pid/fancontroller.cpp /openbmc/phosphor-pid-control/pid/fancontroller.hpp /openbmc/phosphor-pid-control/pid/pidcontroller.cpp /openbmc/phosphor-pid-control/pid/pidcontroller.hpp /openbmc/phosphor-pid-control/pid/pidthread.cpp /openbmc/phosphor-pid-control/pid/stepwisecontroller.cpp /openbmc/phosphor-pid-control/pid/stepwisecontroller.hpp /openbmc/phosphor-pid-control/pid/thermalcontroller.cpp /openbmc/phosphor-pid-control/pid/thermalcontroller.hpp /openbmc/phosphor-pid-control/pid/util.cpp /openbmc/phosphor-pid-control/pid/util.hpp /openbmc/phosphor-pid-control/pid/zone.cpp /openbmc/phosphor-pid-control/pid/zone.hpp /openbmc/phosphor-pid-control/scripts/writesensor.mako.cpp /openbmc/phosphor-pid-control/scripts/writezone.mako.cpp /openbmc/phosphor-pid-control/sensors/builder.cpp /openbmc/phosphor-pid-control/sensors/builder.hpp /openbmc/phosphor-pid-control/sensors/builderconfig.cpp /openbmc/phosphor-pid-control/sensors/host.cpp /openbmc/phosphor-pid-control/sensors/host.hpp /openbmc/phosphor-pid-control/sensors/sensor.hpp controller_mock.hpp dbus_active_unittest.cpp dbus_passive_unittest.cpp dbushelper_mock.hpp pid_fancontroller_unittest.cpp pid_stepwisecontroller_unittest.cpp pid_thermalcontroller_unittest.cpp pid_zone_unittest.cpp sensor_host_unittest.cpp
36b7d8eb	05-Oct-2018	James Feist <james.feist@linux.intel.com>	[dbus-passive] Add threshold fan failure When a threshold is crossed for a monitored sensor, assert fan failure. Tested-by: Changed a sensor threshold so that its current reading made the threshold [dbus-passive] Add threshold fan failure When a threshold is crossed for a monitored sensor, assert fan failure. Tested-by: Changed a sensor threshold so that its current reading made the threshold asserted and noticed via print messages that the sensor went into failure state. Also noticed fans ramp. Wrote unit test to verify sensor can move in and out of error state correctly. Change-Id: I83182536e4874eaba97f3f1d48d53ac110fba833 Signed-off-by: James Feist <james.feist@linux.intel.com> show more ... /openbmc/phosphor-pid-control/.gitignore /openbmc/phosphor-pid-control/MAINTAINERS /openbmc/phosphor-pid-control/README.md /openbmc/phosphor-pid-control/configure.ac /openbmc/phosphor-pid-control/dbus/dbusconfiguration.cpp /openbmc/phosphor-pid-control/dbus/dbusconfiguration.hpp /openbmc/phosphor-pid-control/dbus/dbuspassive.cpp /openbmc/phosphor-pid-control/dbus/dbuspassive.hpp /openbmc/phosphor-pid-control/dbus/dbuswrite.cpp /openbmc/phosphor-pid-control/dbus/dbuswrite.hpp /openbmc/phosphor-pid-control/dbus/util.cpp /openbmc/phosphor-pid-control/dbus/util.hpp /openbmc/phosphor-pid-control/interfaces.hpp /openbmc/phosphor-pid-control/main.cpp /openbmc/phosphor-pid-control/pid/ec/pid.cpp /openbmc/phosphor-pid-control/pid/fancontroller.cpp /openbmc/phosphor-pid-control/pid/zone.cpp /openbmc/phosphor-pid-control/sensors/pluggable.cpp /openbmc/phosphor-pid-control/sensors/pluggable.hpp /openbmc/phosphor-pid-control/sensors/sensor.hpp /openbmc/phosphor-pid-control/swampd_diagram.png dbus_passive_unittest.cpp dbushelper_mock.hpp
3dfaafda	20-Sep-2018	James Feist <james.feist@linux.intel.com>	Add hysteresis to stepwise controller Tested-by: Ran on platform monitoring output and wrote unit test Change-Id: I74a1d21544c1a9cb4c1cb26dd4a353cbff0442d0 Signed-off-by: James Feist <james.feist@l Add hysteresis to stepwise controller Tested-by: Ran on platform monitoring output and wrote unit test Change-Id: I74a1d21544c1a9cb4c1cb26dd4a353cbff0442d0 Signed-off-by: James Feist <james.feist@linux.intel.com> show more ... /openbmc/phosphor-pid-control/Makefile.am /openbmc/phosphor-pid-control/dbus/dbusconfiguration.cpp /openbmc/phosphor-pid-control/ipmi/manualcmds.cpp /openbmc/phosphor-pid-control/main.cpp /openbmc/phosphor-pid-control/pid/ec/stepwise.cpp /openbmc/phosphor-pid-control/pid/ec/stepwise.hpp /openbmc/phosphor-pid-control/pid/stepwisecontroller.cpp /openbmc/phosphor-pid-control/pid/stepwisecontroller.hpp Makefile.am pid_stepwisecontroller_unittest.cpp
22c257ab	31-Aug-2018	James Feist <james.feist@linux.intel.com>	Add stepwise controller This adds the ability to use stepwise curves alongside pid control. This creates a base controller class that pidcontroller and stepwise controller inherit from. Note: Hyste Add stepwise controller This adds the ability to use stepwise curves alongside pid control. This creates a base controller class that pidcontroller and stepwise controller inherit from. Note: Hysteresis to come in follow-on patch Tested-by: Created a stepwise controller and noticed that when it crossed a threshold that it contributed to the pwm setting. Change-Id: I6cf842f80eaccafc905d620970afe91e2092d568 Signed-off-by: James Feist <james.feist@linux.intel.com> show more ... /openbmc/phosphor-pid-control/Makefile.am /openbmc/phosphor-pid-control/conf.hpp /openbmc/phosphor-pid-control/configure.ac /openbmc/phosphor-pid-control/dbus/dbusconfiguration.cpp /openbmc/phosphor-pid-control/ipmi/manualcmds.cpp /openbmc/phosphor-pid-control/pid/builder.cpp /openbmc/phosphor-pid-control/pid/builderconfig.cpp /openbmc/phosphor-pid-control/pid/controller.hpp /openbmc/phosphor-pid-control/pid/ec/stepwise.cpp /openbmc/phosphor-pid-control/pid/ec/stepwise.hpp /openbmc/phosphor-pid-control/pid/fancontroller.hpp /openbmc/phosphor-pid-control/pid/pidcontroller.cpp /openbmc/phosphor-pid-control/pid/pidcontroller.hpp /openbmc/phosphor-pid-control/pid/pidthread.cpp /openbmc/phosphor-pid-control/pid/stepwisecontroller.cpp /openbmc/phosphor-pid-control/pid/stepwisecontroller.hpp /openbmc/phosphor-pid-control/pid/thermalcontroller.hpp /openbmc/phosphor-pid-control/pid/zone.cpp /openbmc/phosphor-pid-control/pid/zone.hpp Makefile.am
e2ec0f61	04-Sep-2018	Patrick Venture <venture@google.com>	clang-format: fix pointer alignment, sort using Change-Id: Id433d0ecc10c62807594b3a637e591045223faa6 Signed-off-by: Patrick Venture <venture@google.com> /openbmc/phosphor-pid-control/.clang-format /openbmc/phosphor-pid-control/dbus/dbusconfiguration.cpp /openbmc/phosphor-pid-control/dbus/dbusconfiguration.hpp /openbmc/phosphor-pid-control/dbus/dbuswrite.hpp /openbmc/phosphor-pid-control/interfaces.hpp dbus_passive_unittest.cpp helpers.hpp pid_fancontroller_unittest.cpp pid_zone_unittest.cpp sensor_host_unittest.cpp sensor_manager_unittest.cpp sensor_pluggable_unittest.cpp
da4a5dd1	31-Aug-2018	Patrick Venture <venture@google.com>	add .clang-format Change-Id: I6627b5569c2e0f730be7331403218b823a2c622f Signed-off-by: Patrick Venture <venture@google.com> /openbmc/phosphor-pid-control/.clang-format /openbmc/phosphor-pid-control/conf.hpp /openbmc/phosphor-pid-control/dbus/dbusactiveread.cpp /openbmc/phosphor-pid-control/dbus/dbusactiveread.hpp /openbmc/phosphor-pid-control/dbus/dbuspassive.cpp /openbmc/phosphor-pid-control/dbus/dbuspassive.hpp /openbmc/phosphor-pid-control/dbus/dbuswrite.cpp /openbmc/phosphor-pid-control/dbus/dbuswrite.hpp /openbmc/phosphor-pid-control/dbus/util.cpp /openbmc/phosphor-pid-control/dbus/util.hpp /openbmc/phosphor-pid-control/experiments/drive.cpp /openbmc/phosphor-pid-control/interfaces.hpp /openbmc/phosphor-pid-control/ipmi/manualcmds.cpp /openbmc/phosphor-pid-control/ipmi/manualcmds.hpp /openbmc/phosphor-pid-control/main.cpp /openbmc/phosphor-pid-control/notimpl/readonly.cpp /openbmc/phosphor-pid-control/notimpl/readonly.hpp /openbmc/phosphor-pid-control/notimpl/writeonly.cpp /openbmc/phosphor-pid-control/notimpl/writeonly.hpp /openbmc/phosphor-pid-control/pid/builder.cpp /openbmc/phosphor-pid-control/pid/builder.hpp /openbmc/phosphor-pid-control/pid/builderconfig.cpp /openbmc/phosphor-pid-control/pid/builderconfig.hpp /openbmc/phosphor-pid-control/pid/controller.cpp /openbmc/phosphor-pid-control/pid/controller.hpp /openbmc/phosphor-pid-control/pid/ec/pid.cpp /openbmc/phosphor-pid-control/pid/ec/pid.hpp /openbmc/phosphor-pid-control/pid/fancontroller.cpp /openbmc/phosphor-pid-control/pid/fancontroller.hpp /openbmc/phosphor-pid-control/pid/pidthread.cpp /openbmc/phosphor-pid-control/pid/thermalcontroller.cpp /openbmc/phosphor-pid-control/pid/thermalcontroller.hpp /openbmc/phosphor-pid-control/pid/util.cpp /openbmc/phosphor-pid-control/pid/util.hpp /openbmc/phosphor-pid-control/pid/zone.cpp /openbmc/phosphor-pid-control/pid/zone.hpp /openbmc/phosphor-pid-control/sensors/builder.cpp /openbmc/phosphor-pid-control/sensors/builder.hpp /openbmc/phosphor-pid-control/sensors/builderconfig.cpp /openbmc/phosphor-pid-control/sensors/builderconfig.hpp /openbmc/phosphor-pid-control/sensors/host.cpp /openbmc/phosphor-pid-control/sensors/host.hpp /openbmc/phosphor-pid-control/sensors/manager.cpp /openbmc/phosphor-pid-control/sensors/manager.hpp /openbmc/phosphor-pid-control/sensors/pluggable.cpp /openbmc/phosphor-pid-control/sensors/pluggable.hpp /openbmc/phosphor-pid-control/sensors/sensor.hpp /openbmc/phosphor-pid-control/setsensor.cpp /openbmc/phosphor-pid-control/sysfs/sysfsread.cpp /openbmc/phosphor-pid-control/sysfs/sysfsread.hpp /openbmc/phosphor-pid-control/sysfs/sysfswrite.cpp /openbmc/phosphor-pid-control/sysfs/sysfswrite.hpp /openbmc/phosphor-pid-control/sysfs/util.cpp controller_mock.hpp dbus_active_unittest.cpp dbus_passive_unittest.cpp dbushelper_mock.hpp helpers.hpp pid_fancontroller_unittest.cpp pid_thermalcontroller_unittest.cpp pid_zone_unittest.cpp readinterface_mock.hpp sensor_host_unittest.cpp sensor_manager_unittest.cpp sensor_mock.hpp sensor_pluggable_unittest.cpp util_unittest.cpp writeinterface_mock.hpp zone_mock.hpp /openbmc/phosphor-pid-control/threads/busthread.cpp /openbmc/phosphor-pid-control/util.cpp /openbmc/phosphor-pid-control/util.hpp
40be36ac	29-Aug-2018	Patrick Venture <venture@google.com>	add missing gmock header: read\|write interface mock Change-Id: I8633300650d1f40d9d5b880ebee3be51236db3c5 Signed-off-by: Patrick Venture <venture@google.com> /openbmc/phosphor-pid-control/Makefile.am /openbmc/phosphor-pid-control/configure.ac /openbmc/phosphor-pid-control/dbus/dbusconfiguration.cpp /openbmc/phosphor-pid-control/dbus/dbusconfiguration.hpp /openbmc/phosphor-pid-control/dbus/dbuspassive.cpp /openbmc/phosphor-pid-control/dbus/dbuswrite.cpp /openbmc/phosphor-pid-control/dbus/dbuswrite.hpp /openbmc/phosphor-pid-control/dbus/util.cpp /openbmc/phosphor-pid-control/dbus/util.hpp /openbmc/phosphor-pid-control/ipmi/manualcmds.cpp /openbmc/phosphor-pid-control/main.cpp /openbmc/phosphor-pid-control/sensors/builder.cpp readinterface_mock.hpp writeinterface_mock.hpp /openbmc/phosphor-pid-control/tools/fan_rpm_loop_test.sh /openbmc/phosphor-pid-control/tools/fan_rpm_loop_unittest.sh /openbmc/phosphor-pid-control/util.cpp
2524323e	14-Jun-2018	Patrick Venture <venture@google.com>	test: dbus: dbusactiveread Add initial unit-tests. Change-Id: Id62894faf56a645dc44c51a173a67185ea5d9cd6 Signed-off-by: Patrick Venture <venture@google.com> Makefile.am dbus_active_unittest.cpp
0ef1faf7	13-Jun-2018	Patrick Venture <venture@google.com>	test: dbus: passive read interface Added basic unit-tests and added a factory for creating the DbusPassive read interface so that it can be nicely error checked. This is handled via a valid type ch test: dbus: passive read interface Added basic unit-tests and added a factory for creating the DbusPassive read interface so that it can be nicely error checked. This is handled via a valid type check where the only valid types are 'fan' and 'temp'. Change-Id: I558ed09bf509d26f20c6e431bb0789074e9aa841 Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/dbus/dbuspassive.cpp /openbmc/phosphor-pid-control/dbus/dbuspassive.hpp /openbmc/phosphor-pid-control/dbus/util.cpp /openbmc/phosphor-pid-control/dbus/util.hpp /openbmc/phosphor-pid-control/sensors/builder.cpp Makefile.am dbus_passive_unittest.cpp
0df7c0fb	13-Jun-2018	Patrick Venture <venture@google.com>	dbus: transition to interface for testing To make testing easier, the dbus objects now receive a helper interface to use instead of calling into a helper module. Tested: Ran on quanta-q71l board an dbus: transition to interface for testing To make testing easier, the dbus objects now receive a helper interface to use instead of calling into a helper module. Tested: Ran on quanta-q71l board and it behaved as expected. Change-Id: I2521d9c75aec76e92d2e26dc044d01011e44d552 Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/dbus/dbusactiveread.cpp /openbmc/phosphor-pid-control/dbus/dbusactiveread.hpp /openbmc/phosphor-pid-control/dbus/dbuspassive.cpp /openbmc/phosphor-pid-control/dbus/dbuspassive.hpp /openbmc/phosphor-pid-control/dbus/util.cpp /openbmc/phosphor-pid-control/dbus/util.hpp /openbmc/phosphor-pid-control/sensors/builder.cpp dbushelper_mock.hpp
566a1518	12-Jun-2018	Patrick Venture <venture@google.com>	test: pid: fancontroller Adds unit-tests for the fancontroller. Bugfix: set point not initialized to 0, although bug has no impact. Tested: Ran on quanta-q71l board and it behaved as expected. Chan test: pid: fancontroller Adds unit-tests for the fancontroller. Bugfix: set point not initialized to 0, although bug has no impact. Tested: Ran on quanta-q71l board and it behaved as expected. Change-Id: I516833d8c9ed806b765ff9333801f3d57932a17b Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/pid/controller.hpp /openbmc/phosphor-pid-control/pid/fancontroller.cpp /openbmc/phosphor-pid-control/pid/fancontroller.hpp Makefile.am pid_fancontroller_unittest.cpp
3349ef20	12-Jun-2018	Patrick Venture <venture@google.com>	test: pid: thermalcontroller Tests for the pid/thermalcontroller module. Fixes a bug where one could pass an incorrect number of inputs to the thermalcontroller. This can still be side-stepped by c test: pid: thermalcontroller Tests for the pid/thermalcontroller module. Fixes a bug where one could pass an incorrect number of inputs to the thermalcontroller. This can still be side-stepped by calling the constructor directly. Tested: Ran on quanta-q71l board and it behaved as expected. Change-Id: I3153ae4d907d9f90787b03e9d013d4349d911948 Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/pid/thermalcontroller.cpp Makefile.am pid_thermalcontroller_unittest.cpp
a58197cf	11-Jun-2018	Patrick Venture <venture@google.com>	test: pid: zone Add unit-tests for the PID zone module. Add zone_mock. Tested: Ran on quanta-q71l board and it behaved as expected. Change-Id: I51185b2d2daacea6ffb687e8f38c4fe2b2a1bed3 Signed-off- test: pid: zone Add unit-tests for the PID zone module. Add zone_mock. Tested: Ran on quanta-q71l board and it behaved as expected. Change-Id: I51185b2d2daacea6ffb687e8f38c4fe2b2a1bed3 Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/pid/controller.hpp /openbmc/phosphor-pid-control/pid/fancontroller.cpp /openbmc/phosphor-pid-control/pid/fancontroller.hpp /openbmc/phosphor-pid-control/pid/thermalcontroller.cpp /openbmc/phosphor-pid-control/pid/thermalcontroller.hpp /openbmc/phosphor-pid-control/pid/zone.cpp /openbmc/phosphor-pid-control/pid/zone.hpp /openbmc/phosphor-pid-control/sensors/manager.hpp Makefile.am helpers.hpp pid_zone_unittest.cpp sensor_manager_unittest.cpp zone_mock.hpp
2e3ecb57	22-Jun-2018	Patrick Venture <venture@google.com>	update configure and test/Makefile.am Update configure.ac and test/Makefile.am to properly handle newer googletest, per gerrit/11203. Change-Id: Idcef3d81ff834457fcdc6e0aa1be76b98c64b54c Signed-off update configure and test/Makefile.am Update configure.ac and test/Makefile.am to properly handle newer googletest, per gerrit/11203. Change-Id: Idcef3d81ff834457fcdc6e0aa1be76b98c64b54c Signed-off-by: Patrick Venture <venture@google.com> show more ... /openbmc/phosphor-pid-control/configure.ac Makefile.am
da064285	12-Jun-2018	Patrick Venture <venture@google.com>	util: enable unit-tests Start write tests and fix a missing header inclusion. Change-Id: I4e56323f972b1358dc83a4cb61c25f98cda2a479 Signed-off-by: Patrick Venture <venture@google.com> /openbmc/phosphor-pid-control/Makefile.am /openbmc/phosphor-pid-control/main.cpp /openbmc/phosphor-pid-control/pid/builder.cpp /openbmc/phosphor-pid-control/pid/builder.hpp /openbmc/phosphor-pid-control/pid/builderconfig.cpp /openbmc/phosphor-pid-control/pid/builderconfig.hpp /openbmc/phosphor-pid-control/pid/controller.hpp /openbmc/phosphor-pid-control/pid/fancontroller.cpp /openbmc/phosphor-pid-control/pid/fancontroller.hpp /openbmc/phosphor-pid-control/pid/pidthread.cpp /openbmc/phosphor-pid-control/pid/pidthread.hpp /openbmc/phosphor-pid-control/pid/thermalcontroller.cpp /openbmc/phosphor-pid-control/pid/thermalcontroller.hpp /openbmc/phosphor-pid-control/pid/zone.cpp /openbmc/phosphor-pid-control/pid/zone.hpp Makefile.am util_unittest.cpp /openbmc/phosphor-pid-control/util.hpp
1 2 345