734ed2b5 | 21-Jan-2022 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Clean up PEL Entry D-bus signals
Don't emit an InterfacesAdded signal when restoring the org.open_power.Logging.PEL.Entry interface on D-Bus, since this happens before the bus name is claimed.
PEL: Clean up PEL Entry D-bus signals
Don't emit an InterfacesAdded signal when restoring the org.open_power.Logging.PEL.Entry interface on D-Bus, since this happens before the bus name is claimed.
Also, don't emit PropertiesChanged signals when the PEL code updates the Resolution, EventID, and ServiceProviderNotify properties with their final values on the xyz.openbmc_project.Logging.Entry interface.
Definitely the PC signals aren't necessary during the restore phase, and while technically it'd be valid to send them after the IA signal has already been emitted for the Logging.Entry interface, nobody is listening for them anyway and doing it this way makes it so only InterfacesAdded signals are emitted when event logs are created.
Change-Id: Ia30163fb58e78d3746015903acc7597b2a097aa4
show more ...
|
277c2846 | 21-Jan-2022 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Remove unnecessary iostream include
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I6eac1ebc725d249dc56d5d03265e34d2e8c1fb91 |
7f3c8a49 | 21-Jan-2022 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Convert pel_entry.*pp to unix line endings
Run dox2unix on pel_entry.hpp and pel_entry.cpp
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ib48fa2e01259a00c6f77d1acfb4ed4e8b21b2bf6 |
bf61a982 | 13-Jan-2022 |
zamiseck <zimzam17@gmail.com> |
PEL : phosphor-bmc-code-mgmt errors to registry
Add entries for errors that occur which are specific to phosphor-bmc-code-mgmt. During code updates, there might be issues with processing, downloadin
PEL : phosphor-bmc-code-mgmt errors to registry
Add entries for errors that occur which are specific to phosphor-bmc-code-mgmt. During code updates, there might be issues with processing, downloading and/or validating the image, so there is a need to create the PEL that specifies this process' failures.
Signed-off-by: Zami Seck <zimzam17@gmail.com> Change-Id: I8e291438c19ce480f584b093998bc1ee870e776a
show more ...
|
9d1a0951 | 13-Jan-2022 |
zamiseck <zimzam17@gmail.com> |
PEL : new component id for phosphor-bmc-code-mgmt
Phosphor bmc code management provides a means for software management applications.
Signed-off-by: Zami Seck <zimzam17@gmail.com> Change-Id: Ia0d77
PEL : new component id for phosphor-bmc-code-mgmt
Phosphor bmc code management provides a means for software management applications.
Signed-off-by: Zami Seck <zimzam17@gmail.com> Change-Id: Ia0d77b044dfb60ccce2ac86103e0926f066a609a
show more ...
|
c6ee7c54 | 14-Jan-2022 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Trace when the send-to-host setting changes
Something in the journal will make it easier to remember this setting may have been switched off when someone asks why PELs haven't been sent to the
PEL: Trace when the send-to-host setting changes
Something in the journal will make it easier to remember this setting may have been switched off when someone asks why PELs haven't been sent to the host. It will also provide a timestamp of when the setting was changed if someone wanted to know.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I14170b2c8fc0b96b030f42f7408fdf995cd998b1
show more ...
|
081cfd42 | 07-Dec-2021 |
Alpana Kumari <alpankum@in.ibm.com> |
PEL: Add UnknownSystemType error to message_registry
The following commit introduced this new error- https://gerrit.openbmc-project.xyz/c/openbmc/openpower-vpd- parser/+/49080
Signed-off-by: Alpana
PEL: Add UnknownSystemType error to message_registry
The following commit introduced this new error- https://gerrit.openbmc-project.xyz/c/openbmc/openpower-vpd- parser/+/49080
Signed-off-by: Alpana Kumari <alpankum@in.ibm.com> Change-Id: I05a90e21b7cb8a57b52b092464cd3c9154c54960
show more ...
|
f8e750dd | 14-Jan-2022 |
Andrew Geissler <geissonator@yahoo.com> |
openpower-pels: only fail on hw callouts
After further discussion with the IBM service and manufacturing team, it was determined that firmware should only be automatically going to Quiesce and preve
openpower-pels: only fail on hw callouts
After further discussion with the IBM service and manufacturing team, it was determined that firmware should only be automatically going to Quiesce and preventing the system boot in QuiesceOnError mode when the PEL has a hardware callout present (vs. any type of callout).
Tested: - New unit test case - Verified that an unrecoverable PEL with only a symbolic FRU and a maintenance procedure callout did not trigger the Quiesce logic - Verified that a BMC log with a HW callout still triggers the Quiesce logic - Verified a boot in simulation with Quiesce enabled
Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: I8912d59fd69b699c7da5a44da887cce4e987f6d2
show more ...
|
216999f0 | 12-Jan-2022 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Change common errors to nonError in msg reg
The InternalFailure error is so generic no service would ever be able to be done based on it, so make it informational. If there are any spots in th
PEL: Change common errors to nonError in msg reg
The InternalFailure error is so generic no service would ever be able to be done based on it, so make it informational. If there are any spots in the code base that create this error where a user does need to know about it they will be changed to more specific errors.
Also do the same for the other common generic errors. It's possible these aren't actually committed in code and are only thrown back from D-Bus method calls, but there isn't really a way to know for sure so they have entries.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I12f4d8c977c84aaa2618f209daee3c95dfef7801
show more ...
|
1e792db1 | 07-Jan-2022 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Add low temperature message reg entries
Add entries for temperature critical/warning low and critical/warning low clear to the message registry.
The sensor-monitor application creates these er
PEL: Add low temperature message reg entries
Add entries for temperature critical/warning low and critical/warning low clear to the message registry.
The sensor-monitor application creates these errors when sensors that have these low thresholds defined trip their alarms.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ifb926d1ebeeed246e87565dd69c48a08db61e1dc
show more ...
|
50bfa69a | 06-Jan-2022 |
Sumit Kumar <sumit_kumar@in.ibm.com> |
PEL: Pass in subsystem to use with additional data
There is a requirement to pass in the subsystem to use with the additional data field. In the process update the user header code and SRC with the
PEL: Pass in subsystem to use with additional data
There is a requirement to pass in the subsystem to use with the additional data field. In the process update the user header code and SRC with the passed-in subsystem value instead from the message registry.
Signed-off-by: Sumit Kumar <sumit_kumar@in.ibm.com> Change-Id: I08c8c3bab100fec581df9043f4bb27b28cb556e1
show more ...
|
cc8b1116 | 15-Dec-2021 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Update location code D-Bus interface
The com.ibm.ipzvpd interface is being deprecated, so switch to the replacement one.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I221925a5b9
PEL: Update location code D-Bus interface
The com.ibm.ipzvpd interface is being deprecated, so switch to the replacement one.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: I221925a5b970e63d37bb0add3beb0034a7928645
show more ...
|
f928c4a2 | 27-Nov-2021 |
rajerpp1 <rajerpp1@in.ibm.com> |
PEL: Clock SBE HWP error handling support
-Supporting special error handling for clock related hwp failure -For clock hwp failures we need to -Callout the planar -Using new variable
PEL: Clock SBE HWP error handling support
-Supporting special error handling for clock related hwp failure -For clock hwp failures we need to -Callout the planar -Using new variable (isPlanarCallout) defined in libekb
Signed-off-by: Rajees P P <rajerpp1@in.ibm.com> Change-Id: I82b04e110abccf3de8cc97149344c0b54471ce69
show more ...
|
7f4c11f3 | 13-Dec-2021 |
rajerpp1 <rajerpp1@in.ibm.com> |
PEL: Fixing wrong callout of reference target
-The target provided in HwCallout structure is, only a reference target to find the actual hardware target need to be called out. So, this target shou
PEL: Fixing wrong callout of reference target
-The target provided in HwCallout structure is, only a reference target to find the actual hardware target need to be called out. So, this target should not be called out.
Signed-off-by: Rajees P P <rajerpp1@in.ibm.com> Change-Id: Ibf58b47ceaed051bc88481c631844553d671d409
show more ...
|
dd4bd482 | 08-Dec-2021 |
Zane Shelley <zshelle@us.ibm.com> |
PEL: openpower-hw-diags informational registry entry
Signed-off-by: Zane Shelley <zshelle@us.ibm.com> Change-Id: I79e0f50fae9920f0f14e7c158e9d8d9a576732c4 |
c30f00a3 | 18-Nov-2021 |
Brandon Wyman <bjwyman@gmail.com> |
PEL: Add power supply fan fault
Add a message registry entry for the power supply fan fault. This will be used by the phosphor-psu-monitor application.
Change-Id: I4706444ee382f89246543345c2813cacb
PEL: Add power supply fan fault
Add a message registry entry for the power supply fan fault. This will be used by the phosphor-psu-monitor application.
Change-Id: I4706444ee382f89246543345c2813cacb27416cf Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
show more ...
|
7d2bea7e | 29-Nov-2021 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
PEL: Add error message registry entry for devtree reinit
Adding error entry in the message registry JSON file for devtree reinit failure during Host reboot path. During the regular host reboot path
PEL: Add error message registry entry for devtree reinit
Adding error entry in the message registry JSON file for devtree reinit failure during Host reboot path. During the regular host reboot path only for sleeted DEVTREE attributes need to be reinitialised with previous boot value and all other Attributes need to reinitialised with default value. This new message registery is used to report any failure during this devtree reinitialise function.
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com> Change-Id: Iad60acd08135b21927b260779a5a2a3f0729e45f
show more ...
|
002d8cfd | 01-Dec-2021 |
Brandon Wyman <bjwyman@gmail.com> |
PEL: Add power supply PS_Kill fault
The power supply can indicate a PS_Kill fault due to a load problem or due to the lid on the enclosure being open. Rainier and Everest will have separate call out
PEL: Add power supply PS_Kill fault
The power supply can indicate a PS_Kill fault due to a load problem or due to the lid on the enclosure being open. Rainier and Everest will have separate call outs for this fault.
Use the existing BMC0005 isolation procedure that goes with the over-current fault. That procedure should lead Everest to use the already existing and documented LDSWTCH symbolic FRU.
Change-Id: I4e61f6ff883bdf4ce590619009c144d03f49f465 Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
show more ...
|
b3d45eda | 07-Dec-2021 |
Ramesh Iyyar <rameshi1@in.ibm.com> |
PEL: Added the new message registry for op-hw-isolation error
- The openpower-hw-isolation is used to isolate the hardware from the system boot, and also used for creating the hardware status ev
PEL: Added the new message registry for op-hw-isolation error
- The openpower-hw-isolation is used to isolate the hardware from the system boot, and also used for creating the hardware status event to inform the current hardware status via the external interface.
- The openpower-hw-isolation might encounter the issue while processing the hardware isolation record and hardware status event so that need to create the error log (aka PEL) with specific error for the op-hw-isolation failures.
Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com> Change-Id: Iea9bae2862b3849bcd562be431a54bf4efed5ace
show more ...
|
8c3f1fe0 | 07-Dec-2021 |
Ramesh Iyyar <rameshi1@in.ibm.com> |
PEL: Added the new component id for the op-hw-isolation
- The openpower-hw-isolation is used to isolate the hardware from the system boot, and also used for creating the hardware status event to
PEL: Added the new component id for the op-hw-isolation
- The openpower-hw-isolation is used to isolate the hardware from the system boot, and also used for creating the hardware status event to inform the current hardware status via the external interface.
- The openpower-hw-isolation might encounter the issue while processing the hardware isolation record and hardware status event so that need to create the error log (aka PEL), and that demands to have a specific component id for the openpower-hw-isolation application.
Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com> Change-Id: I24e372b74dcdf7e4fff3505ebeacac5cd7d526ff
show more ...
|
35e79a80 | 30-Nov-2021 |
Matt Spinler <spinler@us.ibm.com> |
PEL: Emit InterfacesAdded on PEL.Entry iface
The constructor used when creating this interface object doesn't emit an InterfacesAdded signal, even though the optional skipSignal argument defaults to
PEL: Emit InterfacesAdded on PEL.Entry iface
The constructor used when creating this interface object doesn't emit an InterfacesAdded signal, even though the optional skipSignal argument defaults to false. It turns out skipSignal is only used for skipping PropertiesChanged signals.
Signed-off-by: Matt Spinler <spinler@us.ibm.com> Change-Id: Ia27dd53d7c0b29ae12a8366899cb4e0a64f01def
show more ...
|
9368b714 | 17-Nov-2021 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
PEL: Add procedure callout for hwp errors
Added infrastructure to enable procedure callout support for the HWP failure related PEL.
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com> Change-Id:
PEL: Add procedure callout for hwp errors
Added infrastructure to enable procedure callout support for the HWP failure related PEL.
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com> Change-Id: Ia688650a1f1c8a184aebb3d258d99bbb1a15d244
show more ...
|
363ac769 | 17-Nov-2021 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
PEL: Fix pdbg target traversal error path issues
Existing pdbg target traversal call back function continues traversal incase any attribute read failure on entity path associated target. This logic
PEL: Fix pdbg target traversal error path issues
Existing pdbg target traversal call back function continues traversal incase any attribute read failure on entity path associated target. This logic is wrong, should be continue collecting available attribute information and stop traversal in this case.
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com> Change-Id: I999254dc24f4620f710f84a4d476dbccc573516d
show more ...
|
417b88ea | 17-Nov-2021 |
Jayanth Othayoth <ojayanth@in.ibm.com> |
PEL: Add location code information support for sub FRUs
only for FRU(Field Replaceable Units) devices. Existing SBE error handling code doesn't provide Location code information to PEL back-end code
PEL: Add location code information support for sub FRUs
only for FRU(Field Replaceable Units) devices. Existing SBE error handling code doesn't provide Location code information to PEL back-end code, and which creates errors in PEL processing for sub FRU callouts from PHAL requested error PEL.
This commits helps to fix the this problem by using libphal based api to get location code instead of direct devtree attribute read. Libphal api uses algorithm to get Location code for sub FRUs by getting information from the parent FRU.
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com> Change-Id: I7203c8a3175e17e8126448c4d6605b75c07d591d
show more ...
|
f380c516 | 19-Nov-2021 |
Sumit Kumar <sumit_kumar@in.ibm.com> |
PEL: Fix for error - unable to read PEL ID file
This is a case when PEL daemon can't read pelID file to get the next pel Id to use. It could be that the file got corrupted during code update or fact
PEL: Fix for error - unable to read PEL ID file
This is a case when PEL daemon can't read pelID file to get the next pel Id to use. It could be that the file got corrupted during code update or factory reset leading to zeros data in file. The fix is to delete the file as there is already code later to recreate file if not available.
Signed-off-by: Sumit Kumar <sumit_kumar@in.ibm.com> Change-Id: I42372cc1d79ece5914e7fdb51f3fa2a2d9cb07e7
show more ...
|