Fix spelling mistakes using codespell

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I698b2cb894ac9b6f17b1571b0886c72ae4bc09b5

Fix spelling errors in log messages

Fixed three instances of misspelled 'occurred' in error messages
and comments.

Change-Id: I3d77a1a4347b7fabbdb6c0d20e986ce878a8c305
Signed-off-by: Arun R <rarun@

Fix spelling errors in log messages

Fixed three instances of misspelled 'occurred' in error messages
and comments.

Change-Id: I3d77a1a4347b7fabbdb6c0d20e986ce878a8c305
Signed-off-by: Arun R <rarun@ami.com>

show more ...

PEL: Add BMC redundancy errors

Add the PEL message registry entries for BMC redundancy related errors.

Also create a new component ID for these, and add the three new
maintenance procedures used.

PEL: Add BMC redundancy errors

Add the PEL message registry entries for BMC redundancy related errors.

Also create a new component ID for these, and add the three new
maintenance procedures used.

The use of the 'cec_hardware' subsystem is temporary until a new
'cec_redundancy' subsystem is added to the PEL spec. Previous
generations used 0x5E for that, but that is used in the registry already
for the SP to hostboot interface.

Change-Id: Iea3fb86f541cc3dca0ced7b3c8b2dc2a6f2a6bb4
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

PEL:Add chassis SRCs to message registry

Added drwrpwr iso procedure to pel_values.cpp, and added SRCS: 110074F0,
110074F1 for input power errors, 110088E0, 110088E0 for Chassis presence
errors to m

PEL:Add chassis SRCs to message registry

Added drwrpwr iso procedure to pel_values.cpp, and added SRCS: 110074F0,
110074F1 for input power errors, 110088E0, 110088E0 for Chassis presence
errors to message_registry.json.

Tested:
Verified changes passed validate_registry.py script in
extensions/openpower-pels/registry/tools. Verified PELS were generated
in event logs, copying the modified message_registry.json into
/etc/phosphor-logging/ on the BMC, and used busctl to call the create
method to create an event log corresponding to the message registry
entry under test, and checked the PEL that was created using peltool.

Change-Id: I8b291c2ebd1605f783b8c322615301916595f9d5
Signed-off-by: Brendan Singer <Brendan.Singer@ibm.com>

show more ...

PEL: Don't hardcode obj path for IM keyword

The VSBP interface that holds the IM VPD value will not always be at a
constant object path. Instead of hardcoding it, use the mapper to find
the path th

PEL: Don't hardcode obj path for IM keyword

The VSBP interface that holds the IM VPD value will not always be at a
constant object path. Instead of hardcoding it, use the mapper to find
the path the interface is on.

A new getSubTree() helper was created for this, and a previous use of a
raw GetSubTree call was changed to use it.

Tested:
IM keyword still shows up in UserData:
```
{
...
"HostState": "Off",
"System IM": "50001000"
}
```

Change-Id: I6aa60d644bf1eb0bbdfb96ec83250eac9344e8df
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

PEL:clang-tidy: Removed unused constants

Fix clang-tidy errors like:
```
../extensions/openpower-pels/tools/peltool.cpp:39:16: error: unused variable 'logging' [clang-diagnostic-unused-const-variabl

PEL:clang-tidy: Removed unused constants

Fix clang-tidy errors like:
```
../extensions/openpower-pels/tools/peltool.cpp:39:16: error: unused variable 'logging' [clang-diagnostic-unused-const-variable]
39 | constexpr auto logging = "xyz.openbmc_project.Logging";
| ^~~~~~~
```

Change-Id: I7b0db7fe0150937b1a5eb389ea68ef82574f3998
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

PEL:clang-tidy: Fix unchecked opt in src.cpp

Fix clang-tidy errors like:

```
../extensions/openpower-pels/src.cpp:647:29: error: unchecked access to optional value [bugprone-unchecked-optional-acce

PEL:clang-tidy: Fix unchecked opt in src.cpp

Fix clang-tidy errors like:

```
../extensions/openpower-pels/src.cpp:647:29: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-erro
rs]
647 | entry->fruIdentity()->getMaintProc().value()),
| ^
```

Change-Id: Ibfcf0245e93cd3179ec97bb8e5b5398790b0128c
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

PEL:clang-tidy: Fix modernize-use-nullptr

Fix clang-tidy errors:

```
../extensions/openpower-pels/src.cpp:123:20: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
123 | if (pMod

PEL:clang-tidy: Fix modernize-use-nullptr

Fix clang-tidy errors:

```
../extensions/openpower-pels/src.cpp:123:20: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
123 | if (pModule == NULL)
| ^~~~
| nullptr
```

Change-Id: I3e3d766411b11b7b2b1a52f257c03f71ffb2f971
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

PEL:clang-tidy: Fix unchecked opt in PLDM call

Fix clang-tidy error:

```
../extensions/openpower-pels/pldm_interface.cpp:231:36: error: unchecked access to optional value [bugprone-unchecked-option

PEL:clang-tidy: Fix unchecked opt in PLDM call

Fix clang-tidy error:

```
../extensions/openpower-pels/pldm_interface.cpp:231:36: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warni
ngs-as-errors]
231 | auto rc = encode_new_file_req(*_instanceID, pelFileType, _pelID, _pelSize,
```

Change-Id: I158e21f6c36bf9592e017c5a48c14a7a746bbcc9
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

PEL: Added the new message registry for data-sync

These error messages are associated with data-sync.

- xyz.openbmc_project.RBMC_DataSync.Error.SyncFailure

This is for scenarios where the issued

PEL: Added the new message registry for data-sync

These error messages are associated with data-sync.

- xyz.openbmc_project.RBMC_DataSync.Error.SyncFailure

This is for scenarios where the issued sync fails,
e.g: Permanent error encountered by an issued rsync,
Failure after all retry attempts etc.

- xyz.openbmc_project.RBMC_DataSync.Error.SyncEventsFailure

This is for scenarios when an event associated with a path,
e.g: Setting a watcher for path, fails.

- xyz.openbmc_project.RBMC_DataSync.Error.ParserFailure

This is when there is a failure during parsing the data sync
JSON configurations.

The above errors are considered as predictive.

- xyz.openbmc_project.RBMC_DataSync.Error.NotifyFailure

This is used when any unexpected outcome occurs regarding
the notify request/service provided by data-sync.
Treated as a non-error log.

Tested
Creation of error log and contents tested in simics.

Change-Id: I27deb1e70444a81b2cddb5bdb892d82b5af5ea69
Signed-off-by: Riya Sabu <riya.sabu461@gmail.com>

show more ...

PEL: Add BMC datasync component ID

The datasync is used to synchronize the filesystem between BMC.
Adding the component to the list with ID "7000" to incorporate
DataSync specific error messages in

PEL: Add BMC datasync component ID

The datasync is used to synchronize the filesystem between BMC.
Adding the component to the list with ID "7000" to incorporate
DataSync specific error messages in the registry.

Change-Id: If6a3227fbfae9712e0f0dd501ab589b36d0beaa9
Signed-off-by: Riya Sabu <riya.sabu461@gmail.com>

show more ...

PEL: Fix typo in function name

Change-Id: I8d6907344151c803e91afdf8c6c3deb904ec315e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more e

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more efficient and succinct.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2516cfa21eaf0fc51902f2b23d4a54241e9d4978

show more ...

Copyright: Move to SPDX-License-Identifier

Original copyright holders have been preserved, this patch moves the
copyright notice to the compact SPDX notation.

Change-Id: I197e79ed3f9b09e293e02bda82

Copyright: Move to SPDX-License-Identifier

Original copyright holders have been preserved, this patch moves the
copyright notice to the compact SPDX notation.

Change-Id: I197e79ed3f9b09e293e02bda820fa4c52d9a88e8
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

PEL: FIX: Wait for obmc-recover-pnor before PHAL init

Problem:
- It is observed intermittent core dumps from phosphor-log-manager
during BMC graceful restart at OSRunning
- Journals show an abort(

PEL: FIX: Wait for obmc-recover-pnor before PHAL init

Problem:
- It is observed intermittent core dumps from phosphor-log-manager
during BMC graceful restart at OSRunning
- Journals show an abort() from dt_expand() in libpdbg immediately
after openpower-update-bios-attr-table.service completes

Root cause:
- phosphor-logging subscribed to JobRemoved for openpower-update-
bios-attr-table.service and kicked off PHAL init on that signal
to avoid loading the default devtree
- In this window, obmc-recover-pnor.service which runs after the
openpower-update-bios-attr-table.service may still accessing the
devtree, so PHAL attempts to parse a devtree that isn’t ready,
leading to libpdbg’s abort() in dt_expand() and a crash

Fix proposed:
- Switch Jobremoved watch from openpower-update-bios-attr-table.
service to obmc-recover-pnor.service

Tested:

Before fix, journal traces showed core dump in phosphor-logging:

```
systemd-coredump[916]: elfutils disabled, parsing ELF objects not
supported
systemd-coredump[916]: [��] Process 400 (phosphor-log-ma) of user
0 dumped core.
systemd[1]: xyz.openbmc_project.Logging.service: Main process
exited, code=dumped, status=6/ABRT
systemd[1]: xyz.openbmc_project.Logging.service: Failed with
result 'core-dump'
```

After fix, no core dump observed in traces, service exits cleanly:

```
systemd[1]: Stopped Phosphor LED Group Management Daemon
systemd[1]: xyz.openbmc_project.Logging.service:
Deactivated successfully.
systemd[1]: Stopped Phosphor Log Manager.
systemd[1]: xyz.openbmc_project.Logging.service:
Consumed 7.914s CPU time.
```

Change-Id: Ic907dcae2b20a81f485fe589703e8e84e5128608
Signed-off-by: Manish Tiwari <tmanish.in+openbmc@gmail.com>

show more ...

PEL: Update ECC error paths

The ECC error paths didn't match the code that creates these errors.

Change-Id: I9364eed0a2d24c29a75392cd091b1de6e1b372a5
Signed-off-by: Eddie James <eajames@linux.ibm.c

PEL: Update ECC error paths

The ECC error paths didn't match the code that creates these errors.

Change-Id: I9364eed0a2d24c29a75392cd091b1de6e1b372a5
Signed-off-by: Eddie James <eajames@linux.ibm.com>

show more ...

PEL: registry: Add message for integrity audit event

Add a new informational log message for when the kernel records an audit
event of type Integrity. These events are related to the Integrity
Measu

PEL: registry: Add message for integrity audit event

Add a new informational log message for when the kernel records an audit
event of type Integrity. These events are related to the Integrity
Measurement Architecture (IMA) functionality in the BMC, and would help
the user to be aware of any activity related to IMA, such as attempts to
execute unsigned binaries.

Change-Id: Idcc20cf46de6c5ecee85990fb21983afb14e7b48
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

PEL: Add journal trace for VPD PELs

This commits adds JournalCapture in message_registry for VPD PELs to
capture journals at the time of PEL.

Change-Id: Ibdd2c9b02d715c6f20644330e6a4545bdec1d90f
Si

PEL: Add journal trace for VPD PELs

This commits adds JournalCapture in message_registry for VPD PELs to
capture journals at the time of PEL.

Change-Id: Ibdd2c9b02d715c6f20644330e6a4545bdec1d90f
Signed-off-by: Anupama B R <anupama.b.r1@ibm.com>

show more ...

PEL: Track PEL creation time for debug

Track how long it takes to create the PEL portion of an event by saving
it as journal metadata. It's only viewable with journalctl options like
'-o verbose'.

PEL: Track PEL creation time for debug

Track how long it takes to create the PEL portion of an event by saving
it as journal metadata. It's only viewable with journalctl options like
'-o verbose'. This can be used for debug and to help when trying to
improve PEL creation performance.

Also move down the trace where this is logged until after the PEL D-Bus
interfaces are updated.

Tested:

Can see the new field:

MESSAGE=Created PEL 0x50000048 (BMC ID 72) with SRC BD55400C
ID=0x50000048
BMCID=72
PEL_CREATE_DURATION=181

Change-Id: I165901f49a229eacf66be76d79972240a41aa155
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

PEL: registry: Add message for factory reset requested

Add a new informational log message for when a BMC factory reset is
requested.

Change-Id: Id4d8ea96682f4e534a3c177daf2c3fda67ec5898
Signed-off

PEL: registry: Add message for factory reset requested

Add a new informational log message for when a BMC factory reset is
requested.

Change-Id: Id4d8ea96682f4e534a3c177daf2c3fda67ec5898
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

PEL: README: Fix linting

Change-Id: Id9656444a88b3b8a5339ecb9562ba4314ed45f73
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

PEL: Add VPD parsing error

VPD parsing can be failed for both data and ECC errors for different
records for a single file. So new generic error is introduced for
exception occurred during VPD parsin

PEL: Add VPD parsing error

VPD parsing can be failed for both data and ECC errors for different
records for a single file. So new generic error is introduced for
exception occurred during VPD parsing.

Change-Id: I4e3bd3814856313d084035c735f37e14e290cd2d
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

show more ...

markdownlint: minor fixes

Make minor fixes suggested by markdownlint.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If0da7a57283aafc4d387a15ded83384302af8e90

PEL: Remove Section::validate() virtual func

There is no need for the validate() function that every PEL section uses
to be virtual, because it is always called directly by the class it's
defined in

PEL: Remove Section::validate() virtual func

There is no need for the validate() function that every PEL section uses
to be virtual, because it is always called directly by the class it's
defined in.

Also, cppcheck was complaining that constructors, where validate() is
called, can't call virtual functions anyway.

Tested:
Unit tests pass

Change-Id: I7190a5299baa85f7956963e21189da0f4c62b68a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

PEL: Removed unused includes

The clangd LSP indicates when includes aren't used directly.

Tested:
Unit tests pass.

Change-Id: I8290fe59abd1cef4fada27aeb5adb2c45c289abb
Signed-off-by: Matt Spinler

PEL: Removed unused includes

The clangd LSP indicates when includes aren't used directly.

Tested:
Unit tests pass.

Change-Id: I8290fe59abd1cef4fada27aeb5adb2c45c289abb
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...