Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf30

Switch from Force Tags to Test Tags

Force Tags is deprecated in Robot 7.0 and will eventually
warn and then after that stop working. Test Tags performs
the same function per docs.

Change-Id: I7cf305754b247b995a05d8da3b9de9ed613ecae2
Signed-off-by: Matt Fischer <matthew.fischer@hpe.com>

show more ...

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the

Robot Framework 7.0 changes

Update robot code syntax overall in the repo

Changes:
- Update the requirement.txt package version for robot
- The '[Return]' setting is deprecated.
Use the 'RETURN' statement instead.
- Singular section headers like '*** Test Case ***'
are deprecated. Use plural format like
'*** Test Cases ***' instead.
- Singular section headers like '*** Variable ***'
are deprecated

Tested:
- Ran from sandbox with the version
$ robot --version
Robot Framework 7.0 (Python 3.10.12 on linux)

and also tested on latest python version

Robot Framework 7.0 (Python 3.11.9 on linux)

Change-Id: I54e85f9d799556c63b9a39f79483f83e9b980768
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Remove legacy test suites and move the SLP suite

Changes:
- As part of the legacy test cleanup, REST test suites
are removed and the SLP suite moved to security.

Tested:
- NA

Change-I

Remove legacy test suites and move the SLP suite

Changes:
- As part of the legacy test cleanup, REST test suites
are removed and the SLP suite moved to security.

Tested:
- NA

Change-Id: I0a44708981332b6cca35b7cef7480de8e8e68485
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Test suite robot syntax error fix

Error message:
Keyword 'BuiltIn.Should Be Equal As Strings'
got positional argument after named arguments.

Changes:
- Fix the dictionary access in test

Test suite robot syntax error fix

Error message:
Keyword 'BuiltIn.Should Be Equal As Strings'
got positional argument after named arguments.

Changes:
- Fix the dictionary access in test code. This is due to
robot old syntax vs newer version changes.

Tested:
- NA

Change-Id: I5bdfcb46e70e11c5dd77a8155d21c585bbeab0d2
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot
- Replaced all the Managers/bmc to Managers/${MANAGER_ID} across all the scripts
- Also in data/variables.py updated chassis id for the few redfish uri.

Tested:
- Ran All The Scripts Successfully

Change-Id: Iff3673aae27657e0799dec5cb94c1651a0cd5d18
Signed-off-by: ganesanb <ganesanb@ami.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c8895

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c88953
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix test case tag names from multiple suites

Change-Id: I3890effc456c6f8f406d9c010dc7dafff22b503e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Automation fix to delete the non functional image

Changes:
- In previous code if user try to install the firmware which is
non-functional but in active state then the code update skip,

Automation fix to delete the non functional image

Changes:
- In previous code if user try to install the firmware which is
non-functional but in active state then the code update skip,
and it changes the priority to lowest and then make it
fucntional image.
- In new implementation, user can flash the firmware.
- When user flash an image which is non functional on BMC,
then these changes will delete the non functional image on BMC.
After the deleting the non fucntional image, a fresh code update
start with user image.

Signed-off-by: susilsi7 <susilsi7@in.ibm.com>
Change-Id: Ib4a42506614495e3c0b572d445d3858c13bfc4fc

show more ...

Move REST software manager from redfish to extended/code_update/ directory

Redfish code changes for the same are WIP.

Change-Id: I988aaf3350f2ff2966138e0a7dd21d79b41093cb
Signed-off-by: George Keis

Move REST software manager from redfish to extended/code_update/ directory

Redfish code changes for the same are WIP.

Change-Id: I988aaf3350f2ff2966138e0a7dd21d79b41093cb
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add Test Timeout directive to force test update to exit

We have noticed that some of the update hangs for unexplained
reason at the moment. Adding this directive may help do clean
shutdown fail tha

Add Test Timeout directive to force test update to exit

We have noticed that some of the update hangs for unexplained
reason at the moment. Adding this directive may help do clean
shutdown fail than hanging.

Change-Id: Ibaab502974c70f89a6dc2bb6c4de300ac8185087
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Revert "Automation fix to delete the non functional image"

This reverts commit b7df3de484b7334cea20a8201531433fdc378b84.

Reason for revert: Failing code update due to condition it doesnt meet

Chan

Revert "Automation fix to delete the non functional image"

This reverts commit b7df3de484b7334cea20a8201531433fdc378b84.

Reason for revert: Failing code update due to condition it doesnt meet

Change-Id: Ic2269f5f8945c3c78fb3969005e065683c68d3b9

show more ...

Automation fix to delete the non functional image

Changes:
- In previous code if user try to install the firmware which is
non-functional but in active state then the code update skip,

Automation fix to delete the non functional image

Changes:
- In previous code if user try to install the firmware which is
non-functional but in active state then the code update skip,
and it changes the priority to lowest and then make it
fucntional image.
- In new implementation, user can flash the firmware.
- When user flash an image which is non functional on BMC,
then these changes will delete the non functional image on BMC.
After the deleting the non fucntional image, a fresh code update
start with user image.

Change-Id: I98e2f98698e7c0b9535cc4415b55081d445cc16c
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

Fix typo in code documentation

Change-Id: Ib2f0023657ce4f9f8feddfac772c0ff53e88e50b
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Set ApplyTime policy to OnReset

Changes:
- Set ApplyTime attribute to "OnReset" to prevent BMC taking
auto reset when activation completes.

Change-Id: I21077bd4b7cb0155f2091239a736cdfb4c2

Set ApplyTime policy to OnReset

Changes:
- Set ApplyTime attribute to "OnReset" to prevent BMC taking
auto reset when activation completes.

Change-Id: I21077bd4b7cb0155f2091239a736cdfb4c20ed4b
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Address issue for deprecated syntax

Change from :FOR to FOR/END to address a new WARNING in
the new robot version.

Sample warning message as mention below.

FOR loop starting on line 26: For loop h

Address issue for deprecated syntax

Change from :FOR to FOR/END to address a new WARNING in
the new robot version.

Sample warning message as mention below.

FOR loop starting on line 26: For loop header
': FOR' is deprecated. Use 'FOR' instead.

Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>
Change-Id: I1720b3c7e6fbbafda3fca6f91edf97c80fdd9f41

show more ...

Remove TODO action items from the codes

These comments are no longer valid or lost in time. The fixes
are resilience so far and changing could lead to wider impacts.
Removing them for good and we wi

Remove TODO action items from the codes

These comments are no longer valid or lost in time. The fixes
are resilience so far and changing could lead to wider impacts.
Removing them for good and we will fix as an when it is reported.

Change-Id: Ida20fa841565de63823f7066bd5106c5b68ef880
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Adjust to unquoted version_id

The version_id from /etc/os-release is no longer double-quoted. Made
adjustments to bmc code update code.

Change-Id: I9135292c9068c3a73620f72ca6667920c824933d
Signed-

Adjust to unquoted version_id

The version_id from /etc/os-release is no longer double-quoted. Made
adjustments to bmc code update code.

Change-Id: I9135292c9068c3a73620f72ca6667920c824933d
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Update pass execution check for code update

Change-Id: I29818d0125e09c806ba30a6414bab22a13666075
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Removing keyword to install certificate using REST

Change-Id: I7b5e7869af19e64cbbb18d2ececfd9b3fa9f6c15
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>

Robot coding guideline fixes

Changes:
- Remove excessive new line entries.
- Fix line char 110 exceeding.

Change-Id: I06d99185d1507c704bd77d1b6998ed29b8df2e4e
Signed-off-by: George Keishing

Robot coding guideline fixes

Changes:
- Remove excessive new line entries.
- Fix line char 110 exceeding.

Change-Id: I06d99185d1507c704bd77d1b6998ed29b8df2e4e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Skip BMC image install if already functional

Changes:
- Added check to skip image upload if the same version is
already functional else the upload would fail otherwise
with "Version

Skip BMC image install if already functional

Changes:
- Added check to skip image upload if the same version is
already functional else the upload would fail otherwise
with "Version already exists or failed to be extracted."

Change-Id: I1e6c2e36cc39787873f3f8e3860bbc72cd4ad2fd
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

REST software priority set using boolean value

Change-Id: I6ec741513a0baf28ca43166d23831b5738b1096d
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Verify Post Code Update State

Resolve openbmc/openbmc-test-automation#1958

Change-Id: I298ec1c011d310c3aa35de250d1730657fe37dcc
Signed-off-by: Sivas SRR <sivas.srr@in.ibm.com>

Change Rvalid to Valid

Change all references to keywords like "Rvalid Values" to "Valid Values".
"Rvalid Values" has been deprecated.

Change-Id: I1b418fa69e5753c8bfb9e6a06a8b566359e10cae
Signed-off

Change Rvalid to Valid

Change all references to keywords like "Rvalid Values" to "Valid Values".
"Rvalid Values" has been deprecated.

Change-Id: I1b418fa69e5753c8bfb9e6a06a8b566359e10cae
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

host_code_update: Do not restart code update service

Restarting the code update services may had been needed as a workaround
at some point in time, but it should not longer be needed.

Tested: Perfo

host_code_update: Do not restart code update service

Restarting the code update services may had been needed as a workaround
at some point in time, but it should not longer be needed.

Tested: Performed a host code update on witherspoon.

Change-Id: Id3d4dc73658825cf4e99d6a0764b57a17d96120b
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...