resolve stricter warnings

In order to convert this repository to Meson, we need to make it
compile under `warning_level=3`. Fix a number of warning classes
across the repository or disable them.

S

resolve stricter warnings

In order to convert this repository to Meson, we need to make it
compile under `warning_level=3`. Fix a number of warning classes
across the repository or disable them.

Some fixes are:

* Add missing header files.
* Fully initialize structs as necessary.
* Add `__attribute__((unused))` on parameters as necessary.
* Fix comparisons between signed and unsigned.
* Fix printf specifiers as necessary.
* Avoid case-fallthrough.
* Remove if conditions which are always true.

Some warnings would require extensive code changes, due to their
pervasive use, and so are disabled at a per-file level:
* `-Wpointer-arith`
* `-Wunused-result`

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If8992b9108f12b39f796ed090ba29868c9f3c627

show more ...

Add backend_adjust_offset to avoid the windows overlap

In mihawk, the windows overlap will cause the cache coherence.
Hostboot writes the SPD data to BMC through a window and read it

Add backend_adjust_offset to avoid the windows overlap

In mihawk, the windows overlap will cause the cache coherence.
Hostboot writes the SPD data to BMC through a window and read it
back with another window. It causes the data missed and DIMM lost.

Hostboot log
23.80714|<<DBG-956|SPD::getMemType() - MemType: 0xff, Error: NoHUID: 0x30008.

BMC log: The overlaped windows
Window @ 0x756e0000 for size 0x00046000 maps flash offset 0x000e7000
Window @ 0x757e0000 for size 0x00048000 maps flash offset 0x000e5000

Tested: 1. In mihawk, it can fix the SPD cache coherence issue
2. Add unit test to verify VPNOR offset alignment

Change-Id: I92670ade4e2a91b5c49a0acabfc0456f90d49b93
Signed-off-by: Alvin Wang <alvinwang@msn.com>
[AJ: Remove some MSG_INFO() spam, fix whitespace issues]
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd: Remove flash API compatibility shim

The flash API compatibility was kept to reduce the line noise in the
previous backend patch. Remove the compatibility layer now and convert

mboxd: Remove flash API compatibility shim

The flash API compatibility was kept to reduce the line noise in the
previous backend patch. Remove the compatibility layer now and convert
the remaining call-sites.

Change-Id: I4b6e54f4463059a7804918add81e7572db7b7c21
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd: Add a backend abstraction layer to mboxd.

Introduce a backend abstraction, enabling multiple implementations to be
compiled in at once. This change formally abstracts the two exis

mboxd: Add a backend abstraction layer to mboxd.

Introduce a backend abstraction, enabling multiple implementations to be
compiled in at once. This change formally abstracts the two existing
backends, mtd and vpnor.

With the backend abstraction in place, subsequent backends are easier to
implement.

This change is based of Evan's work and he retains authorship credit. I
(AJ) have reworked the patch to pass the vpnor tests, refactored some
parts to enable broader use of const structures and others to clarify
the initialisation sequences.

Due to the existing lack of abstraction the patch has unfortunately
wide-ranging impacts. I've whittled it down as much as I consider
reasonable.

Change-Id: I29984a36dae4ea86ec00b853d2a756f0b9afb3ec
Signed-off-by: Evan Lojewski <github@meklort.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

daemon: Remove the concept of triggering or suppressing events

Rather, trigger them (or not) as necessary in the relevant code-paths.
This ensures that any call to one of protocol_events

daemon: Remove the concept of triggering or suppressing events

Rather, trigger them (or not) as necessary in the relevant code-paths.
This ensures that any call to one of protocol_events_{set,clear}()
actually has a consequence that we can set about dealing with in the
transport layer.

Change-Id: If64733fa53ed9def0da8330c99cbe48327bab934
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

windows: Always allocate a default-size dirty byte map

The current strategy caused memory corruption if windows are down-sized
from the default when a dirty-byte-map reallocation is trig

windows: Always allocate a default-size dirty byte map

The current strategy caused memory corruption if windows are down-sized
from the default when a dirty-byte-map reallocation is triggered, as the
code would only allocate a dirty byte map of the current size. When the
window is resized up a gain the dirty byte map buffer is too small, and
we write off the end.

Instead, always allocate a byte map of the default window size which is
the largest the window can be.

Change-Id: I6f8dc414fb26c64e4947d5a19d6b795ead36e180
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd: Refactor and rename mbox.h to mboxd.h

Refine the purpose of the header file to represent what's required for
the daemon itself, not its constituent pieces. Rather, split those

mboxd: Refactor and rename mbox.h to mboxd.h

Refine the purpose of the header file to represent what's required for
the daemon itself, not its constituent pieces. Rather, split those
definitions out to their respective header files and include them as
necessary.

Finally the header file is renamed to better reflect its purpose.

Change-Id: I48c409f57d96c844589cd865b24f197477dfe87c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

protocol: Provide abstraction over event notification

How this works will be transport-dependent. Move the event notification
helpers into the protocol abstraction and call-back through

protocol: Provide abstraction over event notification

How this works will be transport-dependent. Move the event notification
helpers into the protocol abstraction and call-back through the
registered flush handler as necessary.

Change-Id: I29e3a9a9785b92de46a2b2750257fb7f8480a184
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

mboxd: Cleanup errnos not captured by tests

Change-Id: I95d1eee536e4113867fceb5dcda45e15dc032002
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxd: Rename mboxd_msg to transport_mbox

Change-Id: I0f4e206648c02a98fa938a7e582470c8d90904f1
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename create_map_window to windows_create_map

Change-Id: Ic491b97b0aa775201f6fc709fb0703b3fde4d9b2
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename search_windows to windows_search

Change-Id: I523851c2cb654bc7c88532f2097f9c24196f6e78
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename find_largest_window to windows_find_largest

Change-Id: Id69c4773e5acb5c840f82b4ed708aa993a804aa7
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename find_oldest_window to windows_find_oldest

Change-Id: I7b76fc57b6b1002c195af86167ae4fa6fd99489c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename reset_all_windows to windows_reset_all

Change-Id: Ibcbfa51e83a678fb1eddeeebfb22dd870bb112da
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename reset_window to window_reset

Change-Id: I68a9e19c229b4c786be2a00c3ca7ed5e274c7a0f
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename close_current_window to windows_close_current

Change-Id: I77f54a95dca865b91c7ba4f51212e43a049bc62a
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename set_window_bytemap to window_set_bytemap

Change-Id: I0185e92cfb2adb0dff94f9a04f4fc225f640e446
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename alloc_window_dirty_bytemap to windows_alloc_dirty_bytemap

Change-Id: I33b115def628ad85a4034901c17611a9509575ad
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename write_from_window* to window_flush*

Change-Id: I17b3457c1689114e76652632358faca3a5130d9d
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename free_windows to windows_free

Change-Id: Ifd9edb499069b6b7df48155aa2c8e955426751a5
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

windows: Rename init_windows to windows_init

Change-Id: Icdee1694b230d3c03075b840ec31450a236ab9e1
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

mboxd: Rename windows files

Change-Id: I44e110906fd0f751f8f34b175f971e65896a7301
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>