clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ica590f8613f1fb89ab1ca676ac51c1cc7e38d67f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I3e9e6350864ac267819a4b8d670bef7d3746976e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch

use std::format instead of fmt::format

The std::format is sufficient for the uses in this repository except
for in one file (override_fan_target.cpp, since P2286 isn't supported
by GCC yet). Switch to std::format whenever possible.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib2576fb530a4d7ce238e1b0bd95b40b476ec2107

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I152f141a5e8343b92b5ce81d3ca16eec77b5606b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

control: Fix InterfacesRemoved match string

The interfaces_removed trigger was using the wrong match for the
InterfacesRemoved signal. It was trying look for the object path in
question to be the '

control: Fix InterfacesRemoved match string

The interfaces_removed trigger was using the wrong match for the
InterfacesRemoved signal. It was trying look for the object path in
question to be the 'path' field, but 'path' is just the path of the
object manager sending the signal. It should be looking at argument 0
instead. This was previously fixed for InterfacesAdded but somehow
missed for this one.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If818b228472606dd204d507cfe04c7bacdc5fc03

show more ...

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review

meson support: remove code warnings 2

This commit contains code changes necessary to support the increased
warning level from Meson builds. Most changes are for unused variables.
to keep the review size manageable, this commit contains only control
changes (plus one in sensor-monitor).

Change-Id: Ie20f1d9028add4b605e4cc9fb230940710365706
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

control: Be more lenient toward missing sensors

In the cases where the service name of a sensor (i.e. group member) is
known ahead of time, but that service isn't actually running, the code
will try

control: Be more lenient toward missing sensors

In the cases where the service name of a sensor (i.e. group member) is
known ahead of time, but that service isn't actually running, the code
will try to make a get property call on it anyway and crash. Fix that
by catching the exception and continuing on.

Also, if the same type of service isn't running but is used in an action
that runs on a timer with 'preload_groups' set in the config to have the
code try to get all properties in the groups after each timer
expiration, there will be an exception thrown there too. In that case,
the exception is caught by the sdeventplus handler so the app doesn't
crash, but it prevents the run() call from completing. Catch that
exception as well in Manager::addGroups() so the actions can complete.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ifb56333508c3ceb6027e1e004d946c330dbd8634

show more ...

control: Let Manager::addObjects() take a service

When calling Manager::addObjects(), pass in the service of the object,
if known, so that addObjects() can use that service to call
getManagedObjects

control: Let Manager::addObjects() take a service

When calling Manager::addObjects(), pass in the service of the object,
if known, so that addObjects() can use that service to call
getManagedObjects() with and add objects to the cache even if the
D-Bus path passed in doesn't exist.

This fixes a bug where if the path doesn't exist, that function won't
add anything at all, even though getProperties() in init.cpp was
depending on it doing that so that it only needed to call addObjects()
once per group as a performance enhancement.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I971a244d665d3aaf493c3d03e7a4fec87e7e512d

show more ...

control:init trigger: Only call addObjects once

The 'init' trigger will attempt to add the D-Bus properties of all of
its group members to the objects cache with the Manager::addObjects()
function.

control:init trigger: Only call addObjects once

The 'init' trigger will attempt to add the D-Bus properties of all of
its group members to the objects cache with the Manager::addObjects()
function.

That function will call GetManagedObjects to add *all* group D-Bus
paths provided by the service that has the path/interface/property
passed in.

If the group had a service listed in its JSON configuration, then all
members of the group come from the same service, so we know the
first addObjects call would add all group members so there is no need to
keep calling it on the remaining members.

This can lead to a significant performance improvement on startup when
the D-Bus objects in the groups don't exist yet since it would end up
calling addObjects on each member which drives at least GetSubTree
mapper calls each time.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Icc27fdae922fa6f068cd72d9c2299451f768e7d6

show more ...

control - Ensure `nameHasOwner` set on all group members

It was found that `nameHasOwner` method calls upon fan control starting
was not setting all group members' service owned states. This was due

control - Ensure `nameHasOwner` set on all group members

It was found that `nameHasOwner` method calls upon fan control starting
was not setting all group members' service owned states. This was due to
skipping group members if they were hosted by the same service, which
actually caused a problem later when the action would be run looking at
the service state for all groups members. With this fix all group
members get an initial service owned state thru `nameHasOwner`.

Change-Id: Icd8e16e0a2235522aa531a629a82aa2af47c5199
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control - Remove `nameOwnerChanged` signal flight recorder

Remove due to the possibility of being called more than once if more
than one event uses the same group trigger as it could be confusing th

control - Remove `nameOwnerChanged` signal flight recorder

Remove due to the possibility of being called more than once if more
than one event uses the same group trigger as it could be confusing that
more than one signal was received when it was not. This is due to the
`sd_bus_message_rewind` in Manager::handleSignal().

Change-Id: I6e6739658c67fe745e525b3da9bffd0213119c8c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: `nameOwnerChanged` signals update all caches

When a `nameOwnerChanged` signal is received, update all entries within
the service tree cache for the given service's owner state change. Also,

control: `nameOwnerChanged` signals update all caches

When a `nameOwnerChanged` signal is received, update all entries within
the service tree cache for the given service's owner state change. Also,
use the service tree cache to cross reference removal of the associated
interfaces from objects within the objects cache.

Change-Id: Idab52a7533d626f1f7ef03397f904a74cb6457a3
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Support group service names in name owner triggers

If a group provides a service name, which is required to be the service
name for all group members and their interfaces, use that service

control: Support group service names in name owner triggers

If a group provides a service name, which is required to be the service
name for all group members and their interfaces, use that service name
when subscribing to nameOwnerChanged signals or calling the nameHasOwner
method. This can be used so that the service name does not have to be
looked up for each group member(and interface) or where the service for
a group(and interface) may not be on dbus when subscribing.

Change-Id: Ic52aef519eef61103478742c7a32e1f268809d38
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Create parameter trigger

Create a new event trigger that will run actions when a parameter is
either added, removed, or changed.

When the trigger is enabled it is added to the Manager clas

control: Create parameter trigger

Create a new event trigger that will run actions when a parameter is
either added, removed, or changed.

When the trigger is enabled it is added to the Manager class since that
is where parameters are stored, and then the Manager watches for
parameter changes and runs actions as needed.

The JSON config would look like:
{
"class": "parameter",
"parameter": "pcie_floor_index"
}

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I8ff281d49ac780e8ff38f3e8ed02ab95395f1fd3

show more ...

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Change-Id: I21baf6b70401d996519b5940d0cd685535475a2f
Signed-off-b

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Change-Id: I21baf6b70401d996519b5940d0cd685535475a2f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

control: Correct same signal object subscription of actions

When the same signal for a signal object is subscribed to (such as
across events), the actions should be included on the list of actions t

control: Correct same signal object subscription of actions

When the same signal for a signal object is subscribed to (such as
across events), the actions should be included on the list of actions to
be called when that specific signal is received. Previously these
actions were being moved off the event's list of actions, which was not
ideal. This instead copies a reference to the event's list of actions to
the list of actions to be called when the particular signal is received.

Change-Id: I260f7134a67ec82f9e90a66c4cfe9189ca7d4304
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Correct subscribing/handling of signals

When subscribing to signals, a pointer to the signal packages should be
used for the location to store the list of signal packages. This way the
call

control: Correct subscribing/handling of signals

When subscribing to signals, a pointer to the signal packages should be
used for the location to store the list of signal packages. This way the
callback is bound to the pointer and not the local variable that was
then getting moved.

Also, in handling signal messages, since there could be more than one
signal package to check against the signal received, a rewind must be
done to the signal message so that additional signal packages can read
the message contents again.

Change-Id: Iddea2011d25068d6f71bdee91801537cd5994728
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Have iA match use arg0Path param

InterfacesAdded signals are sent from the path the ObjectManager is
implemented on, and the path that has the new interface is in the first
argument of the

control: Have iA match use arg0Path param

InterfacesAdded signals are sent from the path the ObjectManager is
implemented on, and the path that has the new interface is in the first
argument of the signal.

For example, this dbus-monitor output:
path=/org/open_power/control;
interface=org.freedesktop.DBus.ObjectManager;
member=InterfacesAdded
object path "/org/open_power/control/occ1"

Update the match string for this signal to match on the group member
using 'arg0path' (the .../occ1 entry above) instead of 'path' (the
/org/open_power/control entry).

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If22157aa863504415f771aa366bc45b0e91405d7

show more ...

control: Subscribe to nameOwnerChanged once per service

When more than one member of an event group's service is the same,
there's no need to subscribe to the nameOwnerChanged signal again for
the s

control: Subscribe to nameOwnerChanged once per service

When more than one member of an event group's service is the same,
there's no need to subscribe to the nameOwnerChanged signal again for
the same service. This was causing the same actions that the first
subscription already moved into the list of actions for this signal to
be "moved" again which is not possible nor what should be done since
those same actions were already associated to the signal.

Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Change-Id: Idfc1da551cbdf8ca2e1697c02c408d3ed51bc31f

show more ...

control: Add power on/off triggers

Add two new classes of triggers: powerOn and powerOff. They are only
called during the power on and power off state changes, respectively.

They behave the same a

control: Add power on/off triggers

Add two new classes of triggers: powerOn and powerOff. They are only
called during the power on and power off state changes, respectively.

They behave the same as the existing init trigger.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I9d39210843192b9c343c7838c604fcce7c8d3f3d

show more ...

control: Timer trigger can preload groups

The timer trigger is used to run actions when it expires. This commit
adds the ability for it to preload group properties so the latest values
are in the c

control: Timer trigger can preload groups

The timer trigger is used to run actions when it expires. This commit
adds the ability for it to preload group properties so the latest values
are in the cache before it runs the actions.

This means that there doesn't need to be propertiesChanged triggers for
the groups, instead the load just reads them straight from D-Bus.

One reason to use this is so an action can be run on a slower cadence than
propertiesChanged signals would be sent. An example is a virtual sensor
that has component sensors spread out across multiple daemons. Even if
the daemons all use the same poll rates, they can be staggered between
them so virtual sensor changes could occur faster then any component
sensor read interval.

The trade off is there will be D-Bus traffic every timer interval, even
in the case the group property values don't change.

To enable this, use the following in the trigger JSON:
"preload_groups": true

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I1a92007c10fdd8017c1a89d15983ae50134c852a

show more ...

control: `member` signal triggers use event groups

Remove the ability to provide a `member` trigger's attributes from the
event trigger configuration in favor of using the configured event's
groups.

control: `member` signal triggers use event groups

Remove the ability to provide a `member` trigger's attributes from the
event trigger configuration in favor of using the configured event's
groups. This aligns with the recent design direction that event triggers
are setup from the event groups.

Change-Id: I304cfdffedd54317e440e7566988392a1410af6a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Use event groups on `signal` triggers

Use the provided event groups when enabling any `signal` triggers
instead of the action groups. Event groups are what's used with setting
up event trig

control: Use event groups on `signal` triggers

Use the provided event groups when enabling any `signal` triggers
instead of the action groups. Event groups are what's used with setting
up event triggers and may or may not be a different set of groups than
what's used when actions are run depending on event configuration.

Change-Id: I78b6255ada52ed718469a6700b4bc2603b2a85cb
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Use event groups on `init` triggers

Use the provided event groups when enabling any `init` triggers instead
of the action groups. Event groups is what's used with setting up event
triggers

control: Use event groups on `init` triggers

Use the provided event groups when enabling any `init` triggers instead
of the action groups. Event groups is what's used with setting up event
triggers and may or may not be a different set of groups than what's
used when actions are run depending on event configuration.

Change-Id: I804e798e169598080583965e6922fc5fb1cfa2be
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Pass event groups when enabling triggers

The `init` and `signal` triggers need to use the event groups when
retrieving group member values and subscribing to signals respectively.
This is t

control: Pass event groups when enabling triggers

The `init` and `signal` triggers need to use the event groups when
retrieving group member values and subscribing to signals respectively.
This is the first step towards fixing that actions are optional on
events and the design direction that `init` and `signal` triggers will
use the event groups (which may or may not be the same as the groups on
same event's actions) when populating/updating the cached state of all
the group members.

Change-Id: Id5a1891f94572d6c843d98603eb1c8233471e23c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...