7a2cf16c | 12-Nov-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Enable support for SMBIOS version 3.0
SMBIOS 3.2 is essentially a superset of SMBIOS 3.0. The changes from SMBIOS 3.0 to 3.2 added new structures and fields to accommodate more recent hardware featu
Enable support for SMBIOS version 3.0
SMBIOS 3.2 is essentially a superset of SMBIOS 3.0. The changes from SMBIOS 3.0 to 3.2 added new structures and fields to accommodate more recent hardware features and capabilities, but they did not remove or fundamentally alter any pre-existing structures from 3.0. This means that:
- SMBIOS 3.2 remains backward-compatible with SMBIOS 3.0. Any software or system expecting information from SMBIOS 3.0 should still be able to interpret the data in SMBIOS 3.2 without issues.
Since we already support 3.2, its safe to assume that the code can also parse the smbios table version 3.0 without any issues. Hence adding 3.0 in the list of supported versions.
Tested By: Tested this change by sending the SMBIOS 3.0 tables from coreboot to BMC via IPMI, and the smbios app seems to parse the data successfully and host the dbus objects of CPU's and DIMM's.
Change-Id: I2af595ed49b7c697abb6d19331470ad17e060836 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
1d73dccc | 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda formatting also changed, so we have made changes to the organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style. See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: I1210c7b95e65a82cc5675ada03441af6727a3930 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
4e1cf099 | 08-Mar-2024 |
Jonathan Doman <jonathan.doman@intel.com> |
cpuinfoapp: Make PECI features optional
Add a feature flag `cpuinfo-peci` to optionally disable the features in cpuinfoapp that rely on PECI (PPIN, SST), to support configurations that want I2C-base
cpuinfoapp: Make PECI features optional
Add a feature flag `cpuinfo-peci` to optionally disable the features in cpuinfoapp that rely on PECI (PPIN, SST), to support configurations that want I2C-based SSPEC detection but don't want to use libpeci.
Tested: Disabled `cpuinfo-peci` and verified SSPEC was still written into the Model property.
Change-Id: Ie3ab9214d9d6ab238a61933de3e3856eca298fa8 Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
show more ...
|
abdccd3a | 26-Jan-2024 |
Josh Lehan <krellan@google.com> |
Add assoc-trim-path option and Board match
When a custom object path is being used (not the default object path that comes from IPMI), allow the Board interface to be a valid interface for associati
Add assoc-trim-path option and Board match
When a custom object path is being used (not the default object path that comes from IPMI), allow the Board interface to be a valid interface for associating the Inventory object with, not just the System interface.
The purpose is to support large systems of the blade server style, which have CPU and DIMM attached to a Board that is itself attached to a System, not attached to the System directly.
Adding the assoc-trim-path option, disabled by default, to drop the rightmost path component when setting up this association. This bypasses the Board and associates the CPU and DIMM directly with the underlying System.
Cleaning up the systemInfoUpdate() function, to correct a logic error in which the match rule would not be set up for later if an exception happened the first time. Also sleeping, to work around a race condition with Object Mapper.
Tested: I tested it both with and without the assoc-trim-path option, and it seemed to have the desired effect. With this option enabled, I was able to attach CPU and DIMM to the proper System, even though there was a Board object in the hierarchy between them.
Change-Id: Ibb5302e01b9d1b0453bdb14092ede594a9e71415 Signed-off-by: Josh Lehan <krellan@google.com>
show more ...
|
06eb6300 | 15-Feb-2024 |
Josh Lehan <krellan@google.com> |
Enable support for SMBIOS version 3.4
As the currently supported 3.5 standard is a superset of 3.4, according to a glance at the https://www.dmtf.org/standards/smbios spec, enabling support for 3.4
Enable support for SMBIOS version 3.4
As the currently supported 3.5 standard is a superset of 3.4, according to a glance at the https://www.dmtf.org/standards/smbios spec, enabling support for 3.4 should be as straightforward as simply adding it to this allowlist of supported versions.
This change is inspired by the proposed https://github.com/openbmc/smbios-mdr/issues/6 which suggests a similar change for 3.1 version. The only reason I am not adding 3.1 at the same time here, is that I only have a 3.4 SMBIOS in the machine I am testing now.
Tested: The SMBIOS from my host is no longer needlessly rejected for being of 3.4 version.
Change-Id: I29bcb872377c87088b2ed4fc0ec90a03d89c15d8 Signed-off-by: Josh Lehan <krellan@google.com>
show more ...
|
d8dd1208 | 08-Aug-2023 |
Yaswanth Reddy M <yaswanthx.reddy.munukuru@intel.com> |
Increase timeout to 2-sec for syncing SMBIOS data
MDRv2 (Send Data Set Done) command, sent from bios to BMC is taking more time in some cases. The timeout should be 2 sec instead of 0.02 sec.
Teste
Increase timeout to 2-sec for syncing SMBIOS data
MDRv2 (Send Data Set Done) command, sent from bios to BMC is taking more time in some cases. The timeout should be 2 sec instead of 0.02 sec.
Tested: While sending mdr2 command from bios to BMC timeout is not seen.
Change-Id: I6f8a6109ea20f1ca1a1b00d497bd362934f14290 Signed-off-by: Yaswanth Reddy M <yaswanthx.reddy.munukuru@intel.com>
show more ...
|
c6d87a5c | 08-Feb-2024 |
Josh Lehan <krellan@google.com> |
Clean up some buffer allocations
While investigating some memory corruption, I found two bugs: the backing store the SMBIOS data gets loaded into was left uninitialized, and the buffer used for the
Clean up some buffer allocations
While investigating some memory corruption, I found two bugs: the backing store the SMBIOS data gets loaded into was left uninitialized, and the buffer used for the version check was allocated using a pointer where a size should have been used instead.
Tested: While I can not say for sure this solves the corruption, it seems to make it much less frequent, during my testing. I am not saying it is gone, but I can no longer reproduce it.
Change-Id: Ic5d28a0d55cfb179c1bd73e95df2a6bf119f6d8c Signed-off-by: Josh Lehan <krellan@google.com>
show more ...
|
b5d7222f | 11-Jan-2024 |
Jonathan Doman <jonathan.doman@intel.com> |
sst: Don't always wake idle CPU
Some parts of SST are important (initial discovery, appliedConfig change) and should use wake-on-PECI to ensure success even if the CPU is in an idle PkgC state. Othe
sst: Don't always wake idle CPU
Some parts of SST are important (initial discovery, appliedConfig change) and should use wake-on-PECI to ensure success even if the CPU is in an idle PkgC state. Other parts are not important enough to justify increasing the CPU power draw. Add a WakePolicy parameter to the SSTInterface infrastructure to use a different policy in different contexts.
Change-Id: I91435cc0357ab60ca4656e1bc51286e046ae3809 Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
show more ...
|
027277a4 | 11-Sep-2023 |
Josh Lehan <krellan@google.com> |
Refactor MDRV2 class to allow more than one
Refactored the main MDRV2 class to allow more than one object of this class to exist at the same time. All hardcoded paths have been made parameters to th
Refactor MDRV2 class to allow more than one
Refactored the main MDRV2 class to allow more than one object of this class to exist at the same time. All hardcoded paths have been made parameters to the constructor, so that they can be varied at runtime as needed, to avoid overlap.
Also did some necessary internal cleanups to facilitate this.
Tested: Created multiple copies of the MDRV2 object at the same time, it worked, all appeared on D-Bus, under distinct object paths and inventory paths. Destructed the MDRV2 object, it disappeared from D-Bus, constructed it again, it came back.
https://gist.github.com/Krellan/6930bc2ed1ac16b93afcc3a12c02e545
Change-Id: Icd1ebf50086b526cf0cff149eb8ddc59da78f0a9 Signed-off-by: Josh Lehan <krellan@google.com>
show more ...
|
e05a5423 | 23-Aug-2023 |
David Wang <davidwang@quantatw.com> |
Add CPU functional property
ProcessorSummary in bmcweb always shows disable. Because bmcweb depends on `xyz.openbmc_project.State.Decorator.OperationalStatus` interface and `Functional` property to
Add CPU functional property
ProcessorSummary in bmcweb always shows disable. Because bmcweb depends on `xyz.openbmc_project.State.Decorator.OperationalStatus` interface and `Functional` property to return CPU functional state. In this change, include the interface into smbios-mdr and re-add the property `Functional` removed by smbios-mdr/+/36177
Tested: ``` GET /redfish/v1/Systems/system/ "ProcessorSummary": { "CoreCount": 112, "Count": 2, "Status": { "Health": "OK", "HealthRollup": "OK", "State": "Enabled" }
busctl introspect xyz.openbmc_project.Smbios.MDR_V2 /xyz/openbmc_project/inventory/system/chassis/motherboard/cpu0 xyz.openbmc_project.State.Decorator.OperationalStatus interface - - - .Functional property b true emits-change writable ```
Change-Id: I1b4d239ce02d2634a54afb98e4b5e72923fda4fb Signed-off-by: David Wang <davidwang@quantatw.com>
show more ...
|
f079e836 | 19-Sep-2023 |
Josh Lehan <krellan@google.com> |
Initialize first byte in IPMI cache file
In the IPMI cache file, the first byte of this file was always essentially random, because it was in a structure that had this field uninitialized. Fixing it
Initialize first byte in IPMI cache file
In the IPMI cache file, the first byte of this file was always essentially random, because it was in a structure that had this field uninitialized. Fixing it, by arbitrarily choosing the value 0x01.
Added a new constant "mdrDirVersion" for this, and also added a similar constant for "smbiosDirVersion" (which was being initialized, but to a magic number directly in the code, not a constant).
Tested: Cache files now appear consistently.
Change-Id: I1f13ae973965b1a7105e2ac054ae30c52f45e2a9 Signed-off-by: Josh Lehan <krellan@google.com>
show more ...
|
6076d2c3 | 19-Sep-2023 |
Josh Lehan <krellan@google.com> |
Entered remaining CPU family text strings
The table of CPU family text strings was incomplete, missing many entries, of processors both historical and bleeding-edge. Added the missing entries, as pe
Entered remaining CPU family text strings
The table of CPU family text strings was incomplete, missing many entries, of processors both historical and bleeding-edge. Added the missing entries, as per Table 23 of DSP0134 3.7.0 spec.
Following the consistent format of whatever spelling and capitalization the entry had in the spec, but with the dropping of special marketing characters like (C), (R), (TM).
Tested: My CPU no longer shows up as "Unknown Processor Family".
Change-Id: I499cb516de27bf4adec7d034030c3d9c19c2c833 Signed-off-by: Josh Lehan <krellan@google.com>
show more ...
|
21cb0e87 | 16-Aug-2023 |
Michael Shen <gpgpgp@google.com> |
Change MemoryInfo.attributes type to uint8_t
PDI changed the type of `attributes` from uint8_t to size_t. However the SMBIOS spec only reserved 1 byte for this field. So we need to keep `attribute`
Change MemoryInfo.attributes type to uint8_t
PDI changed the type of `attributes` from uint8_t to size_t. However the SMBIOS spec only reserved 1 byte for this field. So we need to keep `attribute` in 1 byte otherwise the field after `attribute` will be shifted.
Tested: Before .MemorySizeInKB property u 1258291200
After .MemorySizeInKB property u 33554432
Change-Id: I1e2bfa78d4259c7b86a471ed880f2c5ca923bc66 Signed-off-by: Michael Shen <gpgpgp@google.com>
show more ...
|
f2d8bb48 | 26-Jul-2023 |
Jonathan Doman <jonathan.doman@intel.com> |
Fix compilation warnings
Various small issues: * Member initialization order * Comparison of different signedness * Unused parameters * Unused variable
Change-Id: Ie59db239b4216ad089f7cf0f289e6ed3d
Fix compilation warnings
Various small issues: * Member initialization order * Comparison of different signedness * Unused parameters * Unused variable
Change-Id: Ie59db239b4216ad089f7cf0f289e6ed3d6ac8e18 Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
show more ...
|
410bbc27 | 12-Jul-2023 |
Joseph Fu <joseph.fu@quantatw.com> |
Populate MemoryTotalWidth property
The "MemoryTotalWidth" property did not display correct information from the smbios file. Add function to transfer "totalWidth" type and return data in sdbusplus f
Populate MemoryTotalWidth property
The "MemoryTotalWidth" property did not display correct information from the smbios file. Add function to transfer "totalWidth" type and return data in sdbusplus format.
Tested: Before ``` root@qbmc:root@qbmc:~# busctl introspect xyz.openbmc_project.Smbios.MDR_V2 /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0 xyz.openbmc_project.Inventory.Item.Dimm NAME TYPE SIGNATURE RESULT/VALUE FLAGS .AllowedSpeedsMT property aq 0 emits-change writable .CASLatencies property q 0 emits-change writable .ECC property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .FormFactor property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MaxMemorySpeedInMhz property q 4800 emits-change writable .MemoryAttributes property y 2 emits-change writable .MemoryConfiguredSpeedInMhz property q 4800 emits-change writable .MemoryDataWidth property q 64 emits-change writable .MemoryDeviceLocator property s "DIMM0" emits-change writable .MemoryMedia property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MemorySizeInKB property t 33554432 emits-change writable .MemoryTotalWidth property q 0 emits-change writable .MemoryType property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MemoryTypeDetail property s "SynchronousUnbuffered" emits-change writable .RevisionCode property q 0 emits-change writable ``` After patching, MemoryTotalWidth property get correct value. ``` root@qbmc:~# busctl introspect xyz.openbmc_project.Smbios.MDR_V2 /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0 xyz.openbmc_project.Inventory.Item.Dimm NAME TYPE SIGNATURE RESULT/VALUE FLAGS .AllowedSpeedsMT property aq 0 emits-change writable .CASLatencies property q 0 emits-change writable .ECC property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .FormFactor property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MaxMemorySpeedInMhz property q 4800 emits-change writable .MemoryAttributes property y 2 emits-change writable .MemoryConfiguredSpeedInMhz property q 4800 emits-change writable .MemoryDataWidth property q 64 emits-change writable .MemoryDeviceLocator property s "DIMM0" emits-change writable .MemoryMedia property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MemorySizeInKB property t 33554432 emits-change writable .MemoryTotalWidth property q 72 emits-change writable .MemoryType property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MemoryTypeDetail property s "SynchronousUnbuffered" emits-change writable .RevisionCode property q 0 emits-change writable ```
Change-Id: I355ef057d7d28e4507d7c91eb45ab2453ed1923e Signed-off-by: Joseph Fu <joseph.fu@quantatw.com>
show more ...
|
a1ff2445 | 15-Jun-2023 |
Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> |
Populate Memory attributes
Add support to populate MemoryMedia, Slot and Socket attribute values to dbus attributes.
Tested: Memory attributes MemoryMedia,Slot and Socket are populated in dbus thro
Populate Memory attributes
Add support to populate MemoryMedia, Slot and Socket attribute values to dbus attributes.
Tested: Memory attributes MemoryMedia,Slot and Socket are populated in dbus through busctl command Command: busctl introspect xyz.openbmc_project.Smbios.MDR_V2 /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0 Response: NAME TYPE SIGNATURE RESULT/VALUE FLAGS ....
xyz.openbmc_project.Inventory.Decorator.LocationCode interface - - - .LocationCode property s "BANK 0 CPU0_DIMM_A" emits-change writable xyz.openbmc_project.Inventory.Item interface - - - .Present property b true emits-change writable .PrettyName property s "" emits-change writable xyz.openbmc_project.Inventory.Item.Dimm interface - - -
.MemoryAttributes property u 8388610 emits-change writable .MemoryConfiguredSpeedInMhz property q 19460 emits-change writable .MemoryDataWidth property q 64 emits-change writable .MemoryDeviceLocator property s "BANK 0 CPU0_DIMM_A" emits-change writable .MemoryMedia property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MemorySizeInKB property u 1468006400 emits-change writable .MemoryTotalWidth property q 0 emits-change writable .MemoryType property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MemoryTypeDetail property s "SynchronousRegistered" emits-change writable .RevisionCode property q 0 emits-change writable xyz.openbmc_project.Inventory.Item.Dimm.MemoryLocation interface - - - .Channel property y 0 emits-change writable .MemoryController property y 0 emits-change writable .Slot property y 65 emits-change writable .Socket property y 1 emits-change writable .....
Signed-off-by: poram srinivasa rao <poramx.srinivasa.rao@intel.com> Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Change-Id: Iabc2a58642167344711550b669ed4f207fb39d45
show more ...
|
036374a2 | 14-Jun-2023 |
George Liu <liuxiwei@inspur.com> |
Change the byte of the MemoryAttributes attribute to the size type
We prefer to use size_t type instead of byte type in PDI[1]
[1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/63
Change the byte of the MemoryAttributes attribute to the size type
We prefer to use size_t type instead of byte type in PDI[1]
[1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/63799
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I211a7cd553338995170407fa583d8926a6c98f53
show more ...
|
5a122a6e | 03-May-2023 |
Brandon Kim <brandonkim@google.com> |
mdrv2: Attempt to update D-Bus objects in place
When systemInfoUpdate() is called multiple times, there's a potential race condition of a user polling for the objects while the array of D-Bus object
mdrv2: Attempt to update D-Bus objects in place
When systemInfoUpdate() is called multiple times, there's a potential race condition of a user polling for the objects while the array of D-Bus objects are erased and being repopulated. This results in incomplete set of memory or CPU counts, which can lead to unforseen consequences.
Tested: Verified that a corner case that was hitting this case consistently (when SMBIOS was transferred using ipmi-blob repeatedly) goes away with this implementation.
Signed-off-by: Brandon Kim <brandonkim@google.com> Change-Id: I312aa91cd11b1dd06502d04272889922108d39a2
show more ...
|
c39d3dfc | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require additional settings for best compatibility and re-running the formatter. Copy the latest .clang-format from the docs repository and reformat the repository.
Change-Id: I172b14c1a881c734851b7dc6e0e90ee2e11cce03 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
33ae81fe | 26-Apr-2023 |
Jason M. Bills <jason.m.bills@intel.com> |
Update to the new sdbusplus namespace format
The sdbusplus namespace format was updated in [1]. This updates the local namespaces to the new format.
[1]: https://github.com/openbmc/sdbusplus/commit
Update to the new sdbusplus namespace format
The sdbusplus namespace format was updated in [1]. This updates the local namespaces to the new format.
[1]: https://github.com/openbmc/sdbusplus/commit/5011340e14da7fc04f8b20721c4631f778200edd
Change-Id: Ic6b874fb86d2ff2192d8067871bd2170696f2b8c Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>
show more ...
|
a3f5b385 | 26-Apr-2023 |
Jason M. Bills <jason.m.bills@intel.com> |
Update class name to MDRV2
In this sdbusplus change, [1], the class name in server.hpp was updated from MDR_V2 to MDRV2. This updates the local class name to match.
[1]: https://github.com/openbmc/
Update class name to MDRV2
In this sdbusplus change, [1], the class name in server.hpp was updated from MDR_V2 to MDRV2. This updates the local class name to match.
[1]: https://github.com/openbmc/sdbusplus/commit/5011340e14da7fc04f8b20721c4631f778200edd
Change-Id: I2c00b29837a72a985b3d1cc359b1bbd952074b63 Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>
show more ...
|
79a7f6c2 | 04-Apr-2023 |
Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> |
CPU: Update processor family table
Add few Intel CPU definitions to processor family table.
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Change-Id: I3df93900a4acced283c147f7e
CPU: Update processor family table
Add few Intel CPU definitions to processor family table.
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Change-Id: I3df93900a4acced283c147f7e64f561480b24aba
show more ...
|
0b1d942d | 31-Mar-2023 |
Joseph Fu <joseph.fu@quantatw.com> |
Fix memory extendedSize type
Modify "extendedSize" type to support 64-bit environment. The size_t type uses 8 bytes in a 64-bit environment, the properties "MemorySizeInKB" and "MemoryConfiguredSpee
Fix memory extendedSize type
Modify "extendedSize" type to support 64-bit environment. The size_t type uses 8 bytes in a 64-bit environment, the properties "MemorySizeInKB" and "MemoryConfiguredSpeedInMhz" will get wrong values from smbios file.
Tested: ``` root@qbmc:~# busctl introspect xyz.openbmc_project.Smbios.MDR_V2 \ > /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0 \ > xyz.openbmc_project.Inventory.Item.Dimm .AllowedSpeedsMT property aq 0 emits-change writable .CASLatencies property q 0 emits-change writable .ECC property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .FormFactor property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MaxMemorySpeedInMhz property q 4800 emits-change writable .MemoryAttributes property y 2 emits-change writable .MemoryConfiguredSpeedInMhz property q 1100 emits-change writable .MemoryDataWidth property q 64 emits-change writable .MemoryDeviceLocator property s "P0 CHANNEL A DIMM0" emits-change writable .MemoryMedia property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MemorySizeInKB property t 3479875137107394560 emits-change writable .MemoryTotalWidth property q 0 emits-change writable ... ``` After ``` root@qbmc:~# busctl introspect xyz.openbmc_project.Smbios.MDR_V2 \ > /xyz/openbmc_project/inventory/system/chassis/motherboard/dimm0 \ > xyz.openbmc_project.Inventory.Item.Dimm NAME TYPE SIGNATURE RESULT/VALUE FLAGS .AllowedSpeedsMT property aq 0 emits-change writable .CASLatencies property q 0 emits-change writable .ECC property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .FormFactor property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MaxMemorySpeedInMhz property q 4800 emits-change writable .MemoryAttributes property y 2 emits-change writable .MemoryConfiguredSpeedInMhz property q 4800 emits-change writable .MemoryDataWidth property q 64 emits-change writable .MemoryDeviceLocator property s "P0 CHANNEL A DIMM0" emits-change writable .MemoryMedia property s "xyz.openbmc_project.Inventory.Item.D... emits-change writable .MemorySizeInKB property t 33554432 emits-change writable .MemoryTotalWidth property q 0 emits-change writable ... ```
Change-Id: I205de7df72269e472143ea3a3fc2f6f9e4af56ee Signed-off-by: Joseph Fu <joseph.fu@quantatw.com>
show more ...
|
b4c3bcd7 | 09-Mar-2023 |
Jonathan Doman <jonathan.doman@intel.com> |
sst: Prefer cached values over default values
In anticipation of support for future CPUs, change some assumptions: * When host is off, return cached property values instead of "default" values. CP
sst: Prefer cached values over default values
In anticipation of support for future CPUs, change some assumptions: * When host is off, return cached property values instead of "default" values. CPUs may not guarantee support for level 0, so there is no universal default. * Must always check the backend interface is ready before using it. * Rename numLevels() to maxLevel() since there may be discontinuities in the supported levels. * Also add some more debug prints.
Tested: * On CPU that supports level 0 - verified that output of sst-info.sh script was the same before and after these changes. * On a CPU that only supports level 4 - verified that when host was powered off, the AppliedConfig showed config4 (valid) instead of config0 (invalid).
Change-Id: Idffcb9a6534ba32760f6d6b2ac244f47427995ea Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
show more ...
|
bb9c622d | 03-Nov-2022 |
Gobinath Krishnamoorthy <gobinathk@google.com> |
Use mobo's object system iface to find mobo path.
This change use system interface to find the inventory object path of the root board in the system. This replaces the `ReScan` method to get the roo
Use mobo's object system iface to find mobo path.
This change use system interface to find the inventory object path of the root board in the system. This replaces the `ReScan` method to get the root object path. The `ReScan` implementation in EntityManager never upstreamed and that CL was abandoned. CL: https://gerrit.openbmc.org/c/openbmc/entity-manager/+/46128
TESTED:
busctl get-property xyz.openbmc_project.Smbios.MDR_V2 \ > /xyz/openbmc_project/inventory/system/chassis/motherboard/cpu0 \ > xyz.openbmc_project.Association.Definitions Associations a(sss) 1 "chassis" "processors" "/xyz/openbmc_project/inventory/system/board/motherboard"
busctl get-property xyz.openbmc_project.Smbios.MDR_V2 \ > /xyz/openbmc_project/inventory/system/chassis/motherboard/cpu1 \ > xyz.openbmc_project.Association.Definitions Associations a(sss) 1 "chassis" "processors" "/xyz/openbmc_project/inventory/system/board/motherboard"
busctl --verbose get-property xyz.openbmc_project.ObjectMapper \ /xyz/openbmc_project/inventory/system/board/motherboard/processors \ xyz.openbmc_project.Association endpoints ARRAY "s" { STRING "/xyz/openbmc_project/inventory/system/chassis/motherboard/cpu0"; STRING "/xyz/openbmc_project/inventory/system/chassis/motherboard/cpu1"; };
Signed-off-by: Gobinath Krishnamoorthy <gobinathk@google.com> Change-Id: Idc6f8c58324c7618a2c4c5a2c4079599c7c29cf4
show more ...
|