| ac4cb328 | 10-Jun-2025 |
Prithvi Pai <ppai@nvidia.com> |
Change PDI to Software.Asset
Added patch to change the PDI from Inventory.Decorator.Asset to Software.Asset because Decorator.Asset represents hardware information. This patch also addresses the con
Change PDI to Software.Asset
Added patch to change the PDI from Inventory.Decorator.Asset to Software.Asset because Decorator.Asset represents hardware information. This patch also addresses the concern of having association which is not documented. Hence the same is removed.
Software.Asset is a new PDI to represent the Software Asset information (Merged) [1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/79966
Tested: [2] busctl get-property xyz.openbmc_project.Smbios.MDR_V2 /xyz/openbmc_project/software/UEFI xyz.openbmc_project.Software.Asset Manufacturer s "NVIDIA" [3] busctl get-property xyz.openbmc_project.Smbios.MDR_V2 /xyz/openbmc_project/software/UEFI xyz.openbmc_project.Software.Asset ReleaseDate s "2025-05-18T04:03:37+00:00"
Change-Id: Iabaa4a9b5efaf5378bad1d4b66b3aeb43df32ee1 Signed-off-by: Prithvi Pai <ppai@nvidia.com>
show more ...
|
| 7a8ef1ee | 02-Jun-2025 |
Prithvi Pai <ppai@nvidia.com> |
Add defaultmotherboard path variable
Added missing variable `defaultmotherboardpath`. This variable is used under meson flag `custom-dbus-path` The build failed as this variable was missing.
Tested
Add defaultmotherboard path variable
Added missing variable `defaultmotherboardpath`. This variable is used under meson flag `custom-dbus-path` The build failed as this variable was missing.
Tested: Build passes now
Change-Id: I324879ac43b3d1236be8fe74e641fba4e484dd4a Signed-off-by: Prithvi Pai <ppai@nvidia.com>
show more ...
|
| ed3d4d1b | 05-May-2025 |
Prithvi Pai <ppai@nvidia.com> |
smbios-mdr: Add custom dbus object path
The patch adds a configurable meson option which when enabled, customizes the dbus object path.
Earlier efforts where made to have similar functionality and
smbios-mdr: Add custom dbus object path
The patch adds a configurable meson option which when enabled, customizes the dbus object path.
Earlier efforts where made to have similar functionality and the some MRs for same were rejected for various reasons [1] https://gerrit.openbmc.org/c/openbmc/smbios-mdr/+/46129 [2] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/46739 [3] https://gerrit.openbmc.org/c/openbmc/entity-manager/+/44196
Tested:
1) Dbus tree output ``` /xyz/openbmc_project |-/xyz/openbmc_project/inventory |`-/xyz/openbmc_project/inventory/system |`-/xyz/openbmc_project/inventory/system/chassis ||-/xyz/openbmc_project/inventory/system/chassis/Chassis_0 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot0 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot1 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot10 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot11 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot12 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot13 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot14 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot15 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot16 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot17 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot18 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot19 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot2 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot3 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot4 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot5 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot6 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot7 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot8 |||- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/pcieslot9 ||`- /xyz/openbmc_project/inventory/system/chassis/Chassis_0/tpm0 ```
Change-Id: I765e56a30c3e5712c2f43fc6a8302be5cc9d9a96 Signed-off-by: Prithvi Pai <ppai@nvidia.com>
show more ...
|
| 6a84b4c8 | 02-May-2025 |
Prithvi Pai <ppai@nvidia.com> |
Moved PDI from TPM.interface to TrustedComponent.interface
This patch moved PDI from TPM.interface to TrustedComponent.interface The changes were made as per discussion mentioned below [1] https://g
Moved PDI from TPM.interface to TrustedComponent.interface
This patch moved PDI from TPM.interface to TrustedComponent.interface The changes were made as per discussion mentioned below [1] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/79157
The association is removed as it is not documented
Tested: dbus introspect output [2] busctl get-property xyz.openbmc_project.Smbios.MDR_V2 /xyz/openbmc_project/inventory/system/chassis/Chassis_0/tpm xyz.openbmc_project.Inventory.Item.TrustedComponent TrustedComponentType [3] s "xyz.openbmc_project.Inventory.Item.TrustedComponent.ComponentAttachType.Discrete"
Change-Id: I28dbda71ed5493e06330e58d8079f1a940e04c85 Signed-off-by: Prithvi Pai <ppai@nvidia.com>
show more ...
|
| 1aea7e44 | 11-Apr-2025 |
Prithvi Pai <ppai@nvidia.com> |
Update FormFactor property on DIMM interface
The patch adds the `FormFactor` property on DIMM interface. BMC parses the SMBIOS Type 17 records and assigns the DIMM FormFactor.
Tested: [1] busctl ge
Update FormFactor property on DIMM interface
The patch adds the `FormFactor` property on DIMM interface. BMC parses the SMBIOS Type 17 records and assigns the DIMM FormFactor.
Tested: [1] busctl get-property xyz.openbmc_project.Smbios.MDR_V2 xyz/openbmc_project/inventory/system/chassis/motherboard/dimm1 xyz.openbmc_project.Inventory.Item.Dimm FormFactor s "xyz.openbmc_project.Inventory.Item.Dimm.FormFactor.Die"
Change-Id: I14b7f0ea0a51e58306c117fcde1b268da798cd36 Signed-off-by: Prithvi Pai <ppai@nvidia.com>
show more ...
|
| 26e04a86 | 02-Apr-2025 |
Prithvi Pai <ppai@nvidia.com> |
Remove duplicate functions to get smbios slot counts
Currently there are duplicate functions to get CPU count, dimm count, pcie slot count, tpm count and firmware inventory record counts. The curren
Remove duplicate functions to get smbios slot counts
Currently there are duplicate functions to get CPU count, dimm count, pcie slot count, tpm count and firmware inventory record counts. The current patch refactors the same and removes the duplicate.
Tested: 1) DBus tree with this changes looks as before
`- /xyz/openbmc_project |- /xyz/openbmc_project/Smbios | `- /xyz/openbmc_project/Smbios/MDR_V2 |- /xyz/openbmc_project/inventory |`- /xyz/openbmc_project/inventory/system |`- /xyz/openbmc_project/inventory/system/chassis |`- /xyz/openbmc_project/inventory/system/chassis/motherboard |`- /xyz/openbmc_project/inventory/system/chassis/motherboard/bios `- /xyz/openbmc_project/software `- /xyz/openbmc_project/software/UEFI
Change-Id: Ie77be54ac240819df785f93272cc2b8398b6c2d0 Signed-off-by: Prithvi Pai <ppai@nvidia.com>
show more ...
|
| 6f9e7a76 | 14-Mar-2025 |
Prithvi Pai <ppai@nvidia.com> |
smbios-mdr: Expose Firmware Inventory Information
SMBIOS Type 45 defines the data structure to expose Firmware Inventory information. Added patch which exposes the same on the DBus.
Introduced fw-i
smbios-mdr: Expose Firmware Inventory Information
SMBIOS Type 45 defines the data structure to expose Firmware Inventory information. Added patch which exposes the same on the DBus.
Introduced fw-inventory-dbus meson option which by default, will be disabled. When enabled fw-inventory is exposed to dbus
Introduced expose-firmware-component-name meson option which by default, will be disabled. When enabled fw-component name is exposed as dbus object
Tested: 1) No crash is seen when firmware is flashed with change 2) Firmware Inventory information is available under dbus tree ``` busctl tree xyz.openbmc_project.Smbios.MDR_V2 `- /xyz `- /xyz/openbmc_project |- /xyz/openbmc_project/Smbios | `- /xyz/openbmc_project/Smbios/MDR_V2 `- /xyz/openbmc_project/software `- /xyz/openbmc_project/software/UEFI ```
Change-Id: If5b367f21dedc0addef4f7b1d4c6dac6a5dc17c2 Signed-off-by: Prithvi Pai <ppai@nvidia.com>
show more ...
|
| 5af42bbf | 11-Feb-2025 |
Prithvi Pai <ppai@nvidia.com> |
smbios-mdr: Add TPM Device Information
Type 43 of SMBIOS records defines the data structure to expose TPM Device information. Add patch which displays the TPM Device information on dbus. Introduced
smbios-mdr: Add TPM Device Information
Type 43 of SMBIOS records defines the data structure to expose TPM Device information. Add patch which displays the TPM Device information on dbus. Introduced `TPM_DBUS` meson option which will be disabled by default When enabled, the TPM information is populated on DBUS.
Tested:
TPM information is available under dbus tree of smbios-mdr ``` :~# busctl tree xyz.openbmc_project.Smbios.MDR_V2 `- /xyz `- /xyz/openbmc_project |- /xyz/openbmc_project/Smbios | `- /xyz/openbmc_project/Smbios/MDR_V2 |- /xyz/openbmc_project/inventory | `- /xyz/openbmc_project/inventory/system | `- /xyz/openbmc_project/inventory/system/chassis | |- /xyz/openbmc_project/inventory/system/chassis/motherboard/bios | `- /xyz/openbmc_project/inventory/system/chassis/motherboard/tpm ```
Change-Id: Icd42f4f043bf5a970f4829e5d318568360fe4b59 Signed-off-by: Prithvi Pai <ppai@nvidia.com>
show more ...
|
| ce89a37c | 05-Feb-2025 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
smbios-mdr:Add support to toggle pcieslot presence
In the current state, the PCIeslot presence is always hardcoded to `true`, since the PCIeSlots are always embedded on the board. But the slot prese
smbios-mdr:Add support to toggle pcieslot presence
In the current state, the PCIeslot presence is always hardcoded to `true`, since the PCIeSlots are always embedded on the board. But the slot presence is not really useful. Since we are already getting the current usage of the slot in the SMBIOS Type 9 structure we could use the "Available"/"Occupied" status in the current usage field to indicate the drive presence.
Modify the slot presence code to only mark "true" if the current usage of the slot is "Occupied" & make it "false" if it is anything other than that.
Tested By: 1. Enabled the meson option via the meta-ibm layer by adding PACKAGECONFIG:append = "slot-drive-presence" 2. Post the SMBIOS transfer, could see the presence of the slot being toggled with respect to the current occupancy of the slot.
Change-Id: I57e6f48dc501e7e1625a5389ea1e989c5e585824 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
| f3b25e55 | 07-Feb-2025 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
pcieslot: Add slottype by length support
Add necessary support needed to display the fulllength & halflength slottypes on dbus.
Tested By: 1. Once coreboot/u-root transfers the smbios tables, I cou
pcieslot: Add slottype by length support
Add necessary support needed to display the fulllength & halflength slottypes on dbus.
Tested By: 1. Once coreboot/u-root transfers the smbios tables, I could see that the PCIeSlot types also show the fulllength & halflength slots on dbus & also confirmed the same on the openbmc webUI.
Change-Id: Iaf47f3525c86a82f5b57ac8cf05b9cb12b44f5cc Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
| b1094b2c | 05-Feb-2025 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Add asset tag support for processor
Type 4 (processor information), has assetTag field at 21h address, pick the string from the offset and host the assettag property.
Tested by: 1. After the smbios
Add asset tag support for processor
Type 4 (processor information), has assetTag field at 21h address, pick the string from the offset and host the assettag property.
Tested by: 1. After the smbios table transfer from coreboot/u-root the CPU dbus objects reflects the assettag information as well successfully.
Change-Id: I2492446f31a6a15fa19672b09c2cb0d5b919ff64 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
| 07a2c9aa | 01-Feb-2025 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: I1ece44942d482015c870eb78f9f386e5487a963f Signed-off-by: Patrick Williams <p
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: I1ece44942d482015c870eb78f9f386e5487a963f Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 669e4c3c | 20-Jan-2025 |
Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> |
Add SMBIOS version 3.8 to supported version list
Added latest SMBIOS release version v3.8 (which is backward compatible) to supported version list, without introducing new v3.8 structures.
Tested:
Add SMBIOS version 3.8 to supported version list
Added latest SMBIOS release version v3.8 (which is backward compatible) to supported version list, without introducing new v3.8 structures.
Tested: SMBIOS table on test system sending SMBIOS in v3.8 properly exposed on D-Bus
Signed-off-by: Jan Sowinski <jan.sowinski@intel.com> Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Change-Id: I9910c8f8c12f1ee1380ff4c5e9c67687189da5d9
show more ...
|
| 8f789c3a | 10-Jul-2024 |
Tony Lee <tony.lee@quantatw.com> |
Enable MemoryLocation properties to be customized
-Enable MemoryLocation properties to be customized by a json table. Example of memoryLocationTable.json: { "<MemoryDeviceLocator>": { "Mem
Enable MemoryLocation properties to be customized
-Enable MemoryLocation properties to be customized by a json table. Example of memoryLocationTable.json: { "<MemoryDeviceLocator>": { "MemoryController": 1, "Socket":48, "Slot":0, "Channel":0 } }
-Add attribute "memoryController", "slot", "channel", "socket" in MemoryLocation.
Tested:
memoryLocationTable.json: { "DIMM4": { "MemoryController": 1, "Socket":48, "Slot":0, "Channel":0 } }
with the change: curl -k -X GET http://${bmc}/redfish/v1/Systems/system/Memory/dimm1 { "@odata.id": "/redfish/v1/Systems/system/Memory/dimm1", "@odata.type": "#Memory.v1_11_0.Memory", "AllowedSpeedsMHz": [], "BaseModuleType": "RDIMM", "BusWidthBits": 80, "CapacityMiB": 49152, "DataWidthBits": 64, "ErrorCorrection": "SingleBitECC", "FirmwareRevision": "0", "Id": "dimm1", "Location": { "PartLocation": { "LocationType": "Slot", "ServiceLabel": "DIMM4" } }, "Manufacturer": "", "MemoryDeviceType": "DDR5", "MemoryLocation": { "Channel": 0, "MemoryController": 1, "Slot": 0, "Socket": 48 }
without the change:
curl -k -X GET http://${bmc}/redfish/v1/Systems/system/Memory/dimm1 { "@odata.id": "/redfish/v1/Systems/system/Memory/dimm1", "@odata.type": "#Memory.v1_11_0.Memory", "AllowedSpeedsMHz": [], "BaseModuleType": "RDIMM", "BusWidthBits": 80, "CapacityMiB": 49152, "DataWidthBits": 64, "ErrorCorrection": "SingleBitECC", "FirmwareRevision": "0", "Id": "dimm1", "Location": { "PartLocation": { "LocationType": "Slot", "ServiceLabel": "DIMM4" } }, "Manufacturer": "", "MemoryDeviceType": "DDR5", "MemoryLocation": { "Channel": 0, "MemoryController": 0, "Slot": 0, "Socket": 0 }
Change-Id: Ic5ff09715a619907f06d06af33aa0d1755c8b4f3 Signed-off-by: Tony Lee <tony.lee@quantatw.com>
show more ...
|
| 8049822c | 02-Dec-2024 |
Quang Nguyen <quangnguyen@os.amperecomputing.com> |
Enable support for SMBIOS version 3.7
Currently, SMBIOS-MDR supports up to version 3.5, and the changes introduced in versions 3.6 and 3.7 are largely supported as well. Therefore, enable the suppor
Enable support for SMBIOS version 3.7
Currently, SMBIOS-MDR supports up to version 3.5, and the changes introduced in versions 3.6 and 3.7 are largely supported as well. Therefore, enable the supported version to 3.7.
Tested: The implementation was verified using EDK2, which supports SMBIOS version 3.7, ensuring that all SMBIOS data is correctly populated on D-Bus.
Change-Id: I61d3667d6ecf5635750022153ab30a54530ef2d3 Signed-off-by: Quang Nguyen <quangnguyen@os.amperecomputing.com>
show more ...
|
| 7a2cf16c | 12-Nov-2024 |
Manojkiran Eda <manojkiran.eda@gmail.com> |
Enable support for SMBIOS version 3.0
SMBIOS 3.2 is essentially a superset of SMBIOS 3.0. The changes from SMBIOS 3.0 to 3.2 added new structures and fields to accommodate more recent hardware featu
Enable support for SMBIOS version 3.0
SMBIOS 3.2 is essentially a superset of SMBIOS 3.0. The changes from SMBIOS 3.0 to 3.2 added new structures and fields to accommodate more recent hardware features and capabilities, but they did not remove or fundamentally alter any pre-existing structures from 3.0. This means that:
- SMBIOS 3.2 remains backward-compatible with SMBIOS 3.0. Any software or system expecting information from SMBIOS 3.0 should still be able to interpret the data in SMBIOS 3.2 without issues.
Since we already support 3.2, its safe to assume that the code can also parse the smbios table version 3.0 without any issues. Hence adding 3.0 in the list of supported versions.
Tested By: Tested this change by sending the SMBIOS 3.0 tables from coreboot to BMC via IPMI, and the smbios app seems to parse the data successfully and host the dbus objects of CPU's and DIMM's.
Change-Id: I2af595ed49b7c697abb6d19331470ad17e060836 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
show more ...
|
| 1d73dccc | 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda formatting also changed, so we have made changes to the organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style. See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: I1210c7b95e65a82cc5675ada03441af6727a3930 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 4e1cf099 | 08-Mar-2024 |
Jonathan Doman <jonathan.doman@intel.com> |
cpuinfoapp: Make PECI features optional
Add a feature flag `cpuinfo-peci` to optionally disable the features in cpuinfoapp that rely on PECI (PPIN, SST), to support configurations that want I2C-base
cpuinfoapp: Make PECI features optional
Add a feature flag `cpuinfo-peci` to optionally disable the features in cpuinfoapp that rely on PECI (PPIN, SST), to support configurations that want I2C-based SSPEC detection but don't want to use libpeci.
Tested: Disabled `cpuinfo-peci` and verified SSPEC was still written into the Model property.
Change-Id: Ie3ab9214d9d6ab238a61933de3e3856eca298fa8 Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
show more ...
|
| abdccd3a | 26-Jan-2024 |
Josh Lehan <krellan@google.com> |
Add assoc-trim-path option and Board match
When a custom object path is being used (not the default object path that comes from IPMI), allow the Board interface to be a valid interface for associati
Add assoc-trim-path option and Board match
When a custom object path is being used (not the default object path that comes from IPMI), allow the Board interface to be a valid interface for associating the Inventory object with, not just the System interface.
The purpose is to support large systems of the blade server style, which have CPU and DIMM attached to a Board that is itself attached to a System, not attached to the System directly.
Adding the assoc-trim-path option, disabled by default, to drop the rightmost path component when setting up this association. This bypasses the Board and associates the CPU and DIMM directly with the underlying System.
Cleaning up the systemInfoUpdate() function, to correct a logic error in which the match rule would not be set up for later if an exception happened the first time. Also sleeping, to work around a race condition with Object Mapper.
Tested: I tested it both with and without the assoc-trim-path option, and it seemed to have the desired effect. With this option enabled, I was able to attach CPU and DIMM to the proper System, even though there was a Board object in the hierarchy between them.
Change-Id: Ibb5302e01b9d1b0453bdb14092ede594a9e71415 Signed-off-by: Josh Lehan <krellan@google.com>
show more ...
|
| 06eb6300 | 15-Feb-2024 |
Josh Lehan <krellan@google.com> |
Enable support for SMBIOS version 3.4
As the currently supported 3.5 standard is a superset of 3.4, according to a glance at the https://www.dmtf.org/standards/smbios spec, enabling support for 3.4
Enable support for SMBIOS version 3.4
As the currently supported 3.5 standard is a superset of 3.4, according to a glance at the https://www.dmtf.org/standards/smbios spec, enabling support for 3.4 should be as straightforward as simply adding it to this allowlist of supported versions.
This change is inspired by the proposed https://github.com/openbmc/smbios-mdr/issues/6 which suggests a similar change for 3.1 version. The only reason I am not adding 3.1 at the same time here, is that I only have a 3.4 SMBIOS in the machine I am testing now.
Tested: The SMBIOS from my host is no longer needlessly rejected for being of 3.4 version.
Change-Id: I29bcb872377c87088b2ed4fc0ec90a03d89c15d8 Signed-off-by: Josh Lehan <krellan@google.com>
show more ...
|
| d8dd1208 | 08-Aug-2023 |
Yaswanth Reddy M <yaswanthx.reddy.munukuru@intel.com> |
Increase timeout to 2-sec for syncing SMBIOS data
MDRv2 (Send Data Set Done) command, sent from bios to BMC is taking more time in some cases. The timeout should be 2 sec instead of 0.02 sec.
Teste
Increase timeout to 2-sec for syncing SMBIOS data
MDRv2 (Send Data Set Done) command, sent from bios to BMC is taking more time in some cases. The timeout should be 2 sec instead of 0.02 sec.
Tested: While sending mdr2 command from bios to BMC timeout is not seen.
Change-Id: I6f8a6109ea20f1ca1a1b00d497bd362934f14290 Signed-off-by: Yaswanth Reddy M <yaswanthx.reddy.munukuru@intel.com>
show more ...
|
| c6d87a5c | 08-Feb-2024 |
Josh Lehan <krellan@google.com> |
Clean up some buffer allocations
While investigating some memory corruption, I found two bugs: the backing store the SMBIOS data gets loaded into was left uninitialized, and the buffer used for the
Clean up some buffer allocations
While investigating some memory corruption, I found two bugs: the backing store the SMBIOS data gets loaded into was left uninitialized, and the buffer used for the version check was allocated using a pointer where a size should have been used instead.
Tested: While I can not say for sure this solves the corruption, it seems to make it much less frequent, during my testing. I am not saying it is gone, but I can no longer reproduce it.
Change-Id: Ic5d28a0d55cfb179c1bd73e95df2a6bf119f6d8c Signed-off-by: Josh Lehan <krellan@google.com>
show more ...
|
| b5d7222f | 11-Jan-2024 |
Jonathan Doman <jonathan.doman@intel.com> |
sst: Don't always wake idle CPU
Some parts of SST are important (initial discovery, appliedConfig change) and should use wake-on-PECI to ensure success even if the CPU is in an idle PkgC state. Othe
sst: Don't always wake idle CPU
Some parts of SST are important (initial discovery, appliedConfig change) and should use wake-on-PECI to ensure success even if the CPU is in an idle PkgC state. Other parts are not important enough to justify increasing the CPU power draw. Add a WakePolicy parameter to the SSTInterface infrastructure to use a different policy in different contexts.
Change-Id: I91435cc0357ab60ca4656e1bc51286e046ae3809 Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
show more ...
|
| 027277a4 | 11-Sep-2023 |
Josh Lehan <krellan@google.com> |
Refactor MDRV2 class to allow more than one
Refactored the main MDRV2 class to allow more than one object of this class to exist at the same time. All hardcoded paths have been made parameters to th
Refactor MDRV2 class to allow more than one
Refactored the main MDRV2 class to allow more than one object of this class to exist at the same time. All hardcoded paths have been made parameters to the constructor, so that they can be varied at runtime as needed, to avoid overlap.
Also did some necessary internal cleanups to facilitate this.
Tested: Created multiple copies of the MDRV2 object at the same time, it worked, all appeared on D-Bus, under distinct object paths and inventory paths. Destructed the MDRV2 object, it disappeared from D-Bus, constructed it again, it came back.
https://gist.github.com/Krellan/6930bc2ed1ac16b93afcc3a12c02e545
Change-Id: Icd1ebf50086b526cf0cff149eb8ddc59da78f0a9 Signed-off-by: Josh Lehan <krellan@google.com>
show more ...
|
| e05a5423 | 23-Aug-2023 |
David Wang <davidwang@quantatw.com> |
Add CPU functional property
ProcessorSummary in bmcweb always shows disable. Because bmcweb depends on `xyz.openbmc_project.State.Decorator.OperationalStatus` interface and `Functional` property to
Add CPU functional property
ProcessorSummary in bmcweb always shows disable. Because bmcweb depends on `xyz.openbmc_project.State.Decorator.OperationalStatus` interface and `Functional` property to return CPU functional state. In this change, include the interface into smbios-mdr and re-add the property `Functional` removed by smbios-mdr/+/36177
Tested: ``` GET /redfish/v1/Systems/system/ "ProcessorSummary": { "CoreCount": 112, "Count": 2, "Status": { "Health": "OK", "HealthRollup": "OK", "State": "Enabled" }
busctl introspect xyz.openbmc_project.Smbios.MDR_V2 /xyz/openbmc_project/inventory/system/chassis/motherboard/cpu0 xyz.openbmc_project.State.Decorator.OperationalStatus interface - - - .Functional property b true emits-change writable ```
Change-Id: I1b4d239ce02d2634a54afb98e4b5e72923fda4fb Signed-off-by: David Wang <davidwang@quantatw.com>
show more ...
|