tools/visualize-pdr: bump paramiko to 3.4.0

Bumps paramiko[1] from 2.10.1 to 3.4.0. Below are the list
of commits[2] from 2.10.1 to 3.4.0.

[1]: https://github.com/paramiko/paramiko
[2]: https://git

tools/visualize-pdr: bump paramiko to 3.4.0

Bumps paramiko[1] from 2.10.1 to 3.4.0. Below are the list
of commits[2] from 2.10.1 to 3.4.0.

[1]: https://github.com/paramiko/paramiko
[2]: https://github.com/paramiko/paramiko/compare/2.10.1...3.4.0

Change-Id: I10b98730ae91c8273b1ac713925c9d7d0cc8a4a9
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

bump cryptography in /tools/visualize-pdr

Bumps cryptography dependency to latest.

Look Changelog[1] and commits list[2] for more information.

[1]: https://github.com/pyca/cryptography/blob/main/C

bump cryptography in /tools/visualize-pdr

Bumps cryptography dependency to latest.

Look Changelog[1] and commits list[2] for more information.

[1]: https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst
[2]: https://github.com/pyca/cryptography/compare/39.0.1...43.0.1

Change-Id: I141cbffd61f3edd1114c2b61549a4adee3c588c5
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

fix markdownlint issues reported in CI

There are a lot of warnings reported by markdownlint in the CI, this
commit aims at fixing all of them.

Tested :

No more warnings reported by markdownlint in

fix markdownlint issues reported in CI

There are a lot of warnings reported by markdownlint in the CI, this
commit aims at fixing all of them.

Tested :

No more warnings reported by markdownlint in the CI.

Change-Id: I92d24bc0efd230dd0974ff49853ef928caf1febd
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I539a0c5baa63be240fc1c76367c0af338dd89c7b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

bump cryptography from 3.4.7 to 39.0.1

Here is the change log:

```
* SECURITY ISSUE - Fixed a bug where Cipher.update_into accepted Python buffer protocol objects, but allowed immutable buffers [CV

bump cryptography from 3.4.7 to 39.0.1

Here is the change log:

```
* SECURITY ISSUE - Fixed a bug where Cipher.update_into accepted Python buffer protocol objects, but allowed immutable buffers [CVE-2023-23931]
* Updated Windows, macOS, and Linux wheels to be compiled with OpenSSL 3.0.8.
```

Change-Id: I3a5f88506c6bc560c66c6b0bb8005bc2d133f3ea
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

tools: fw-update: allow ISO 8610 date formats

Currently, the ReleaseDateTime data is expected to be in a
"%d/%m/%Y %H:%M:%S" format.

However, this is ambiguous (ie., is locale-specific).

This chan

tools: fw-update: allow ISO 8610 date formats

Currently, the ReleaseDateTime data is expected to be in a
"%d/%m/%Y %H:%M:%S" format.

However, this is ambiguous (ie., is locale-specific).

This change adds supoort to allow an ISO 8601 format of:

"%Y-%m-%dT%H:%M:%S"

and a relaxed version with the 'T' separator replaced with a space:

"%Y-%m-%d %H:%M:%S"

Update the readme and example json to switch to the preferred format.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Change-Id: Ica3ae824979df6b666b8abb619ceaedffd90b374

show more ...

tools: fw-update: Don't wrap datetime parsing in a catch KeyError block

Currently, all of the datetime parse is wrapped in a `catch KeyError`
block. However, the only part of this that would raise a

tools: fw-update: Don't wrap datetime parsing in a catch KeyError block

Currently, all of the datetime parse is wrapped in a `catch KeyError`
block. However, the only part of this that would raise a KeyError is
where we extract the PackageReleaseDateTime from the metadata dict.

Instead, just do the key lookup separately, and parse outside of the
catch block.

Then, since we're handling a default anyway, just use .get() and then we
don't need to catch the KeyError.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Change-Id: Iae6b92383af4fe49770e77005fcb575faa125703

show more ...

fwupdate-tools: Support for multiple components

At present ComponentIdentifier is used in
ApplicableComponents field to select images that
apply for a firmware device. Which restricts to
have same C

fwupdate-tools: Support for multiple components

At present ComponentIdentifier is used in
ApplicableComponents field to select images that
apply for a firmware device. Which restricts to
have same ComponentIdentifier for multiple
components. This patch will enable to use
ComponentImageInformationArea index in
ApplicableComponents field.

Unit Tests:
1. Modify ApplicableComponents with index and
verify the package with previous package.
There should not be any difference
2. Verify multiple components with same
component identifier
3. Test out of index for ApplicableComponents

Signed-off-by: Chinmay Shripad Hegde <hosmanechinmay@gmail.com>
Change-Id: Ibf5069d568f0a922d52db261219c2557d2d2f715

show more ...

fwupdate-tools: Add support for user specified ComponentComparisonStamp from metadata file.

Currently, ComponentComparisonStamp is not supported in metadata file
and the value is hardcoded in the sc

fwupdate-tools: Add support for user specified ComponentComparisonStamp from metadata file.

Currently, ComponentComparisonStamp is not supported in metadata file
and the value is hardcoded in the script. This change will enable to
specify ComponentComparisonStamp in metadata file when ComponentOptions
is set to 1.

Unit Tests:
1. ComponentOptions values other than 1. verify Default
ComponentComparisonStamp used
2. ComponentOptions is 1 and component comparison stamp is missing,
verify error message
3. ComponentOptions is 1, ComponentComparisonStamp provided in the
metadata file. Verify the package with hexdump
4. Verify error messages for invalid value for ComponentComparisonStamp

Signed-off-by: Chinmay Shripad Hegde <hosmanechinmay@gmail.com>
Change-Id: I772d30ebe5d80e2cdca365ad4025cca774db218d

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I0d25f27a5e449578967915d9f570cc29246927d7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I0acc99c570b2a51

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I0acc99c570b2a51383f46c62a04367e50f7c42b9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix pycodestyle errors

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: If9e9fc799062c207e74afdf07f018f325fb5a373

visualize-pdr : bump paramiko from 2.7.2 to 2.10.1

There are a lot of improvements in the parmiko python module, and the
latest version of paramiko is much cleaner/faster & effecient and it
also has

visualize-pdr : bump paramiko from 2.7.2 to 2.10.1

There are a lot of improvements in the parmiko python module, and the
latest version of paramiko is much cleaner/faster & effecient and it
also has various CVE's fixed.

change log : https://www.paramiko.org/changelog.html
dependabot PR: https://github.com/openbmc/pldm/pull/33

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I39bf51dd60a87a1c619fdef788863444db66fc55

show more ...

pldm_visualise_pdrs: check for tty

Check for a tty before using a carriage return. This yields sane
behavior when redirecting output to something other than a shell e.g.
more, less, etc...

Change-

pldm_visualise_pdrs: check for tty

Check for a tty before using a carriage return. This yields sane
behavior when redirecting output to something other than a shell e.g.
more, less, etc...

Change-Id: I250fefc531a2aaced9bee433388e25fccb4952ce
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs: run pldmtool directly

Add support for running pldm_visualise_pdrs locally on the same system
as pldmtool. This is roughly equivalent to:

pldm_visualise_pdrs.py --bmc localhost

pldm_visualise_pdrs: run pldmtool directly

Add support for running pldm_visualise_pdrs locally on the same system
as pldmtool. This is roughly equivalent to:

pldm_visualise_pdrs.py --bmc localhost

but without the SSH overhead.

To invoke pldm_visualise_pdrs in this manner, run it without any command
line options. If pldmtool is found in PATH it will be used to fetch the
PDRs. If it is not, an error message is displayed instructing the user
to either install pldmtool or use the --bmc option and connect to a
remote target. A side effect of this is that the --bmc and --password
parameters are now optional.

Change-Id: I1befdb19d4eaa1fb6d685e84b14926530238b20d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs: add process abstraction

Wrap the paramiko process control and access methods in a process
abstraction to facilitate new ways of running pldmtool.

Change-Id: Ibacc45dd3a09022c42

pldm_visualise_pdrs: add process abstraction

Wrap the paramiko process control and access methods in a process
abstraction to facilitate new ways of running pldmtool.

Change-Id: Ibacc45dd3a09022c420b76a5828583e84ffd63e1
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs: Add executor abstraction

Wrap the paramiko connection logic into an executor abstraction to
facilitate new ways of running pldmtool.

Change-Id: Ief7cc9bd926ca0ca96a595fd8051f94

pldm_visualise_pdrs: Add executor abstraction

Wrap the paramiko connection logic into an executor abstraction to
facilitate new ways of running pldmtool.

Change-Id: Ief7cc9bd926ca0ca96a595fd8051f940316c7aa9
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: add jump host support

A jump host allows tunneling an ssh connection through an intermediate
server. Enabling this means using any ProxyCommand host directives from
an ssh c

pldm_visualise_pdrs.py: add jump host support

A jump host allows tunneling an ssh connection through an intermediate
server. Enabling this means using any ProxyCommand host directives from
an ssh config if one exists, and feeding that to paramiko.

Change-Id: Ic4aa6c765a6fe9a0bcb790d1bce23fa9c49de419
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: add support for ssh_config

Add support for parsing user ssh_configs. For now, this lets users
specify an ssh_config host entry with the --bmc parameter and the script
will p

pldm_visualise_pdrs.py: add support for ssh_config

Add support for parsing user ssh_configs. For now, this lets users
specify an ssh_config host entry with the --bmc parameter and the script
will pick up the hostname and user directives if they are specified in
the host entry. Like ssh itself, a --user option on the command line
overrides any user specified in the ssh_config host entry.

Change-Id: I4d564677424e984de033a1d15ca6d51342091772
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: make use of --all

pldmtool platform getpdr has a new --all option that dumps all the PDRS.
Probe pldmtool to see if it supports the --all option and if it does,
use it, as it

pldm_visualise_pdrs.py: make use of --all

pldmtool platform getpdr has a new --all option that dumps all the PDRS.
Probe pldmtool to see if it supports the --all option and if it does,
use it, as it is at least an order of magnitude faster than invoking
pldmtool once for each PDR.

The pldmtool error handling code is complicated significantly, because
with the much larger json documents being printed by --all, it becomes
important that the json decoder be able to start decoding the document
before pldmtool has sent all the pdrs.

get_pdrs is restructured as a generator selection method, given that
different versions of pldmtool have different capabilities.

Change-Id: I01a3dccad3a85d701cd86ab35d8908ef7fc772ac
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: add some error handling

If pldmtool exits with non-zero status it will likely cause a json
decoder error to be thrown because it didn't write anything to stdout.
This is misl

pldm_visualise_pdrs.py: add some error handling

If pldmtool exits with non-zero status it will likely cause a json
decoder error to be thrown because it didn't write anything to stdout.
This is misleading, so check the pldmtool exit status before attempting
to read the json document it prints.

Change-Id: I8e6d1008a054bc6ed0699f051fb537be8785c863
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

tools: Extend support for ComponentOptions

Add support for both Force Update and Use Component Comparison Stamp.

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: Ief6e56e8a167a989c27b6b22

tools: Extend support for ComponentOptions

Add support for both Force Update and Use Component Comparison Stamp.

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: Ief6e56e8a167a989c27b6b2244b340ed0956d799

show more ...

pldm_visualise_pdrs.py: use a generator

Factor the logic and implementation of iterating over PDRs out from the
logic of sorting data into the various pdr type containers in
fetch_pdrs_from_bmc. Mo

pldm_visualise_pdrs.py: use a generator

Factor the logic and implementation of iterating over PDRs out from the
logic of sorting data into the various pdr type containers in
fetch_pdrs_from_bmc. Move the factored-out logic to a new generator
method get_pdrs. This facilitates new ways of getting PDRs into the
program without disturbing the code that processes them.

Change-Id: I23e9b56b3ec1d275f93fef51edeed11d6de696bd
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: make --user optional

Most ssh clients (ssh, scp, etc) will default to the currently logged in
user if unspecified elsewhere, including paramiko itself.

Make --user optional

pldm_visualise_pdrs.py: make --user optional

Most ssh clients (ssh, scp, etc) will default to the currently logged in
user if unspecified elsewhere, including paramiko itself.

Make --user optional and default to the currently logged in user to be
consistant with the behavior of other ssh client applications. This
also avoids the unusual sitation where --user is only required if it
does not appear in an ssh configuration file host entry (useful if
support for parsing ssh configurations were to be added in the future).

Change-Id: I0d4fdd51d03c205b1457ea199934fda2e3a2ab29
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: remove impossible branch

These arguments are marked as required. Given that, this branch can
never evaluate to false, so just remove it.

Change-Id: I403cf561b121b28e3fe161f

pldm_visualise_pdrs.py: remove impossible branch

These arguments are marked as required. Given that, this branch can
never evaluate to false, so just remove it.

Change-Id: I403cf561b121b28e3fe161f810fc6c8ba26317ee
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...