clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8078c8196a2d5706179dc10bf20c0af1a69ec962
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: Provide missing dependencies for the local build

Currently local meson build fails because tests don't require the
necessary dependencies.
Provide missing dependencies to fix the issue.

Test

meson: Provide missing dependencies for the local build

Currently local meson build fails because tests don't require the
necessary dependencies.
Provide missing dependencies to fix the issue.

Tested:
"meson setup build && cd build && meson compile" finishes successfully.

Change-Id: Icaab5b5a5d2ec23e9adc76ff2df5ec07d1a87cc7
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I657f0cb5283a0b4177332d94a88af660f3de8f11
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic63a70d32f4683e0bd92b625cc36c836aa8395a8

show more ...

Remove compilation using autotools

The intent behind this commit is build P-I-M with meson, so need to
remove files related to autotools.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id:

Remove compilation using autotools

The intent behind this commit is build P-I-M with meson, so need to
remove files related to autotools.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I886726460fe46c69163d743cab5164d3774f2979

show more ...

meson: Add meson build for test

This commit is to add meson build for test.
and later, we will remove autotools and replace it with meson.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id:

meson: Add meson build for test

This commit is to add meson build for test.
and later, we will remove autotools and replace it with meson.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia36cec4eda7937461f62f43dd74907e82a164bf6

show more ...

meson: Eliminate warning messages

Eliminate `[-Werror=unused-parameter]` warning message

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: If4f8aee3ce71b5c6e6ad1d168859c03bd7bfa933

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id5a06698ddd6f91510a34aaf9df535bd34c099c0

manager: explicitly pass deferSignal

Explicitly pass the deferSignal parameter to the dbus bindings to enable
creating objects without emitting signals.

The patch does not introduce any functional

manager: explicitly pass deferSignal

Explicitly pass the deferSignal parameter to the dbus bindings to enable
creating objects without emitting signals.

The patch does not introduce any functional change - only future
capability; the dbus binding argument is defaulted to emit a signal
(deferSignal = false) and that logic is preserved - moved from the
binding call site to higher up the call stack (updateInterfaces).

A careful observer may notice this patch highlights that interfaces are
constructed with the map-of-properties constructor with signals enabled.
This is arguably a bug in the bindings - it would never make sense to
construct an interface in this fashion and send PropertiesChanged
signals while the interface is in the process of being constructed.
This patch retains the current broken behavior, with a fix to be
provided in a later patch.

Change-Id: I0d9ef93651595b751e96cae07d9f1095770c05a6
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

manager: claim busname after startup complete

Idiomatic DBus programming would have us defer claiming a well known bus
name until after all of our startup initialization is done. This avoids
unnece

manager: claim busname after startup complete

Idiomatic DBus programming would have us defer claiming a well known bus
name until after all of our startup initialization is done. This avoids
unnecessary PropertiesChanged or ObjectManager signals during our
startup phase with callbacks that generate dbus activity such as
createObjects or setProperty.

Change-Id: I5f91bbc2a9a5b343e8db214ebadb52bc71b2d459
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

manager: remove unused interface

The manager doesn't use the interface being passed in, so remove it.

Change-Id: I1ebb07a7fa109d41a0a06772c5229b896f4352f3
Signed-off-by: Brad Bishop <bradleyb@fuzzi

manager: remove unused interface

The manager doesn't use the interface being passed in, so remove it.

Change-Id: I1ebb07a7fa109d41a0a06772c5229b896f4352f3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

style: update clang-format

Pull the most recent OpenBMC style rules and run clang-format.

Change-Id: I11a25ea1e62d6c739010d9dd742a139fb17cc09a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.co

style: update clang-format

Pull the most recent OpenBMC style rules and run clang-format.

Change-Id: I11a25ea1e62d6c739010d9dd742a139fb17cc09a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iea684a5a06d6d8f3e83b0dc1d7b8080dc2751466

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8ae0323c7eabb6c0cde2126b07a7396b4e3e17ea

Load the associations definitions

Parse the JSON file to load in the _associations
data structures. Any failures will cause an exception
to be thrown that will crash the app.

The JSON looks like:

Load the associations definitions

Parse the JSON file to load in the _associations
data structures. Any failures will cause an exception
to be thrown that will crash the app.

The JSON looks like:

[
{
"path": "The relative path of the inventory object to create the
org.openbmc.Associations interface on."
"endpoints":
[
{
"types":
{
"fType": "The forward association type."
"rType": "The reverse association type."
},
"paths":
[
"The list of association endpoints for this
inventory path and association type."
]
}
]
}
]

Change-Id: I098fdc607f0c3ab2861f9b33e3e0d46e4989bd7a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

serialization: adapt to filesystem API changes

The behavior of std::filesystem::path::append changed on its journey
from experimental:: to std::
Add a testcase and adapt to the behavior change.

Fix

serialization: adapt to filesystem API changes

The behavior of std::filesystem::path::append changed on its journey
from experimental:: to std::
Add a testcase and adapt to the behavior change.

Fixes: e6b21c74581c30ea635aabbbc08d0a56f8e27063
Change-Id: I4bdb43ea9b85933ec12ae0f4b609ec3a33d77d01
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

manager: Add build testcase

Add a basic compile time test that ensures manager.hpp can build on
its own.

Change-Id: Id10cdd8135fd4a41ebf2a76bc1e0da2d1916c6fa
Signed-off-by: Brad Bishop <bradleyb@fu

manager: Add build testcase

Add a basic compile time test that ensures manager.hpp can build on
its own.

Change-Id: Id10cdd8135fd4a41ebf2a76bc1e0da2d1916c6fa
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

manager: refactor interface templates

Many of the templates in manager.hpp are _almost_ testable. Enable
testing by porting to a new header - interface_ops.hpp - to be activated
later.

Enhancement

manager: refactor interface templates

Many of the templates in manager.hpp are _almost_ testable. Enable
testing by porting to a new header - interface_ops.hpp - to be activated
later.

Enhancements include:

Dropped 'PropertiesVariant' wrapper template for reduced comprehensional
complexity.

More intuitive HasProperties implementation. HasProperties is a type
traits template that simply checks for the presence of a nested
PropertiesVariant typename. These are provided by sdbusplus generated
server bindings for dbus interfaces that have properties.

Standalone templates for make, assign, serialize and deserialize
interface. There was no good reason to couple these, and the
resulting types and method names are more intuitive.

Templated serialize/deserialize operations so the dependency on
cereal can be abstracted away.

Change-Id: Ia449628eeaa9732bbbc51b0609bd449f43ebcb7c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

serialize: Add build testcase

Add a basic compile time test that ensures serialize.hpp can build on
its own.

Change-Id: Ib83e9fa73fd44c00884299b48b896f1fe53752c7
Signed-off-by: Brad Bishop <bradley

serialize: Add build testcase

Add a basic compile time test that ensures serialize.hpp can build on
its own.

Change-Id: Ib83e9fa73fd44c00884299b48b896f1fe53752c7
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

utils: Add unit tests

Ensure utils.hpp can build on its own, and add some unit tests.

Change-Id: Ia147b699105ff4497d9226630ef19e57d91de3c3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

types: Add build testcase

Add a basic compile time test that ensures types.hpp can build on its
own.

Change-Id: Idbf8a68feb1bf30b4fb573d254edf3a2f0a6f0cc
Signed-off-by: Brad Bishop <bradleyb@fuzzie

types: Add build testcase

Add a basic compile time test that ensures types.hpp can build on its
own.

Change-Id: Idbf8a68feb1bf30b4fb573d254edf3a2f0a6f0cc
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

test: Add test-driver, minor refactoring

Add the test driver so we can run unit tests with the check target.

Drop GTEST_CPPFLAGS - gtest has proper pkg-config support now.

Default not-found messag

test: Add test-driver, minor refactoring

Add the test driver so we can run unit tests with the check target.

Drop GTEST_CPPFLAGS - gtest has proper pkg-config support now.

Default not-found messages are sufficient - use those.

Change-Id: I887f6bc46a029b6b23254da7508745952f865869
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Fix std::variant usage

This change makes it possible to use std::variant as a drop in
replacement for mapbox::variant.

Change-Id: Ia729c3a7832eec4dd6cddadba9bc160b6ba9ad90
Signed-off-by: William A.

Fix std::variant usage

This change makes it possible to use std::variant as a drop in
replacement for mapbox::variant.

Change-Id: Ia729c3a7832eec4dd6cddadba9bc160b6ba9ad90
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

formatter: update clang-format and fix-up file(s)

clang-format-6.0 introduced new changes, also then updates to
.clang-format introduce more new changes.

Change-Id: Iec9f84e3a7a5bf254d66eee46cdc9b3

formatter: update clang-format and fix-up file(s)

clang-format-6.0 introduced new changes, also then updates to
.clang-format introduce more new changes.

Change-Id: Iec9f84e3a7a5bf254d66eee46cdc9b3070e06687
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Enable clang-format

Fix up problems and enable clang-format during CI builds.

Change-Id: Ia5c88281f7090c0aa09ba586d968f1fcd8aba4f1
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>