control:ibm,Rainier: Add hot PCIe card

Add the 'Moso' card to all Rainier models.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I2ad38ea9926f76fe9324052ef68045bd086dcb63

control:configs:Everest: Add a new floor index

Add a new floor index of 4, and change the Cedar Lake and Haleakala
cards to use it.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Icd8f

control:configs:Everest: Add a new floor index

Add a new floor index of 4, and change the Cedar Lake and Haleakala
cards to use it.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Icd8fd365f756e3d36199237dec2d478aa8091f0e

show more ...

control:configs: BlueRidge 2U fan support

The BlueRidge 2U is similar to the Rainier 2U but uses different fans.
The only difference from Rainier so far is the fan ceiling is changing
from 18000 to

control:configs: BlueRidge 2U fan support

The BlueRidge 2U is similar to the Rainier 2U but uses different fans.
The only difference from Rainier so far is the fan ceiling is changing
from 18000 to 17000.

Copy over the Rainier files that reference this and change the values.
The groups.json and pcie_cards.json used will still be obtained from the
Rainier directory.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ib935e0d168d6b6cad2f26b5d455aec957af204e5

show more ...

control:ibm,Bonnell: Add hot PCIe card

Add the 'GTO' PCIe card to the list of hot PCIe cards, and add floor
values for its floor index.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I

control:ibm,Bonnell: Add hot PCIe card

Add the 'GTO' PCIe card to the list of hot PCIe cards, and add floor
values for its floor index.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ie2863a08cdf9c85ca5e6c25d56d4cc367da60218

show more ...

control:Bonnell: Increase ambient values by 4.5

Increase any values referencing the ambient temperature by 4.5 degrees
to account for the fact that the actual temperature is 4.5 degrees
higher than

control:Bonnell: Increase ambient values by 4.5

Increase any values referencing the ambient temperature by 4.5 degrees
to account for the fact that the actual temperature is 4.5 degrees
higher than what the sensor shows.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I2441c68676a716f7d5324b81bb48102187ab600f

show more ...

control:Bonnell: Remove hot PCIe cards

It turns out that Bonnell doesn't have any 'hot' pcie cards, so the
floor can just be based on ambient and altitude.

This commit removes the cards from pcie_c

control:Bonnell: Remove hot PCIe cards

It turns out that Bonnell doesn't have any 'hot' pcie cards, so the
floor can just be based on ambient and altitude.

This commit removes the cards from pcie_cards.json and removes any PCIe
floor index values from the mapped_floor action in events.json. It
still leaves the infrastructure to keep things more common with the
other IBM systems, and to make it easier to add in a card if/when a hot
one comes into plan.

There is also a code update needed to allow an empty pcie_cards.json
file.

Tested:
Floors are set appropriately based on the altitude and ambient.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I10e6904602c7abf61121f7c610059f164405b758

show more ...

control:Bonnell: Config updates

The following updates were made to the Bonnell fan control config:
- Change max RPMs to 17000 from 18000
- The fans could never actually hit 18000
- Add the real PC

control:Bonnell: Config updates

The following updates were made to the Bonnell fan control config:
- Change max RPMs to 17000 from 18000
- The fans could never actually hit 18000
- Add the real PCIe card list
- Update the floor table and the associated parameters
- Some unused floor indices are left in the table to make
it easier for future expansion.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia7f4627f9458322e250452e67f330ede063c7efe

show more ...

control:Bonnell: Update dram temp thresholds

Move the dram temp range to 64-61 from 68-65.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I0f3847e70e59e8cd15e5934827c9d3df23530bb6

control:configs:Everest: Update hot cards

The Lassen and Glacier Park EDR cards need to use a value 3 for their
PCIe floor index on Everest.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-

control:configs:Everest: Update hot cards

The Lassen and Glacier Park EDR cards need to use a value 3 for their
PCIe floor index on Everest.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Idf7c34793f7a9e514886e0ba04997c6a5adc569d

show more ...

control:configs:rainier: Add new hot card

Add the Narwhal adapter to the hot card list for all of the Rainier
models.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iebf50f3d170aa1a1df

control:configs:rainier: Add new hot card

Add the Narwhal adapter to the hot card list for all of the Rainier
models.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iebf50f3d170aa1a1dfbf2aeec06d00f666f48007

show more ...

control:config:ibm: Use count_state_floor delay

Add a 5 second delay to the count_state_floor action that watches for
non functional sensors to all IBM configurations. With this change, a
sensor ha

control:config:ibm: Use count_state_floor delay

Add a 5 second delay to the count_state_floor action that watches for
non functional sensors to all IBM configurations. With this change, a
sensor has to be nonfunctional for at least 5 seconds for the floor to
change.

This is being done because the NVMe temperature sensors would briefly be
set to nonfunctional when a drive is removed.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6fa70f2551c11b2cfe8ee4696b6d72d57a3a7bd5

show more ...

cnfgs:p10bmc: Rename the IBM config directories

Due to the fan applications now using the
xyz.openbmc_project.Inventory.Decorator.Compatible interface instead of
the xyz.openbmc_project.Configuratio

cnfgs:p10bmc: Rename the IBM config directories

Due to the fan applications now using the
xyz.openbmc_project.Inventory.Decorator.Compatible interface instead of
the xyz.openbmc_project.Configuration.IBMCompatibleSystem one, the names
of the systems have changed as the new interface uses a different
property value format.

Rename all of the directories that mirror those property names to the new
ones.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ie541d15b47a155e88800fb7def76c0e8fbd8182b

show more ...

control:configs:rainier-4u: Use memory DVFS temps

Instead of hardcoding the increase and decrease temperatures for the
memory related sensors, do the same as what was done for the processor
core and

control:configs:rainier-4u: Use memory DVFS temps

Instead of hardcoding the increase and decrease temperatures for the
memory related sensors, do the same as what was done for the processor
core and ioring temps and use an offset from the DVFS (dynamic
voltage and frequency scaling) sensor for that sensor type.

This is being done because DDR4 and DDR5 memory have different DVFS
temperatures where the OCC starts throttling/slewing, and so just
hardcoding a single temperature value wouldn't work.

The *_increase_temp and *_decrease_temp modifier values were chosen such that
the final increase and decrease parameter temperature values were the
same as what the hardcoded temperatures were for DDR4. They were
calculated by subtracting the old increase/decrease temp values from the
DVFS value.

Note: The 4U and 1S4U Use the same values for everything.

Tested:
Checked the parameters that were present on a Rainier-4U:
"dram_extmb_dvfs_decrease_temp": 63.0,
"dram_extmb_dvfs_increase_temp": 66.0,
"pmic_dvfs_decrease_temp": 62.0,
"pmic_dvfs_increase_temp": 65.0,

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia162046dc376d514284303337ba192a79d705b3d

show more ...

control:configs:everest: Use memory DVFS temps

Instead of hardcoding the increase and decrease temperatures for the
memory related sensors, do the same as what was done for the processor
core and io

control:configs:everest: Use memory DVFS temps

Instead of hardcoding the increase and decrease temperatures for the
memory related sensors, do the same as what was done for the processor
core and ioring temps and use an offset from the DVFS (dynamic
voltage and frequency scaling) sensor for that sensor type.

This is being done because DDR4 and DDR5 memory have different DVFS
temperatures where the OCC starts throttling/slewing, and so just
hardcoding a single temperature value wouldn't work.

The *_increase_temp and *_decrease_temp modifier values were chosen such that
the final increase and decrease parameter temperature values were the
same as what the hardcoded temperatures were for DDR4. They were
calculated by subtracting the old increase/decrease temp values from the
DVFS value.

Tested:
Checked the parameters that were present on an Everest:
"dram_extmb_dvfs_decrease_temp": 52.0,
"dram_extmb_dvfs_increase_temp": 55.0,
"pmic_dvfs_decrease_temp": 55.0,
"pmic_dvfs_increase_temp": 58.0,

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I4e76cfc13325df3a3c3d0a993381f2418c088c24

show more ...

control:configs:rainier-2u: Use memory DVFS temps

Instead of hardcoding the increase and decrease temperatures for the
memory related sensors, do the same as what was done for the processor
core and

control:configs:rainier-2u: Use memory DVFS temps

Instead of hardcoding the increase and decrease temperatures for the
memory related sensors, do the same as what was done for the processor
core and ioring temps and use an offset from the DVFS (dynamic
voltage and frequency scaling) sensor for that sensor type.

This is being done because DDR4 and DDR5 memory have different DVFS
temperatures where the OCC starts throttling/slewing, and so just
hardcoding a single temperature value wouldn't work.

The *_increase_temp and *_decrease_temp modifier values were chosen such that
the final increase and decrease parameter temperature values were the
same as what the hardcoded temperatures were for DDR4. They were
calculated by subtracting the old increase/decrease temp values from the
DVFS value.

Tested:
Checked the parameters that were present on a Rainier-2U:
"dram_extmb_dvfs_decrease_temp": 52.0,
"dram_extmb_dvfs_increase_temp": 55.0,
"pmic_dvfs_decrease_temp": 65.0,
"pmic_dvfs_increase_temp": 68.0,

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I339df9e803f81ba0e6c1f05bb9403dc4a59ade8e

show more ...

control:cnfgs:ibm,bonnell: Enable fan control

Check in the JSON files to enable fan control on IBM's Bonnell system.
It is a 1 socket 4 DIMM 2 fan system. It uses the same fan model as the
Rainier

control:cnfgs:ibm,bonnell: Enable fan control

Check in the JSON files to enable fan control on IBM's Bonnell system.
It is a 1 socket 4 DIMM 2 fan system. It uses the same fan model as the
Rainier 2U, and uses mostly the same settings as the Rainier 2U with the
exception of having some lower floors, though only when there are no hot
PCIe cards present.

The floor values when there are hot PCIe card present may change in the
future.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I30b42fa4f2c2715ba26bbfef4a3d28dc77373390

show more ...

control:configs:rainier-*4u: Add new hot card

Add the Shale PCIe card to the hot cards list pcie_cards.json for
the Rainier 4U and 1S4U.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id:

control:configs:rainier-*4u: Add new hot card

Add the Shale PCIe card to the hot cards list pcie_cards.json for
the Rainier 4U and 1S4U.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I84ad11d790f48584fe6fffd850a474532e5214fe

show more ...

control:configs:rainier-2u: Add new hot card

Add the Lassen InfiniBand adapter to the hot cards list for the Rainier
2U.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I88f84068f2e22e7

control:configs:rainier-2u: Add new hot card

Add the Lassen InfiniBand adapter to the hot cards list for the Rainier
2U.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I88f84068f2e22e743fdd764b17914383ea3371a0

show more ...

control:configs:rainier-*4u: Add new hot card

Add the Dragonhead PCIe card to the hot cards list pcie_cards.json for
the Rainier 4U and 1S4U.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change

control:configs:rainier-*4u: Add new hot card

Add the Dragonhead PCIe card to the hot cards list pcie_cards.json for
the Rainier 4U and 1S4U.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Idd355a350f39e0c8739fd3c68f16840f7da70cec

show more ...

control:configs: rainier-1s4u floor updates

If the model value of the first processor is 5CF9, use a different
mapped_floor table with higher floors.

Signed-off-by: Matt Spinler <spinler@us.ibm.com

control:configs: rainier-1s4u floor updates

If the model value of the first processor is 5CF9, use a different
mapped_floor table with higher floors.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I2ebea798e3c5e5bf60aa82d12b4139239f383a72

show more ...

control:configs: Add altitude group to Rainier 4Us

The altitude is used by actions in the Rainier 4U and 1S4U, but was
missing from the groups.json files. This caused the altitude offsets
used by th

control:configs: Add altitude group to Rainier 4Us

The altitude is used by actions in the Rainier 4U and 1S4U, but was
missing from the groups.json files. This caused the altitude offsets
used by the mapped floor action to always be zero.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I46748a9dfe5f054964c11ae28009c0c73b23b1fc

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I961ec77b2617da3e097e64e0d8e8980bb7e5b426
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

control:cnfgs:p10bmc: Add svc names to some groups

The group configuration files provide the ability to add the D-Bus
service owner of the group, if it's known and if there is only one
service provi

control:cnfgs:p10bmc: Add svc names to some groups

The group configuration files provide the ability to add the D-Bus
service owner of the group, if it's known and if there is only one
service providing everything in the group. If that is provided, then
fan control can register for a NameOwnerChanged signal if that service
starts after fan control.

For that reason, add service names to some of the groups that were
missing one. It is most important for the virtual ambient group, where
it was seen that it could start after fan control so fan control was
setting the fan targets to a higher value than necessary.

Note that the service name isn't needed for any of the inventory related
groups because they aren't used in the 'services missing' event.

There is a TODO in the code to figure out how to handle this case when
the service name can't be hardcoded, maybe by adding a timer to do some
retries. That may be done in the future.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I1b42e67b6824e7c31a5eef3ecaddfd8ec2487224

show more ...

control:ibm,bonnell: Add minimal config files

The Bonnell platform has two dual rotor fans. Add the minimum config
files so that fan control will set a power on target of 14100 RPM and do
nothing e

control:ibm,bonnell: Add minimal config files

The Bonnell platform has two dual rotor fans. Add the minimum config
files so that fan control will set a power on target of 14100 RPM and do
nothing else.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ic4b02d2ec8e9a91559873835ae8aedd968e9fb18

show more ...

control:action: fan override actions for locked rotor

For dual-rotor fans, when one rotor fails the other rotor should be
locked at the system's full-speed value. Here this rule is simplified so
tha

control:action: fan override actions for locked rotor

For dual-rotor fans, when one rotor fails the other rotor should be
locked at the system's full-speed value. Here this rule is simplified so
that both rotors of the pair are locked at the same speed.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: Idca46bd71885f0a8b8277469b9ba730ffa86366e

show more ...