PHAL: Added non functional boot processor failure handling

Added support to create PELs' specific to non functional
boot processor related failure during boot window.

Implemented "NonFunctionalBoot

PHAL: Added non functional boot processor failure handling

Added support to create PELs' specific to non functional
boot processor related failure during boot window.

Implemented "NonFunctionalBootProc" message registry
specific PEL function and special callouts to these type
of failures.

Tested: verified PEL manually.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I17c208197a9fd08b1a0aca519da4e03813862255

show more ...

PHAL: istep mode: hardware error is not stopping boot process.

In the istep mode an error is logged with hardware error
should stop the boot process and stays in Quiesce state if the
stop on error

PHAL: istep mode: hardware error is not stopping boot process.

In the istep mode an error is logged with hardware error
should stop the boot process and stays in Quiesce state if the
stop on error policy is enabled.
Noticed diffrent behaviour in istep mode, like Quiesce calls
phal-create-boottime-guard-indicator.service. This service
starts start_host@0.service, causing normal boot start in the
middle of a Quiesce.

In most cases, this would be fine, but we didn't use firmware
to boot so we did not run "start_host@0.service".

Proposed fix is to remove Wants=start_host@0.service

Tested: forced the checkstop during istep boot.
system stay's at Quiesce state.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I4c11648f9162e2c0c861cb1c96edafd6e22323b6

show more ...

Execute mp reboot prior to host dump delete service

The entries for the dumps stored in the host memory needs to
be deleted during a power off but that should be skipped
in the case of a memory pres

Execute mp reboot prior to host dump delete service

The entries for the dumps stored in the host memory needs to
be deleted during a power off but that should be skipped
in the case of a memory preserving reboot.

Add changes to make sure the host dump clear service
executes after enter mp reboot service, so dump clear
service can be skipped if the indicater file exists.

Tests:
Feb 24 11:38:53 systemd[1]: Finished Start memory preserving reboot host0.
Feb 24 11:38:53 systemd[1]: Condition check resulted in Remove host dump entries during poweroff being skipped.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I736a2c6245b494db054b086a1b63348838d926a7

show more ...

PHAL: Add new service file to indicate guard actions.

- Currently, the host is in the infinite loop to boot if the host
firmware trying to recover resources and informs that to the BMC by
the gr

PHAL: Add new service file to indicate guard actions.

- Currently, the host is in the infinite loop to boot if the host
firmware trying to recover resources and informs that to the BMC by
the graceful boot request.

- The PHAL will try to apply guard records in all types of boots.

- The host firmware will try to recover resources if that's are
guarded and did not meet the minimum hardware check to boot
the host and initiate a graceful boot to adjust boot params
(HWAS_STATE).

- When the BMC handles the host graceful boot request, PHAL will
apply the guard records and informs self boot engine about
the bad resources but, the host firmware did not apply the guard
records in the previous boot so when comparing the resources
state that's informed by the self boot engine are mismatching
and entering into an infinite loop to boot.

- So, the guard records actions changed in the BMC to supports
resource recovery feature.

- PowerOn / TI (terminate immediately) / Checkstop / Watchdog timeout:

- Clear ephemeral type records.
- Apply persistent type records.

- MPIPL:

- Apply persistent type records of the Core and FC.

- Graceful reboot from hostboot / Reboot from UI user or PHYP:

- No guard actions in the PHAL.

- To support the above guard actions in the BMC for the different boots,
BMC will create the "/tmp/phal/boottime_guard_indicator" file by using
the added service file that will get triggered as part the
obmc-host-start@0.target (PowerOn) and obmc-host-quiesce@0.target (TI,
Checkstop, and Watchdog timeout), PHAL need to take appropriate guard
actions for the same types of boot and remove that indication so that
no guard action can be handled during graceful reboot request from
hostboot and Reboot from UI or PHYP as well. MPIPL can be handled by
the existing IPL_TYPE value provided by the BMC to PHAL as part of
the MPIPL boot request.

- Added the above support in this patch for PHAL.

Tested:

- Pre-request: Created the "MC" of guard records to hit the minimum
hardware check.

- Verified by PowerOn (aka cold boot).

- Verified TI and Checkstop by injecting clock error at the runtime.
(i2cset -y 8 0x6a 0xb6 0x1a)

- Verified TI and Checkstop by injecting runtime "Fata" guard.
(putscom pu.c 20028440 0000000000000800 -n0 -p00 -c1)

- Verified MPIPL by using the PHYP macro.
(altermem c00 -t p 00000000)

- Verified Graceful request from hostboot as part boot param adjust
and SBE image update request.

- Verified Reboot, GracefulWarmReboot, ForceWarmReboot from the BMC.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I6422a8fb68559d7b02677a2f018f0d726ddd8952

show more ...

PHAL: Add service dependency to DEVTREE creation

Start the services that require DEVTREE after the
openpower-update-bios-attr-table.service since that's the one that
sets up the DEVTREE symlink. Als

PHAL: Add service dependency to DEVTREE creation

Start the services that require DEVTREE after the
openpower-update-bios-attr-table.service since that's the one that
sets up the DEVTREE symlink. Also update the path to DEVTREE to the one
defined by the meson options.

Tested: Verified phal started after the bios attr service file, powered
on, and issued reboot at power on without any errors. Verified service
files had devtree path of:
Environment="PDBG_DTB=/media/hostfw/running/DEVTREE"

Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Change-Id: If41f86b287b70c48d17c6f4b2af9aa0adfb81488

show more ...

PHAL: Additional callout support for sbe timeout error

Sbe Boot timeout or chip-op timeout case BMC should run
sbe_extract_rc procedure to identify the correct callout
and service action. Currently

PHAL: Additional callout support for sbe timeout error

Sbe Boot timeout or chip-op timeout case BMC should run
sbe_extract_rc procedure to identify the correct callout
and service action. Currently this procedure based callout
handling is not place. Adding callout recommended by RAS
team till the actual callout code in place.

Tested:

"Callout Count": "2",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this type as a unit",
"Procedure": "BMC0002"
}, {
"FRU Type": "Normal Hardware FRU",
"Priority": "Medium Priority",
"Location Code": "xxx", --> processor callout
"Part Number": "xxx",
"CCIN": "xxx",
"Serial Number": "xxx"

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I40444eb5da1a5f329b09dea1bce15e1bab53e1d8

show more ...

PHAL: Compute RO device tree file path from RW device tree symbolic link

Example:
RW file = /media/hostfw/running/DEVTREE -> 81e00672.lid
RO file = /media/hostfw/running-ro/ + 81e00672.lid

Compute

PHAL: Compute RO device tree file path from RW device tree symbolic link

Example:
RW file = /media/hostfw/running/DEVTREE -> 81e00672.lid
RO file = /media/hostfw/running-ro/ + 81e00672.lid

Compute the lid name by reading the RW symbolic link and use
it to comptue RO file.

Symbolic links cannot be created to RO files so using this approach

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I46101b8e246267c861edb5eae1ac24420cfc3c6d

show more ...

PHAL: Log informational type event for threadStopAll failure

currently threadStopAll command chip-op failure is marked as
unrecoverable type event. This is only called in
poweroff/error path, good c

PHAL: Log informational type event for threadStopAll failure

currently threadStopAll command chip-op failure is marked as
unrecoverable type event. This is only called in
poweroff/error path, good chance of chip-op failure in some
use-cases. Since there no service action required related to
this failure converting un-recoverable errors to informational

Tested: Verified PEL

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I04be09046967055579fc64980d81247e975a9c76

show more ...

PHAL: Modify sbe error pel interface to pass in error type

At present all sbe related pels are created with severity
as Error(unrecoverable), modifying the API to specify the
severity type by the ca

PHAL: Modify sbe error pel interface to pass in error type

At present all sbe related pels are created with severity
as Error(unrecoverable), modifying the API to specify the
severity type by the caller.

Some of the chip-op is expected to fail in power-off/error path.
This commit will help to set custom priority of the failure.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: If072061bf995b2db58259eba64e7e8f7ace20f6c

show more ...

PHAL: Clock error handling support

-Supporting new flag to indicate planar callout required
-This flag can be set from either clock HWP error or clock
non-HWP error.
-Adding new error type

PHAL: Clock error handling support

-Supporting new flag to indicate planar callout required
-This flag can be set from either clock HWP error or clock
non-HWP error.
-Adding new error type for ipl error callback
-This error type can be called for non-hwp failures
-Additional data sent will be parsed and included in PEL
-Different prefix is added for HWP error and PLAT error.
Tested:
"Primary SRC": {
"Deconfigured": "False",
"Guarded": "False",
"Error Details": {
"Message": "Failure occured during boot process"
},
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Normal Hardware FRU",
"Priority": "Mandatory, replace all with this type as a unit",
"Location Code": "U780C.ND0.1234567-P0",
"Part Number": "F040221",
"CCIN": "2E33",
"Serial Number": "YL2E33010000"
}]
}
},
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",

"PLAT_FFDC_FAIL_TYPE": "STATUS_READ",
"PLAT_FFDC_I2C_RC": "0",
"PLAT_HW_CO_01_CALLOUT_PLANAR": "true",
"PLAT_HW_CO_01_CLK_POS": "1",
"PLAT_HW_CO_01_HW_ID": "PROC_REF_CLOCK",
"PLAT_HW_CO_01_PRIORITY": "HIGH",
"PLAT_RC": "10",
"PLAT_RC_DESC": "Error in executing clock initialisation",
"_PID": "21916"
},
"User Data 2": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Deconfigured": false,
"Guarded": false,
"InventoryPath": "/xyz/openbmc_project/inventory/system/chassis/motherboard",
"Priority": "H"
}
]
}

Signed-off-by: Rajees P P <rajerpp1@in.ibm.com>
Change-Id: Ifd2268b1c99be4dbfa9234e910d7e87771adb176

show more ...

PHAL: Fixing wrong callout of reference target

-The target provided in HwCallout structure is, only a reference target
to find the actual hardware target need to be called out. So, this
target sho

PHAL: Fixing wrong callout of reference target

-The target provided in HwCallout structure is, only a reference target
to find the actual hardware target need to be called out. So, this
target should not be called out.

Signed-off-by: Rajees P P <rajerpp1@in.ibm.com>
Change-Id: I64082ae30d936d8b2e46458b460e66ff064f049b

show more ...

host-restart: set restart reason on mpreboot

When a memory preserving reboot (caused by a host firmware crash) is the
reason for a host restart, ensure the RestartCause is set appropriately.

This p

host-restart: set restart reason on mpreboot

When a memory preserving reboot (caused by a host firmware crash) is the
reason for a host restart, ensure the RestartCause is set appropriately.

This property is used by other software on some systems to guide
partition behaviors in the host code.

The phosphor-state-manager software is responsible for resetting the
RestartCause when the host is powered off.

Tested:
- Verified RestartCause was correctly set to Host.RestartCause.HostCrash
when executing the service.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ia99b13f8ee1267dcd2adb3edd0f29eea106043b2

show more ...

PHAL: Set HardwareIsolation policy before start the host

- The HardwareIsolation (aka guard) policy is used to prevent
the HardwareIsolation functionality during the boot of the host
by the user

PHAL: Set HardwareIsolation policy before start the host

- The HardwareIsolation (aka guard) policy is used to prevent
the HardwareIsolation functionality during the boot of the host
by the user.

- In this patch, using that policy flag to ignore the isolated hardware
records to apply during the start of the host from the BMC context.

- By default, it will be set as "true" before starting the host to boot
if the HardwareIsolation policy is not present or failed to read that
policy.

- Created the error log with procedure callout if failed to read
the HardwareIsolation policy.

Tested:
- Verified the HWAS_STATE of the isolated hardware, is not applied when
the HardwareIsolation policy is enabled.

- Verified the HWAS_STATE of the isolated hardware, is applied when
the HardwareIsolation policy is disabled.

- Verified the HWAS_STATE of the isolated hardware, is applied when
the HardwareIsolation policy is not present.

- PEL for the third test case.

```
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x3000",
...
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "CEC Hardware",
"Event Scope": "Entire Platform",
"Event Severity": "Unrecoverable Error",
"Event Type": "Not Applicable",
"Action Flags": [
"Service Action Required",
"Report Externally",
"HMC Call Home"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},
...
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x3000",
...
"Error Details": {
"Message": "Failure occured during boot process"
},
"Valid Word Count": "0x09",
"Reference Code": "BD503001",
...
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Medium Priority",
"Procedure": "BMC0001"
}]
}
...
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"REASON_FOR_PEL": "Failed to read the HardwareIsolation policy from the path [/xyz/openbmc_project/hardware_isolation/allow_hw_isolation] interface [xyz.openbmc_project.Object.Enable]. Continuing with default mode(allow_hw_isolation)",
"_PID": "681"
},
"User Data 2": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Priority": "M",
"Procedure": "BMC0001"
}
]
}
}
```

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I2d7e33ad1e6af69b150d6637619c17db5b9a7151

show more ...

README: Updated the build steps

- Updated the .gitignore file.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I3c472a7845e19d462d148be3405083ed3dbc52b4

PHAL: Add callout details for platform related errors

1) At present platform errors are treated as normal ipl errors
and no callout details are added.

2) Modified to add callout info to the FFDC ob

PHAL: Add callout details for platform related errors

1) At present platform errors are treated as normal ipl errors
and no callout details are added.

2) Modified to add callout info to the FFDC object when there
is error in plat code.

Tested:
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x3000",
"SRC Version": "0x02",
"SRC Format": "0x55",
"Virtual Progress SRC": "False",
"I5/OS Service Event Bit": "False",
"Hypervisor Dump Initiated":"False",
"Power Control Net Fault": "False",
"Backplane CCIN": "2E33",
"Deconfigured": "True",
"Guarded": "False",
"Error Details": {
"Message": "Failure occured during boot process"
},
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Normal Hardware FRU",
"Priority": "Medium Priority",
"Location Code": "U780C.ND0.WZS0003-P0-C14",
"Part Number": "F200203",
"CCIN": "AB41",
"Serial Number": " ",
"MRU Id": "00010000"
}]
}

"User Data 2": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Deconfigured": true,
"EntityPath": [
35,
1,
0,
2,
0,
5,
2,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0
],
"GuardType": "",
"Guarded": false,
"LocationCode": "Ufcs-P0-C14",
"MRUs": [
{
"ID": 65536,
"Priority": "M"
}
],
"Priority": "M"
}
]
}

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I8d3f1603c751efe74e5e06d4ebb9956681acdaa5

show more ...

pdbg api based op-stop-instructions service updates

Replaced pdbg tool based stop all with api based
openpower-proc-control procedure based approach.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ib

pdbg api based op-stop-instructions service updates

Replaced pdbg tool based stop all with api based
openpower-proc-control procedure based approach.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I4c4f635ec87f128dbcb89e6c78e4f1a0b41a2cd7

show more ...

P9: threadStopall procedure support

This procedure is used to stop all instruction in the threads
for the p9 feature enabled systems. Here following best case
approach. Like issue processor level st

P9: threadStopall procedure support

This procedure is used to stop all instruction in the threads
for the p9 feature enabled systems. Here following best case
approach. Like issue processor level stop all chip-op with
ignore hardware error mode. Since this function is used in
power-off/error path.

Tested: verified procedure on p9 based systems

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I14af85340143d2383683d9fb823394b9ce7b56ca

show more ...

PHAL: threadStopall procedure support

This procedure is used to stop all instruction in the threads
for the phal feature enabled systems. Here following best case
approach. Like issue processor leve

PHAL: threadStopall procedure support

This procedure is used to stop all instruction in the threads
for the phal feature enabled systems. Here following best case
approach. Like issue processor level stop all chip-op with
ignore hardware error mode. Since this function is used in
power-off/error path

Tested: Verified success/error path
root@xxxx:/tmp# openpower-proc-control threadStopAll
PDBG Initilization started
Enter: threadStopProc(/proc0)
Enter: threadStopProc(/proc1)
SBE (/proc1) is not ready for chip-op: state(0x00000000)
Enter: threadStopProc(/proc2)
SBE (/proc2) is not ready for chip-op: state(0x00000000)
Enter: threadStopProc(/proc3)
SBE (/proc3) is not ready for chip-op: state(0x00000000)

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I654b0b7df209e618b3d7a8fba948c0e48b53a7e0

show more ...

PHAL: enabled devtree attributes reinit during boot

This commit enables the devtree attribute reinitialization
during boot process by adding reinitDevtree procedure in the
phal-reinit-devtree.servic

PHAL: enabled devtree attributes reinit during boot

This commit enables the devtree attribute reinitialization
during boot process by adding reinitDevtree procedure in the
phal-reinit-devtree.service.

Tested: verified normal poweron.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I17b66966ff46ce307e36c5fd8b7f2ede399cb0a4

show more ...

PHAL: devtree file based attribute override support

This commits enables the file based devtree attribute override
attributes tool enabled feature to export attribute to override
file during "attrib

PHAL: devtree file based attribute override support

This commits enables the file based devtree attribute override
attributes tool enabled feature to export attribute to override
file during "attributes write" command.
During devtree re-initiaization service execution, enabled
to import attribute override file based data to the devtree.

User can also manually create attribute override file by creating
cronus attribute override format file.
Example:
target = k0
ATTR_FREQ_PAU_MHZ u32 0x000008ca

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I21335c0c81249f4d60b235ea204d0e90420fd29c

show more ...

PHAL: reinitialize the devtree attributes

In the regular host boot path devtree attribute need to
initialize the default data and also some of the selected
attributes need to preserve with previous

PHAL: reinitialize the devtree attributes

In the regular host boot path devtree attribute need to
initialize the default data and also some of the selected
attributes need to preserve with previous boot value.
Preserve attribute list is available BMC pre-defined location.
This function helps to meet the host ipl requirement
related to attribute persistency management for host ipl.

Steps involved
1. create attribute data file from devtree r/w version based on
the attribute list file installed in bmc.
2. create temporary copy of r/w version devtree for attributes
updates and initialise with r/o DEVTREE version
to default data.
3. apply step-1 attribute file on top of the temporary
copy file.
4. Incase any failure from step 1 to 3 log an error and
update r/w version with r/o version ( genesis boot).
5. Update DEVTREE r/w version with temporary version file.

Also added devtree libs part of the pdata repository to
export/import attributes devtree.

Tested: verified the devtree attribute values.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I20c17ba3013a0b4b01f9f8e0d4462c91489308e8

show more ...

Add TemporaryFile class

Added support for creating temporary file
- Constructor creates the temporary file.
- Destructor deletes the file.
- Provided remove function to delete the file.

Signed-off-

Add TemporaryFile class

Added support for creating temporary file
- Constructor creates the temporary file.
- Destructor deletes the file.
- Provided remove function to delete the file.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I2a5e81af8cf4f4621e5ec6437b936126b7e9ba5a

show more ...

PHAL: Add procedure callout for hwp errors

Added infrastructure to enable procedure callout support
for the HWP failure related PEL

Tested:
User data 1
"HWP_PROC_CO_01_MAINT_PROCEDURE": "BMC0002",

PHAL: Add procedure callout for hwp errors

Added infrastructure to enable procedure callout support
for the HWP failure related PEL

Tested:
User data 1
"HWP_PROC_CO_01_MAINT_PROCEDURE": "BMC0002",
"HWP_PROC_CO_01_PRIORITY": "MEDIUM",

"Callout Section": {
"FRU Type": "Maintenance Procedure Required",
"Priority": "Medium Priority",
"Procedure": "BMC0002"
}

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I25f7bed2817a767c219a7a4c2ad6d71ccb3bbf07

show more ...

PHAL: Add BMC0001 procedure callout for SBE boot error

Added procedure callout during SBE boot error processing
function, when fail to get boot processor information.

Tested:
"Callout Section": {

PHAL: Add BMC0001 procedure callout for SBE boot error

Added procedure callout during SBE boot error processing
function, when fail to get boot processor information.

Tested:
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this
type as a unit",
"Procedure": "BMC0001"
}]
}

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ifd9311e25b8447409d901ba446185337e38ef305

show more ...

PHAL: added createErrorPEL wrapper function

Refactored createBootErrorPEL to support callout and
additional data information as optional parameter to
support diffrent types of PEL creation.

Also re

PHAL: added createErrorPEL wrapper function

Refactored createBootErrorPEL to support callout and
additional data information as optional parameter to
support diffrent types of PEL creation.

Also renamed createBootErrorPEL -> createErrorPEL.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Iee6e356740179caf6486a2750cf30278240a5785

show more ...