remove installs on templated services and targets

New yocto is getting more stringent on installation of templated service
and targets.

Templated services are installed by bitbake recipes so there'

remove installs on templated services and targets

New yocto is getting more stringent on installation of templated service
and targets.

Templated services are installed by bitbake recipes so there's no
need to have the WantedBy/RequiredBy in those services.

Here's a summary of the error we get for packages which have templated
services doing an install:
```
ERROR: obmc-phosphor-image-1.0-r0 do_rootfs: Postinstall scriptlets of
['<package>' 'inst returned 1, marking as unpacked only, configuration
required on target']
If the intention is to defer them to first boot,
then please place them into pkg_postinst_ontarget:${PN} ().
Deferring to first boot via 'exit 1' is no longer supported.
```

Tested:
- Confirmed image builds with new yocto and services are still installed
as expected

Change-Id: Idefed9dec8c295a2c8abc486c4a6a82097c61adc
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more e

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more efficient and succinct.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I59b1cef85e4e0e5dd14b33a4e1bc15aaef2a8aac

show more ...

remove is_method_error call

An `is_method_error` is not appropriate after an sdbus `call` since
`call` will always throw an exception. Remove the pointless call
and instead catch the exception.

Ch

remove is_method_error call

An `is_method_error` is not appropriate after an sdbus `call` since
`call` will always throw an exception. Remove the pointless call
and instead catch the exception.

Change-Id: I9b5da6b36efaf9b1eddf15270a35690b66fed607
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated

meson: use non-deprecated systemd packageconfig

Systemd's packageconfig file has both `systemdsystemunitdir` and
`systemd_system_unit_dir` defined. The non-underscore one appears
to be a deprecated alias[1]. Move to the non-deprecated /
underscore-separated variant.

[1]: https://github.com/systemd/systemd/commit/4908de44b0a0409f84a7cdc5641b114d6ce8ba03

Change-Id: Ib480e73b95e3cc64b25ec9d59b8bba8aaa3a4154
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

utilize systemd semantic for non-critical ExecStart

The "|| true" was always a bit of a hack to have systemd services ignore
commands which are not critical. It seems recent systemd releases have
br

utilize systemd semantic for non-critical ExecStart

The "|| true" was always a bit of a hack to have systemd services ignore
commands which are not critical. It seems recent systemd releases have
broken that workaround.

Utilize the official[1] systemd mechanism to indicate a command within
the service is optional and ok to fail (=-).

The location of the "|| true" within the commands quotation marks
now matters. But lets just get rid of it all together now that we have a
way to just have systemd allow the command to fail and continue.

Tested:
Wrote a little test service:
```
[Unit]
Description=Test Service

[Service]
RemainAfterExit=yes
Type=oneshot
ExecStart=/bin/sh -c "busctl set-property invalid || true"
ExecStart=-/bin/sh -c "busctl set-property invalid" || true
ExecStart=-/bin/sh -c "busctl set-property invalid"
ExecStart=/bin/echo 'we made it past all invalid tests above'

[Install]

```

[1]: https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Command%20lines

Change-Id: I5b16a5abf9ba8e0a384bac1130b77bf0252b9dd9
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I8df086777589ac2f29fa9d238b52ed43f15236ed
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ica5455c0f9120c0215968b5529883ced937e0140
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: Ica5455c0f9120c0215968b5529883ced937e0140
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: I47bfd98f41af7fbfdf9ca2d220277427be3c0cfb
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I299e3888aee418ddcf391a44cd9ba563edabfe83
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add subproject wrap files

As a start on getting the repo to build standalone outside of a docker
or bitbake environment, add meson wrap files for most of its
dependencies.

A subproject is still nee

Add subproject wrap files

As a start on getting the repo to build standalone outside of a docker
or bitbake environment, add meson wrap files for most of its
dependencies.

A subproject is still needed for pdbg. It will take a bit more work as
a subprojects/packagefiles/pdbg/meson.build has to be created for it.

Tested:
Meson gets past these dependencies and then fails on pdbg.

Change-Id: I7379d1feafd00d42f3d38ba08aac6267f9eca76b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]

README.md: Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I8bbe4c5b1484f526a917836cc6c215e9b3789c31

show more ...

README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Cont

README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "Contains procedures that inter..."]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ie4cbc4e78c3db550b5ec4e15f8baee5585e65f0b

show more ...

Update OWNERS file to add dhruvaraj as reviewer

Add myself dhruvaraj@in.ibm.com as a reviewer

Change-Id: Ia09ee68cf091900df4801d3a4e5a237017123bd6
Signed-off-by: Dhruvaraj Subhashchandran <dhruvara

Update OWNERS file to add dhruvaraj as reviewer

Add myself dhruvaraj@in.ibm.com as a reviewer

Change-Id: Ia09ee68cf091900df4801d3a4e5a237017123bd6
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Option to override dump request D-Bus path

Added option for overriding the object path for requesting OpenPOWER
dumps. On recent systems the object path is changed so adding option
to override the p

Option to override dump request D-Bus path

Added option for overriding the object path for requesting OpenPOWER
dumps. On recent systems the object path is changed so adding option
to override the path in the recipe.

Change-Id: Ice2f46e61b4a7604230d495463c5c90fdc549505
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

State.Chassis: update service name

Both phosphor-state-manager and x86-power-control have code that exposes
both the Chassis and Chassis0 bus names as a backwards compatibility
when multi-chassis su

State.Chassis: update service name

Both phosphor-state-manager and x86-power-control have code that exposes
both the Chassis and Chassis0 bus names as a backwards compatibility
when multi-chassis support was added. Switch to the numbered bus name,
which is expected to be the non-deprecated one.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I27303e285de0279a7733613de4df7dafb136aa71

show more ...

Remove Jayanth from maintainers

No longer actively contributing to OpenPOWER projects.
Feel free to CC me in case any inputs required to existing code.

Change-Id: I813df787e7e81790d8109b8509183588b

Remove Jayanth from maintainers

No longer actively contributing to OpenPOWER projects.
Feel free to CC me in case any inputs required to existing code.

Change-Id: I813df787e7e81790d8109b8509183588b04ac037
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I06e9ad76b7e259a962f15f0b013d92a62f02a039
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

PHAL:Fix missing clock diagnostic data during ipl

During the IPL process, the Chassis Power State D-Bus property is
updated once all services and targets within the Chassis Power On target
have been

PHAL:Fix missing clock diagnostic data during ipl

During the IPL process, the Chassis Power State D-Bus property is
updated once all services and targets within the Chassis Power On target
have been completed. During this specific timeframe, when the
"op-clock-data-logger@.service.in" initiates, it may fail to capture
clock data due to a failed check. This situation occurs because, even
though the chassis power is turned on, the D-Bus property does not
provide the precise status, resulting in a missed opportunity to record
informational clock data.

The "op-clock-data-logger@.service.in" service is already configured to
start after the "obmc-host-started@%i.target" and is set to conflict
with the "obmc-host-stop@%i.target." This design ensures that whenever
this method is invoked, the chassis power will always be in the ON
state. Therefore, there is no need to redundantly check the chassis
power state for being ON. Consequently, the redundant conditional
statement has been removed.

Tested and found the clock informational diagnostic data added after
every ipl.

Change-Id: I56e62467be14c6f203d163d86aa6a5fd748d0d85
Signed-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>

show more ...

phal: fix ignoring attributes warning

This to fix the below compilation warnings with latest
yocto rebase .

einit_devtree.cpp:28:62: error: ignoring attributes
on template argument 'int (*)(FILE*

phal: fix ignoring attributes warning

This to fix the below compilation warnings with latest
yocto rebase .

einit_devtree.cpp:28:62: error: ignoring attributes
on template argument 'int (*)(FILE*)'
[-Werror=ignored-attributes]
| 28 | using FILE_Ptr =
std::unique_ptr<FILE, decltype(&std::fclose)>;

Change-Id: I12e0f4034eea80d19c0f1236102ab0bafd42432e
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: Ia3f5c607a348f062a0f112d5eae8b51ecc23fd37
Signed-off-by: J

switch fmt::format to use std::format

fmt::format is supported in the c++ std. This will
help to remove fmt package dependency.

Change-Id: Ia3f5c607a348f062a0f112d5eae8b51ecc23fd37
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: If38b6927d9f9855b4ac1527d481de50a33ff2675

show more ...

Reset dump attribute on obmc-host-quiesce target

The pvm_sys_dump_active bios attribute prevents new dump creation when a
dump is already in progress/ is being offloaded. This attribute is
cleared b

Reset dump attribute on obmc-host-quiesce target

The pvm_sys_dump_active bios attribute prevents new dump creation when a
dump is already in progress/ is being offloaded. This attribute is
cleared by the PHYP when the dump is offloaded and deleted.

In case of a PHYP TI with host getting into quiesced state, the
attribute is not cleared which prevents further dump creation. To handle
this scenario, the attribute is reset when the host reaches quiesce
state.

The corresponding bitbake recipe will do the actual installation.

This change is just a documentation to support
https://gerrit.openbmc.org/c/openbmc/openbmc/+/65709 changes

Tested:
When the host is quiesced, initiated a user triggered system dump and
tested. The new system dump is created successfully.

Change-Id: I1484df5056d56a5c71c7ccbb10da9969e46d2a47
Signed-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Idb2f3600e67c3eef66f49

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Idb2f3600e67c3eef66f490eda55bf24c1edfde19
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

gcc13 : fix argument format issues

gcc13 based build failed with below error.
error: static assertion failed: Cannot format an argument.
To make type T formattable provide a formatter<T> special

gcc13 : fix argument format issues

gcc13 based build failed with below error.
error: static assertion failed: Cannot format an argument.
To make type T formattable provide a formatter<T> specialization:
https://fmt.dev/latest/api.html#udt

Problem looks similar to https://github.com/fmtlib/fmt/issues/391

Fix is to convert the "enum" type to underlying_type in fmt::format function.

Change-Id: I155fc854428492462dfec3b3818d08daa16e36bf
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in Op

systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in OpenBMC had been taking advantage of in that
we were able to document our templated target dependencies without it
actually doing anything. The real installation of services within
targets occurs in our bitbake recipes due to the complexity of chassis
and host instances on a per machine basis.

Leave the dependency information in the service files but comment them
out. It's useful to be able to look at a service and understand which
targets it's going to be installed into by the bitbake recipes.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I58b4e0f280bcf0268a737aec2613f2d6ca8c8eba

show more ...