FFDC replace eval with importlib code

Changes:
- Remove eval functions
- Add importlib code to replace eval
- Update plugin documentation and YAML
- Tweak code to handle new changes

FFDC replace eval with importlib code

Changes:
- Remove eval functions
- Add importlib code to replace eval
- Update plugin documentation and YAML
- Tweak code to handle new changes

Tested:
- Ran with the changes from sandbox.
- Tested YAML with different plugin examples
- Tested bad path YAML
Change-Id: Iea0d4b879c1afc4fd25ab3a3c3ccb0e0875f86bc
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

FFDC lib and plugins code documentation

Changes:
- Update function code documentation
- Add missing shebang in the files

Tested: - Checked with pyflake, pycodesyle and tested
the

FFDC lib and plugins code documentation

Changes:
- Update function code documentation
- Add missing shebang in the files

Tested: - Checked with pyflake, pycodesyle and tested
the changes on local sandbox

Change-Id: Ice2231e3bd3dbe2f00f5cf758e11b23fe3ca475e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

FFDC SSH lib and plugins code documentation

Changes:
- Add code documentation for the functions

Tested:
- Checked with pyflake, pycodesyle and tested
the changes on local sandbox

Change

FFDC SSH lib and plugins code documentation

Changes:
- Add code documentation for the functions

Tested:
- Checked with pyflake, pycodesyle and tested
the changes on local sandbox

Change-Id: Ia82edfffe51caa7ca0cd8059f4565660376c0d51
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix unused variable in FFDC

Changes:
- remove undefined name 'target_list'

Tested:
- NA
Change-Id: I8bae1516af68eb2535e80867feb79c7174603c59
Signed-off-by: George Keishing <gkeishin@in.ibm.co

Fix unused variable in FFDC

Changes:
- remove undefined name 'target_list'

Tested:
- NA
Change-Id: I8bae1516af68eb2535e80867feb79c7174603c59
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

FFDC code fix using pyflake

Changes:
- Fixed the following error
ffdc/ffdc_collector.py:56:9:
local variable 'e' is assigned to but never used

ffdc/ffdc_collector.py:913:21: undef

FFDC code fix using pyflake

Changes:
- Fixed the following error
ffdc/ffdc_collector.py:56:9:
local variable 'e' is assigned to but never used

ffdc/ffdc_collector.py:913:21: undefined name 'self'
ffdc/ffdc_collector.py:918:21: undefined name 'self'
ffdc/ffdc_collector.py:1356:9:
local variable 'env_vars_list' is assigned to but never used

ffdc/lib/ssh_utility.py:67:9:
local variable 'e' is assigned to but never used

ffdc/plugins/redfish.py:8:1: 'os' imported but unused

Tested:
- pyflake ffdc/
- Tested the changes on sandbox
Change-Id: Ib4e774e1e7e16b49a36a5a00e35d6e60b4868715
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix code documentation length

Changes:
- E501 line too long > 79 characters

Tested:
- NA
Change-Id: I725470b4a85c18461ee51ae486c5aa32400ada7d
Signed-off-by: George Keishing <gkeishin@in.ibm

Fix code documentation length

Changes:
- E501 line too long > 79 characters

Tested:
- NA
Change-Id: I725470b4a85c18461ee51ae486c5aa32400ada7d
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

SSH port for plugin call to log collector

Fixes the following error:
ERROR: execute_python_eval: __init__()
missing 1 required positional argument: 'port_ssh'

Changes:
- Added port vari

SSH port for plugin call to log collector

Fixes the following error:
ERROR: execute_python_eval: __init__()
missing 1 required positional argument: 'port_ssh'

Changes:
- Added port variable argument

Tested:
- Ran chnages from sandbox.

Change-Id: I0e75b757022e3cbfdc06480fdc88af7024fa4dd8
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot

Managers ID : Introduced variable to declare Managers ID in resource.robot and updated all the scripts in openbmc-test-automation

Changes:
- Introduced ${MANAGER_ID} variable in resource.robot
- Replaced all the Managers/bmc to Managers/${MANAGER_ID} across all the scripts
- Also in data/variables.py updated chassis id for the few redfish uri.

Tested:
- Ran All The Scripts Successfully

Change-Id: Iff3673aae27657e0799dec5cb94c1651a0cd5d18
Signed-off-by: ganesanb <ganesanb@ami.com>
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

pycodestyle: Module level import not at top of file

Changes:
- Added NOQA on python files import to skip CI
- Fix import order reported by CI.

Tested:
- CI will catch this if there i

pycodestyle: Module level import not at top of file

Changes:
- Added NOQA on python files import to skip CI
- Fix import order reported by CI.

Tested:
- CI will catch this if there is error

Change-Id: I39a11d3e815a08488671ed948f073828e19aee37
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Revert "Fix for module level import not at top of file"

This reverts commit 47375aa789dcb11ba969895f61dfb12a773e2164.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Icc40562b861262

Revert "Fix for module level import not at top of file"

This reverts commit 47375aa789dcb11ba969895f61dfb12a773e2164.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Icc40562b861262d8fb72d68b43654334985eea4d

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix for module level import not at top of file

Change-Id: I1994b58a027cdac3bf4084b77db61bc646aaaba6
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

ffdc: Integrate ffdc script into robot framework flow.

This commit provides interface to enable automation tests (robot/jenkins)
to activate the new cli ffdc collector.

- Patchset 1: Initial commit

ffdc: Integrate ffdc script into robot framework flow.

This commit provides interface to enable automation tests (robot/jenkins)
to activate the new cli ffdc collector.

- Patchset 1: Initial commit for review.
- Patchset 2: Redesing and fixing issues
- Patchset 3: Fix build issue (pycodestyle)
- Patchset 4: Default ffdc store location running direct CLI
- Patchset 5: Addressing review comments and questions
- Patchset 6: Restore direct CLI default location to /tmp
- Patchset 7: Addressing issues from comments
Also extend socket timeout for long-running command peltool -a
- Patchset 8: Use Builtin().log_to_console("") method in the bridge code
- Patchset 9: Rebase

Tests:
- Standalone script: python3 ./ffdc/collect_ffdc.py
- Within robot env: python3 -m robot .... -v FFDC_DEFAULT:0 ./tools/myffdc.robot

Signed-off-by: Peter D Phan <peterp@us.ibm.com>
Change-Id: Ic892c48efe7dbdb3a4345ba89c3a0257f03a7ffb

show more ...

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
py

Update python code for python 3.8 or higher compatibility

Changes:
- Update shebang directive to use python3 explicitly.
- remove preexec_fn feature which is deprecated in higher
python version 3.8 and above.
- bufsize fix, from documentation bufsize 1 means line buffered
(only usable if universal_newlines=True i.e., in a text mode)
refer: https://docs.python.org/3/library/subprocess.html
- Fix SyntaxWarning: "is" with "=="

Change-Id: Ib96c1ba8c2327d6774d0d731b48ca7e61a4a297a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Plugin: Add date time util module

Change-Id: I6ab1d8bb8df63b8590ce7800e60415d90ea3bad3
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

ffdc: Trigger paramiko exec_command() timeout mechanism

Add data read/write operation to trigger paramiko exec_command() timeout mechanism.
Reading channel status does not activate the timeout mecha

ffdc: Trigger paramiko exec_command() timeout mechanism

Add data read/write operation to trigger paramiko exec_command() timeout mechanism.
Reading channel status does not activate the timeout mechanism.

Test:
- Regression test to openbmc, ubuntu, rhel with standard config and plugins

Change-Id: Ib65304dbbfc1f2df592296e5b5025c928cef86d4
Signed-off-by: Peter D Phan <peterp@us.ibm.com>

show more ...

Add support to walk through /redfish/v1 using plugin

Changes:
- Add check for plugin response if dictionary
- Add new redfish plugin module
- Add entry in the YAML

Tested:
- Wi

Add support to walk through /redfish/v1 using plugin

Changes:
- Add check for plugin response if dictionary
- Add new redfish plugin module
- Add entry in the YAML

Tested:
- With plugin
- Generic existing testing

Change-Id: I71291e337d0a064bbe024fbef193380ec3cfb8ad
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

ffdc: Add scp plugin.

- Set 1: Initial code
- Set 2: Expand comments
- Set 2: Allow filename to be either list-of-filenames or just filename

Test:
- Tested standalone plugin to SSH/SCP remote hosts

ffdc: Add scp plugin.

- Set 1: Initial code
- Set 2: Expand comments
- Set 2: Allow filename to be either list-of-filenames or just filename

Test:
- Tested standalone plugin to SSH/SCP remote hosts.

Signed-off-by: Peter D Phan <peterp@us.ibm.com>
Change-Id: If85d4b06b5da05f7403a3af28fa15a6d7f6c5925

show more ...

Add list data return from SSH response

Changes:
- Add new parameter in SSH to accept type
- Support ONLY string and list

Change-Id: I579ebb98a1bc633e682471e124030330a0a775ae
Signed-off-by

Add list data return from SSH response

Changes:
- Add new parameter in SSH to accept type
- Support ONLY string and list

Change-Id: I579ebb98a1bc633e682471e124030330a0a775ae
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add plugin shell execution script

Change-Id: Ie2444c332e54956c547e74fa71da5a9465c0f8c8
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

ffdc: Add examples for ffdc/plugins modules

Test:
- Standalon plugin example modules

Signed-off-by: Peter D Phan <peterp@us.ibm.com>
Change-Id: I2721ffd066fdfbf74e1b1ebc1dc46637a29ce225