Fix for Change in LED Controller service

Due to below upstream change, user unable to Set SM Signal for different
LED's. All the dbus calls also affected due to this change.
https://gerrit.openbmc.o

Fix for Change in LED Controller service

Due to below upstream change, user unable to Set SM Signal for different
LED's. All the dbus calls also affected due to this change.
https://gerrit.openbmc.org/c/openbmc/phosphor-led-sysfs/+/57455

Currently all LED Controllers are grouped into single service.
So this fix provides to support for all the LED controllers based on
new service i.e. xyz.openbmc_project.LED.Controller

Tested:
Ipmitool commands are verified working as expected.
Command: ipmitool raw 0x30 0xb4 0x03 0x02 //Set Security mode
Response: //Success
Command: ipmitool raw 0x30 0x15 0x0D 00 00 00 //Set SM Signal
Response: //Success

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I4ee6f0d3f6148aae69e04fde028ab8ec46187ad8

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Id2036ab746164981596b3ee36259f3ca5d3f1334
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

storagecommands: Split validation logic

The Fru validation logic is useful in isolation, split it into a
separate library that can be included.

Tested:
[0/1] Running all tests.
1/12 phosphor-objmg

storagecommands: Split validation logic

The Fru validation logic is useful in isolation, split it into a
separate library that can be included.

Tested:
[0/1] Running all tests.
1/12 phosphor-objmgr / well_known OK 0.24s
2/12 phosphor-objmgr / need_to_introspect OK 0.22s
3/12 phosphor-objmgr / name_change OK 0.16s
4/12 phosphor-objmgr / interfaces_added OK 0.13s
5/12 phosphor-objmgr / handler OK 0.09s
6/12 phosphor-objmgr / mapper OK 0.07s
7/12 phosphor-host-ipmid / entitymap_json OK 0.06s
8/12 phosphor-host-ipmid / message OK 0.05s
9/12 phosphor-host-ipmid / session/closesession OK 0.03s
10/12 phosphor-objmgr / associations OK 0.20s
11/12 phosphor-host-ipmid / dbus-sdr/sensorcommands OK 0.02s
12/12 intel-ipmi-oem / message OK 0.02s

Ok: 12
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0

Change-Id: I9130eb81703b0cda7c3229f16cd689dd2c96c55c
Signed-off-by: Peter Foley <pefoley@google.com>

show more ...

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-

sdbusplus: avoid deprecated phosphor::Timer

sdbusplus had an older type named `phosphor::Timer` which was
recently renamed to `sdbusplus::Timer`. Update the code to use
the new type alias.

Change-Id: I694f0624eae2cdbb071ab97fe019cd5684615541
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

intel-ipmi-oem: Fixing bios.xml parsing

The main fix is the change translate 'sif','gif','dif' from 'IF' to 'IF
NOT'. Now all bios knobs with depex equal "TRUE" will be visible over
RF.

Tested: man

intel-ipmi-oem: Fixing bios.xml parsing

The main fix is the change translate 'sif','gif','dif' from 'IF' to 'IF
NOT'. Now all bios knobs with depex equal "TRUE" will be visible over
RF.

Tested: manually checked on platform, all knobs with depex set as "TRUE"
are visible over RF. PSYS bios knobs are visible and it is possible to
set them over redfish.

Change-Id: I684fb29f9feb50df7a48aa77a79fad11943dd055
Signed-off-by: Jatkiewicz, Joanna <joanna.jatkiewicz@intel.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I1367c2eabf95f27b5acb08b9e6fd6eedcb77377f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

changes to make it build without cheating

intel-ipmi-oem was using header files from phosphor-host-ipmid that were
not actually in the distributed list of headers. Since intel-ipmi-oem is
on its way

changes to make it build without cheating

intel-ipmi-oem was using header files from phosphor-host-ipmid that were
not actually in the distributed list of headers. Since intel-ipmi-oem is
on its way to removing the files that use those headers anyway, this is
a stop-gap measure to be able to compile in the meantime.

Tested: sensors work as before

Change-Id: Ie443d2b53d12936f0ec7747cc9a01ed75ac63ab5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Maue

changes needed for meson build

Fix warnings that the meson build turns into errors.

Tested: builds without warnings.

Change-Id: I66b02c4c616f37d09ceba61c494903acc3d28bd5
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Add OEM get BMC Version String command

Change-Id: If8704427844eee4f54173425a2b74787f939a9cf
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

Build fixes for gcc-12

These changes are required for the build to work with GCC-12

Tested: built with local CI scripts

Change-Id: I15cdd0c0d38f92e35ab151bd22271d8a2bd78312
Signed-off-by: Vernon M

Build fixes for gcc-12

These changes are required for the build to work with GCC-12

Tested: built with local CI scripts

Change-Id: I15cdd0c0d38f92e35ab151bd22271d8a2bd78312
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Added support for ipmi tool based mux slot disable

Currently ipmitool doesn't support mctp mux-slot
disabling capablity.

this patch will support to disable/enable mctp
mux slot funtionality using i

Added support for ipmi tool based mux slot disable

Currently ipmitool doesn't support mctp mux-slot
disabling capablity.

this patch will support to disable/enable mctp
mux slot funtionality using ipmi tool.

Change-Id: I0bdbd86d2fb4f806d61f665a8014c0c097ee4258
Signed-off-by: Vasu V <vasu.v@intel.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I59c0a8c4b89131ecd3e9a841ed37ef3b8dcf8e9d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Use knob->prompt for DisplayName in BiosAttributeRegistry

GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/
shows list of Attributes under RegistryEntries. Each attribute
co

Use knob->prompt for DisplayName in BiosAttributeRegistry

GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/
shows list of Attributes under RegistryEntries. Each attribute
corresponds to a knob in BIOS.

DisplayName is currently filled with knob->name but knob->prompt is more
accurate for DisplayName as that is the name we see in EDKII menu.

Code changes makes the above mentioned fix.

Tested
Sample knobs from BIOS.
<knob name="ADDDCEn" prompt="ADDDC Sparing" ... >
<options>
<option text="Disable" value="0x0"/>
<option text="Enable" value="0x1"/>
</options>
</knob>

Corresponding Redfish response in BiosAttributeRegistry
{
"AttributeName": "ADDDCEn",
"CurrentValue": "0x00",
"DefaultValue": "0x00",
"DisplayName": "ADDDC Sparing",
"HelpText": "Enable/Disable ADDDC Sparing",
"MenuPath": "./",
"ReadOnly": false,
"Type": "Enumeration",
"Value": [
{
"ValueDisplayName": "Disable",
"ValueName": "0x0"
},
{
"ValueDisplayName": "Enable",
"ValueName": "0x1"
}
]
}

Change-Id: I6ee251e32169cecb4d86436373397054863552b5
Signed-off-by: Arun Lal K M <arun.lal@intel.com>

show more ...

Show option->text of BIOS knob in Redfish response.

GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/
shows list of Attributes under RegistryEntries. Each attribute
correspo

Show option->text of BIOS knob in Redfish response.

GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/
shows list of Attributes under RegistryEntries. Each attribute
corresponds to a knob in BIOS.

If knob in BIOS is of type Enumeration, it will have 'option' with
'text' and 'value'. This text should be mapped to
attribute->Value->ValueDisplayName.

Code changes are made for the same.

Tested
Sample knobs from BIOS.

<knob name="AdaptiveRefreshMgmtLevel" ... >
<options>
<option text="Default" value="0x0"/>
<option text="Level A" value="0x1"/>
<option text="Level B" value="0x2"/>
<option text="Level C" value="0x3"/>
</options>
</knob>
<knob name="ADDDCEn" ... >
<options>
<option text="Disable" value="0x0"/>
<option text="Enable" value="0x1"/>
</options>
</knob>

Corresponding Redfish response in BiosAttributeRegistry

{
"AttributeName": "AdaptiveRefreshMgmtLevel",
"CurrentValue": "0x00",
"DefaultValue": "0x00",
"DisplayName": "AdaptiveRefreshMgmtLevel",
"HelpText": "ARFM Level when ... ",
"MenuPath": "./",
"ReadOnly": false,
"Type": "Enumeration",
"Value": [
{
"ValueDisplayName": "Default",
"ValueName": "0x0"
},
{
"ValueDisplayName": "Level A",
"ValueName": "0x1"
},
{
"ValueDisplayName": "Level B",
"ValueName": "0x2"
},
{
"ValueDisplayName": "Level C",
"ValueName": "0x3"
}
]
},
{
"AttributeName": "ADDDCEn",
"CurrentValue": "0x00",
"DefaultValue": "0x00",
"DisplayName": "ADDDCEn",
"HelpText": "Enable/Disable ADDDC Sparing",
"MenuPath": "./",
"ReadOnly": false,
"Type": "Enumeration",
"Value": [
{
"ValueDisplayName": "Disable",
"ValueName": "0x0"
},
{
"ValueDisplayName": "Enable",
"ValueName": "0x1"
}
]
}

Change-Id: I26795681c45247ea954edf48b1a9da80ace31ae5
Signed-off-by: Arun Lal K M <arun.lal@intel.com>

show more ...

Remove MDRv1 SMBIOS commands

MDRv1 SMBIOS commands are no longer supported. This removes the IPMI
handlers.

Tested: builds and runs as expected; MDRv1 commands are not present

Change-Id: Ie5370172

Remove MDRv1 SMBIOS commands

MDRv1 SMBIOS commands are no longer supported. This removes the IPMI
handlers.

Tested: builds and runs as expected; MDRv1 commands are not present

Change-Id: Ie537017254cfeba58d60f79b5005c4d729665d3c
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Change terminology to inclusive terms

Tested: No functionality changes, code still compiles.

Change-Id: I61dd3c6f3ecfb96088a68b1254a22c5fa5376b3d
Signed-off-by: Matt Simmering <matthew.simmering@in

Change terminology to inclusive terms

Tested: No functionality changes, code still compiles.

Change-Id: I61dd3c6f3ecfb96088a68b1254a22c5fa5376b3d
Signed-off-by: Matt Simmering <matthew.simmering@intel.com>

show more ...

Fix Get and Set SM Signal Fan PWM Command

The Get SM Signal and Set SM Signal IPMI commands function under the
assumption that there is a 1:1 relationship between the fan Pulse Width
Modulator (PWM)

Fix Get and Set SM Signal Fan PWM Command

The Get SM Signal and Set SM Signal IPMI commands function under the
assumption that there is a 1:1 relationship between the fan Pulse Width
Modulator (PWM), and the fan tachometer. Not all hardware follows this
model. The code changes in this commit updates these IPMI commands to handle
the introduction of HW that uses one PWM output to control two fans.

For systems that have a 1:1 PWM/Tachometer relationship, this code improves
upon the original "signal instance" lookup. The "signal instance" now
specifies a "fan number". Systems may not have a linear relationship between
"fan header numbers" and the PWM that controls the fan on that header. Prior
to this commit the "signal instance" had to be the PWM number. Now the Get/Set
commands associate a linear fan number to the respective PWM.

Systems that use one PWM to control multiple fans, and by extension multiple
tachometers use a secondary lookup to determine the fan to modify/read. The
JSON file describing the fan PWM/tachometer is updated to add a "PWMName"
record. The instance number is combined with the PWMName entry to identify
the correct HW to read/modify. The PWMName entry in the JSON file nomenclature
defines two fans (i.e. "PWMName:" "Pwm_3_4"), which are associated to a PWM,
(i.e. "Pwm": 1).

Tested:
On system with default PWM name:
IPMI command:
ipmitool raw 0x30 0x14 0x0d 6 0x00 # read fan 7 pwm
32
ipmitool raw 0x30 0x15 0x05 6 0x1 0x48 # set fan 7 pwm (72%)
ipmitool raw 0x30 0x14 0x0d 6 0x00 # read fan 7 pwm
48
root@intel-obmc:~# busctl get-property
xyz.openbmc_project.EntityManager
/xyz/openbmc_project/inventory/system/chassis/Fan_7
xyz.openbmc_project.Configuration.AspeedFan.Connector Pwm
t 12
(In this system, Fan 7 is connected to PWM 12)

Dbus tree showing default name:
busctl tree xyz.openbmc_project.FanSensor
`-/xyz/openbmc_project/sensors
|-/xyz/openbmc_project/sensors/fan_pwm
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_1
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_13
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_14
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_15
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_16
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_2
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_3
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_4
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_5
| `-/xyz/openbmc_project/sensors/fan_pwm/Pwm_6

On system with non-default PWM name:
IPMI command:
ipmitool raw 0x30 0x14 0x0d 1 0x00 # read fan 2 pwm
64
ipmitool raw 0x30 0x15 0x05 0 0x1 0x48 # set fan 2 pwm
ipmitool raw 0x30 0x14 0x0d 0 0x00 # read fan 1 pwm
48 # shared with fan 2

Dbus tree showing non-default PWM name:
busctl tree xyz.openbmc_project.FanSensor
`-/xyz/openbmc_project/sensors
|-/xyz/openbmc_project/sensors/fan_pwm
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_11_12
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_1_2
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_3_4
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_5_6
| |-/xyz/openbmc_project/sensors/fan_pwm/Pwm_7_8
| `-/xyz/openbmc_project/sensors/fan_pwm/Pwm_9_10

Change-Id: I9a40256ed892170f8ba88a3a617b5a2e11693c9f
Signed-off-by: Alex Schendel <alex.schendel@intel.com>

show more ...

Condense std::variants

Where possible, reduce to a single std::variant type to reduce binary
size.

Change-Id: I73b59765109ce1ccd7339f0e214d1ec3929e1ffc
Signed-off-by: Jason M. Bills <jason.m.bills@

Condense std::variants

Where possible, reduce to a single std::variant type to reduce binary
size.

Change-Id: I73b59765109ce1ccd7339f0e214d1ec3929e1ffc
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Add flat_map to includes

A recent change made it so that flat_map is not transitively included by
object_server.hpp in sdbusplus. Explicitly add the required enum.

Tested: Code builds.

Signed-off

Add flat_map to includes

A recent change made it so that flat_map is not transitively included by
object_server.hpp in sdbusplus. Explicitly add the required enum.

Tested: Code builds.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I50ee58bf194400358b8af29b653f22d4aabd8daa

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie7375047bd567aa052d3bd35a6dd7008779a05b4

show more ...

move PowerRestoreDelay to RestorePolicy interface

The `xyz.openbmc_project.Control.Power.RestoreDelay` is undocumented
which prevents to use phosphor-settings to handle this parameter.

This propert

move PowerRestoreDelay to RestorePolicy interface

The `xyz.openbmc_project.Control.Power.RestoreDelay` is undocumented
which prevents to use phosphor-settings to handle this parameter.

This property looks good fit to
`xyz.openbmc_project.Control.Power.RestorePolicy` interface, so it was
included there.

Type of the value was changed from uint16 to uint64 and units changes
from seconds to microseconds.
See https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/50231
for details.

Tested: Jason M. Bills confirmed that the commands to get and set the
power restore delay correctly convert to and from unit64_t.

Signed-off-by: Andrei Kartashev <a.kartashev@yadro.com>
Change-Id: I58dd601e561b53660ddb50e2b2c2b77ee2083030

show more ...

Add OEM Command to Read Mailbox PFR Registers

This OEM command allows user to read PFR mailbox
registers by specifying register address, no of
bytes to read and register identifier
(single byte or F

Add OEM Command to Read Mailbox PFR Registers

This OEM command allows user to read PFR mailbox
registers by specifying register address, no of
bytes to read and register identifier
(single byte or FIFO register)
Below command supports reading of single byte and
FIFO registers

ipmitool raw 0x3e 0x84 [Register Address] [No of Bytes to Read] [Register Identifier]
Note: Register Identifier:0 for single byte read register
Register Identifier:1 for FIFO read register

Tested:
1.Single Byte Register Testing:
a.ipmitool raw 0x3e 0x84 0x08 13 0:
Successfully returned 13 bytes starting from the single byte read register address 0x08.
2.FIFO Read Register Testing:
a.ipmitool raw 0x3e 0x84 0x08 13 1:
Successfully returned 13 bytes from the FIFO address 0x08.
3.When Register Identifier is not 0 or 1 command will fail.
4.When either of register address or no of bytes is zero the command will fail.

Signed-off-by: Ankita Vilas Gawade <ankita.gawade@intel.com>
Change-Id: Ie64af93b1c9d79d407b331ef9d0d64a408614780

show more ...

Add support for Enumeration in BIOSConfig

Bios knobs have options (possible set of values for the knob) as Enumaration,
Hence BMC must treat it as type enumuration and not as string.

Bios knobs hav

Add support for Enumeration in BIOSConfig

Bios knobs have options (possible set of values for the knob) as Enumaration,
Hence BMC must treat it as type enumuration and not as string.

Bios knobs have options (possible set of values for the knob) as
Enumaration,Hence BMC must treat it as type enumuration and not as
string.

This change is also to support the following change in bios-settings-mgr
https://gerrit.openbmc-project.xyz/c/openbmc/bios-settings-mgr/+/49126

Tested:
By giving following commands and making sure functionalities
are not affected.

1) GET to
/Registries/BiosAttributeRegistry/BiosAttributeRegistry/

2) GET to
Systems/system/Bios/Settings

3) PATCH to
Systems/system/Bios/Settings

Redfish validator result:
1) For /redfish/v1/Registries/
Counter({'metadataNamespaces': 2295, 'pass': 2053, 'skipOptional': 1267,
'warnDeprecated': 232, 'passGet': 11, 'warningPresent': 6,
'serviceNamespaces': 5})
Validation has succeeded.

2) For /redfish/v1/Systems/system/Bios/
Counter({'pass': 7405, 'metadataNamespaces': 2295, 'skipOptional': 14,
'serviceNamespaces': 4, 'passGet': 2, 'passAction': 2, 'reflink': 1,
'warningPresent': 1})
Validation has succeeded.

Signed-off-by: Arun Lal K M <arun.lal@intel.com>
Change-Id: Ib86b0dbd3536a33fa85c8bb9897901b8220c4539

show more ...

Fix issue with hex string to integer conversion

Not able to PATCH few attributes in BiosAttributeRegistry,
evaluation of depex expression is getting failed, so attributes
which are not patchable are

Fix issue with hex string to integer conversion

Not able to PATCH few attributes in BiosAttributeRegistry,
evaluation of depex expression is getting failed, so attributes
which are not patchable are also added to Base Table.

Changes made to pass evaluation of depex expression.

Tested:
1. Enable "BMC remote setup" in EDKII Menu from Bios and set
User Admin Password.
2. Perform Reset Bios or DC Cycle or AC cycle.
3. Wait for 120 seconds after complete bios boot up and check
for bios.xml file in /var/oob folder.
4. Get - /redfish/v1/Registries/BiosAttributeRegistry
/BiosAttributeRegistry
Response: All patchable attributes are displayed.
5. Select random attribute and
Patch - /redfish/v1/Systems/system/Bios/Settings
Body:
{
"data": {
"Ioe0PcieRootPortEn_5": "0x0"
}}
6. Repeat steps 2, 3 and 4
Response:
{
"@odata.id": "/redfish/v1/Registries/BiosAttributeRegistry
/BiosAttributeRegistry",
"@odata.type": "#AttributeRegistry.v1_3_2.AttributeRegistry",
"Id": "BiosAttributeRegistry",
"Language": "en",
"Name": "Bios Attribute Registry",
"OwningEntity": "OpenBMC",
"RegistryEntries": {
"Attributes": [
{
"AttributeName": "Ioe0PcieRootPortEn_5",
"CurrentValue": "0x00",
"DefaultValue": "0x01",
"DisplayName": "Ioe0PcieRootPortEn_5",
"HelpText": "Control the PCI Express Root Port.",
"MenuPath": "./",
"ReadOnly": false,
"Type": "String",
"Value": [
{
"OneOf": "0x0"
},
{
"OneOf": "0x1"
}
]
},.....
]
}
}

Signed-off-by: Snehalatha Venkatesh <snehalathax.v@intel.com>
Change-Id: I48e850758c0b9873c5f6645151e613dd0d0a7b39

show more ...

SEL log Generator ID should Conform to IPMI Spec

In IMPI specification, the generator ID for SEL log is 2 bytes long.
Apart from the Generator ID, it contains LUN and channel information.
The fix is

SEL log Generator ID should Conform to IPMI Spec

In IMPI specification, the generator ID for SEL log is 2 bytes long.
Apart from the Generator ID, it contains LUN and channel information.
The fix is to change 1-Byte Generator ID to 2-byte generator ID and
include all missing information into it.

Tested
Following tests were executed:
1) Run ipmitool raw -l 1 0x4 0x2 0x4 0x8 0x1 0x6 0x1 0x5
This ensures that non-zero LUN information is included
in the SEL record.

2) Instrument the code to look like ME has created an event
and make sure that logs are saved properly.

For 1) and 2) logs are read from the WebUI to make sure that
they are being saved as expected.

Signed-off-by: Sujoy Ray <sujoy.ray@intel.com>
Change-Id: I78d4423cc24c941af7bf0cd70423a95747ba4a76

show more ...