fru-device: use lg2::error instead of cerr

An old commit was rebased and applied without testing. It does not
compile due to other refactoring that migrated from cerr to lg2.
Adjust the correspondi

fru-device: use lg2::error instead of cerr

An old commit was rebased and applied without testing. It does not
compile due to other refactoring that migrated from cerr to lg2.
Adjust the corresponding log statement in fru-device.

Fixes: 1cd0b0440109 ("fru-device: use ioctl to write fru for 16-bit address")
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I465624f40f553f184b53294d5c355aff28d238e9

show more ...

fru-device: use ioctl to write fru for 16-bit address

smbus commands only support eeproms with 8-bit address [1]. this patch
checks device address type and uses ioctl if uses 16-bit addressing.

tes

fru-device: use ioctl to write fru for 16-bit address

smbus commands only support eeproms with 8-bit address [1]. this patch
checks device address type and uses ioctl if uses 16-bit addressing.

tested on 24AA64 eeprom.

[1] https://docs.kernel.org/i2c/smbus-protocol.html -> command byte is
only 8 bits.

Change-Id: Iff999acab7c8d04757826a389af3e5f19759bd0b
Signed-off-by: Robin Cheng <rocheng@nvidia.com>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I0bad72781974fbf4d87f1dc6a6bb68ed7568da24
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

meson: create static library utils_lib

utils.cpp was compiled 3 times in tests and binaries. Create a static
library so it is only compiled once.

Tested: Code compiles.

Change-Id: Ief6f7153c4494b7

meson: create static library utils_lib

utils.cpp was compiled 3 times in tests and binaries. Create a static
library so it is only compiled once.

Tested: Code compiles.

Change-Id: Ief6f7153c4494b77fa7a1b9a53e1971bdd4652f2
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

fru_device: fix I2C functionality checking error

The I2C functionality 'I2C_FUNC_SMBUS_READ_I2C_BLOCK' checking missed
the logical AND '&' operation value.

Change-Id: I0ce0842c9a5949d354446786e41ae

fru_device: fix I2C functionality checking error

The I2C functionality 'I2C_FUNC_SMBUS_READ_I2C_BLOCK' checking missed
the logical AND '&' operation value.

Change-Id: I0ce0842c9a5949d354446786e41ae84ba4ef0ea7
Signed-off-by: Haiyue Wang <haiyuewa@163.com>

show more ...

Flat map all the things

In an earlier commit, entity-manager gained required dependency
on std::flat_map. This means that EM can only compile with gcc-15,
which the project only recently moved to.

Flat map all the things

In an earlier commit, entity-manager gained required dependency
on std::flat_map. This means that EM can only compile with gcc-15,
which the project only recently moved to. Rather than move backwards,
port forward all uses of boost flat_map and flat_set to their std
equivalents.

Tested: entity-manager launches and enumerates devices on
gb200-obmc.

Change-Id: Id24803057711c60d5b00f436db80b27edbb756a3
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

fru_device: Add the ability to skip addresses for all buses

In certain situations, we won't know the buses ahead of time,
like when probing muxes dynamically using EntityManager. We do
however know

fru_device: Add the ability to skip addresses for all buses

In certain situations, we won't know the buses ahead of time,
like when probing muxes dynamically using EntityManager. We do
however know the general range of where our eeproms are. Ideally
we would have the ability to set a range of addresses, but this
is a lower lift change, to allow addresses to blocklisted across
all buses.

Tested:
Ran on an nvl32-obmc model with i2c tracing enabled.
Added a blocked list entry and checked logging as well
as that no i2c transactions were issued by fru-device
to the blocked addresses. Existing FRU's worked as
expected.

Change-Id: I9fbebc426a8a5244aa9ea07e41d6a38458088cbb
Signed-off-by: Marc Olberding <molberding@nvidia.com>

show more ...

Allow decoding MAC addresses in some FRUs

Some motherboards store their mac address in a zlib compressed chunk at
a known location in the FRU. Decode that section, and pull the mac
address into the

Allow decoding MAC addresses in some FRUs

Some motherboards store their mac address in a zlib compressed chunk at
a known location in the FRU. Decode that section, and pull the mac
address into the appropriate field.

This requires some refactoring so that the indexing can now have the
indexes passed through the various parse functions.

To use this functionality requires the use of libxml and zlib, which are
added as new dependencies.

Change-Id: Icb5c2e46e2a08ca83b3559892169ee2b3f319b2e
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

fru-device: move Adding and updating a property into a helper

Adds updating and adding properties to a helper function
that's divorced from dbus logic. This allows other code
to modify a fru buffer.

fru-device: move Adding and updating a property into a helper

Adds updating and adding properties to a helper function
that's divorced from dbus logic. This allows other code
to modify a fru buffer.

Tested:
Called updateproperty on nvl32-obmc. Result was correct

Change-Id: I432f89003cf5608900c018f72edef877534bfe40
Signed-off-by: Marc Olberding <molberding@nvidia.com>

show more ...

use phosphor-logging

Migrate all instances of std::cerr and std::cout to phosphor-logging
such as lg2::error, lg2::info, lg2::debug, ...

The use of modern logging infrastructure helps with developm

use phosphor-logging

Migrate all instances of std::cerr and std::cout to phosphor-logging
such as lg2::error, lg2::info, lg2::debug, ...

The use of modern logging infrastructure helps with development since
additional logging levels such as `debug` and `warning` are available.

Migrating the remaining logging calls helps to make the code more
readable and uniform.

Tested: Inspection, and on Tyan S8030

Restarted EM with patch applied.
Logs appear as usual.

```
Sep 15 13:52:46 s8030-bmc-30303035c0c1 entity-manager[23480]: Inventory Added: Supermicro PWS 920P SQ 0
Sep 15 13:52:46 s8030-bmc-30303035c0c1 entity-manager[23480]: Inventory Added: Supermicro PWS 920P SQ 1
Sep 15 13:52:46 s8030-bmc-30303035c0c1 entity-manager[23480]: Inventory Added: Tyan S8030 Baseboard
Sep 15 13:52:46 s8030-bmc-30303035c0c1 entity-manager[23480]: Inventory Added: MBX 1.57 Chassis
```

`busctl tree` output appears as before.

Did a power cycle to trigger a few more log prints

```
Sep 15 13:55:14 s8030-bmc-30303035c0c1 entity-manager[23480]: power match triggered
```

Created configuration file with missing fields to trigger error print.
```
{
"Exposes": [],
"Type": "error"
}
```

```
Sep 15 13:56:58 s8030-bmc-30303035c0c1 entity-manager[23659]: Finished loading json configuration in 7938ms
Sep 15 13:56:58 s8030-bmc-30303035c0c1 entity-manager[23659]: configuration file missing probe:
{"Exposes":[],"Type":"error"}
Sep 15 13:56:59 s8030-bmc-30303035c0c1 entity-manager[23659]: configuration file missing probe:
{"Exposes":[],"Type":"error"}
```

Change-Id: I3452f983c9c14cd02ab9b56451c4b3e4a13c3979
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

fru-device: fixup fru edit commit

Adds a number of fixups to review comments and simplifications
to the flow of the previous fru-edit commit.

Tested: Edited FRU property on nvl32-obmc
```
root@nvl3

fru-device: fixup fru edit commit

Adds a number of fixups to review comments and simplifications
to the flow of the previous fru-edit commit.

Tested: Edited FRU property on nvl32-obmc
```
root@nvl32-obmc:/sys/bus/i2c/devices/4-0051# busctl introspect xyz.openbmc_project.FruDevice /xyz/openbmc_project/FruDevice/MSX4_MG1_000
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.FruDevice interface - - -
.UpdateFruField method ss b -
.ADDRESS property u 81 emits-change
.BOARD_INFO_AM1 property s "NULL" emits-change writable
.BOARD_LANGUAGE_CODE property s "0" emits-change
.BOARD_MANUFACTURER property s "Giga Computing" emits-change writable
.BOARD_MANUFACTURE_DATE property s "20250101T000800Z" emits-change
.BOARD_PART_NUMBER property s "123456789AB" emits-change writable
.BOARD_PRODUCT_NAME property s "MSX4-MG1-000" emits-change writable
.BOARD_SERIAL_NUMBER property s "S2510200007" emits-change writable
.BUS property u 4 emits-change
.CHASSIS_PART_NUMBER property s "01234567" emits-change writable
.CHASSIS_SERIAL_NUMBER property s "01234567890123456789AB" emits-change writable
.CHASSIS_TYPE property s "23" emits-change
.Common_Format_Version property s "1" emits-change
.PRODUCT_ASSET_TAG property s "01234567890" emits-change writable
.PRODUCT_LANGUAGE_CODE property s "0" emits-change
.PRODUCT_MANUFACTURER property s "Giga Computing" emits-change writable
.PRODUCT_PART_NUMBER property s "000000000001" emits-change writable
.PRODUCT_PRODUCT_NAME property s "XL44-SX2-AAS1-000" emits-change writable
.PRODUCT_SERIAL_NUMBER property s "01234567890123" emits-change writable
.PRODUCT_VERSION property s "0100" emits-change writable
root@nvl32-obmc:/sys/bus/i2c/devices/4-0051# busctl call xyz.openbmc_project.FruDevice /xyz/openbmc_project/FruDevice/MSX4_MG1_000 xyz.openbmc_project.FruDevice UpdateFruField ss "PRODUCT_ASSET_TAG" "12345678901234"
b true
root@nvl32-obmc:/sys/bus/i2c/devices/4-0051# busctl introspect xyz.openbmc_project.FruDevice /xyz/openbmc_project/FruDevice/MSX4_MG1_000
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.FruDevice interface - - -
.UpdateFruField method ss b -
.ADDRESS property u 81 emits-change
.BOARD_INFO_AM1 property s "NULL" emits-change writable
.BOARD_LANGUAGE_CODE property s "0" emits-change
.BOARD_MANUFACTURER property s "Giga Computing" emits-change writable
.BOARD_MANUFACTURE_DATE property s "20250101T000800Z" emits-change
.BOARD_PART_NUMBER property s "123456789AB" emits-change writable
.BOARD_PRODUCT_NAME property s "MSX4-MG1-000" emits-change writable
.BOARD_SERIAL_NUMBER property s "S2510200007" emits-change writable
.BUS property u 4 emits-change
.CHASSIS_PART_NUMBER property s "01234567" emits-change writable
.CHASSIS_SERIAL_NUMBER property s "01234567890123456789AB" emits-change writable
.CHASSIS_TYPE property s "23" emits-change
.Common_Format_Version property s "1" emits-change
.PRODUCT_ASSET_TAG property s "12345678901234" emits-change writable
.PRODUCT_LANGUAGE_CODE property s "0" emits-change
.PRODUCT_MANUFACTURER property s "Giga Computing" emits-change writable
.PRODUCT_PART_NUMBER property s "000000000001" emits-change writable
.PRODUCT_PRODUCT_NAME property s "XL44-SX2-AAS1-000" emits-change writable
.PRODUCT_SERIAL_NUMBER property s "01234567890123" emits-change writable
.PRODUCT_VERSION property s "0100" emits-change writable
```

Change-Id: Ic4cd7111cd4f3694faed79793e1abc98f254617b
Signed-off-by: Marc Olberding <molberding@nvidia.com>

show more ...

fru-device: Add support to dynamically add FRU fields

This patch adds the ability to dynamically add or update FRU fields
at runtime, enhancing system flexibility in managing FRU data.

Previously,

fru-device: Add support to dynamically add FRU fields

This patch adds the ability to dynamically add or update FRU fields
at runtime, enhancing system flexibility in managing FRU data.

Previously, field modification was limited to the preassigned space
available in the FRU area. Any attempt to exceed this boundary would
fail:
Example:
```busctl set-property xyz.openbmc_project.FruDevice /xyz/openbmc_project/FruDevice/MDA_WCU_AI xyz.openbmc_project.FruDevice CHASSIS_SERIAL_NUMBER s "1234567890123"
busctl set-property xyz.openbmc_project.FruDevice /xyz/openbmc_project/FruDevice/MDA_WCU_AI xyz.openbmc_project.FruDevice CHASSIS_SERIAL_NUMBER s "12345678901234"
Failed to set property CHASSIS_SERIAL_NUMBER on interface xyz.openbmc_project.FruDevice: Invalid argument
hexdump -C /sys/bus/i2c/drivers/at24/8-0051/eeprom
```
With this patch, the FRU area can extend dynamically. All FRU areas are
repacked, and the FRU common header is updated without errors:
Example:
```
busctl set-property xyz.openbmc_project.FruDevice /xyz/openbmc_project/FruDevice/MDA_WCU_AI xyz.openbmc_project.FruDevice CHASSIS_SERIAL_NUMBER s "1234567890123"
busctl set-property xyz.openbmc_project.FruDevice /xyz/openbmc_project/FruDevice/MDA_WCU_AI xyz.openbmc_project.FruDevice CHASSIS_SERIAL_NUMBER s "12345678901234567890123456789"
```
Also check eeprom so that FRU areas get aligned properly.

Key changes:
- Introduced support through the `UpdateFruField` API.
- Utilizes `disassembleFruData` to parse existing FRU data into editable
fields.
- Applies field changes using `setField`, which handles updates or
additions.
- Reconstructs updated FRU binary data with `assembleFruData` before
committing it back.

TESTED=Build for Tiagopass & test on QEMU using below commands:
busctl call xyz.openbmc_project.FruDevice \
/xyz/openbmc_project/FruDevice/BMC_Storage_Module \
xyz.openbmc_project.FruDevice UpdateFruField ss \
"CHASSIS_INFO_AM10" "1234567890"

Readback:
busctl introspect xyz.openbmc_project.FruDevice \
/xyz/openbmc_project/FruDevice/BMC_Storage_Module

Change-Id: I5df2776211cb5cfd23570e479568da4717df3097
Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>

show more ...

fru_device: Remove unused systemBus parameter

The systemBus connection object was passed into several functions
but was never used within them. This change removes the unused
parameter to simplify t

fru_device: Remove unused systemBus parameter

The systemBus connection object was passed into several functions
but was never used within them. This change removes the unused
parameter to simplify the function signatures and improve clarity.

Modified Functions:
- updateFRUProperty
- addFruObjectToDbus
- rescanOneBus
- rescanBusses
- main

Change-Id: Ide90e794afd2a812e08f8d83a663caed53c1ab2b
Signed-off-by: Sora Su <baxiche@gmail.com>

show more ...

clang-tidy-21: fix cppcoreguidelines-pro-bounds-pointer-arithmetic

Fix various pro-bounds-pointer-arithmetic warnings that started being
reported with clang-tidy-21.

```
error: do not use pointer a

clang-tidy-21: fix cppcoreguidelines-pro-bounds-pointer-arithmetic

Fix various pro-bounds-pointer-arithmetic warnings that started being
reported with clang-tidy-21.

```
error: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic,-warnings-as-errors]
```

Forked this change from [1]

References:
[1] https://gerrit.openbmc.org/c/openbmc/entity-manager/+/84049

Tested: Inspection only.

Change-Id: I535802825e68d7f5fe01ed2428d127f7a18ab4f8
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Support Gigabyte FRU located at non-zero offsets

Some Gigabyte EEPROMs store FRU data at an offset rather than at the
beginning of the device. To handle this, support for detecting a
"GIGABYTE" mark

Support Gigabyte FRU located at non-zero offsets

Some Gigabyte EEPROMs store FRU data at an offset rather than at the
beginning of the device. To handle this, support for detecting a
"GIGABYTE" marker has been added.

Change-Id: I7399b22ad3bb596b357084c79f25a8d33617ec50
Signed-off-by: Mark Kuo <makuo@nvidia.com>
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

fru-device: Add option to allow updating all FRU fields

This patch introduces a new meson option `fru-update-property` to enable
updating FRU properties via D-Bus. This is particularly useful during

fru-device: Add option to allow updating all FRU fields

This patch introduces a new meson option `fru-update-property` to enable
updating FRU properties via D-Bus. This is particularly useful during
lab testing to modify FRU fields as needed.

TESTED=Build for tiagopass with fru-update-property set to true.
Verify the following:
1. Run command:
`busctl introspect xyz.openbmc_project.FruDevice
/xyz/openbmc_project/FruDevice/BMC_Storage_Module`

2. Verify the FRU fields are `writable`
Example:
...
.PRODUCT_ASSET_TAG property s "XXXXXXX"
emits-change writable
.PRODUCT_FRU_VERSION_ID property s "1.0"
emits-change writable
.PRODUCT_INFO_AM1 property s "XXXXXXXXX"
emits-change writable
.PRODUCT_INFO_AM2 property s "Config A"
emits-change writable
...

3. Update FRU field:
busctl set-property xyz.openbmc_project.FruDevice
/xyz/openbmc_project/FruDevice/BMC_Storage_Module
xyz.openbmc_project.FruDevice PRODUCT_INFO_AM2 s "123"

4. Verify by reading the field:
busctl get-property xyz.openbmc_project.FruDevice
/xyz/openbmc_project/FruDevice/BMC_Storage_Module
xyz.openbmc_project.FruDevice PRODUCT_INFO_AM2
s "123"

root@tiogapass:~# hexdump /sys/bus/i2c/drivers/at24/6-0054/eeprom
0000000 0001 0100 000d f100 0c01 3600 d0e6 58c6
0000010 5858 5858 d258 4d42 2043 7453 726f 6761
0000020 2065 6f4d 7564 656c 58cd 5858 5858 5858
0000030 5858 5858 5858 58ce 5858 5858 5858 5858
0000040 5858 5858 c358 2e31 c930 5858 5858 5858
0000050 5858 d258 5858 5858 5858 5858 5858 5858
0000060 5858 5858 5858 39c1 0c01 c600 5858 5858
0000070 5858 54d2 6f69 6167 5020 7361 2073 6953
0000080 676e 656c ce32 5858 5858 5858 5858 5858
0000090 5858 5858 58c4 5858 cd32 5858 5858 5858
00000a0 5858 5858 5858 c758 5858 5858 5858 c358
00000b0 2e31 c930 5858 5858 5858 5858 c858 6f43
00000c0 666e 6769 4120 45c1 0000 0000 0000 0000
00000d0 0000 0000 0000 0000 0000 0000 0000 0000
*
0002000
root@tiogapass:~# busctl set-property xyz.openbmc_project.FruDevice
/xyz/openbmc_project/FruDevice/BMC_Storage_Module
xyz.openbmc_project.FruDevice PRODUCT_INFO_AM1 s "123456"
root@tiogapass:~# hexdump /sys/bus/i2c/drivers/at24/6-0054/eeprom
0000000 0001 0100 000d f100 0c01 3600 d0e6 58c6
0000010 5858 5858 d258 4d42 2043 7453 726f 6761
0000020 2065 6f4d 7564 656c 58cd 5858 5858 5858
0000030 5858 5858 5858 58ce 5858 5858 5858 5858
0000040 5858 5858 c358 2e31 c930 5858 5858 5858
0000050 5858 d258 5858 5858 5858 5858 5858 5858
0000060 5858 5858 5858 39c1 0c01 c600 5858 5858
0000070 5858 54d2 6f69 6167 5020 7361 2073 6953
0000080 676e 656c ce32 5858 5858 5858 5858 5858
0000090 5858 5858 58c4 5858 cd32 5858 5858 5858
00000a0 5858 5858 5858 c758 5858 5858 5858 c358
00000b0 2e31 c630 3231 3433 3635 43c8 6e6f 6966
00000c0 2067 c141 0000 4f00 0000 0000 0000 0000
00000d0 0000 0000 0000 0000 0000 0000 0000 0000
*
0002000

Change-Id: Iff11d64a291e6bdb653b6c524ca90e2e16003ec3
Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>

show more ...

Replace boost starts_with with std::string

C++20 introduces std::string::starts_with, which provides standard,
efficient, and header-light ways to check string prefixes and
suffixes.
Replacing boost

Replace boost starts_with with std::string

C++20 introduces std::string::starts_with, which provides standard,
efficient, and header-light ways to check string prefixes and
suffixes.
Replacing boost::starts_with reduces Boost dependencies, and improves
compilation performance.

Change-Id: I5f146d9a1abe6d04d95f8228853139eda773218c
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

copyright: move to SPDX-License-Identifier

Using SPDX-License-Identifier is more compact and leaves more space on
the screen.

Following the example of bmcweb here and replacing all the old copyrigh

copyright: move to SPDX-License-Identifier

Using SPDX-License-Identifier is more compact and leaves more space on
the screen.

Following the example of bmcweb here and replacing all the old copyright
headers with SPDX.

Change-Id: Iace8c887d58e554e0521b040d332c624a20a3aa8
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

automatic clang-tidy fixes

Apply fixes automatically generated by clang-tidy when ran with
clang-tidy-20. These appear to be optimization fixes around usage
of std::map and/or std::unordered_map.

automatic clang-tidy fixes

Apply fixes automatically generated by clang-tidy when ran with
clang-tidy-20. These appear to be optimization fixes around usage
of std::map and/or std::unordered_map.

Change-Id: I920cf1c6f27f0f1ecb219e83736f390544ded10e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

cleanup: Move em only utils code into em directory

More separation of code for improvement of repository maintainability.

Change-Id: I4e77b472355066483cf646cdcd29e7ed660294a3
Signed-off-by: Christo

cleanup: Move em only utils code into em directory

More separation of code for improvement of repository maintainability.

Change-Id: I4e77b472355066483cf646cdcd29e7ed660294a3
Signed-off-by: Christopher Meis <christopher.meis@9elements.com>

show more ...

cleanup: move fru-device service code into own directory

Improving repository structure for increasing maintainability.

Change-Id: Ie18131d534b750cacb0746450377a37a880b0dbe
Signed-off-by: Christoph

cleanup: move fru-device service code into own directory

Improving repository structure for increasing maintainability.

Change-Id: Ie18131d534b750cacb0746450377a37a880b0dbe
Signed-off-by: Christopher Meis <christopher.meis@9elements.com>

show more ...