Add missing Entries fields for CPU and BMC LogServices

The CPU and BMC LogServices were missing their Entries
fields, so adding them back.

Tested: Checked for presence of Entries fields and passed

Add missing Entries fields for CPU and BMC LogServices

The CPU and BMC LogServices were missing their Entries
fields, so adding them back.

Tested: Checked for presence of Entries fields and passed the
Redfish Service Validator.

Change-Id: I3caa251dd8acf05d4c37c2b30bb0374500849e84
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Update the CPU Log Timestamp location

The CPU Log timestamp was moved to a new location in the schema,
so this looks in the new place to get the timestamp for the
Created field.

Tested: Verified th

Update the CPU Log Timestamp location

The CPU Log timestamp was moved to a new location in the schema,
so this looks in the new place to get the timestamp for the
Created field.

Tested: Verified that the Created field is correctly populated in
the LogEntry.

Change-Id: Ie90e169aa999284ebc009867634beb35a4e74587
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

bmcweb: Implement single Redfish "system" endpoint

This commit changes the redfish behavior to move to a single, known name
under the /redfish/v1/Systems/system path. This is advantageous for a
lot

bmcweb: Implement single Redfish "system" endpoint

This commit changes the redfish behavior to move to a single, known name
under the /redfish/v1/Systems/system path. This is advantageous for a
lot of reasons.
1. Lots fewer dbus calls to determine the system name for every path.
This could be optimized in other ways, like checking the system name on
startup, but because redfish paths are not intended to be informative,
this patchset takes the opinion that less code is better.
2. Lots of lowered complexity, given that each endpoint underneath
/system doesn't need an individual "does this system exist, and is the
name right" check.
3. This makes it possible to correctly implement the "Links" property in
Chassis, which is required for the OCP base server profile

Tested By:
Very minimal testing done, but it seems to pass the validator.

Change-Id: Iea3cb5081b92a3843b6877decd009936de00561c
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

bmcweb: move variant usage to std namespace

Change-Id: I9d7069668f91f2ac72d2f4a440f63e0e85dd5269
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

Move filesystem from experimental namespace

Splice it into standard for gcc8

Change-Id: I584206dd737c9d90cf93bfa8541980fdd8f6d39b
Signed-off-by: James Feist <james.feist@linux.intel.com>

Remove custom version of getPtr

Now that sdbusplus variant supports std::get_if, we can remove our
custom, mapbox namespaced implementation that does the same thing.

Change-Id: I854c473003e28e41dd4

Remove custom version of getPtr

Now that sdbusplus variant supports std::get_if, we can remove our
custom, mapbox namespaced implementation that does the same thing.

Change-Id: I854c473003e28e41dd45dba08ca683433f1c1774
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

bmcweb: Redfish away from json cache

In the original incarnation of bmcweb, route registration was done
automatically. This has proved to be a terrible idea, wraught with
corner cases and issues.

bmcweb: Redfish away from json cache

In the original incarnation of bmcweb, route registration was done
automatically. This has proved to be a terrible idea, wraught with
corner cases and issues.

The route registration is currently the only user of the
redfish::Node::json element. Unfortunately, as written, this structure
consumes a lot of memory that's duplicated and not very useful. From a
performance perspective, there is almost no difference between
rebuilding the structure for each GET request, and having the "cache"
that needs to be copied into the response and modified before it can be
useful.

In the programming tradeoffs for bmc, lower memory usage is more important
than latency, especially at these levels.

Change-Id: I785e8352123e5e886acf05cd59cb23648f93839d
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Move Redfish PECI to the new json interface

This change adds vector handling to the new json interface
and modifies the SendRawPECI Redfish command to utilize it.

Tested: Executed raw PECI commands

Move Redfish PECI to the new json interface

This change adds vector handling to the new json interface
and modifies the SendRawPECI Redfish command to utilize it.

Tested: Executed raw PECI commands with good and bad input
to check that it will work and error out correctly.

Change-Id: Ic1c837f5823d28555f727849156b4dabf1b8acef
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Change the BMC LogService to only display from the message registry

This change renames the existing BMC LogService that displays all
entries in the journal to a BMC Journal LogService.

The new sta

Change the BMC LogService to only display from the message registry

This change renames the existing BMC LogService that displays all
entries in the journal to a BMC Journal LogService.

The new standard BMC LogService is modified to only display messages
from the registry. The registry MessageId and MessageArgs must
be included in the journal metadata as "REDFISH_MESSAGE_ID" and
"REDFISH_MESSAGE_ARG_<x>" respectively, where <x> is the arg
number from the registry.

Change-Id: I4556cbea5032ec639ad1fda084571144defe23dc
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add helper functions to get data from the journal

This change adds helper functions to simplify getting
metadata, IDs, and timestamps from the journal.

Change-Id: Icb8a08b52f7311e6471238fe90bfc4d7c

Add helper functions to get data from the journal

This change adds helper functions to simplify getting
metadata, IDs, and timestamps from the journal.

Change-Id: Icb8a08b52f7311e6471238fe90bfc4d7cae55ecd
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Simplify Redfish error message property interface

The error message code used a json_pointer object which must
begin with a '/' character and had to be sent as an extra
parameter. This change simpl

Simplify Redfish error message property interface

The error message code used a json_pointer object which must
begin with a '/' character and had to be sent as an extra
parameter. This change simplifies the interface by using a
string so there doesn't have to be a '/'. This allowed the
same property argument passed for the message to be used
for the property field path.

Tested: Sent an error with a property and verified that it is
correctly displayed.

Change-Id: I0571e2eee627cedf29d751588a4f1bceee66f084
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

bmcweb: merge conflict resolution

Merge conflict in: Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON

bmcweb: merge conflict resolution

Merge conflict in: Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncResp object, this allows for simply calling
the Redfish error and returning.

Change-Id: I3b37cce1e7f603c0b4cc74a16f8f00da9a7f1373
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Add paging and partial results for BMCLogService

Since BMC logs can be very large and may take some time
to load, the browser could time out during the request.

This change adds partial results sup

Add paging and partial results for BMCLogService

Since BMC logs can be very large and may take some time
to load, the browser could time out during the request.

This change adds partial results support for those logs
using the $skip and $top redfish query parameters so only
up to 1000 are printed at a time with a link to get the next
1000 if they exist.

Tested: Loaded a log with more than 1000 entries and confirmed
that $skip entries are skipped and only $top (up to 1000) are
loaded. Also verified that the nextLink property correctly
points to the next set of log entries.

Change-Id: I0a586524a8aab47b9ab457e1d3f56a8b6d97a700
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncRe

Improve the Redfish error reporting interface

Makes the Redfish error reporting interface automatically handle
setting the http status and JSON content in the response object.

When using an AsyncResp object, this allows for simply calling
the Redfish error and returning.

Change-Id: Icfdce2de763225f070e8dd61e591f296703f46bb
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add a BMC LogService

Adds a redfish LogService that provides the contents of the
BMC journald instance available over readfish.

This should be considered a prototype at this time, and suggestions o

Add a BMC LogService

Adds a redfish LogService that provides the contents of the
BMC journald instance available over readfish.

This should be considered a prototype at this time, and suggestions on
how this could be done better are welcome.

At some point in the future, we could make this available over the
redfish TaskService via SSE.

Change-Id: Ibca0d473dcef545763256cc1df5574571a3af414
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Redfish Rename LogService variables

To match naming convention.

Change-Id: I18371e7c605c03eaade5e3c00d2852c95ffa751a
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

Implement redfish LogService

This commit implements an optional LogService endpoint for debugging
CPUs over Redish. It exposes both the ability to create a new log with
the LogImmediate action, as

Implement redfish LogService

This commit implements an optional LogService endpoint for debugging
CPUs over Redish. It exposes both the ability to create a new log with
the LogImmediate action, as well as to pull a stored log using the
LogCollection schema. This feature is disabled by default, and should
be enabled in the meta-x86 layer.

Change-Id: Ied1d5e263a0857e09cd9a24fddec9c11a4066cd2
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...