Break out DBus EventLog

As part of a EventLog refactor, break out all code
used for Systems DBus EventLog, in order to make the code base
more maintainable in the long run.

Tested: Only code extrac

Break out DBus EventLog

As part of a EventLog refactor, break out all code
used for Systems DBus EventLog, in order to make the code base
more maintainable in the long run.

Tested: Only code extraction. Code compiles.

Change-Id: I94de7bf3171fd3963eebec6608438f8d07cee44c
Signed-off-by: Oliver Brewka <oliver.brewka@9elements.com>

show more ...

Provide successResponse body for EventLog Entries

This change ensures that success response body is provided when deleting
EventLog entries.
Status Code 204 No Content causes user confusion when usi

Provide successResponse body for EventLog Entries

This change ensures that success response body is provided when deleting
EventLog entries.
Status Code 204 No Content causes user confusion when using things
like curl. Follow other deletes.

redfish/v1/Systems/system/LogServices/EventLog/Actions/\
LogService.ClearLog -w "%{http_code}\n"

{
"@Message.ExtendedInfo": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The request completed successfully.",
"MessageArgs": [],
"MessageId": "Base.1.19.Success",
"MessageSeverity": "OK",
"Resolution": "None."
}
]
}


Change-Id: I443fdbb29e041a515dd3ee793cc73f27096ab23e
Signed-off-by: Sandeep Patil <sandeepap@ami.com>

show more ...

Add check to omit `DateTime` from etag calculation

Ignores any json property named `DateTime` when calculating
the etag value of an HTTP response as per the updated
Redfish Spec (section 6.5: ETags)

Add check to omit `DateTime` from etag calculation

Ignores any json property named `DateTime` when calculating
the etag value of an HTTP response as per the updated
Redfish Spec (section 6.5: ETags)

Tested:
- Redfish Service Validator passes
- Tested on romulus:
1. GET resource with a "DateTime" field
```
curl -k -H "X-Auth-Token: $XAUTH_TOKEN" "https://$BMC/redfish/v1/TaskService" \
--etag-save ./etag.txt -v
...
< etag: "6A4CE897"
...
{
"@odata.id": "/redfish/v1/TaskService",
"@odata.type": "#TaskService.v1_1_4.TaskService",
"CompletedTaskOverWritePolicy": "Oldest",
"DateTime": "2025-07-23T17:08:20+00:00",
"Id": "TaskService",
"LifeCycleEventOnTaskStateChange": true,
"Name": "Task Service",
"ServiceEnabled": true,
"Status": {
"State": "Enabled"
},
"Tasks": {
"@odata.id": "/redfish/v1/TaskService/Tasks"
}
```

2. GET same resource again later, etag is same as before
```
curl -k -H "X-Auth-Token: $XAUTH_TOKEN" "https://$BMC/redfish/v1/TaskService" \
--etag-save ./etag.txt -v
...
< etag: "6A4CE897"
...
{
"@odata.id": "/redfish/v1/TaskService",
"@odata.type": "#TaskService.v1_1_4.TaskService",
"CompletedTaskOverWritePolicy": "Oldest",
"DateTime": "2025-07-23T17:10:48+00:00",
"Id": "TaskService",
"LifeCycleEventOnTaskStateChange": true,
"Name": "Task Service",
"ServiceEnabled": true,
"Status": {
"State": "Enabled"
},
"Tasks": {
"@odata.id": "/redfish/v1/TaskService/Tasks"
}
```
"DateTime" is the only value to have changed, but since
it is ignored the etag did not change

3. GET with if-none-match returns 304
```
curl -k -H "X-Auth-Token: $XAUTH_TOKEN" "https://$BMC/redfish/v1/TaskService" \
--etag-save ./etag.txt --etag-compare ./etag.txt -v
...
> if-none-match: "6A4CE897"
...
< HTTP/2 304
< allow: GET
< odata-version: 4.0
< strict-transport-security: max-age=31536000; includeSubdomains
< pragma: no-cache
< cache-control: no-store, max-age=0
< x-content-type-options: nosniff
< etag: "6A4CE897"
< date: Wed, 23 Jul 2025 17:14:39 GMT
< content-length: 0
<
...
```

Change-Id: I51f7668e75719c69c55535e4a1e48c8bae7c9488
Signed-off-by: Corey Ethington <cethington@coreweave.com>

show more ...

Break out Journal EventLog

As part of a EventLog refactor, break out all code
used for Systems Journal EventLog, in order to make the code base
more maintainable in the long run.

Tested: Only code

Break out Journal EventLog

As part of a EventLog refactor, break out all code
used for Systems Journal EventLog, in order to make the code base
more maintainable in the long run.

Tested: Only code extraction. Code compiles.

Change-Id: I855c8c680d3de68944b0ae03ff7f181e6790c456
Signed-off-by: Oliver Brewka <oliver.brewka@9elements.com>

show more ...

Extract downloadEntryCallback function

As part of a EventLog refactor, extract this function into a
log_services utility.

Tested: Only code extraction. Code compiles.

Change-Id: Iaa7aa583a38587c33

Extract downloadEntryCallback function

As part of a EventLog refactor, extract this function into a
log_services utility.

Tested: Only code extraction. Code compiles.

Change-Id: Iaa7aa583a38587c338280af2a9fff65d3732f301
Signed-off-by: Oliver Brewka <oliver.brewka@9elements.com>

show more ...

Make declaration consistent

Declare this inline void, not the other way around to be consistent.

This is done to support regex fixing of elements.

Change-Id: Ibfec17042b94c07ddc34048881fe5c7d0a290

Make declaration consistent

Declare this inline void, not the other way around to be consistent.

This is done to support regex fixing of elements.

Change-Id: Ibfec17042b94c07ddc34048881fe5c7d0a290971
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

Fix Crashdump LogServices SubordinateOverrides privileges

This updates SubordinateOverrides permissions on Crashdump LogServices.

1) GET methods
```
- /redfish/v1/Systems/<str>/LogServices/Crash

Fix Crashdump LogServices SubordinateOverrides privileges

This updates SubordinateOverrides permissions on Crashdump LogServices.

1) GET methods
```
- /redfish/v1/Systems/<str>/LogServices/Crashdump/
- /redfish/v1/Systems/<str>/LogServices/Crashdump/Entries/<str>/
```

2) POST methods
```
- /redfish/v1/Systems/<str>/LogServices/Crashdump/Actions/LogService.ClearLog/
- /redfish/v1/Systems/<str>/LogServices/Crashdump/Actions/LogService.CollectDiagnosticData/
```

Tested:
- Redfish Validator passes

Change-Id: Ief83b4aa6a778ee1ed0d0de8725979a5c1266e56
Signed-off-by: Myung Bae <myungbae@us.ibm.com>

show more ...

Add SubordinateOverrides & Fix Log_services privileges

SubordinateOverrides:
This commit automates the creation of SubordinateOverrides privileges
structures from the redfish privilege registry.

Add SubordinateOverrides & Fix Log_services privileges

SubordinateOverrides:
This commit automates the creation of SubordinateOverrides privileges
structures from the redfish privilege registry. In addition, it
enhances the function of parse_registries.py.

It reads SubordinateOverrides privilege registry from DMTF and
generates const defines SubordinateOverrides for all the privilege
registry entries in the same format that the Privileges struct
accepts.

Moreover, it generates unique const defines for all
SubordinateOverrides target levels.
Ex: EthernetInterface SubordinateOverrides has two "Targets":
["Manager", "EthernetInterfaceCollection"]. So
parse_registries.py generates two unique const

1) Subordinate override for Manager -> EthernetInterface
2) Subordinate override for Manager ->
EthernetInterfaceCollection -> EthernetInterface

Note: if SubordinateOverrides privilege gets changed, then it
automatically updates that route privilege, but if
SubordinateOverrides target gets changed, then the user needs to
update that manually.

Fix Log_services privileges:
In Log_services, some of the privileges not following the
Redfish_1.1.0_PrivilegeRegistry registry.

This commit contains the following LogServices privileges.

1) POST method
```
ComputerSystem -> LogServiceCollection -> LogService
- POST /redfish/v1/Systems/<str>/LogServices/EventLog/Actions/LogService.ClearLog/
- POST /redfish/v1/Systems/<str>/LogServices/Dump/Actions/LogService.CollectDiagnosticData/
- POST /redfish/v1/Systems/<str>/LogServices/Dump/Actions/LogService.ClearLog/
- POST /LogServices/PostCodes/Actions/LogService.ClearLog/
```

2) DELETE method
```
ComputerSystem -> LogServiceCollection -> LogService -> LogEntryCollection -> LogEntry
- DELETE /redfish/v1/Systems/<str>/LogServices/EventLog/Entries/<str>/
```

This commit also changes the current privilege

1) ConfigureManager to ConfigureComponents.

```
DELETE /redfish/v1/Systems/<str>/LogServices/EventLog/Entries/<str>
```

2) ConfigureCompnents -> ConfigureManager

```
POST /redfish/v1/Systems/<str>/LogServices/Dump/Actions/LogService.ClearLog/
POST /redfish/v1/Systems/<str>/LogServices/EventLog/Actions/LogService.ClearLog/
POST /redfish/v1/Systems/<str>/LogServices/Dump/Actions/LogService.CollectDiagnosticData/
```

Tested: manually tested on Witherspoon system, there is no change in
output. Run Redfish validator, with all different Privileges;
Error Get: UUID: String '' does not match pattern ''
this commit doesn't affect UUID

Email sent to openbmc list:
https://lists.ozlabs.org/pipermail/openbmc/2021-August/027232.html

Change-Id: I37d8a2882f1cfaa59a482083f180fdd0805e2e7d
Signed-off-by: Abhishek Patel <Abhishek.Patel@ibm.com>
Signed-off-by: Myung Bae <myungbae@us.ibm.com>

show more ...

Task: Fix missing properties in task monitor

Task monitor URI when the task is running contains partial information.
Properties like progress percent, message is missing. Same issue is
present when

Task: Fix missing properties in task monitor

Task monitor URI when the task is running contains partial information.
Properties like progress percent, message is missing. Same issue is
present when task is created and response is returned.

This patch fixes missing properties in task creation response and task
monitor URI.

Tested:
- Task creation with fwupdate response shows all properties
- Task monitor URI provides complete information when running
- Verified task creation and monitor response for log service

Change-Id: I77c6d9b9302d13b8480cf5a3419b8c6754e5049d
Signed-off-by: Chinmay Shripad Hegde <hosmanechinmay@gmail.com>
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

Refactor fillDbusEventLogEntry handling

Currently, EventLog entry output is directly produced from the
dbusPropertyMap in a function like
- Extract DbusEventLogEntry from PropertyMap
- Generate json

Refactor fillDbusEventLogEntry handling

Currently, EventLog entry output is directly produced from the
dbusPropertyMap in a function like
- Extract DbusEventLogEntry from PropertyMap
- Generate json output from DbusEventLogEntry struct.

There is a need to generate json output conditionally based on
DbusLogEntry content. For example, an OEM may choose to add a new
d-dbus field like `Hidden` to hide those entries from Redfish output.

For this kind of need, it is better to separate the current
`fillDbusEventLogEntryFromPropertyMap()` into 2 steps like

From:
```
fillEventLogLogEntryFromPropertyMap(asyncResp, resp, asyncResp->res.jsonValue);
==>
std::optional<DbusEventLogEntry> optEntry =
fillDbusEventLogEntryFromPropertyMap(propertyMap);
fillEventLogLogEntryFromDbusLogEntry(*optEntry, asyncResp->res.jsonValue);
```

Then, we can add a condition easily before generating json output like
this.
```
std::optional<DbusEventLogEntry> optEntry =
fillDbusEventLogEntryFromPropertyMap(propertyMap);
if( !optEntry->Hidden )
{
fillEventLogLogEntryFromDbusLogEntry(*optEntry, asyncResp->res.jsonValue);
}
```

Tested:
- Get /redfish/v1/Systems/system/LogServices/EventLog/Entries
- Compare the outputs of before and after change.

Change-Id: I75f4debb7f10037a5fbca445b04650e6903c7628
Signed-off-by: Myung Bae <myungbae@us.ibm.com>

show more ...

Refactor lambda on dBusEventLogEntryGet

Similar to other patches, refactor this lambda into a normal function
so that the successive commits can be more readable.

Tested:
- Redfish service validato

Refactor lambda on dBusEventLogEntryGet

Similar to other patches, refactor this lambda into a normal function
so that the successive commits can be more readable.

Tested:
- Redfish service validator passes

Change-Id: I0323af66a301d06667fddd05f83fde19d81cdb2b
Signed-off-by: Myung Bae <myungbae@us.ibm.com>

show more ...

Return 200 OK for all dumps in LogService.ClearLog

Change:
* Return 200 OK in a dump when doing ClearLog.

Reason:
* Status Code 204 No Content causes user confusion when using things
like curl.
*

Return 200 OK for all dumps in LogService.ClearLog

Change:
* Return 200 OK in a dump when doing ClearLog.

Reason:
* Status Code 204 No Content causes user confusion when using things
like curl.
* ClearLog is an Action, so the relevant section of the spec is
"Table - POST (action) status codes".

Tested:
* Ran the ast2600-evb on QEMU and verified that the ClearLog dump for
Managers and Systems returned a 200 status code along with the
expected response data.

[Manager Dump]
```
yahanc@amyc:~$ curl -k -u root:0penBmc -X POST https://127.0.0.1:2443/\
redfish/v1/Managers/bmc/LogServices/Dump/Actions/LogService.ClearLog \
-w "%{http_code}\n"
{
"@Message.ExtendedInfo": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The request completed successfully.",
"MessageArgs": [],
"MessageId": "Base.1.19.Success",
"MessageSeverity": "OK",
"Resolution": "None."
}
]
}200
yahanc@amyc:~$
```
[Manager FaultLog]
```
yahanc@amyc:~$ curl -k -u root:0penBmc -X POST https://127.0.0.1:2443/\
redfish/v1/Managers/bmc/LogServices/FaultLog/Actions/\
LogService.ClearLog -w "%{http_code}\n"
{
"@Message.ExtendedInfo": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The request completed successfully.",
"MessageArgs": [],
"MessageId": "Base.1.19.Success",
"MessageSeverity": "OK",
"Resolution": "None."
}
]
}200
yahanc@amyc:~$
```
[System EventLog]
```
yahanc@amyc:~$ curl -k -u root:0penBmc -X POST https://127.0.0.1:2443/\
redfish/v1/Systems/system/LogServices/EventLog/Actions/\
LogService.ClearLog -w "%{http_code}\n"
{
"@Message.ExtendedInfo": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The request completed successfully.",
"MessageArgs": [],
"MessageId": "Base.1.19.Success",
"MessageSeverity": "OK",
"Resolution": "None."
}
]
}200
yahanc@amyc:~$
```

Change-Id: I85cde45ce5063365866a4b2e76c3b55de7c10e11
Signed-off-by: Amy Chang <yahanc@nvidia.com>

show more ...

Add async_method_call to utility

Adding async_method_call in dbus utility gives us a place where we can
intercept method call requests from dbus to potentially add
logging/caching.

An example of lo

Add async_method_call to utility

Adding async_method_call in dbus utility gives us a place where we can
intercept method call requests from dbus to potentially add
logging/caching.

An example of logging is in the later commit:
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/78265/

We already do this for setProperty, this moves the method calls to
follow a similar pattern.

Tested: Redfish service validator passes.

Change-Id: I6d2c96e2b6b6a023ed2138106a55faebca161592
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

Fix crash on requesting all events if dbus logging enabled

afterLogEntriesGetManagedObjects prepares members array (all the
LogEntry objects) to be used in response to the /EventLog/Entries
requests

Fix crash on requesting all events if dbus logging enabled

afterLogEntriesGetManagedObjects prepares members array (all the
LogEntry objects) to be used in response to the /EventLog/Entries
requests. It calls the fillEventLogLogEntryFromPropertyMap for every
event passing the dbus properties map and json object, expecting
the function to translate the properties map to JSON. It stores all
the json objects in an array. It uses .emplace_back on the array
to create an empty instance of JSON object which it immediately
passes to be filled.
If something fails in fillEventLogLogEntryFromPropertyMap (like DBus
property map is malformed), it fires an internal error and return
immediately without filling any fields in JSON object.
As a result, in case of earlier return from the function, the array will
have objects with no data. After collecting all the objects, it reorders
the elements by Id, however as some of them have no Id fields populated,
accessing to non-existent fields causes service to crash.

Testing:
Before the command [1] the process core dumped.

After, the same command [1] works [2].
Requesting individual entries keeps working [3].

[1] Command to fetch all EventLog Entries:
```
curl -ks -H "Content-Type: application/json" -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog/Entries
```

[2] Result from the server after fixing
```
root@bmc:~# curl -ks -H "Content-Type: application/json" -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog/Entries
{
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/Entries",
"@odata.type": "#LogEntryCollection.LogEntryCollection",
"Description": "Collection of System Event Log Entries",
"Name": "System Event Log Entries",
"error": {
"@Message.ExtendedInfo": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The request failed due to an internal service error. The service is still operational.",
"MessageArgs": [],
"MessageId": "Base.1.19.InternalError",
"MessageSeverity": "Critical",
"Resolution": "Resubmit the request. If the problem persists, consider resetting the service."
}
],
"code": "Base.1.19.InternalError",
"message": "The request failed due to an internal service error. The service is still operational."
}
}
```

[3] Fetching a single entry correct and failing
```
root@bmc:~# curl -ks -H "Content-Type: application/json" -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog/Entries/1
{
"error": {
"@Message.ExtendedInfo": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The request failed due to an internal service error. The service is still operational.",
"MessageArgs": [],
"MessageId": "Base.1.19.InternalError",
"MessageSeverity": "Critical",
"Resolution": "Resubmit the request. If the problem persists, consider resetting the service."
}
],
"code": "Base.1.19.InternalError",
"message": "The request failed due to an internal service error. The service is still operational."
}
}

root@bmc:~# curl -ks -H "Content-Type: application/json" -H "X-Auth-Token: $token" https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog/Entries/2
{
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/2",
"@odata.type": "#LogEntry.v1_9_0.LogEntry",
"AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/2/attachment",
"Created": "2025-04-02T09:54:37.777+00:00",
"EntryType": "Event",
"Id": "2",
"Message": "Sensor 'BIC_JI_SENSOR_MB_RETIMER_TEMP_C' reading of 10.2 (xyz.openbmc_project.Sensor.Value.Unit.DegreesC) is below the 15.5 lower critical threshold.",
"MessageArgs": [
"BIC_JI_SENSOR_MB_RETIMER_TEMP_C",
"10.2",
"xyz.openbmc_project.Sensor.Value.Unit.DegreesC",
"15.5"
],
"MessageId": "SensorEvent.1.0.ReadingBelowLowerCriticalThreshold",
"Modified": "2025-04-02T09:54:37.777+00:00",
"Name": "System Event Log Entry",
"Resolution": "Check the condition of the resources listed in RelatedItem.",
"Resolved": false,
"Severity": "Critical"
}
```

Change-Id: I231b2266ccee27e83363cd1363c130d3fe8f1ed3
Signed-off-by: Igor Kanyuka <ifelmail@gmail.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I2f0b9d0fb6e01ed36a2f34c750ba52de3b6d15d1
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I2f0b9d0fb6e01ed36a2f34c750ba52de3b6d15d1
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix includes

Clang-tidy misc-include-cleaner appears to now be enforcing
significantly more headers than previously. That is overall a good
thing, but forces us to fix some issues. This commit is

Fix includes

Clang-tidy misc-include-cleaner appears to now be enforcing
significantly more headers than previously. That is overall a good
thing, but forces us to fix some issues. This commit is largely just
taking the clang-recommended fixes and checking them in. Subsequent
patches will fix the more unique issues.

Note, that a number of new ignores are added into the .clang-tidy file.
These can be cleaned up over time as they're understood. The majority
are places where boost includes a impl/x.hpp and x.hpp, but expects you
to use the later. include-cleaner opts for the impl, but it isn't clear
why.

Change-Id: Id3fdd7ee6df6c33b2fd35626898523048dd51bfb
Signed-off-by: Ed Tanous <etanous@nvidia.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move hostlogger utilities

clang-tidy misc-include-fixer tries to remove the log_services.hpp
include from systems_logsevices_hostlogger.hpp file. This causes these
two helper functions to go missin

Move hostlogger utilities

clang-tidy misc-include-fixer tries to remove the log_services.hpp
include from systems_logsevices_hostlogger.hpp file. This causes these
two helper functions to go missing.

These arguably should've been moved in
7945eeed0fe8f9c7bf07669294499ae0108da1d3 where we created this file, but
the second best time to plant a tree is now, so move them.

Tested: Code compiles. No test harnesses for hostlogger.

Change-Id: Ic0693472deb6c3bd355f042a0105661fa0873dfe
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

Use SPDX identifiers

SPDX identifiers are simpler, and reduce the amount of cruft we have in
code files. They are recommended by linux foundation, and therefore we
should do as they allow.

This pa

Use SPDX identifiers

SPDX identifiers are simpler, and reduce the amount of cruft we have in
code files. They are recommended by linux foundation, and therefore we
should do as they allow.

This patchset does not intend to modify any intent on any existing
copyrights or licenses, only to standardize their inclusion.

[1] https://www.linuxfoundation.org/blog/blog/copyright-notices-in-open-source-software-projects

Change-Id: I935c7c0156caa78fc368c929cebd0f068031e830
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

Move getProperty calls to utility

Having all dbus calls run through the same utility reduces the amount of
generated code, and more importantly, gives us a place where we can log
the requests and re

Move getProperty calls to utility

Having all dbus calls run through the same utility reduces the amount of
generated code, and more importantly, gives us a place where we can log
the requests and responses to help with debugging.

Tested: Redfish service validator passes.

Change-Id: Ic1bf45130b5069cd57f7af26e12c8d3159c87c67
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

Format readjson

clang-format may potentially reformat the readJson calls if they may
have more keys or key names are longer. This makes formatting in a way
that's readable by forcing to break a line

Format readjson

clang-format may potentially reformat the readJson calls if they may
have more keys or key names are longer. This makes formatting in a way
that's readable by forcing to break a line for each key using an
empty-comment (`//`) each line.

It also allows trivially alphabetizing the list such that new additions
are less likely to have merge conflicts.

Tested:
- Check whitespace only.
- Code compiles.
- Redfish Service Validator with the same results before this

Change-Id: I3824a8c4faa9fa7c820d5d2fab6b565404926e2c
Signed-off-by: Ed Tanous <etanous@nvidia.com>
Signed-off-by: Myung Bae <myungbae@us.ibm.com>

show more ...

event logs: introduce struct DbusEventLogEntry

This creates a partial representation of dbus interface
xyz.openbmc_project.Logging.Entry as a struct.

There is also a function to extract it from dbu

event logs: introduce struct DbusEventLogEntry

This creates a partial representation of dbus interface
xyz.openbmc_project.Logging.Entry as a struct.

There is also a function to extract it from dbus.

Which helps to refactor function fillEventLogLogEntryFromPropertyMap
to be smaller.

Tested: not tested, simple refactoring. All the data types remain the
same as before.

Change-Id: Ib32cac967bde487b137ceaf845dfb682e605a175
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

Fix status for non-existent JsonSchema FileGet

This will fix the incorrect status 500 to status 404 for the
non-eixstent JsonSchema FileGet.

```
% redfishtool raw GET -r ${bmc} -u root -p 0penBmc

Fix status for non-existent JsonSchema FileGet

This will fix the incorrect status 500 to status 404 for the
non-eixstent JsonSchema FileGet.

```
% redfishtool raw GET -r ${bmc} -u root -p 0penBmc -S Always /redfish/v1/JsonSchemas/ComputerSystem/ComputerSystem.v1_99_1.json
redfishtool: Transport: Response Error: status_code: 500 -- Internal Server Error
redfishtool: raw: Error getting response
```

This commit also refactor `Response::openFile()` to return `ec` so that
the caller can check the reason of the failure.

Tested:
- Verify redfishtool result for the non-existent JsonSchema file like
```
% redfishtool raw GET -r ${bmc} -u root -p 0penBmc -S Always /redfish/v1/JsonSchemas/<schema>/<non-existent-schema>.json
redfishtool: Transport: Response Error: status_code: 404 -- Not Found
redfishtool: raw: Error getting response
```
- Redfish Service validator passes

Change-Id: I98927c076bb6e7dfb3742183b4b3545e328d2657
Signed-off-by: Myung Bae <myungbae@us.ibm.com>

show more ...

Remove duplicated block comments

Static analysis flags that these two comments are redundant[1], which
seem to be duplicated a lot in copyright headers. Although there is a
larger discussion that c

Remove duplicated block comments

Static analysis flags that these two comments are redundant[1], which
seem to be duplicated a lot in copyright headers. Although there is a
larger discussion that can likely be had.

[1] https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=edtanous_bmcweb&open=AY9_HYjgKXKyw1ZFwgVP

Tested: Comment change only. Code compiles.

Change-Id: Ia960317761f558a87842347ca0b5f3da63f8e730
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

static -> inline

Declaring a function static in a header makes no sense, because a header
isn't a compile unit. Find all the issues and replace them with inline.

Change-Id: Icfc2b72d94b41a3a880da1

static -> inline

Declaring a function static in a header makes no sense, because a header
isn't a compile unit. Find all the issues and replace them with inline.

Change-Id: Icfc2b72d94b41a3a880da1ae6975beaa30a6792b
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...

Break out hostlogger

Similar to what we've done elsewhere, break out hostlogger into its own
file.

Tested: Code compiles.

Change-Id: Ib9a48577878f57eb7ed4e3cf6b84a58a3ec203f6
Signed-off-by: Ed Tan

Break out hostlogger

Similar to what we've done elsewhere, break out hostlogger into its own
file.

Tested: Code compiles.

Change-Id: Ib9a48577878f57eb7ed4e3cf6b84a58a3ec203f6
Signed-off-by: Ed Tanous <etanous@nvidia.com>

show more ...