Fix some warnings

-werror on the newest version of GCC finds even more stuff than was
found before. Fix all of them.

Tested: No functional change. In theory these cases can't occur unless
a dbus

Fix some warnings

-werror on the newest version of GCC finds even more stuff than was
found before. Fix all of them.

Tested: No functional change. In theory these cases can't occur unless
a dbus interface is broken.

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: Id11e29e4851075b511e69cbc006aa8d7e1e229f0

show more ...

Fix a bunch of warnings

using the list of warnings from here:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100

Seems lik

Fix a bunch of warnings

using the list of warnings from here:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100

Seems like a good place to start, and would improve things a bit
type-wise. This patchset attempts to correct all the issues in one
shot.

Tested:
It builds. Will test various subsystems that have been touched

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I588c26440e5a97f718a0f0ea74cc84107d53aa1e

show more ...

Don't return a 500 error for entries without priority metadata

This change makes an entry with no priority metadata default to
"OK" instead of returning a 500 error.

Tested:
Logged an entry without

Don't return a 500 error for entries without priority metadata

This change makes an entry with no priority metadata default to
"OK" instead of returning a 500 error.

Tested:
Logged an entry without priority and confirmed that getting the
Entries returns 200.

Passed the Redfish Service Validator.

Change-Id: I5a4633ef8542da6eaacad28953e5c99d992576fa
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Fix getting individual journal entries with an underscore

The journal entries with an underscore in the ID could not
be accessed individually.

This change tracks the unique ID while searching for t

Fix getting individual journal entries with an underscore

The journal entries with an underscore in the ID could not
be accessed individually.

This change tracks the unique ID while searching for the entry
so it can find the correct entry with an underscore.

Tested:
Checked that individual journal entries with and without an
underscore can be accessed.

Passed the Redfish Service Validator.

Change-Id: I4aedbe1cb7d5f3cb896c5a0e766e9a274f0ee076
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add support to request a single Journal Event Log Entry

This change adds back support to request a single Journal Event
Log Entry.

Tested:
Requested a single valid entry and got it.
Requested an in

Add support to request a single Journal Event Log Entry

This change adds back support to request a single Journal Event
Log Entry.

Tested:
Requested a single valid entry and got it.
Requested an invalid entry and got the correct error message.
Passed the Redfish Service Validator.

Change-Id: Ibd2defee04510c1b52fe010cf3e2c6aced94537f
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Don't store LogEntry IDs across requests

Because the previous timestamp is stored across Entries requests,
a single entry will increment the ID on every refresh since the
previous timestamp will alw

Don't store LogEntry IDs across requests

Because the previous timestamp is stored across Entries requests,
a single entry will increment the ID on every refresh since the
previous timestamp will always match.

This change clears the previous timestamp on the first entry of
each request.

Tested:
Refreshed a single LogEntry many times and confirmed that the ID
does not change.

Change-Id: I8bf81b6c2eb6ac4037a17008ba54ebfccb42e0dd
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Redfish:Support to Delete a single event log

Tested:Use redfish to delete a single event log
Before:
curl -k -H "X-Auth-Token: $bmc_token" -X DELETE https://${bmc}/redfish/v1/Systems/system/LogServi

Redfish:Support to Delete a single event log

Tested:Use redfish to delete a single event log
Before:
curl -k -H "X-Auth-Token: $bmc_token" -X DELETE https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog/Entries/2 -d '{"[]"}'
Method Not Allowed

After:
curl -k -H "X-Auth-Token: $bmc_token" -X DELETE https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog/Entries/2 -d '{"[]"}'

No error response,and the entry 2 is deleted.

Signed-off-by: Chicago Duan <duanzhijia01@inspur.com>
Change-Id: I31e4470d73b72012b8727d466530202e2609000d

show more ...

Fix Redfish Validator Errors in EventLog

/redfish/v1/Systems/system/LogServices/EventLog
ERROR - LogService.v1_0_0.LogService:Actions : Could not get
details on this property (This item should not b

Fix Redfish Validator Errors in EventLog

/redfish/v1/Systems/system/LogServices/EventLog
ERROR - LogService.v1_0_0.LogService:Actions : Could not get
details on this property (This item should not be a List)
ERROR - Actions: Item is present, but no schema found

Before:

curl -k https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog/
{
"@odata.context": "/redfish/v1/$metadata#LogService.LogService",
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog",
"@odata.type": "#LogService.v1_1_0.LogService",
"Actions": [
{
"#LogService.ClearLog": {
"target": "/redfish/v1/Systems/system/LogServices/EventLog/Actions/LogService.ClearLog"
}
}
],

After:

curl -k https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog/
{
"@odata.context": "/redfish/v1/$metadata#LogService.LogService",
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog",
"@odata.type": "#LogService.v1_1_0.LogService",
"Actions": {
"#LogService.ClearLog": {
"target": "/redfish/v1/Systems/system/LogServices/EventLog/Actions/LogService.ClearLog"
}
},

LogService.ClearLog currently does not work on master on Witherspoon,
see https://github.com/openbmc/bmcweb/issues/97

Change-Id: Id2cea926b4f5248782c751f3da247c4dc5662cf3
Tested: No longer see the Errors.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

bmcweb: Clear up event log entry class names

It wasn't immediately clear what some of the classes
did without digging through the implementation. This
should clear up any confusion between the Journ

bmcweb: Clear up event log entry class names

It wasn't immediately clear what some of the classes
did without digging through the implementation. This
should clear up any confusion between the Journal and
DBus implementations of the event log entry classes.

Tested: Verified changes were present in both implementations
of event log enttry.

Change-Id: Id0d6bad5c73feb93608ac1ad457235a1d31fe018
Signed-off-by: Anthony Wilson <wilsonan@us.ibm.com>

show more ...

redfish: Give DBus event logging its own classes

Since the DBus implementation of event logging is
completely different than the journal implementation,
moved it to its own class to be consistent.

redfish: Give DBus event logging its own classes

Since the DBus implementation of event logging is
completely different than the journal implementation,
moved it to its own class to be consistent.

Tested: Verified both implementations work the same
as before the class split.

Change-Id: I95e3b837f9d99b78034695545ab5791386d94a13
Signed-off-by: Anthony Wilson <wilsonan@us.ibm.com>

show more ...

Fix parsing of Redfish messages with empty MessageArgs

The current parsing shows an empty string as a MessageArg for
messages that have no arguments. This fixes it to correctly
display an empty Mes

Fix parsing of Redfish messages with empty MessageArgs

The current parsing shows an empty string as a MessageArg for
messages that have no arguments. This fixes it to correctly
display an empty MessageArgs.

It also fixes a parsing range check error for the case when
a message without MessageArgs is not terminated with a comma.

Tested:
Verified that messages show without args show in Redfish with
an empty MessageArgs.

Injected a message without a terminating comma and confirmed that
it is correctly parsed and displayed.

Change-Id: I896554941d2d239afa889d41edef1f1f71b59906
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add ClearLog support for the Redfish Event Log Service

This change adds support for the LogService.ClearLog action to
clear the Redfish Event Log.

Tested:
1. Added entries to the EventLog
2.

Add ClearLog support for the Redfish Event Log Service

This change adds support for the LogService.ClearLog action to
clear the Redfish Event Log.

Tested:
1. Added entries to the EventLog
2. Sent the ClearLog action using Postman:
/redfish/v1/Systems/system/LogServices/EventLog/Actions/LogService.ClearLog
3. Confirmed that the EventLog was empty
4. Added entries to the EventLog
5. Confirmed that the new entries logged successfully

Change-Id: I6ac4ea4aff8d7defbea693a2c8a755a712fb39a6
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Fix a trailing slash on LogServices

Redfish takes a not-so-strong opinion on trailing slashes, and while
they're kind of allowed, the validator does mention them.

This fixes the URI endpoint to not

Fix a trailing slash on LogServices

Redfish takes a not-so-strong opinion on trailing slashes, and while
they're kind of allowed, the validator does mention them.

This fixes the URI endpoint to not contain a slash.

Tested:
Ran redfish service validator, and observed no new errors.

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I697f99e17fd4564f5f9648b972a1168de78c271d

show more ...

Improve Redfish log entry parsing

This change makes the log entry parsing more robust by checking
only for the first space to get the timestamp instead of
splitting on all spaces.

Tested:
Added log

Improve Redfish log entry parsing

This change makes the log entry parsing more robust by checking
only for the first space to get the timestamp instead of
splitting on all spaces.

Tested:
Added log entries using sensor override and confirmed that all
of them can be correctly displayed in the EventLog LogService.

Change-Id: Ic0374f6bf8d5ec052dae84b36ab48d16041c614f
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Use syslog for Redfish messages

Limitations were discovered after the journal was made persistent
that reduce the benefits of using it directly for persistent event
logs.

As an alternative, we will

Use syslog for Redfish messages

Limitations were discovered after the journal was made persistent
that reduce the benefits of using it directly for persistent event
logs.

As an alternative, we will leave the journal volatile and use
rsyslog to persist only the event logs. This change switches
to the syslog files for Redfish event messages instead of looking
directly in the journal.

Tested:
Navigated to
"/redfish/v1/Systems/system/LogServices/EventLog/Entries"
and confirmed that all of the stored Event Log Entries are returned.

Change-Id: Ib0aebda68eb95bb171fccd208350c3d073787a13
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Construct Redfish messages using the Message Registry

Instead of using the message and severity from the journal,
this change allows Redfish to search for the MessageId in the
Message Registries to

Construct Redfish messages using the Message Registry

Instead of using the message and severity from the journal,
this change allows Redfish to search for the MessageId in the
Message Registries to construct the message. This will provide
more accurate Redfish messages and severities since they come
from a single source.

Tested:
Logged Redfish events using new MessageIds and confirmed that
the correct message from the Message Registry is displayed
rather than the message from the journal.

Change-Id: I294593647998c988b36ffccaf95a69cbeab3f92e
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Change application and interface names to Crashdump

Crashdump is the preferred name, so replace all uses of
CPU Log with Crashdump.

Tested: On-demand crashdump functions correctly

Change-Id: I6cf8

Change application and interface names to Crashdump

Crashdump is the preferred name, so replace all uses of
CPU Log with Crashdump.

Tested: On-demand crashdump functions correctly

Change-Id: I6cf8fb81bc8f2e85dd4a3561835f3fafbff764e5
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Remove references to experimental filesystem

We're at CPP17 everywhere now, no need to keep the
experimental refrerence.

Tested: It builds

Change-Id: I5f6571eb411bf055e9715f7d96d1be5a3cb2e119
Sign

Remove references to experimental filesystem

We're at CPP17 everywhere now, no need to keep the
experimental refrerence.

Tested: It builds

Change-Id: I5f6571eb411bf055e9715f7d96d1be5a3cb2e119
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Change the name from Immediate to On-Demand for CPU Log

The name "Immediate" was confusing, so changing the name to
"OnDemand" to make it's purpose more clear.

Tested:
Used Postman to send a POST t

Change the name from Immediate to On-Demand for CPU Log

The name "Immediate" was confusing, so changing the name to
"OnDemand" to make it's purpose more clear.

Tested:
Used Postman to send a POST to "/redfish/v1/Systems/system/
LogServices/CpuLog/Actions/Oem/CpuLog.OnDemand" and verified
that the expected On-Demand data was returned.

Change-Id: If9b6b30e1c424227601fb6b7381470f571afca9e
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Initial redfish logging support

This was imported from a fork:
https://github.com/ampere-openbmc/bmcweb/commits/ampere-next/redfish-core/lib/logservices.hpp

Which had a series of commits from TungV

Initial redfish logging support

This was imported from a fork:
https://github.com/ampere-openbmc/bmcweb/commits/ampere-next/redfish-core/lib/logservices.hpp

Which had a series of commits from TungVuX and hyche

The initial patch is that code verbatim.
Follow up patches on top of this make the necessary changes
for current bmcweb:
- Move to sdbusplus
- C++ naming convention changes
- Clang format
- Some refactoring

Tested:
Verified new services work correctly when queried
e.g. curl -k -H "X-Auth-Token: $bmc_token" -X GET \
https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog/Entries
displays the entries properly.

RedfishServiceValidator results:
/redfish/v1/Systems/system/LogServices
pass: 3
passGet: 1
skipOptional: 1
/redfish/v1/Systems/system/LogServices/EventLog
pass: 5
passGet: 1
skipOptional: 8
/redfish/v1/Systems/system/LogServices/EventLog/Entries
pass: 3
passGet: 1
skipOptional: 1
/redfish/v1/Systems/system/LogServices/EventLog/<str>
pass: 6
passGet: 1
skipOptional: 16

Sample Output: curl -k -H "X-Auth-Token: $bmc_token" -X GET https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog/Entries
{
"@odata.context": "/redfish/v1/$metadata#LogEntryCollection.LogEntryCollection",
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/Entries",
"@odata.type": "#LogEntryCollection.LogEntryCollection",
"Description": "Collection of System Event Log Entries",
"Members": [
{
"@odata.context": "/redfish/v1/$metadata#LogEntry.LogEntry",
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1",
"@odata.type": "#LogEntry.v1_4_0.LogEntry",
"Created": "2019-02-22T17:11:00+00:00",
"EntryType": "Event",
"Id": "1",
"Message": "example.xyz.openbmc_project.Example.Elog.AutoTestSimple",
"Name": "System DBus Event Log Entry",
"Severity": "Critical"
}
],
"Members@odata.count": 1,
"Name": "System Event Log Entries"
}

Change-Id: I422b0d0ec577ea734fecfb6f49101ec5ff45a556
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Signed-off-by: Anthony Wilson <wilsonan@us.ibm.com>

show more ...

Revert "bmcweb: Fix a bunch of warnings"

This reverts commit 6ea007a2faec52ad62680015d2a3f00371a1e351.

Reason for revert: Reports of bmcweb seg faults.

Change-Id: I408f1bb29c2f8e427a6621cdaac8c31b

Revert "bmcweb: Fix a bunch of warnings"

This reverts commit 6ea007a2faec52ad62680015d2a3f00371a1e351.

Reason for revert: Reports of bmcweb seg faults.

Change-Id: I408f1bb29c2f8e427a6621cdaac8c31b847ebf06

show more ...

bmcweb: Fix a bunch of warnings

bmcweb classically has not taken a strong opinion on warnings. With
this commit, that policy is changing, and bmcweb will invoke the best
warnings we are able to ena

bmcweb: Fix a bunch of warnings

bmcweb classically has not taken a strong opinion on warnings. With
this commit, that policy is changing, and bmcweb will invoke the best
warnings we are able to enable, and turn on -Werror for all builds.

This is intended to reduce the likelihood of hard-to-debug situations
that the compiler coulve caught early on.

Change-Id: I57474410821e82666b3a108cfd0db7d070e8900a
Signed-off-by: Ed Tanous <ed@tanous.net>

show more ...

Fix Entries path to point to Systems/system

The corrected Entries path for the CPU LogService did not get
updated with the move from Managers/bmc to Systems/system, so
this change fixes it.

Tested:

Fix Entries path to point to Systems/system

The corrected Entries path for the CPU LogService did not get
updated with the move from Managers/bmc to Systems/system, so
this change fixes it.

Tested: Checked that the Entries path points to Systems/system
and that it correctly leads to the Entries resource.

Change-Id: I1897d43a428408c7a9f16d06747f3654bc8a7e35
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

bmcweb: /s/boost::string_view/std::string_view/g

With boost 1.69, we get the new option, BOOST_BEAST_USE_STD_STRING_VIEW
which allows us to use std::string for all beast interfaces, instead of
boost

bmcweb: /s/boost::string_view/std::string_view/g

With boost 1.69, we get the new option, BOOST_BEAST_USE_STD_STRING_VIEW
which allows us to use std::string for all beast interfaces, instead of
boost string_view. This was originally intended to try to reduce the
binary size, but the comparison shows only a minor improvement.

boost::string_view: 7420780 bytes
std::string_view: 7419948 bytes

832 bytes saved ! ! ! ! !

So instead, we will use the argument that it's more standard and easier
for people to grok.

Tested By:
Pulled down some bmcweb endpoints, and observed no change. Because the
two objects are essentially drop in replacements for one another, there
should be no change.

Change-Id: I001e8cf2a0124de4792a7154bf246e3c35ef3f97
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Move the CPU LogService to Systems

The CPU LogService doesn't belong under BMC LogServices,
so moving it to Systems LogServices.

Tested: Verified that the CPU LogService shows up under Systems
and

Move the CPU LogService to Systems

The CPU LogService doesn't belong under BMC LogServices,
so moving it to Systems LogServices.

Tested: Verified that the CPU LogService shows up under Systems
and passed the Redfish Service Validator.

Change-Id: Ic04157b966dc0395db94046f37c33590a4e20553
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...