sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia5d0845741f1d8d4bc6fd227c6d2e6f3a8d42b2e

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86e11299512704fa1df1e5f6517ea25cc6eced8f

Redfish: Log service implementation for system dump

Dump is the debug data collected at any point of time
from the system and is stored in a file
Currently, Redfish doesn't have schema for operation

Redfish: Log service implementation for system dump

Dump is the debug data collected at any point of time
from the system and is stored in a file
Currently, Redfish doesn't have schema for operations
on debug data(dump).
This commit implements logService for system dump.

we have a DMTF proposal to extend existing LogService schema
for this purpose but its still work in progress,
so moved to oem schema.
below commit has changes to move properties to OEM
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/30352

Tested By:
GET https://${IP}/redfish/v1/Systems/system/LogServices/SystemDump
DELETE https://${IP}/redfish/v1/Systems/system/LogServices/SystemDump/Entries/<id>

Redfish validator passed.
(above mentioned commit required to pass validator).

Change-Id: I4a4a4083be4556bc46a4335d31ce56f834bd4f5a
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

Correct privilege levels for LogService

Correct the privilege levels for LogService as per
privilege registry under redfish specification.
https://redfish.dmtf.org/registries/Redfish_1.0.4_Privilege

Correct privilege levels for LogService

Correct the privilege levels for LogService as per
privilege registry under redfish specification.
https://redfish.dmtf.org/registries/Redfish_1.0.4_PrivilegeRegistry.json

1) ClearLog actions(EventLog, CrashDump, PostCode,
JournalLog etc..) are subordinates of LogService
should be executed with "ConfigureComponents"
privilege level.

2) For security reasons, Restricted CrashDump
(LogService and LogEntry) to "ConfigureComponents".

Tested:
- Created Operator, User and Administrator users
and validated all methods under LogService, LogEntry
LogServiceCollections and LogEntryCollections, its
subordinates.

Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
Change-Id: I4ce1ee90b3b999a80daa9aa20e5e7d79b64a9b85

show more ...

Redfish: Allow slash at the end of Resource

This is defined in the Redfish protocol.
Easiest way to allow this is to end the Node URL with "/", which most
Nodes in bmcweb already had.

Before:
curl

Redfish: Allow slash at the end of Resource

This is defined in the Redfish protocol.
Easiest way to allow this is to end the Node URL with "/", which most
Nodes in bmcweb already had.

Before:
curl -k https://${bmc}/redfish/v1/TaskService/
Not Found

After both /redfish/v1/TaskService/ and /redfish/v1/TaskService
return the Task Service.

Tested:
Validator passed.

Change-Id: Ic806dc5c91f631b87642e49b486a6b6da7fdf955
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Change EventLog Id to match odata.id

Could not find a hard rule to require the Id to match the last segment
of the URL/@odata.id but all Redfish mockups match this way, other bmcweb
resources do as

Change EventLog Id to match odata.id

Could not find a hard rule to require the Id to match the last segment
of the URL/@odata.id but all Redfish mockups match this way, other bmcweb
resources do as well, and redfishtool is easier to use if this is true.

Before:
$ python redfishtool.py -r xxxxxx -u xxxx -p xxxxxxx -S Always \
Systems Logs -i EventLog
5 Transport:getPathBy2:Match: failed match: matchProp=Id, matchValue=EventLog, readValue=Event Log

Tested:
Validator passed.

curl -k https://${bmc}/redfish/v1/Systems/system/LogServices/EventLog
{
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog",
"@odata.type": "#LogService.v1_1_0.LogService",
"Actions": {
"#LogService.ClearLog": {
"target": "/redfish/v1/Systems/system/LogServices/EventLog/Actions/LogService.ClearLog"
}
},
"Description": "System Event Log Service",
"Entries": {
"@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/Entries"
},
"Id": "EventLog",
"Name": "Event Log Service",
"OverWritePolicy": "WrapsWhenFull"

Change-Id: Ia324bebfcae65a195adbb3a4126100d82efde383
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Match BMCWeb crashdump to the D-Bus interface provided by crashdump

The crashdump service changed to eliminate hangs, and failures to
retrieve the crashdump data. The BMCWeb crashdump handling code

Match BMCWeb crashdump to the D-Bus interface provided by crashdump

The crashdump service changed to eliminate hangs, and failures to
retrieve the crashdump data. The BMCWeb crashdump handling code has to
be aligned with the server.

Tested:
Confirmed each of the primary functions operates as expected.
Getting the collection
Getting the entries
Forcing an on demand capture
Polling for the on demand capture to complete
Retrieving the creashdump data
Clearing all of the crashdump content
Ran service validator

Change-Id: Ie8fb48369a782d905b942c1f9bef11f387f6463e
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Log BIOS POST Codes Through Redfish

Added PostCodes MessageID, PostCodesLogService, PostCodesClear,
PostCodesEntry and PostCodesEntryCollection to redfish-core log_services.
Design document located

Log BIOS POST Codes Through Redfish

Added PostCodes MessageID, PostCodesLogService, PostCodesClear,
PostCodesEntry and PostCodesEntryCollection to redfish-core log_services.
Design document located at openbmc/docs/designs/redfish-postcodes.md:

Tested:
Build with changes in phosphor-dbus-interfaces
and phosphor-post-code-manager.
PostCode Collection and entries passed RedfishServiceValidator test.
Boot cycles are ordered so that B1 is for the most recent power on.

Reviewed redfish log contents against
design document that is mentioned above:
bmc/redfish/v1/Systems/system/LogServices
bmc/redfish/v1/Systems/system/LogServices/PostCodes
bmc/redfish/v1/Systems/system/LogServices/PostCodes/Entries

Send POST clear commands and verified PostCodes log is cleared and
boot cycle count is reset to 1.

Change-Id: I8de4d4749d1a17d590619d70670d279c01753b03
Signed-off-by: ZhikuiRen <zhikui.ren@intel.com>

show more ...

Task: Add payload support

This adds the payload values to task responses.

Tested: passed validator

Change-Id: I50467e28ce8142d198f916ea0c63bd413edcd524
Signed-off-by: James Feist <james.feist@linu

Task: Add payload support

This adds the payload values to task responses.

Tested: passed validator

Change-Id: I50467e28ce8142d198f916ea0c63bd413edcd524
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

log: Fix Validator

Should be updating state when finished, not status.

Tested: Validator passed again

Change-Id: Ida75eb480d7873c56e37f99b4a093be20362c9d6
Signed-off-by: James Feist <james.feist@l

log: Fix Validator

Should be updating state when finished, not status.

Tested: Validator passed again

Change-Id: Ida75eb480d7873c56e37f99b4a093be20362c9d6
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

task: add fwupdate support

This adds firmware update task service support. It adds
a match and updates the task value when the interface
changes.

Tested: On successful fwupdate task was created and

task: add fwupdate support

This adds firmware update task service support. It adds
a match and updates the task value when the interface
changes.

Tested: On successful fwupdate task was created and
updated correctly. On failed fwupdate the status went
to failed.

Change-Id: Id12cc5d5270e8e45498b665e78601c5c30775323
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add Success to Crashdump response

This adds the success message to the task when it is
finished.

Tested: Passed Validator

Change-Id: Ib1010249157c0be713ccfd076e93d9502471fc65
Signed-off-by: James

Add Success to Crashdump response

This adds the success message to the task when it is
finished.

Tested: Passed Validator

Change-Id: Ib1010249157c0be713ccfd076e93d9502471fc65
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add TaskService

This adds tasks service to Redfish and creates an
example for crashdump. The TaskData object creates
tasks that can be updated based on d-bus matches. It
also has a configurable time

Add TaskService

This adds tasks service to Redfish and creates an
example for crashdump. The TaskData object creates
tasks that can be updated based on d-bus matches. It
also has a configurable timeout using timers. Task
Monitor uses these task objects to reply with a 202
until the async task is done, then a 204 when it is
either failed or completed.

Messages support will come in future commit.

Tested: Validator passed, wrote script to poll monitor,
verified that got 202 with location header and retry-after
set correctly, then 204, then 404.

Change-Id: I109e671baa1c1eeff1a11ae578e7361bf6ef9f14
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

log service: Remove odata.context

Tested: Built this commit and the commits under it.
Loaded on a Witherspoon and ran validator.
No errors.
Change-Id: Id54bc61319f500c4122213bd0e0d6b

log service: Remove odata.context

Tested: Built this commit and the commits under it.
Loaded on a Witherspoon and ran validator.
No errors.
Change-Id: Id54bc61319f500c4122213bd0e0d6ba140c7c690
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move Crashdump to OemCrashdump

All other Oem Schemas start with Oem.
This is used by the update_schemas.py to determine an Oem
schema and is a reasonable requirement for Oem schemas.

https://github

Move Crashdump to OemCrashdump

All other Oem Schemas start with Oem.
This is used by the update_schemas.py to determine an Oem
schema and is a reasonable requirement for Oem schemas.

https://github.com/openbmc/bmcweb/blob/a3268f98f308ca7c8660b1ace44d5b9a40be204b/scripts/update_schemas.py#L43

Tested: Ran the validator against this change on a Witherspoon
with BMCWEB_ENABLE_REDFISH_CPU_LOG enabled and OemCheck
true. Validator passed. Might be worth running on a
system that actually uses BMCWEB_ENABLE_REDFISH_CPU_LOG.

curl -k https://${bmc}/redfish/v1/Systems/system/LogServices/Crashdump
{
"@odata.context": "/redfish/v1/$metadata#LogService.LogService",
"@odata.id": "/redfish/v1/Systems/system/LogServices/Crashdump",
"@odata.type": "#LogService.v1_1_0.LogService",
"Actions": {
"#LogService.ClearLog": {
"target": "/redfish/v1/Systems/system/LogServices/Crashdump/Actions/LogService.ClearLog"
},
"Oem": {
"#Crashdump.OnDemand": {
"target": "/redfish/v1/Systems/system/LogServices/Crashdump/Actions/Oem/Crashdump.OnDemand"
}
}
},
"Description": "Oem Crashdump Service",
"Entries": {
"@odata.id": "/redfish/v1/Systems/system/LogServices/Crashdump/Entries"
},
"Id": "Oem Crashdump",
"MaxNumberOfRecords": 3,
"Name": "Open BMC Oem Crashdump Service",
"OverWritePolicy": "WrapsWhenFull"
}

Change-Id: Iacc11be1284b99c2ed9a6c2ca0a936bd97855afb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Changed input data format for Crashdump.SendRawPeci

At present, the Crashdump.SendRawPeci redfish interface accepts one
PECI command at a time. Changed it to accept array of PECI commands
through wh

Changed input data format for Crashdump.SendRawPeci

At present, the Crashdump.SendRawPeci redfish interface accepts one
PECI command at a time. Changed it to accept array of PECI commands
through which multiple PECI commands can be aggregated into one redfish
call. Also provided backward compatibility for existing single PECI
command input format.

Tested:
Tested by aggregating 1000 PECI commands in one redfish call.
Tested by giving single PECI command with the existing format.

Change-Id: I05c547438ce9833519807b39347223183bdfb4ed
Signed-off-by: Karthick Sundarrajan <karthick.sundarrajan@intel.com>

show more ...

Return no-content instead of waiting for OnDemand

Since an OnDemand crashdump could take some time it may cause
the request to time out before the response can be sent.

The correct fix for this is

Return no-content instead of waiting for OnDemand

Since an OnDemand crashdump could take some time it may cause
the request to time out before the response can be sent.

The correct fix for this is to implement the Redfish Task Monitor
service to handle all asynchronous tasks. Until then, this
change will return 204 (no content) and add the OnDemand log to
the Entries list.

When Task Monitor is implemented it can return 202 (accepted) with
the location of the Task to poll.

Tested:
Used Postman to trigger the OnDemand action and immediately got a
204 response. Polled the Entries list and saw the OnDemand entry
after it was ready.

Change-Id: I3e2692ec5d377823072e0d610fa3ca17a9259a37
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Return 503 instead of 500 when Crashdump is busy

Tested:
Used Postman to send the OnDemand action twice and got a 503 with
a retry message on the second attempt.

Change-Id: I319a6318ee57e504a54b3fd

Return 503 instead of 500 when Crashdump is busy

Tested:
Used Postman to send the OnDemand action twice and got a 503 with
a retry message on the second attempt.

Change-Id: I319a6318ee57e504a54b3fdb6894a5aeb43af203
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Return a 404 instead of 500 for invalid Crashdump URIs

Tested:
Used a browser to request an invalid Crashdump URI and got a
404 with a resource not found error.

Change-Id: Idcac7868bb1f3b4c0248926b

Return a 404 instead of 500 for invalid Crashdump URIs

Tested:
Used a browser to request an invalid Crashdump URI and got a
404 with a resource not found error.

Change-Id: Idcac7868bb1f3b4c0248926b46be2cf4fce05328
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Add "Retry-After" header for temporarily unavailable messages

Whenever the Redfish response is that a service is temporarily
unavailable, the "Retry-After" header is added with the same
value, so ju

Add "Retry-After" header for temporarily unavailable messages

Whenever the Redfish response is that a service is temporarily
unavailable, the "Retry-After" header is added with the same
value, so just set the header automatically with the response.

Tested:
Confirmed that the "Retry-After" header is set correctly with
the Redfish temporarily unavailable message.

Change-Id: I9c940be94d9d284b9633c5caa2ce71ade76d22d5
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Replace all uses of NULL with nullptr

This was an automatic change made by clang-tidy. It moves all uses of
NULL to nullptr, which are equivalent, but nullptr is prefered.

Tested: Code compiles.

Replace all uses of NULL with nullptr

This was an automatic change made by clang-tidy. It moves all uses of
NULL to nullptr, which are equivalent, but nullptr is prefered.

Tested: Code compiles.

Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I9526599b222693c9723a69934b599c7a5b5d1fbf

show more ...

Add support for LogService.ClearLog to Crashdump

Tested:
Used Postman to send the LogService.ClearLog action on Crashdump
and verified that the existing logs were cleared and the next new
log starte

Add support for LogService.ClearLog to Crashdump

Tested:
Used Postman to send the LogService.ClearLog action on Crashdump
and verified that the existing logs were cleared and the next new
log started at ID 0.

Passed the Redfish Service Validator.

Change-Id: I9b895b3d2e1865add42e4c35c77f55c8832385da
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Enable autoexpand on the Crashdump LogEntryCollection

The current Crashdump LogEntry contains non-standard properties
and could be very large causing problems for autoexpand.

This change uses a Log

Enable autoexpand on the Crashdump LogEntryCollection

The current Crashdump LogEntry contains non-standard properties
and could be very large causing problems for autoexpand.

This change uses a LogEntry OEM type to specify a URI where the
full log can be retrieved and enables autoexpand on the
LogEntryCollection.

Tested:
Passed the Redfish Service Validator.

Change-Id: I6a402d216e6d8228ea2825ab4c6d02b9c8023fc5
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

Simplify the OnDemand Crashdump return data

Tested:
Ran an on-demand crashdump and confirmed that the output is
correct.

Change-Id: I993a36d3a6966433cbc6ede9e2d0702b319e3fd0
Signed-off-by: Jason M.

Simplify the OnDemand Crashdump return data

Tested:
Ran an on-demand crashdump and confirmed that the output is
correct.

Change-Id: I993a36d3a6966433cbc6ede9e2d0702b319e3fd0
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...

bmcweb: fix "Clear Event Logs" functionality behavior in System logs page on WebUI

When BMCWEB_ENABLE_REDFISH_DBUS_LOG_ENTRIES option set to ON that means bmcweb will look to phosphor-logging for an

bmcweb: fix "Clear Event Logs" functionality behavior in System logs page on WebUI

When BMCWEB_ENABLE_REDFISH_DBUS_LOG_ENTRIES option set to ON that means bmcweb will look to phosphor-logging for any D-Bus log entries.
These will then be translated to Redfish EventLog Entries. Thus, we can see those Redfish Eventlog Entries when select "Event" system log type in System logs page.

However, when this option set to ON, the "Clear Event Logs" functionality still clear /var/log/redfish file instead of
clear log through xyz.openbmc_project.Collection.DeleteAll interface by DeleteAll action.

It should to clear D-Bus log entries when BMCWEB_ENABLE_REDFISH_DBUS_LOG_ENTRIES option is ON.

Thus, we provide our modification for correct this functionality behavior.

Tested by: Nuvoton NPCM750 EVB and RunBMC Olympus platforms in WebUI.
when BMCWEB_ENABLE_REDFISH_DBUS_LOG_ENTRIES option is ON to clear D-Bus log entries,
and when option is OFF to clear /var/log/redfish log entries.

Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: I71445806ae5a79c2c0622908f7ac60daaa2119b8
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>

show more ...