Fix content-type return behavior for */*

An HTTP header of Accepts: */* throws a big wrench into our
implementation for a couple reasons. First, because it's the default in
a lot of commonly-used l

Fix content-type return behavior for */*

An HTTP header of Accepts: */* throws a big wrench into our
implementation for a couple reasons. First, because it's the default in
a lot of commonly-used libraries, and second, because clients use it
when they certainly don't mean what the specification says it should
mean "ie, I accept ANY type".

This commit tries to address some of that, by making an explicit option
for content-type="ANY" and pushes it to the individual callers to handle
explicitly as if it were yet another type. In most protocols, there's a
"most common" representation, so protocols are free to use that, or to
explicitly handle it, and require that the user be explicit.

Tested:
Redfish Protocol Validator no longer locks up. (TBD, getting bugs filed
with protocol validator for this missing Accepts header).

For ServiceRoot
GET /redfish/v1 Accepts: application/json - returns json
GET /redfish/v1 Accepts: */* - returns json
GET /redfish/v1 Accepts: text/html - returns html
GET /redfish/v1 no-accepts header - returns json

Redfish-service-validator passes.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iae6711ae587115d3e159a48a6fc46a903ed6c403

show more ...

LogService: System dump calls common dump handlers

This patchset transitions System dump route handlers to the new style
of calling common dump handlers via std::bind_front() instead of
defining a l

LogService: System dump calls common dump handlers

This patchset transitions System dump route handlers to the new style
of calling common dump handlers via std::bind_front() instead of
defining a lambda. BMC dump and FaultLog dump were previously
transitioned to the new style (see "LogService: Add support for Fault
Log" at https://gerrit.openbmc.org/c/openbmc/bmcweb/+/53175).

Note that System dump wasn't using a common dump handler for outputting
its LogService info (/redfish/v1/Systems/system/LogServices/Dump/)
before, so calling the common handler here is new.

No expected client impact.

Tested:

Get System dump LogService info:
curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Systems/system/LogServices/Dump/

(Diffed the ouput before and after applying this patchset and confirmed
they were equivalent except for the "DateTime", as expected. Also added
unit tests for getting dump LogService info.)

Create System dump entry. (Existing code for creating an entry via the
Redfish LogService action CollectDiagnosticData isn't currently working
for System dump, so instead directly call the corresponding D-Bus
method by running the following from the BMC console):
busctl call xyz.openbmc_project.Dump.Manager /xyz/openbmc_project/dump/system xyz.openbmc_project.Dump.Create CreateDump a{sv} 0

Get Entry:
curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Systems/system/LogServices/Dump/Entries/1

Get Entry Collection:
curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Systems/system/LogServices/Dump/Entries

Delete Entry:
curl -k -H "X-Auth-Token: $token" -X DELETE http://${bmc}/redfish/v1/Systems/system/LogServices/Dump/Entries/1

Clear Log:
curl -k -H "X-Auth-Token: $token" -X POST http://${bmc}/redfish/v1/Systems/system/LogServices/Dump/Actions/LogService.ClearLog

Redfish Service Validator succeeded on the following URI tree:
/redfish/v1/Systems/system/LogServices/Dump

Signed-off-by: Claire Weinan <cweinan@google.com>
Change-Id: I5d66da17794c29672be8713481018bf3ce397ddf

show more ...

Improve content type

We have a number of specialized content-type functions for varying
levels of degree, and most of them rely on quite a few strings. This
commit changes them to consolidate on tw

Improve content type

We have a number of specialized content-type functions for varying
levels of degree, and most of them rely on quite a few strings. This
commit changes them to consolidate on two APIs.

isContentTypeSupported, which as the name implies, takes a single
content type, and returns a bool about whether or not that content type
is allowed.

getPreferedContentType, which takes an array of multiple options, and
fine the first one in the list that matches the clients expected string.

These two functions makes these functions more able to be reused in the
future, and don't require specialized entries for each possible type or
combination of types that we need to check for.

Tested: Unit tests passing. Pretty good coverage.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I8b976d0cefec5f24e62fbbfae33d12cc803cb373

show more ...

Remove nlohmann brace initialization

There's a few last places (outside of tests) where we still use
nlohmann brace initialization. Per the transforms we've been doing,
move these to constructing t

Remove nlohmann brace initialization

There's a few last places (outside of tests) where we still use
nlohmann brace initialization. Per the transforms we've been doing,
move these to constructing the objects explicitly, using operator[],
nlohmann::object_t and nlohmann::array_t. Theses were found by manual
inspection grepping for all uses of nlohmann::json.

This is done to reduce binary size and reduce the number of intermediate
objects being constructed. This commit saves a trivial amount of size
(~4KB, Half a percent of total) and in addition but makes our
construction consistent.

Tested:
Redfish service validator passes.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I7478479a9fdc41b254eef325002d413c1fb411a0

show more ...

used sdbusplus::unpackPropertiesNoThrow part 8

used sdbusplus::unpackPropertiesNoThrow in other places, also replaced
all usages of "GetAll" with sdbusplus::asio::getAllProperties

bmcweb size:

used sdbusplus::unpackPropertiesNoThrow part 8

used sdbusplus::unpackPropertiesNoThrow in other places, also replaced
all usages of "GetAll" with sdbusplus::asio::getAllProperties

bmcweb size: 2697640 -> 2685336 (-12304)
compressed size: 1129728 -> 1126078 (-3650)

Tested:
- Executed redfish service validator, no new errors detected

Change-Id: I916e462e004fcbde67c209daef295de8f5fb68eb
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

show more ...

LogService: Increase Fault Log timestamp precision

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/55837 introduced support
for microsecond-precision timestamps in bmcweb.

Here we modify the Fault Lo

LogService: Increase Fault Log timestamp precision

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/55837 introduced support
for microsecond-precision timestamps in bmcweb.

Here we modify the Fault Log LogService
(/redfish/v1/Managers/bmc/LogServices/FaultLog) to use
microsecond-precision "Created" timestamps for its log entries. The
motivation for increased precision is to increase the chance of having
unique timestamps in case faults happen in quick succession. Unique
timestamps are helpful for data center tools to keep log entries in
chronological order and to track which entries have been seen before.

The "Created" timestamp is based on the "Elapsed" property of the
D-Bus interface xyz.openbmc_project.Time.EpochTime [1]. Dump entries
must implement xyz.openbmc_project.Time.EpochTime [2].

Note: our intention is to increase timestamp precision to microseconds
for all dump types. However at the moment the BMC dump and System dump
managers (in phosphor-debug-collector module) are not populating
EpochTime with microsecond precision as they should. So for now this
patchset only increases precision for the FaultLog dump type.

Changes to the Redfish tree:
Clients will now see microsecond-precision instead of second-precision
"Created" timestamps for fault log entries.

Tested:
Verified that Fault Log entries include microsecond-precision "Created"
timestamps both when entries are retrieved individually and as a
collection.

Example commands:
```
curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries

curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries/1
```

Example timestamp output:
"Created": "2022-07-12T15:56:33.017346+00:00",

Also verified that BMC dump and System dump "Created" timestamps remain
unchanged (they still use second-precision).

Example commands:
```
curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/Dump/Entries

curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Systems/system/LogServices/Dump/Entries
```

Redfish Service Validator succeeded on the following URI trees:
/redfish/v1/Managers/bmc/LogServices/FaultLog
/redfish/v1/Managers/bmc/LogServices/Dump

[1] https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Time/EpochTime.interface.yaml
[2] https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Dump/Entry.interface.yaml

Signed-off-by: Claire Weinan <cweinan@google.com>
Change-Id: I400a24def8dbeff1046b93f0bb64e04ae5038e9a

show more ...

Update content of ResourceNotFound/ResourceAlreadyExists message

According to Redfish Base Message Registry definition [1], the first
argument of ResourceNotFound and ResourceAlreadyExists is the sc

Update content of ResourceNotFound/ResourceAlreadyExists message

According to Redfish Base Message Registry definition [1], the first
argument of ResourceNotFound and ResourceAlreadyExists is the schema
name of the resource. This patch changes the first argument to non-
versioned schema name treewide.

Tested:
Verified the error message matches the definition, and Redfish Service
Validator passed.

[1] https://redfish.dmtf.org/registries/Base.1.13.0.json

Change-Id: Ib5cd853578ef0bffda1184d10827241e94faaf68
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

Fix function name handleLogServicesCollectionGet

Renamed handleLogServicesCollectionGet() to
handleBMCLogServicesCollectionGet() (added "BMC").

handleLogServicesCollectionGet() was a function first

Fix function name handleLogServicesCollectionGet

Renamed handleLogServicesCollectionGet() to
handleBMCLogServicesCollectionGet() (added "BMC").

handleLogServicesCollectionGet() was a function first introduced in
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/53175 but the function
name was accidentally made to be too broad. The function only handles
outputting the collection of LogServices specifically under
/redfish/v1/Managers/bmc/LogServices.

No expected client impact.

Tested:

Redfish Service Validator succeeded on the following URI:
/redfish/v1/Managers/bmc/LogServices/

Signed-off-by: Claire Weinan <cweinan@google.com>
Change-Id: I4648db2eaa5417c2428b514fdda1dbf82af0b3f0

show more ...

query_param: Move maxEntriesPerPage to Query struct

Putting the maxEntriesPerPage next to the top parameter makes it more
clear about its intention as Ed suggested. Here it is also renamed to
maxTop

query_param: Move maxEntriesPerPage to Query struct

Putting the maxEntriesPerPage next to the top parameter makes it more
clear about its intention as Ed suggested. Here it is also renamed to
maxTop to illustrate its relationship with top.

Tested:
Build, unit test and Redfish Service Validator passed.

Change-Id: I035eea7e33d78439685a81092a4dd9332cfc501a
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

LogServices: Fix dump timestamp regression

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/55468 was a refactoring
task that was not intended to have any client impact. However it had a
bug where it u

LogServices: Fix dump timestamp regression

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/55468 was a refactoring
task that was not intended to have any client impact. However it had a
bug where it unintentionally changed the “Created” timestamp of log
entries of all dump types to be smaller (earlier) than pre-refactoring.

Tested:

FaultLog entry before fix (timestamp too large--reported as max Redfish
time):
curl k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries/1
{
"@odata.id": "/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries/1",
"@odata.type": "#LogEntry.v1_8_0.LogEntry",
"Created": "9999-12-31T23:59:59+00:00",
"EntryType": "Event",
"Id": "1",
"Name": "FaultLog Dump Entry"
}

FaultLog entry after fix (timestamp reported correctly):
curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries/1
{
"@odata.id": "/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries/1",
"@odata.type": "#LogEntry.v1_8_0.LogEntry",
"Created": "2022-08-14T10:29:40+00:00",
"EntryType": "Event",
"Id": "1",
"Name": "FaultLog Dump Entry"
}

Tested similarly for a BMC Dump entry.

Interestingly, it seems like the System Dump entry timestamp before the
refactoring task was too small, and the bug actually helped to correct
it. In any case, this change reverts timestamp behavior to match what it
was pre-refactoring.

Redfish Service Validator succeeded on the following URI trees:
/redfish/v1/Managers/bmc/LogServices/FaultLog
/redfish/v1/Managers/bmc/LogServices/Dump
/redfish/v1/Systems/system/LogServices/Dump

Signed-off-by: Claire Weinan <cweinan@google.com>
Change-Id: I7badbd348595a7bcb61982a4cd6b7e82a16b0219

show more ...

Move time utils to be in one place

We've accumulated several time utility functions in the http classes.
Time isn't a core HTTP primitive, so http is not where those functions
below.

This commit mo

Move time utils to be in one place

We've accumulated several time utility functions in the http classes.
Time isn't a core HTTP primitive, so http is not where those functions
below.

This commit moves all the time functions from the crow::utility
namespace into the redfish::time_utils namespace, as well as moves the
unit tests.

No code changes where made to the individual functions, with the
exception of changing the namespace on the unit tests.

Tested: Unit tests pass.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I8493375f60aea31899c84ae703e0f71a17dbdb73

show more ...

dbus_utility: Remove ManagedItem type alias

Type alias ManagedItem is identical to ManagedObjectType::value_type,
remove it.

Tested:
Build pass. No significant change in compressed binary size.

Ch

dbus_utility: Remove ManagedItem type alias

Type alias ManagedItem is identical to ManagedObjectType::value_type,
remove it.

Tested:
Build pass. No significant change in compressed binary size.

Change-Id: I6d0f0498399ee639d8a5445fe908a7c311327e41
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

Use enum overload for field setting

There are two overloads of addHeader, one that takes a string, and one
that takes a boost enum. For most common headers, boost contains a
string table with all o

Use enum overload for field setting

There are two overloads of addHeader, one that takes a string, and one
that takes a boost enum. For most common headers, boost contains a
string table with all of those entries anyway, so there's no point in
duplicating the strings, and ensures that we don't make trivial
mistakes, like capitalization or - versus underscore that aren't caught
at compile time.

Tested:
This saves a trivial amount (572 bytes) of compressed binary size.

curl --insecure -vvv --user root:0penBmc https://192.168.7.2/redfish/v1

returns < Content-Type: application/json

curl --insecure -vvv -H "Accept: text/html" --user root:0penBmc https://192.168.7.2/redfish/v1

Returns
< Content-Type: text/html;charset=UTF-8

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I34c198b4f9e219247fcfe719f9b3616d35aea3dc

show more ...

Return proper redfish errors for createDump call

Currently, only internal server error will be returned to a client when
there is a create dump dbus call failure in the backend, irrespective
of the

Return proper redfish errors for createDump call

Currently, only internal server error will be returned to a client when
there is a create dump dbus call failure in the backend, irrespective
of the error that's returned by the phosphor-dump-manager.

This change will send a proper error response to the user based on the
host state.

Tested By:

curl -k -H "X-Auth-Token: $bmc_token" -X POST https://${bmc}
/redfish/v1/Systems/system/LogServices/Dump/Actions/
LogService.CollectDiagnosticData -d
'{"DiagnosticDataType":"OEM", "OEMDiagnosticDataType":"Resource_vps_str"}'
{
"error": {
"@Message.ExtendedInfo": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The request could not be performed because the resource is in standby.",
"MessageArgs": [],
"MessageId": "Base.1.8.1.ResourceInStandby",
"MessageSeverity": "Critical",
"Resolution": "Ensure that the resource is in the correct power state and resubmit the request."
}
],
"code": "Base.1.8.1.ResourceInStandby",
"message": "The request could not be performed because the resource is in standby."
}
}

curl -k -H "X-Auth-Token: $bmc_token" -X POST
https://${bmc}/redfish/v1/Managers/bmc/LogServices/
Dump/Actions/LogService.CollectDiagnosticData -d '{"DiagnosticDataType":"Manager"}'
{
"error": {
"@Message.ExtendedInfo": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The operation failed because the service at /redfish/v1/Managers/bmc/LogServices/Dump/ is disabled and cannot accept requests.",
"MessageArgs": [
"/redfish/v1/Managers/bmc/LogServices/Dump/"
],
"MessageId": "Base.1.11.0.ServiceDisabled",
"MessageSeverity": "Warning",
"Resolution": "Enable the service and resubmit the request if the operation failed."
}
],
"code": "Base.1.11.0.ServiceDisabled",
"message": "The operation failed because the service at /redfish/v1/Managers/bmc/LogServices/Dump/ is disabled and cannot accept requests."
}
}

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: Ica087e4cac2beeded896f0c83c9481f8164d2c62

show more ...

Drop boost::posix_time

Per the coding standard, if we can support what we need to do with
std variants of something, we should prefer that. This commit adds an
iso8160 to string method that support

Drop boost::posix_time

Per the coding standard, if we can support what we need to do with
std variants of something, we should prefer that. This commit adds an
iso8160 to string method that supports any arbitrary
std::chrono::duration object, which allows doing the full range of all
of our integer types, and reduces the complexity (and presumably compile
times) not pulling in a complex library.

Despite the heavy templating, this only appears to add 108 bytes of
compressed binary size to bmcweb. This is likely due to the decreased
complexity compared to the boost variant (that likely pulls in
boost::locale). (Ie 3 template instantiations of the simple one take
about the same binary space as 1 complex instantiation).

Tested:
Unit tests pass (pretty good coverage here)

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I78200fb391b601eba8d2bfd2de0dd868e4390d6b

show more ...

log_services: PostCode: Do not populate nextLink when reaches end

According to Redfish spec 9.6.12 Next link (Members@odata.nextLink)
property, it shall only be present if the number of members in t

log_services: PostCode: Do not populate nextLink when reaches end

According to Redfish spec 9.6.12 Next link (Members@odata.nextLink)
property, it shall only be present if the number of members in the
resource collection is greater than the number of members returned,
and if the payload does not represent the end of the requested resource
collection. This patch fixes the issue that the nextLink property will
always be present even if the request reaches end in PostCode LogEntry
collection.

Tested:
Verified Members@odata.nextLink in PostCode LogEntry collection is only
populated when ($top + $skip < Members@odata.count).
Redfish Service Validator passed.

Change-Id: I24feca331b279f62f00259e9ec5ca9a8d4c19557
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

LogService: Refactor dump entry parsing

Refactored common code for parsing dump entry information from D-Bus
response objects (shared by getDumpEntryCollection() and
getDumpEntryById()) into a new f

LogService: Refactor dump entry parsing

Refactored common code for parsing dump entry information from D-Bus
response objects (shared by getDumpEntryCollection() and
getDumpEntryById()) into a new function parseDumpEntryFromDbusObject().
The parsing is similar to what is done by parseCrashdumpParameters().

This refactoring is being done in anticipation of adding additional
D-Bus property parsing for dump entries (without this refactoring,
code duplication will increase).

No noticeable client impact.

Tested:

Get dump entries individually and as a collection.
Example commands:
curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries

curl -k -H "X-Auth-Token: $token" -X GET
http://${bmc}/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries/1

curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/Dump/Entries

curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/Dump/Entries/1

Redfish Service Validator succeeded on the following URI trees:
/redfish/v1/Managers/bmc/LogServices/FaultLog
/redfish/v1/Managers/bmc/LogServices/Dump
/redfish/v1/Systems/system/LogServices/Dump

Signed-off-by: Claire Weinan <cweinan@google.com>
Change-Id: If67fb0c1f35175ae0e2968f8d7a52c13e66b1dc7

show more ...

log_service: crashdump entry: remove app

clang14 complains about
"lambda capture 'app' is not used [-Werror,-Wunused-lambda-capture]".

This commit removes app. Originally app is used in Redfish rou

log_service: crashdump entry: remove app

clang14 complains about
"lambda capture 'app' is not used [-Werror,-Wunused-lambda-capture]".

This commit removes app. Originally app is used in Redfish route but we
removed that since crashdump files are not Redfish resources.

Tested: code compiles. Strong type guarantees the correctness.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I935906097fdae3f975f2435adc4964bb7dd3875f

show more ...

Query param: fix regression in top parameters

With the inclusion of ce8ea743055f1b82c60790db40aa3295e03bdf9c it looks
like we're now returning 400 error codes, with a response error of
QueryNotSuppo

Query param: fix regression in top parameters

With the inclusion of ce8ea743055f1b82c60790db40aa3295e03bdf9c it looks
like we're now returning 400 error codes, with a response error of
QueryNotSupportedOnResource for resources which don't support top and
skip (like RegistryFile). This would imply that the Query object NEEDS
a way to represent "user didn't provide us a skip/top parameter" which
arguably means this needs to go back to a std::optional<size_t>.

The error gets added from:
https://github.com/openbmc/bmcweb/blob/d5c80ad9c07b94465d8ea62d2b6f87c30cac765e/redfish-core/include/utils/query_param.hpp#L304
and appears to be a basic logic error in that now all queries assume
that the user provided top and skip, which fails for non-collections.

This commit moves that direction, changing the Query object back to
std::optional<size_t>. This has the unintended consequence of now
putting the idea of "defaults" back into the per-delegated handlers. This
seems reasonable, as arguably the defaults for each individual collection
are going to be different, and at some point we might want to take advant
age of that.

Tested:
1. Tested on Romulus QEMU. All passed.
2. Tested on s7106, Validator passed.

Signed-off-by: Ed Tanous <edtanous@google.com>
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I9f912957d130694b281c6e391602de158eaddcb3

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I46a5eec210002af84239af74a93c830b1d4a13f1

show more ...

LogService: Remove setUpRedfishRoute in crashdump

Crash dump files aren't Redfish resources, so the handler should not
call `setUpRedfishRoute`.

Tested: Can still get crash dump, but OData-Version

LogService: Remove setUpRedfishRoute in crashdump

Crash dump files aren't Redfish resources, so the handler should not
call `setUpRedfishRoute`.

Tested: Can still get crash dump, but OData-Version header is not set.
Change-Id: Ib03ea44f840d96f0465057cc66a424f70f197993
Signed-off-by: Shounak Mitra <shounak@google.com>

show more ...

Use more specific include

Per the coding standard, we should be using the most specific version of
the boost header we rely on.

Tested: Code compiles

Signed-off-by: Ed Tanous <edtanous@google.com>

Use more specific include

Per the coding standard, we should be using the most specific version of
the boost header we rely on.

Tested: Code compiles

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I76dd5a93c10c17d950b0dbac69183dd622363bce

show more ...

Remove usages of boost::starts/ends_with

Per the coding standard, now that C++ supports std::string::starts_with
and std::string::ends_with, we should be using them over the boost
alternatives. Thi

Remove usages of boost::starts/ends_with

Per the coding standard, now that C++ supports std::string::starts_with
and std::string::ends_with, we should be using them over the boost
alternatives. This commit goes through and updates all usages.

Arguably some of these are incorrect, and instances of common error 13,
but because this is mostly a mechanical it intentionally doesn't try to
handle it.

Tested: Unit tests pass.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ic4c6e5d0da90f7442693199dc691a47d2240fa4f

show more ...

Use nlohmann::json::object_t for dump entries

This is a similar change that was recently made for other entry types,
so also applying for dump entries.

I don't have a system that uses this resource

Use nlohmann::json::object_t for dump entries

This is a similar change that was recently made for other entry types,
so also applying for dump entries.

I don't have a system that uses this resource, so I'm not able to test
this change.

Change-Id: I74ba2f05658c6c53d7e397e03aad31a44c7c3280
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>

show more ...

Fix const correctness issues

cppcheck correctly notes that a lot of variables in the new code can be
const. Make most of them const.

Tested: WIP

Signed-off-by: Ed Tanous <edtanous@google.com>
Cha

Fix const correctness issues

cppcheck correctly notes that a lot of variables in the new code can be
const. Make most of them const.

Tested: WIP

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I8f37b6353fd707923f533e1d61c5b5419282bf23

show more ...