Add version to BaseBiosTable to prevent data loss

The initial version of the Base BIOS table did not support Value Display
Names (VDN). Support for VDN was introduced in a commit [1]. A BMC image
cr

Add version to BaseBiosTable to prevent data loss

The initial version of the Base BIOS table did not support Value Display
Names (VDN). Support for VDN was introduced in a commit [1]. A BMC image
created without VDN support stores data in the old BaseBiosTable format.
If a new BMC image (with VDN support) is flashed over an older image
(without VDN support), the BIOS manager attempts to read the binary
archive generated by the older BIOS settings manager. Since it doesn't
recognize the newly added property, it assumes the persisted file is
corrupted and ignores all the saved settings.

To prevent the loss of persisted BIOS data, the versioning support
provided by the Cereal library is used. This version information is
utilized to convert the persisted data into the current supported
format.

[1]: https://github.com/openbmc/bios-settings-mgr/commit/1a448ad88fdaec7e082b4a1c437f7f3c990402cd

Change-Id: If68be37e32ae31d7338d8933df945453a30c113a
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

Fix log message for integer property validation

Update error log message to clarify that the expected variant type is
an integer for Integer properties.

Change-Id: Ie9c5aa53755d146d6c7543397e13396f

Fix log message for integer property validation

Update error log message to clarify that the expected variant type is
an integer for Integer properties.

Change-Id: Ie9c5aa53755d146d6c7543397e13396f745bc72e
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Remove duplicated block comments in copyrights

All the copyright headers from the repository seems to have duplicated
block comments. Removing them.

Change-Id: I13ab1a10e60de14f740bac52624e1c7ac672

Remove duplicated block comments in copyrights

All the copyright headers from the repository seems to have duplicated
block comments. Removing them.

Change-Id: I13ab1a10e60de14f740bac52624e1c7ac672eafc
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

deserialize: Handle wide range of exceptions

We seem to only catch std::length_error exception and cereal exception,
but all the other exceptions like std::bad_alloc are ignored. This
commit would e

deserialize: Handle wide range of exceptions

We seem to only catch std::length_error exception and cereal exception,
but all the other exceptions like std::bad_alloc are ignored. This
commit would ensure that we catch wide range of exceptions and makes
sure we delete the corrpted file in all error scenarios.

Change-Id: Ia607ec18fdce3385fb4857d9a0608f5d8d1e8704
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Add error handling in serialize() & deserialize()

Refined the serialize and deserialize functions to incorporate robust
error handling. These checks would safeguard the application against
potential

Add error handling in serialize() & deserialize()

Refined the serialize and deserialize functions to incorporate robust
error handling. These checks would safeguard the application against
potential runtime crashes.

Change-Id: I39923feeb489a5270b961278118abcc7f4c31dee
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

fix JSON syntax in readme file

hexadecimal numbers are not a valid json values, this commit fixes it.

Change-Id: Id204f09dfc674e71fb029ec08304c9d71a4d5579
Signed-off-by: Manojkiran Eda <manojkiran.

fix JSON syntax in readme file

hexadecimal numbers are not a valid json values, this commit fixes it.

Change-Id: Id204f09dfc674e71fb029ec08304c9d71a4d5579
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

manager: allow running at non-standard path

Add an optional argument to the daemon to allow the persistent
location to be a non-standard path. This enables running the
application as a normal user

manager: allow running at non-standard path

Add an optional argument to the daemon to allow the persistent
location to be a non-standard path. This enables running the
application as a normal user on a developer system rather than
requiring it to be installed in a full BMC image.

Tested:

Ran with `biosconfig-manager /tmp/bios-config-manager`:

```
$ busctl --user tree xyz.openbmc_project.BIOSConfigManager
└─ /xyz
└─ /xyz/openbmc_project
└─ /xyz/openbmc_project/bios_config
├─ /xyz/openbmc_project/bios_config/manager
└─ /xyz/openbmc_project/bios_config/password
```

Change-Id: I42f688e233060c43983d2690facbb1026e678c77
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

gitignore: use typical conventions

Use the typical .gitignore format used by many repositories in
the organization to ignore the build directories and extracted
subproject directories, but not the w

gitignore: use typical conventions

Use the typical .gitignore format used by many repositories in
the organization to ignore the build directories and extracted
subproject directories, but not the wrap files themselves.

Change-Id: Ibd22cb922172abb8e2ad420a20c95823a4696e68
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

remove meson.options

The only option in this repository is configuring the location
of the persistent file location. This is not ever leveraged
by anyone. Reduce the complexity of maintaining a me

remove meson.options

The only option in this repository is configuring the location
of the persistent file location. This is not ever leveraged
by anyone. Reduce the complexity of maintaining a meson.option
to hold a string and just move it to a constant in a header.

Change-Id: I066d88d2831d1d04fd53b47e26cd6fbcabf863d2
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Improve the documentation of bios-settings-mgr

The existing documentation in bios-settings-mgr does not follow any
markdown format, its just bascailly written as a dump of dbus data &
in its state n

Improve the documentation of bios-settings-mgr

The existing documentation in bios-settings-mgr does not follow any
markdown format, its just bascailly written as a dump of dbus data &
in its state no one really cannot understand what it does by reading
the writeup. This commit aims at improving it.

Change-Id: Ib18724b943c9c4889fdf32721c69940a0777faf4
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Format meson files with meson.format

Meson 1.5.0 introduced a new feature to format all the meson
files. Formatting all the meson files is now as simple as running
`meson format -i -r` command in th

Format meson files with meson.format

Meson 1.5.0 introduced a new feature to format all the meson
files. Formatting all the meson files is now as simple as running
`meson format -i -r` command in the repository root folder.

more details : https://mesonbuild.com/Commands.html#format

Change-Id: I6069be2f872e9bbd1e894282fa2c06cf68791e0d
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

OWNERS: Remove surya as a maintainer

I would like to take a moment to acknowledge Surya's valuable
contributions. We greatly appreciate his dedication, particularly in
designing the bios-settings-mg

OWNERS: Remove surya as a maintainer

I would like to take a moment to acknowledge Surya's valuable
contributions. We greatly appreciate his dedication, particularly in
designing the bios-settings-mgr architecture. His work ensured
compatibility for both Intel (using IPMI as the communication
mechanism) and other companies, such as IBM (using PLDM as the
communication mechanism).

However, over the past couple of years, there has been a lack of active
contributions from Surya. He has not significantly engaged in reviews
or discussions during this time. Despite multiple concerns raised at
the TOF about pending changes, we have not received any responses from
him.

To ensure that our maintainer team remains active and responsive,
facilitating timely reviews and support for ongoing projects, we have
decided to remove Surya as a maintainer. We wish him the very best in
his future endeavors.

I will leave this decision open for review for a couple of days. If we
do not receive any response from Surya, I will proceed with merging the
changes.

Change-Id: Ibf4ae3fb12b670d43107aa026be31ba8b10efc40
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR seria

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR serialization)
Subproject subprojects/cereal is buildable: NO (disabling)
"""
Since cereal requires boost only for the sandbox build and this
functionality is not needed, add option to skip building performance
sandbox comparison to solve the issue.

Tested:
"meson setup build" no longer fails with the cereal error.

Change-Id: I130455e22b3b0a419fb0cf31a300a333c713d0ae
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Provide wrap file for boost

Currently local build on the system without boost can fail with
the following message:
"""
meson.build: ERROR: Dependency "boost" not found, tried system
"""
Provi

meson: Provide wrap file for boost

Currently local build on the system without boost can fail with
the following message:
"""
meson.build: ERROR: Dependency "boost" not found, tried system
"""
Provide "boost.wrap" file to fix the issue.

Change-Id: I6ed5fb9ec69f6a3bb778cf6797ae4d303a4222ea
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

Format meson files with meson.format

Meson 1.5.0 introduced a new feature to format all the meson
files. Formatting all the meson files is now as simple as running
`meson format -i -r` command in th

Format meson files with meson.format

Meson 1.5.0 introduced a new feature to format all the meson
files. Formatting all the meson files is now as simple as running
`meson format -i -r` command in the repository root folder.

more details : https://mesonbuild.com/Commands.html#format

Change-Id: I44489d726c70531312127cd9908a0d87543adcdf
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

README.md: Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
MD034/no-bare-urls Bare URL used [Context: "https://github.com/openbmc/doc..."]
```
Refer to ma

README.md: Fix MD034 warnings

The following warnings are generated by using markdownlint analysis:
```
MD034/no-bare-urls Bare URL used [Context: "https://github.com/openbmc/doc..."]
```
Refer to markdown-lint [1] to fix MD034
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/034-no-bare-urls.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I6f02c30bc4a2dc93d40bfc2ad78f00f2ea8aa10b

show more ...

README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Cont

README.md: Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "Remote BIOS Configuration via ..."]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ie015947b88fa9a4f9121639f572b9d08efc4d2bd

show more ...

meson: switch code dependency to libsystemd

For a while now systemd has packaged a separate `libsystemd`. For
meson dependency, `systemd` should be used when looking for systemd
service file paths

meson: switch code dependency to libsystemd

For a while now systemd has packaged a separate `libsystemd`. For
meson dependency, `systemd` should be used when looking for systemd
service file paths and `libsystemd` should be used for `sd_*` functions.

Update the dependency accordingly.

Change-Id: Iab1cb22a31bed0814e993194a6a3383a2e5ba24b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

OWNERS: Add Manoj as an owner

The bios-setting-mgr repository has been in maintenance mode for almost
a couple of years now, and there seems to be a lack of active reviewers
and maintainers. Given t

OWNERS: Add Manoj as an owner

The bios-setting-mgr repository has been in maintenance mode for almost
a couple of years now, and there seems to be a lack of active reviewers
and maintainers. Given that we do not anticipate much active
development in this repo, I would be happy to step in as a maintainer
and ensure that we adhere to upstream coding, C++, and clang standards,
keeping the repository in alignment with the latest practices. I look
forward to helping with the ongoing maintenance and ensuring smooth
support.

Change-Id: I32874939a453b948a6375443629c2f29b644e3c7
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I16de1731b6a2549fb11ca4115a9e477001c1f403
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I90ab45c236c5f818cf0b9257daed59421aa44143
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Update cereal dependency

It seems that, we cannot directly make the cereal packages as required,
since the libcereal bitbake recipe does not seem to supply the necessary
package config files which m

Update cereal dependency

It seems that, we cannot directly make the cereal packages as required,
since the libcereal bitbake recipe does not seem to supply the necessary
package config files which meson build system could find using the
dependency() call.

The libcereal bitbake recipe does not seem to put the package
config files but seem to install the necessary header files into the
includes, so mark the cereal dependency as not required, but
add the checks for finding the necessary cereal headers rather than
the package config file.

Just copied the cereal dependency check code from other repositories
like phosphor-state-manager & pldm.

Tested by :
1. Did a bitbake build with this change and made sure that the
bios-config-mgr builds & figure outs the cereal dependency.

Change-Id: Ib1139bfc41024a9f29953ed0427fa9fc0bbf238c
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Remove an unused variable

This commit removes biosPasswordFile variable which is not used
anywhere in the code.

Tested by:
1. Removed the un-used variable and daemon still compiles and builds. So t

Remove an unused variable

This commit removes biosPasswordFile variable which is not used
anywhere in the code.

Tested by:
1. Removed the un-used variable and daemon still compiles and builds. So this commit is removing an already dead code. Functionally this does not impact any features.

Change-Id: Ic3a1642bff20977d34270e9d9015feee320db374
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Add missing cereal dependency

The repository uses cereal as a serialization library to persist
the dbus object changes.So we better add it to the dependency list
so that , there will be an explicit

Add missing cereal dependency

The repository uses cereal as a serialization library to persist
the dbus object changes.So we better add it to the dependency list
so that , there will be an explicit checking in the configuration
stage rather than bailing out with a compile failure.

Change-Id: Id674c3a1eb47d9df9a9aaeaba278509f467765b8
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Add missing nlohmann_json dependency

The bios-password part of code relies on seed file which is
in JSON format and also uses the nlohmann parse functions to
parse it, so add it to the dependency li

Add missing nlohmann_json dependency

The bios-password part of code relies on seed file which is
in JSON format and also uses the nlohmann parse functions to
parse it, so add it to the dependency list.

Change-Id: I7f4ab5a79f8909ee527861a9275ddc2282599a67
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...