xref: /openbmc/linux/drivers/gpu/drm/msm/dsi/dsi_manager.c (revision 4b4f3acc)
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3  * Copyright (c) 2015, The Linux Foundation. All rights reserved.
4  */
5 
6 #include "msm_kms.h"
7 #include "dsi.h"
8 
9 #define DSI_CLOCK_MASTER	DSI_0
10 #define DSI_CLOCK_SLAVE		DSI_1
11 
12 #define DSI_LEFT		DSI_0
13 #define DSI_RIGHT		DSI_1
14 
15 /* According to the current drm framework sequence, take the encoder of
16  * DSI_1 as master encoder
17  */
18 #define DSI_ENCODER_MASTER	DSI_1
19 #define DSI_ENCODER_SLAVE	DSI_0
20 
21 struct msm_dsi_manager {
22 	struct msm_dsi *dsi[DSI_MAX];
23 
24 	bool is_dual_dsi;
25 	bool is_sync_needed;
26 	int master_dsi_link_id;
27 };
28 
29 static struct msm_dsi_manager msm_dsim_glb;
30 
31 #define IS_DUAL_DSI()		(msm_dsim_glb.is_dual_dsi)
32 #define IS_SYNC_NEEDED()	(msm_dsim_glb.is_sync_needed)
33 #define IS_MASTER_DSI_LINK(id)	(msm_dsim_glb.master_dsi_link_id == id)
34 
35 static inline struct msm_dsi *dsi_mgr_get_dsi(int id)
36 {
37 	return msm_dsim_glb.dsi[id];
38 }
39 
40 static inline struct msm_dsi *dsi_mgr_get_other_dsi(int id)
41 {
42 	return msm_dsim_glb.dsi[(id + 1) % DSI_MAX];
43 }
44 
45 static int dsi_mgr_parse_dual_dsi(struct device_node *np, int id)
46 {
47 	struct msm_dsi_manager *msm_dsim = &msm_dsim_glb;
48 
49 	/* We assume 2 dsi nodes have the same information of dual-dsi and
50 	 * sync-mode, and only one node specifies master in case of dual mode.
51 	 */
52 	if (!msm_dsim->is_dual_dsi)
53 		msm_dsim->is_dual_dsi = of_property_read_bool(
54 						np, "qcom,dual-dsi-mode");
55 
56 	if (msm_dsim->is_dual_dsi) {
57 		if (of_property_read_bool(np, "qcom,master-dsi"))
58 			msm_dsim->master_dsi_link_id = id;
59 		if (!msm_dsim->is_sync_needed)
60 			msm_dsim->is_sync_needed = of_property_read_bool(
61 					np, "qcom,sync-dual-dsi");
62 	}
63 
64 	return 0;
65 }
66 
67 static int dsi_mgr_setup_components(int id)
68 {
69 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
70 	struct msm_dsi *other_dsi = dsi_mgr_get_other_dsi(id);
71 	struct msm_dsi *clk_master_dsi = dsi_mgr_get_dsi(DSI_CLOCK_MASTER);
72 	struct msm_dsi *clk_slave_dsi = dsi_mgr_get_dsi(DSI_CLOCK_SLAVE);
73 	struct msm_dsi_pll *src_pll;
74 	int ret;
75 
76 	if (!IS_DUAL_DSI()) {
77 		ret = msm_dsi_host_register(msm_dsi->host, true);
78 		if (ret)
79 			return ret;
80 
81 		msm_dsi_phy_set_usecase(msm_dsi->phy, MSM_DSI_PHY_STANDALONE);
82 		src_pll = msm_dsi_phy_get_pll(msm_dsi->phy);
83 		if (IS_ERR(src_pll))
84 			return PTR_ERR(src_pll);
85 		ret = msm_dsi_host_set_src_pll(msm_dsi->host, src_pll);
86 	} else if (!other_dsi) {
87 		ret = 0;
88 	} else {
89 		struct msm_dsi *master_link_dsi = IS_MASTER_DSI_LINK(id) ?
90 							msm_dsi : other_dsi;
91 		struct msm_dsi *slave_link_dsi = IS_MASTER_DSI_LINK(id) ?
92 							other_dsi : msm_dsi;
93 		/* Register slave host first, so that slave DSI device
94 		 * has a chance to probe, and do not block the master
95 		 * DSI device's probe.
96 		 * Also, do not check defer for the slave host,
97 		 * because only master DSI device adds the panel to global
98 		 * panel list. The panel's device is the master DSI device.
99 		 */
100 		ret = msm_dsi_host_register(slave_link_dsi->host, false);
101 		if (ret)
102 			return ret;
103 		ret = msm_dsi_host_register(master_link_dsi->host, true);
104 		if (ret)
105 			return ret;
106 
107 		/* PLL0 is to drive both 2 DSI link clocks in Dual DSI mode. */
108 		msm_dsi_phy_set_usecase(clk_master_dsi->phy,
109 					MSM_DSI_PHY_MASTER);
110 		msm_dsi_phy_set_usecase(clk_slave_dsi->phy,
111 					MSM_DSI_PHY_SLAVE);
112 		src_pll = msm_dsi_phy_get_pll(clk_master_dsi->phy);
113 		if (IS_ERR(src_pll))
114 			return PTR_ERR(src_pll);
115 		ret = msm_dsi_host_set_src_pll(msm_dsi->host, src_pll);
116 		if (ret)
117 			return ret;
118 		ret = msm_dsi_host_set_src_pll(other_dsi->host, src_pll);
119 	}
120 
121 	return ret;
122 }
123 
124 static int enable_phy(struct msm_dsi *msm_dsi, int src_pll_id,
125 		      struct msm_dsi_phy_shared_timings *shared_timings)
126 {
127 	struct msm_dsi_phy_clk_request clk_req;
128 	int ret;
129 	bool is_dual_dsi = IS_DUAL_DSI();
130 
131 	msm_dsi_host_get_phy_clk_req(msm_dsi->host, &clk_req, is_dual_dsi);
132 
133 	ret = msm_dsi_phy_enable(msm_dsi->phy, src_pll_id, &clk_req);
134 	msm_dsi_phy_get_shared_timings(msm_dsi->phy, shared_timings);
135 
136 	return ret;
137 }
138 
139 static int
140 dsi_mgr_phy_enable(int id,
141 		   struct msm_dsi_phy_shared_timings shared_timings[DSI_MAX])
142 {
143 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
144 	struct msm_dsi *mdsi = dsi_mgr_get_dsi(DSI_CLOCK_MASTER);
145 	struct msm_dsi *sdsi = dsi_mgr_get_dsi(DSI_CLOCK_SLAVE);
146 	int src_pll_id = IS_DUAL_DSI() ? DSI_CLOCK_MASTER : id;
147 	int ret;
148 
149 	/* In case of dual DSI, some registers in PHY1 have been programmed
150 	 * during PLL0 clock's set_rate. The PHY1 reset called by host1 here
151 	 * will silently reset those PHY1 registers. Therefore we need to reset
152 	 * and enable both PHYs before any PLL clock operation.
153 	 */
154 	if (IS_DUAL_DSI() && mdsi && sdsi) {
155 		if (!mdsi->phy_enabled && !sdsi->phy_enabled) {
156 			msm_dsi_host_reset_phy(mdsi->host);
157 			msm_dsi_host_reset_phy(sdsi->host);
158 
159 			ret = enable_phy(mdsi, src_pll_id,
160 					 &shared_timings[DSI_CLOCK_MASTER]);
161 			if (ret)
162 				return ret;
163 			ret = enable_phy(sdsi, src_pll_id,
164 					 &shared_timings[DSI_CLOCK_SLAVE]);
165 			if (ret) {
166 				msm_dsi_phy_disable(mdsi->phy);
167 				return ret;
168 			}
169 		}
170 	} else {
171 		msm_dsi_host_reset_phy(msm_dsi->host);
172 		ret = enable_phy(msm_dsi, src_pll_id, &shared_timings[id]);
173 		if (ret)
174 			return ret;
175 	}
176 
177 	msm_dsi->phy_enabled = true;
178 
179 	return 0;
180 }
181 
182 static void dsi_mgr_phy_disable(int id)
183 {
184 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
185 	struct msm_dsi *mdsi = dsi_mgr_get_dsi(DSI_CLOCK_MASTER);
186 	struct msm_dsi *sdsi = dsi_mgr_get_dsi(DSI_CLOCK_SLAVE);
187 
188 	/* disable DSI phy
189 	 * In dual-dsi configuration, the phy should be disabled for the
190 	 * first controller only when the second controller is disabled.
191 	 */
192 	msm_dsi->phy_enabled = false;
193 	if (IS_DUAL_DSI() && mdsi && sdsi) {
194 		if (!mdsi->phy_enabled && !sdsi->phy_enabled) {
195 			msm_dsi_phy_disable(sdsi->phy);
196 			msm_dsi_phy_disable(mdsi->phy);
197 		}
198 	} else {
199 		msm_dsi_phy_disable(msm_dsi->phy);
200 	}
201 }
202 
203 struct dsi_connector {
204 	struct drm_connector base;
205 	int id;
206 };
207 
208 struct dsi_bridge {
209 	struct drm_bridge base;
210 	int id;
211 };
212 
213 #define to_dsi_connector(x) container_of(x, struct dsi_connector, base)
214 #define to_dsi_bridge(x) container_of(x, struct dsi_bridge, base)
215 
216 static inline int dsi_mgr_connector_get_id(struct drm_connector *connector)
217 {
218 	struct dsi_connector *dsi_connector = to_dsi_connector(connector);
219 	return dsi_connector->id;
220 }
221 
222 static int dsi_mgr_bridge_get_id(struct drm_bridge *bridge)
223 {
224 	struct dsi_bridge *dsi_bridge = to_dsi_bridge(bridge);
225 	return dsi_bridge->id;
226 }
227 
228 static enum drm_connector_status dsi_mgr_connector_detect(
229 		struct drm_connector *connector, bool force)
230 {
231 	int id = dsi_mgr_connector_get_id(connector);
232 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
233 	struct msm_dsi *other_dsi = dsi_mgr_get_other_dsi(id);
234 	struct msm_drm_private *priv = connector->dev->dev_private;
235 	struct msm_kms *kms = priv->kms;
236 
237 	DBG("id=%d", id);
238 	if (!msm_dsi->panel) {
239 		msm_dsi->panel = msm_dsi_host_get_panel(msm_dsi->host,
240 						&msm_dsi->device_flags);
241 
242 		/* There is only 1 panel in the global panel list
243 		 * for dual DSI mode. Therefore slave dsi should get
244 		 * the drm_panel instance from master dsi, and
245 		 * keep using the panel flags got from the current DSI link.
246 		 */
247 		if (!msm_dsi->panel && IS_DUAL_DSI() &&
248 			!IS_MASTER_DSI_LINK(id) && other_dsi)
249 			msm_dsi->panel = msm_dsi_host_get_panel(
250 					other_dsi->host, NULL);
251 
252 
253 		if (msm_dsi->panel && kms->funcs->set_encoder_mode) {
254 			bool cmd_mode = !(msm_dsi->device_flags &
255 					  MIPI_DSI_MODE_VIDEO);
256 			struct drm_encoder *encoder =
257 					msm_dsi_get_encoder(msm_dsi);
258 
259 			kms->funcs->set_encoder_mode(kms, encoder, cmd_mode);
260 		}
261 
262 		if (msm_dsi->panel && IS_DUAL_DSI())
263 			drm_object_attach_property(&connector->base,
264 				connector->dev->mode_config.tile_property, 0);
265 
266 		/* Set split display info to kms once dual DSI panel is
267 		 * connected to both hosts.
268 		 */
269 		if (msm_dsi->panel && IS_DUAL_DSI() &&
270 			other_dsi && other_dsi->panel) {
271 			bool cmd_mode = !(msm_dsi->device_flags &
272 						MIPI_DSI_MODE_VIDEO);
273 			struct drm_encoder *encoder = msm_dsi_get_encoder(
274 					dsi_mgr_get_dsi(DSI_ENCODER_MASTER));
275 			struct drm_encoder *slave_enc = msm_dsi_get_encoder(
276 					dsi_mgr_get_dsi(DSI_ENCODER_SLAVE));
277 
278 			if (kms->funcs->set_split_display)
279 				kms->funcs->set_split_display(kms, encoder,
280 							slave_enc, cmd_mode);
281 			else
282 				pr_err("mdp does not support dual DSI\n");
283 		}
284 	}
285 
286 	return msm_dsi->panel ? connector_status_connected :
287 		connector_status_disconnected;
288 }
289 
290 static void dsi_mgr_connector_destroy(struct drm_connector *connector)
291 {
292 	struct dsi_connector *dsi_connector = to_dsi_connector(connector);
293 
294 	DBG("");
295 
296 	drm_connector_cleanup(connector);
297 
298 	kfree(dsi_connector);
299 }
300 
301 static int dsi_mgr_connector_get_modes(struct drm_connector *connector)
302 {
303 	int id = dsi_mgr_connector_get_id(connector);
304 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
305 	struct drm_panel *panel = msm_dsi->panel;
306 	int num;
307 
308 	if (!panel)
309 		return 0;
310 
311 	/*
312 	 * In dual DSI mode, we have one connector that can be
313 	 * attached to the drm_panel.
314 	 */
315 	drm_panel_attach(panel, connector);
316 	num = drm_panel_get_modes(panel);
317 	if (!num)
318 		return 0;
319 
320 	return num;
321 }
322 
323 static int dsi_mgr_connector_mode_valid(struct drm_connector *connector,
324 				struct drm_display_mode *mode)
325 {
326 	int id = dsi_mgr_connector_get_id(connector);
327 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
328 	struct drm_encoder *encoder = msm_dsi_get_encoder(msm_dsi);
329 	struct msm_drm_private *priv = connector->dev->dev_private;
330 	struct msm_kms *kms = priv->kms;
331 	long actual, requested;
332 
333 	DBG("");
334 	requested = 1000 * mode->clock;
335 	actual = kms->funcs->round_pixclk(kms, requested, encoder);
336 
337 	DBG("requested=%ld, actual=%ld", requested, actual);
338 	if (actual != requested)
339 		return MODE_CLOCK_RANGE;
340 
341 	return MODE_OK;
342 }
343 
344 static struct drm_encoder *
345 dsi_mgr_connector_best_encoder(struct drm_connector *connector)
346 {
347 	int id = dsi_mgr_connector_get_id(connector);
348 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
349 
350 	DBG("");
351 	return msm_dsi_get_encoder(msm_dsi);
352 }
353 
354 static void dsi_mgr_bridge_pre_enable(struct drm_bridge *bridge)
355 {
356 	int id = dsi_mgr_bridge_get_id(bridge);
357 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
358 	struct msm_dsi *msm_dsi1 = dsi_mgr_get_dsi(DSI_1);
359 	struct mipi_dsi_host *host = msm_dsi->host;
360 	struct drm_panel *panel = msm_dsi->panel;
361 	struct msm_dsi_phy_shared_timings phy_shared_timings[DSI_MAX];
362 	bool is_dual_dsi = IS_DUAL_DSI();
363 	int ret;
364 
365 	DBG("id=%d", id);
366 	if (!msm_dsi_device_connected(msm_dsi))
367 		return;
368 
369 	ret = dsi_mgr_phy_enable(id, phy_shared_timings);
370 	if (ret)
371 		goto phy_en_fail;
372 
373 	/* Do nothing with the host if it is slave-DSI in case of dual DSI */
374 	if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))
375 		return;
376 
377 	ret = msm_dsi_host_power_on(host, &phy_shared_timings[id], is_dual_dsi);
378 	if (ret) {
379 		pr_err("%s: power on host %d failed, %d\n", __func__, id, ret);
380 		goto host_on_fail;
381 	}
382 
383 	if (is_dual_dsi && msm_dsi1) {
384 		ret = msm_dsi_host_power_on(msm_dsi1->host,
385 				&phy_shared_timings[DSI_1], is_dual_dsi);
386 		if (ret) {
387 			pr_err("%s: power on host1 failed, %d\n",
388 							__func__, ret);
389 			goto host1_on_fail;
390 		}
391 	}
392 
393 	/* Always call panel functions once, because even for dual panels,
394 	 * there is only one drm_panel instance.
395 	 */
396 	if (panel) {
397 		ret = drm_panel_prepare(panel);
398 		if (ret) {
399 			pr_err("%s: prepare panel %d failed, %d\n", __func__,
400 								id, ret);
401 			goto panel_prep_fail;
402 		}
403 	}
404 
405 	ret = msm_dsi_host_enable(host);
406 	if (ret) {
407 		pr_err("%s: enable host %d failed, %d\n", __func__, id, ret);
408 		goto host_en_fail;
409 	}
410 
411 	if (is_dual_dsi && msm_dsi1) {
412 		ret = msm_dsi_host_enable(msm_dsi1->host);
413 		if (ret) {
414 			pr_err("%s: enable host1 failed, %d\n", __func__, ret);
415 			goto host1_en_fail;
416 		}
417 	}
418 
419 	if (panel) {
420 		ret = drm_panel_enable(panel);
421 		if (ret) {
422 			pr_err("%s: enable panel %d failed, %d\n", __func__, id,
423 									ret);
424 			goto panel_en_fail;
425 		}
426 	}
427 
428 	return;
429 
430 panel_en_fail:
431 	if (is_dual_dsi && msm_dsi1)
432 		msm_dsi_host_disable(msm_dsi1->host);
433 host1_en_fail:
434 	msm_dsi_host_disable(host);
435 host_en_fail:
436 	if (panel)
437 		drm_panel_unprepare(panel);
438 panel_prep_fail:
439 	if (is_dual_dsi && msm_dsi1)
440 		msm_dsi_host_power_off(msm_dsi1->host);
441 host1_on_fail:
442 	msm_dsi_host_power_off(host);
443 host_on_fail:
444 	dsi_mgr_phy_disable(id);
445 phy_en_fail:
446 	return;
447 }
448 
449 static void dsi_mgr_bridge_enable(struct drm_bridge *bridge)
450 {
451 	DBG("");
452 }
453 
454 static void dsi_mgr_bridge_disable(struct drm_bridge *bridge)
455 {
456 	DBG("");
457 }
458 
459 static void dsi_mgr_bridge_post_disable(struct drm_bridge *bridge)
460 {
461 	int id = dsi_mgr_bridge_get_id(bridge);
462 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
463 	struct msm_dsi *msm_dsi1 = dsi_mgr_get_dsi(DSI_1);
464 	struct mipi_dsi_host *host = msm_dsi->host;
465 	struct drm_panel *panel = msm_dsi->panel;
466 	bool is_dual_dsi = IS_DUAL_DSI();
467 	int ret;
468 
469 	DBG("id=%d", id);
470 
471 	if (!msm_dsi_device_connected(msm_dsi))
472 		return;
473 
474 	/*
475 	 * Do nothing with the host if it is slave-DSI in case of dual DSI.
476 	 * It is safe to call dsi_mgr_phy_disable() here because a single PHY
477 	 * won't be diabled until both PHYs request disable.
478 	 */
479 	if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))
480 		goto disable_phy;
481 
482 	if (panel) {
483 		ret = drm_panel_disable(panel);
484 		if (ret)
485 			pr_err("%s: Panel %d OFF failed, %d\n", __func__, id,
486 									ret);
487 	}
488 
489 	ret = msm_dsi_host_disable(host);
490 	if (ret)
491 		pr_err("%s: host %d disable failed, %d\n", __func__, id, ret);
492 
493 	if (is_dual_dsi && msm_dsi1) {
494 		ret = msm_dsi_host_disable(msm_dsi1->host);
495 		if (ret)
496 			pr_err("%s: host1 disable failed, %d\n", __func__, ret);
497 	}
498 
499 	if (panel) {
500 		ret = drm_panel_unprepare(panel);
501 		if (ret)
502 			pr_err("%s: Panel %d unprepare failed,%d\n", __func__,
503 								id, ret);
504 	}
505 
506 	ret = msm_dsi_host_power_off(host);
507 	if (ret)
508 		pr_err("%s: host %d power off failed,%d\n", __func__, id, ret);
509 
510 	if (is_dual_dsi && msm_dsi1) {
511 		ret = msm_dsi_host_power_off(msm_dsi1->host);
512 		if (ret)
513 			pr_err("%s: host1 power off failed, %d\n",
514 								__func__, ret);
515 	}
516 
517 disable_phy:
518 	dsi_mgr_phy_disable(id);
519 }
520 
521 static void dsi_mgr_bridge_mode_set(struct drm_bridge *bridge,
522 		const struct drm_display_mode *mode,
523 		const struct drm_display_mode *adjusted_mode)
524 {
525 	int id = dsi_mgr_bridge_get_id(bridge);
526 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
527 	struct msm_dsi *other_dsi = dsi_mgr_get_other_dsi(id);
528 	struct mipi_dsi_host *host = msm_dsi->host;
529 	bool is_dual_dsi = IS_DUAL_DSI();
530 
531 	DBG("set mode: " DRM_MODE_FMT, DRM_MODE_ARG(mode));
532 
533 	if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))
534 		return;
535 
536 	msm_dsi_host_set_display_mode(host, adjusted_mode);
537 	if (is_dual_dsi && other_dsi)
538 		msm_dsi_host_set_display_mode(other_dsi->host, adjusted_mode);
539 }
540 
541 static const struct drm_connector_funcs dsi_mgr_connector_funcs = {
542 	.detect = dsi_mgr_connector_detect,
543 	.fill_modes = drm_helper_probe_single_connector_modes,
544 	.destroy = dsi_mgr_connector_destroy,
545 	.reset = drm_atomic_helper_connector_reset,
546 	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
547 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
548 };
549 
550 static const struct drm_connector_helper_funcs dsi_mgr_conn_helper_funcs = {
551 	.get_modes = dsi_mgr_connector_get_modes,
552 	.mode_valid = dsi_mgr_connector_mode_valid,
553 	.best_encoder = dsi_mgr_connector_best_encoder,
554 };
555 
556 static const struct drm_bridge_funcs dsi_mgr_bridge_funcs = {
557 	.pre_enable = dsi_mgr_bridge_pre_enable,
558 	.enable = dsi_mgr_bridge_enable,
559 	.disable = dsi_mgr_bridge_disable,
560 	.post_disable = dsi_mgr_bridge_post_disable,
561 	.mode_set = dsi_mgr_bridge_mode_set,
562 };
563 
564 /* initialize connector when we're connected to a drm_panel */
565 struct drm_connector *msm_dsi_manager_connector_init(u8 id)
566 {
567 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
568 	struct drm_connector *connector = NULL;
569 	struct dsi_connector *dsi_connector;
570 	int ret;
571 
572 	dsi_connector = kzalloc(sizeof(*dsi_connector), GFP_KERNEL);
573 	if (!dsi_connector)
574 		return ERR_PTR(-ENOMEM);
575 
576 	dsi_connector->id = id;
577 
578 	connector = &dsi_connector->base;
579 
580 	ret = drm_connector_init(msm_dsi->dev, connector,
581 			&dsi_mgr_connector_funcs, DRM_MODE_CONNECTOR_DSI);
582 	if (ret)
583 		return ERR_PTR(ret);
584 
585 	drm_connector_helper_add(connector, &dsi_mgr_conn_helper_funcs);
586 
587 	/* Enable HPD to let hpd event is handled
588 	 * when panel is attached to the host.
589 	 */
590 	connector->polled = DRM_CONNECTOR_POLL_HPD;
591 
592 	/* Display driver doesn't support interlace now. */
593 	connector->interlace_allowed = 0;
594 	connector->doublescan_allowed = 0;
595 
596 	drm_connector_attach_encoder(connector, msm_dsi->encoder);
597 
598 	return connector;
599 }
600 
601 bool msm_dsi_manager_validate_current_config(u8 id)
602 {
603 	bool is_dual_dsi = IS_DUAL_DSI();
604 
605 	/*
606 	 * For dual DSI, we only have one drm panel. For this
607 	 * use case, we register only one bridge/connector.
608 	 * Skip bridge/connector initialisation if it is
609 	 * slave-DSI for dual DSI configuration.
610 	 */
611 	if (is_dual_dsi && !IS_MASTER_DSI_LINK(id)) {
612 		DBG("Skip bridge registration for slave DSI->id: %d\n", id);
613 		return false;
614 	}
615 	return true;
616 }
617 
618 /* initialize bridge */
619 struct drm_bridge *msm_dsi_manager_bridge_init(u8 id)
620 {
621 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
622 	struct drm_bridge *bridge = NULL;
623 	struct dsi_bridge *dsi_bridge;
624 	struct drm_encoder *encoder;
625 	int ret;
626 
627 	dsi_bridge = devm_kzalloc(msm_dsi->dev->dev,
628 				sizeof(*dsi_bridge), GFP_KERNEL);
629 	if (!dsi_bridge) {
630 		ret = -ENOMEM;
631 		goto fail;
632 	}
633 
634 	dsi_bridge->id = id;
635 
636 	encoder = msm_dsi->encoder;
637 
638 	bridge = &dsi_bridge->base;
639 	bridge->funcs = &dsi_mgr_bridge_funcs;
640 
641 	ret = drm_bridge_attach(encoder, bridge, NULL);
642 	if (ret)
643 		goto fail;
644 
645 	return bridge;
646 
647 fail:
648 	if (bridge)
649 		msm_dsi_manager_bridge_destroy(bridge);
650 
651 	return ERR_PTR(ret);
652 }
653 
654 struct drm_connector *msm_dsi_manager_ext_bridge_init(u8 id)
655 {
656 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
657 	struct drm_device *dev = msm_dsi->dev;
658 	struct drm_encoder *encoder;
659 	struct drm_bridge *int_bridge, *ext_bridge;
660 	struct drm_connector *connector;
661 	struct list_head *connector_list;
662 
663 	int_bridge = msm_dsi->bridge;
664 	ext_bridge = msm_dsi->external_bridge =
665 			msm_dsi_host_get_bridge(msm_dsi->host);
666 
667 	encoder = msm_dsi->encoder;
668 
669 	/* link the internal dsi bridge to the external bridge */
670 	drm_bridge_attach(encoder, ext_bridge, int_bridge);
671 
672 	/*
673 	 * we need the drm_connector created by the external bridge
674 	 * driver (or someone else) to feed it to our driver's
675 	 * priv->connector[] list, mainly for msm_fbdev_init()
676 	 */
677 	connector_list = &dev->mode_config.connector_list;
678 
679 	list_for_each_entry(connector, connector_list, head) {
680 		if (drm_connector_has_possible_encoder(connector, encoder))
681 			return connector;
682 	}
683 
684 	return ERR_PTR(-ENODEV);
685 }
686 
687 void msm_dsi_manager_bridge_destroy(struct drm_bridge *bridge)
688 {
689 }
690 
691 int msm_dsi_manager_cmd_xfer(int id, const struct mipi_dsi_msg *msg)
692 {
693 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
694 	struct msm_dsi *msm_dsi0 = dsi_mgr_get_dsi(DSI_0);
695 	struct mipi_dsi_host *host = msm_dsi->host;
696 	bool is_read = (msg->rx_buf && msg->rx_len);
697 	bool need_sync = (IS_SYNC_NEEDED() && !is_read);
698 	int ret;
699 
700 	if (!msg->tx_buf || !msg->tx_len)
701 		return 0;
702 
703 	/* In dual master case, panel requires the same commands sent to
704 	 * both DSI links. Host issues the command trigger to both links
705 	 * when DSI_1 calls the cmd transfer function, no matter it happens
706 	 * before or after DSI_0 cmd transfer.
707 	 */
708 	if (need_sync && (id == DSI_0))
709 		return is_read ? msg->rx_len : msg->tx_len;
710 
711 	if (need_sync && msm_dsi0) {
712 		ret = msm_dsi_host_xfer_prepare(msm_dsi0->host, msg);
713 		if (ret) {
714 			pr_err("%s: failed to prepare non-trigger host, %d\n",
715 				__func__, ret);
716 			return ret;
717 		}
718 	}
719 	ret = msm_dsi_host_xfer_prepare(host, msg);
720 	if (ret) {
721 		pr_err("%s: failed to prepare host, %d\n", __func__, ret);
722 		goto restore_host0;
723 	}
724 
725 	ret = is_read ? msm_dsi_host_cmd_rx(host, msg) :
726 			msm_dsi_host_cmd_tx(host, msg);
727 
728 	msm_dsi_host_xfer_restore(host, msg);
729 
730 restore_host0:
731 	if (need_sync && msm_dsi0)
732 		msm_dsi_host_xfer_restore(msm_dsi0->host, msg);
733 
734 	return ret;
735 }
736 
737 bool msm_dsi_manager_cmd_xfer_trigger(int id, u32 dma_base, u32 len)
738 {
739 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
740 	struct msm_dsi *msm_dsi0 = dsi_mgr_get_dsi(DSI_0);
741 	struct mipi_dsi_host *host = msm_dsi->host;
742 
743 	if (IS_SYNC_NEEDED() && (id == DSI_0))
744 		return false;
745 
746 	if (IS_SYNC_NEEDED() && msm_dsi0)
747 		msm_dsi_host_cmd_xfer_commit(msm_dsi0->host, dma_base, len);
748 
749 	msm_dsi_host_cmd_xfer_commit(host, dma_base, len);
750 
751 	return true;
752 }
753 
754 void msm_dsi_manager_attach_dsi_device(int id, u32 device_flags)
755 {
756 	struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
757 	struct drm_device *dev = msm_dsi->dev;
758 	struct msm_drm_private *priv;
759 	struct msm_kms *kms;
760 	struct drm_encoder *encoder;
761 	bool cmd_mode;
762 
763 	/*
764 	 * drm_device pointer is assigned to msm_dsi only in the modeset_init
765 	 * path. If mipi_dsi_attach() happens in DSI driver's probe path
766 	 * (generally the case when we're connected to a drm_panel of the type
767 	 * mipi_dsi_device), this would be NULL. In such cases, try to set the
768 	 * encoder mode in the DSI connector's detect() op.
769 	 */
770 	if (!dev)
771 		return;
772 
773 	priv = dev->dev_private;
774 	kms = priv->kms;
775 	encoder = msm_dsi_get_encoder(msm_dsi);
776 	cmd_mode = !(device_flags &
777 				 MIPI_DSI_MODE_VIDEO);
778 
779 	if (encoder && kms->funcs->set_encoder_mode)
780 		kms->funcs->set_encoder_mode(kms, encoder, cmd_mode);
781 }
782 
783 int msm_dsi_manager_register(struct msm_dsi *msm_dsi)
784 {
785 	struct msm_dsi_manager *msm_dsim = &msm_dsim_glb;
786 	int id = msm_dsi->id;
787 	int ret;
788 
789 	if (id >= DSI_MAX) {
790 		pr_err("%s: invalid id %d\n", __func__, id);
791 		return -EINVAL;
792 	}
793 
794 	if (msm_dsim->dsi[id]) {
795 		pr_err("%s: dsi%d already registered\n", __func__, id);
796 		return -EBUSY;
797 	}
798 
799 	msm_dsim->dsi[id] = msm_dsi;
800 
801 	ret = dsi_mgr_parse_dual_dsi(msm_dsi->pdev->dev.of_node, id);
802 	if (ret) {
803 		pr_err("%s: failed to parse dual DSI info\n", __func__);
804 		goto fail;
805 	}
806 
807 	ret = dsi_mgr_setup_components(id);
808 	if (ret) {
809 		pr_err("%s: failed to register mipi dsi host for DSI %d\n",
810 			__func__, id);
811 		goto fail;
812 	}
813 
814 	return 0;
815 
816 fail:
817 	msm_dsim->dsi[id] = NULL;
818 	return ret;
819 }
820 
821 void msm_dsi_manager_unregister(struct msm_dsi *msm_dsi)
822 {
823 	struct msm_dsi_manager *msm_dsim = &msm_dsim_glb;
824 
825 	if (msm_dsi->host)
826 		msm_dsi_host_unregister(msm_dsi->host);
827 
828 	if (msm_dsi->id >= 0)
829 		msm_dsim->dsi[msm_dsi->id] = NULL;
830 }
831 
832