1df17ff62SJani Nikula // SPDX-License-Identifier: MIT
2df17ff62SJani Nikula /*
3df17ff62SJani Nikula * Copyright © 2022 Intel Corporation
4df17ff62SJani Nikula *
5df17ff62SJani Nikula * High level crtc/connector/encoder modeset state verification.
6df17ff62SJani Nikula */
7df17ff62SJani Nikula
8df17ff62SJani Nikula #include <drm/drm_atomic_state_helper.h>
9df17ff62SJani Nikula
10df17ff62SJani Nikula #include "i915_drv.h"
11df17ff62SJani Nikula #include "intel_atomic.h"
12df17ff62SJani Nikula #include "intel_crtc.h"
133e29d3b3SJani Nikula #include "intel_crtc_state_dump.h"
1451390cc0SRadhakrishna Sripada #include "intel_cx0_phy.h"
15df17ff62SJani Nikula #include "intel_display.h"
16df17ff62SJani Nikula #include "intel_display_types.h"
17df17ff62SJani Nikula #include "intel_fdi.h"
18df17ff62SJani Nikula #include "intel_modeset_verify.h"
19df17ff62SJani Nikula #include "intel_snps_phy.h"
2042a0d256SVille Syrjälä #include "skl_watermark.h"
21df17ff62SJani Nikula
22df17ff62SJani Nikula /*
23df17ff62SJani Nikula * Cross check the actual hw state with our own modeset state tracking (and its
24df17ff62SJani Nikula * internal consistency).
25df17ff62SJani Nikula */
intel_connector_verify_state(struct intel_crtc_state * crtc_state,struct drm_connector_state * conn_state)26df17ff62SJani Nikula static void intel_connector_verify_state(struct intel_crtc_state *crtc_state,
27df17ff62SJani Nikula struct drm_connector_state *conn_state)
28df17ff62SJani Nikula {
29df17ff62SJani Nikula struct intel_connector *connector = to_intel_connector(conn_state->connector);
30df17ff62SJani Nikula struct drm_i915_private *i915 = to_i915(connector->base.dev);
31df17ff62SJani Nikula
32df17ff62SJani Nikula drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s]\n",
33df17ff62SJani Nikula connector->base.base.id, connector->base.name);
34df17ff62SJani Nikula
35df17ff62SJani Nikula if (connector->get_hw_state(connector)) {
36df17ff62SJani Nikula struct intel_encoder *encoder = intel_attached_encoder(connector);
37df17ff62SJani Nikula
38*6b9bd7c3SJani Nikula I915_STATE_WARN(i915, !crtc_state,
39df17ff62SJani Nikula "connector enabled without attached crtc\n");
40df17ff62SJani Nikula
41df17ff62SJani Nikula if (!crtc_state)
42df17ff62SJani Nikula return;
43df17ff62SJani Nikula
44*6b9bd7c3SJani Nikula I915_STATE_WARN(i915, !crtc_state->hw.active,
45df17ff62SJani Nikula "connector is active, but attached crtc isn't\n");
46df17ff62SJani Nikula
47df17ff62SJani Nikula if (!encoder || encoder->type == INTEL_OUTPUT_DP_MST)
48df17ff62SJani Nikula return;
49df17ff62SJani Nikula
50*6b9bd7c3SJani Nikula I915_STATE_WARN(i915,
51*6b9bd7c3SJani Nikula conn_state->best_encoder != &encoder->base,
52df17ff62SJani Nikula "atomic encoder doesn't match attached encoder\n");
53df17ff62SJani Nikula
54*6b9bd7c3SJani Nikula I915_STATE_WARN(i915, conn_state->crtc != encoder->base.crtc,
55df17ff62SJani Nikula "attached encoder crtc differs from connector crtc\n");
56df17ff62SJani Nikula } else {
57*6b9bd7c3SJani Nikula I915_STATE_WARN(i915, crtc_state && crtc_state->hw.active,
58df17ff62SJani Nikula "attached crtc is active, but connector isn't\n");
59*6b9bd7c3SJani Nikula I915_STATE_WARN(i915, !crtc_state && conn_state->best_encoder,
60df17ff62SJani Nikula "best encoder set without crtc!\n");
61df17ff62SJani Nikula }
62df17ff62SJani Nikula }
63df17ff62SJani Nikula
64df17ff62SJani Nikula static void
verify_connector_state(struct intel_atomic_state * state,struct intel_crtc * crtc)65df17ff62SJani Nikula verify_connector_state(struct intel_atomic_state *state,
66df17ff62SJani Nikula struct intel_crtc *crtc)
67df17ff62SJani Nikula {
68df17ff62SJani Nikula struct drm_connector *connector;
69df17ff62SJani Nikula struct drm_connector_state *new_conn_state;
70df17ff62SJani Nikula int i;
71df17ff62SJani Nikula
72df17ff62SJani Nikula for_each_new_connector_in_state(&state->base, connector, new_conn_state, i) {
73df17ff62SJani Nikula struct drm_encoder *encoder = connector->encoder;
74df17ff62SJani Nikula struct intel_crtc_state *crtc_state = NULL;
75df17ff62SJani Nikula
76df17ff62SJani Nikula if (new_conn_state->crtc != &crtc->base)
77df17ff62SJani Nikula continue;
78df17ff62SJani Nikula
79df17ff62SJani Nikula if (crtc)
80df17ff62SJani Nikula crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
81df17ff62SJani Nikula
82df17ff62SJani Nikula intel_connector_verify_state(crtc_state, new_conn_state);
83df17ff62SJani Nikula
84*6b9bd7c3SJani Nikula I915_STATE_WARN(to_i915(connector->dev), new_conn_state->best_encoder != encoder,
85df17ff62SJani Nikula "connector's atomic encoder doesn't match legacy encoder\n");
86df17ff62SJani Nikula }
87df17ff62SJani Nikula }
88df17ff62SJani Nikula
intel_pipe_config_sanity_check(struct drm_i915_private * dev_priv,const struct intel_crtc_state * pipe_config)89df17ff62SJani Nikula static void intel_pipe_config_sanity_check(struct drm_i915_private *dev_priv,
90df17ff62SJani Nikula const struct intel_crtc_state *pipe_config)
91df17ff62SJani Nikula {
92df17ff62SJani Nikula if (pipe_config->has_pch_encoder) {
93df17ff62SJani Nikula int fdi_dotclock = intel_dotclock_calculate(intel_fdi_link_freq(dev_priv, pipe_config),
94df17ff62SJani Nikula &pipe_config->fdi_m_n);
95df17ff62SJani Nikula int dotclock = pipe_config->hw.adjusted_mode.crtc_clock;
96df17ff62SJani Nikula
97df17ff62SJani Nikula /*
98df17ff62SJani Nikula * FDI already provided one idea for the dotclock.
9927d06077SVille Syrjälä * Yell if the encoder disagrees. Allow for slight
10027d06077SVille Syrjälä * rounding differences.
101df17ff62SJani Nikula */
10227d06077SVille Syrjälä drm_WARN(&dev_priv->drm, abs(fdi_dotclock - dotclock) > 1,
103df17ff62SJani Nikula "FDI dotclock and encoder dotclock mismatch, fdi: %i, encoder: %i\n",
104df17ff62SJani Nikula fdi_dotclock, dotclock);
105df17ff62SJani Nikula }
106df17ff62SJani Nikula }
107df17ff62SJani Nikula
108df17ff62SJani Nikula static void
verify_encoder_state(struct drm_i915_private * dev_priv,struct intel_atomic_state * state)109df17ff62SJani Nikula verify_encoder_state(struct drm_i915_private *dev_priv, struct intel_atomic_state *state)
110df17ff62SJani Nikula {
111df17ff62SJani Nikula struct intel_encoder *encoder;
112df17ff62SJani Nikula struct drm_connector *connector;
113df17ff62SJani Nikula struct drm_connector_state *old_conn_state, *new_conn_state;
114df17ff62SJani Nikula int i;
115df17ff62SJani Nikula
116df17ff62SJani Nikula for_each_intel_encoder(&dev_priv->drm, encoder) {
117df17ff62SJani Nikula bool enabled = false, found = false;
118df17ff62SJani Nikula enum pipe pipe;
119df17ff62SJani Nikula
120df17ff62SJani Nikula drm_dbg_kms(&dev_priv->drm, "[ENCODER:%d:%s]\n",
121df17ff62SJani Nikula encoder->base.base.id,
122df17ff62SJani Nikula encoder->base.name);
123df17ff62SJani Nikula
124df17ff62SJani Nikula for_each_oldnew_connector_in_state(&state->base, connector, old_conn_state,
125df17ff62SJani Nikula new_conn_state, i) {
126df17ff62SJani Nikula if (old_conn_state->best_encoder == &encoder->base)
127df17ff62SJani Nikula found = true;
128df17ff62SJani Nikula
129df17ff62SJani Nikula if (new_conn_state->best_encoder != &encoder->base)
130df17ff62SJani Nikula continue;
131df17ff62SJani Nikula
132df17ff62SJani Nikula found = true;
133df17ff62SJani Nikula enabled = true;
134df17ff62SJani Nikula
135*6b9bd7c3SJani Nikula I915_STATE_WARN(dev_priv,
136*6b9bd7c3SJani Nikula new_conn_state->crtc != encoder->base.crtc,
137df17ff62SJani Nikula "connector's crtc doesn't match encoder crtc\n");
138df17ff62SJani Nikula }
139df17ff62SJani Nikula
140df17ff62SJani Nikula if (!found)
141df17ff62SJani Nikula continue;
142df17ff62SJani Nikula
143*6b9bd7c3SJani Nikula I915_STATE_WARN(dev_priv, !!encoder->base.crtc != enabled,
144df17ff62SJani Nikula "encoder's enabled state mismatch (expected %i, found %i)\n",
145df17ff62SJani Nikula !!encoder->base.crtc, enabled);
146df17ff62SJani Nikula
147df17ff62SJani Nikula if (!encoder->base.crtc) {
148df17ff62SJani Nikula bool active;
149df17ff62SJani Nikula
150df17ff62SJani Nikula active = encoder->get_hw_state(encoder, &pipe);
151*6b9bd7c3SJani Nikula I915_STATE_WARN(dev_priv, active,
152df17ff62SJani Nikula "encoder detached but still enabled on pipe %c.\n",
153df17ff62SJani Nikula pipe_name(pipe));
154df17ff62SJani Nikula }
155df17ff62SJani Nikula }
156df17ff62SJani Nikula }
157df17ff62SJani Nikula
158df17ff62SJani Nikula static void
verify_crtc_state(struct intel_crtc * crtc,struct intel_crtc_state * old_crtc_state,struct intel_crtc_state * new_crtc_state)159df17ff62SJani Nikula verify_crtc_state(struct intel_crtc *crtc,
160df17ff62SJani Nikula struct intel_crtc_state *old_crtc_state,
161df17ff62SJani Nikula struct intel_crtc_state *new_crtc_state)
162df17ff62SJani Nikula {
163df17ff62SJani Nikula struct drm_device *dev = crtc->base.dev;
164df17ff62SJani Nikula struct drm_i915_private *dev_priv = to_i915(dev);
165df17ff62SJani Nikula struct intel_encoder *encoder;
166df17ff62SJani Nikula struct intel_crtc_state *pipe_config = old_crtc_state;
167df17ff62SJani Nikula struct drm_atomic_state *state = old_crtc_state->uapi.state;
168df17ff62SJani Nikula struct intel_crtc *master_crtc;
169df17ff62SJani Nikula
170df17ff62SJani Nikula __drm_atomic_helper_crtc_destroy_state(&old_crtc_state->uapi);
171df17ff62SJani Nikula intel_crtc_free_hw_state(old_crtc_state);
172df17ff62SJani Nikula intel_crtc_state_reset(old_crtc_state, crtc);
173df17ff62SJani Nikula old_crtc_state->uapi.state = state;
174df17ff62SJani Nikula
175df17ff62SJani Nikula drm_dbg_kms(&dev_priv->drm, "[CRTC:%d:%s]\n", crtc->base.base.id,
176df17ff62SJani Nikula crtc->base.name);
177df17ff62SJani Nikula
178df17ff62SJani Nikula pipe_config->hw.enable = new_crtc_state->hw.enable;
179df17ff62SJani Nikula
180df17ff62SJani Nikula intel_crtc_get_pipe_config(pipe_config);
181df17ff62SJani Nikula
182df17ff62SJani Nikula /* we keep both pipes enabled on 830 */
183df17ff62SJani Nikula if (IS_I830(dev_priv) && pipe_config->hw.active)
184df17ff62SJani Nikula pipe_config->hw.active = new_crtc_state->hw.active;
185df17ff62SJani Nikula
186*6b9bd7c3SJani Nikula I915_STATE_WARN(dev_priv,
187*6b9bd7c3SJani Nikula new_crtc_state->hw.active != pipe_config->hw.active,
188df17ff62SJani Nikula "crtc active state doesn't match with hw state (expected %i, found %i)\n",
189df17ff62SJani Nikula new_crtc_state->hw.active, pipe_config->hw.active);
190df17ff62SJani Nikula
191*6b9bd7c3SJani Nikula I915_STATE_WARN(dev_priv, crtc->active != new_crtc_state->hw.active,
192df17ff62SJani Nikula "transitional active state does not match atomic hw state (expected %i, found %i)\n",
193df17ff62SJani Nikula new_crtc_state->hw.active, crtc->active);
194df17ff62SJani Nikula
195df17ff62SJani Nikula master_crtc = intel_master_crtc(new_crtc_state);
196df17ff62SJani Nikula
197df17ff62SJani Nikula for_each_encoder_on_crtc(dev, &master_crtc->base, encoder) {
198df17ff62SJani Nikula enum pipe pipe;
199df17ff62SJani Nikula bool active;
200df17ff62SJani Nikula
201df17ff62SJani Nikula active = encoder->get_hw_state(encoder, &pipe);
202*6b9bd7c3SJani Nikula I915_STATE_WARN(dev_priv, active != new_crtc_state->hw.active,
203df17ff62SJani Nikula "[ENCODER:%i] active %i with crtc active %i\n",
204df17ff62SJani Nikula encoder->base.base.id, active,
205df17ff62SJani Nikula new_crtc_state->hw.active);
206df17ff62SJani Nikula
207*6b9bd7c3SJani Nikula I915_STATE_WARN(dev_priv, active && master_crtc->pipe != pipe,
208df17ff62SJani Nikula "Encoder connected to wrong pipe %c\n",
209df17ff62SJani Nikula pipe_name(pipe));
210df17ff62SJani Nikula
211df17ff62SJani Nikula if (active)
212df17ff62SJani Nikula intel_encoder_get_config(encoder, pipe_config);
213df17ff62SJani Nikula }
214df17ff62SJani Nikula
215df17ff62SJani Nikula if (!new_crtc_state->hw.active)
216df17ff62SJani Nikula return;
217df17ff62SJani Nikula
218df17ff62SJani Nikula intel_pipe_config_sanity_check(dev_priv, pipe_config);
219df17ff62SJani Nikula
220df17ff62SJani Nikula if (!intel_pipe_config_compare(new_crtc_state,
221df17ff62SJani Nikula pipe_config, false)) {
222*6b9bd7c3SJani Nikula I915_STATE_WARN(dev_priv, 1, "pipe state doesn't match!\n");
223ac1b49beSJani Nikula intel_crtc_state_dump(pipe_config, NULL, "hw state");
224ac1b49beSJani Nikula intel_crtc_state_dump(new_crtc_state, NULL, "sw state");
225df17ff62SJani Nikula }
226df17ff62SJani Nikula }
227df17ff62SJani Nikula
intel_modeset_verify_crtc(struct intel_crtc * crtc,struct intel_atomic_state * state,struct intel_crtc_state * old_crtc_state,struct intel_crtc_state * new_crtc_state)228df17ff62SJani Nikula void intel_modeset_verify_crtc(struct intel_crtc *crtc,
229df17ff62SJani Nikula struct intel_atomic_state *state,
230df17ff62SJani Nikula struct intel_crtc_state *old_crtc_state,
231df17ff62SJani Nikula struct intel_crtc_state *new_crtc_state)
232df17ff62SJani Nikula {
23352a90349SVille Syrjälä if (!intel_crtc_needs_modeset(new_crtc_state) &&
23452a90349SVille Syrjälä !intel_crtc_needs_fastset(new_crtc_state))
235df17ff62SJani Nikula return;
236df17ff62SJani Nikula
237df17ff62SJani Nikula intel_wm_state_verify(crtc, new_crtc_state);
238df17ff62SJani Nikula verify_connector_state(state, crtc);
239df17ff62SJani Nikula verify_crtc_state(crtc, old_crtc_state, new_crtc_state);
240df17ff62SJani Nikula intel_shared_dpll_state_verify(crtc, old_crtc_state, new_crtc_state);
241df17ff62SJani Nikula intel_mpllb_state_verify(state, new_crtc_state);
24251390cc0SRadhakrishna Sripada intel_c10pll_state_verify(state, new_crtc_state);
243df17ff62SJani Nikula }
244df17ff62SJani Nikula
intel_modeset_verify_disabled(struct drm_i915_private * dev_priv,struct intel_atomic_state * state)245df17ff62SJani Nikula void intel_modeset_verify_disabled(struct drm_i915_private *dev_priv,
246df17ff62SJani Nikula struct intel_atomic_state *state)
247df17ff62SJani Nikula {
248df17ff62SJani Nikula verify_encoder_state(dev_priv, state);
249df17ff62SJani Nikula verify_connector_state(state, NULL);
250df17ff62SJani Nikula intel_shared_dpll_verify_disabled(dev_priv);
251df17ff62SJani Nikula }
252