xref: /openbmc/bmcweb/features/redfish/lib/update_service.hpp (revision 539d8c6bc399e516d39bcaa18262cf206f4c1035)
1729dae72SJennifer Lee /*
2729dae72SJennifer Lee // Copyright (c) 2018 Intel Corporation
3729dae72SJennifer Lee //
4729dae72SJennifer Lee // Licensed under the Apache License, Version 2.0 (the "License");
5729dae72SJennifer Lee // you may not use this file except in compliance with the License.
6729dae72SJennifer Lee // You may obtain a copy of the License at
7729dae72SJennifer Lee //
8729dae72SJennifer Lee //      http://www.apache.org/licenses/LICENSE-2.0
9729dae72SJennifer Lee //
10729dae72SJennifer Lee // Unless required by applicable law or agreed to in writing, software
11729dae72SJennifer Lee // distributed under the License is distributed on an "AS IS" BASIS,
12729dae72SJennifer Lee // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13729dae72SJennifer Lee // See the License for the specific language governing permissions and
14729dae72SJennifer Lee // limitations under the License.
15729dae72SJennifer Lee */
16729dae72SJennifer Lee #pragma once
17729dae72SJennifer Lee 
18d61e5194STejas Patil #include "bmcweb_config.h"
19d61e5194STejas Patil 
203ccb3adbSEd Tanous #include "app.hpp"
213ccb3adbSEd Tanous #include "dbus_utility.hpp"
225b90429aSEd Tanous #include "error_messages.hpp"
23757178a5SEd Tanous #include "generated/enums/update_service.hpp"
240ed80c8cSGeorge Liu #include "multipart_parser.hpp"
252c6ffdb0SEd Tanous #include "ossl_random.hpp"
263ccb3adbSEd Tanous #include "query.hpp"
273ccb3adbSEd Tanous #include "registries/privilege_registry.hpp"
28a8e884fcSEd Tanous #include "task.hpp"
295b90429aSEd Tanous #include "task_messages.hpp"
3008d81adaSJohn Edward Broadbent #include "utils/collection.hpp"
313ccb3adbSEd Tanous #include "utils/dbus_utils.hpp"
325b90429aSEd Tanous #include "utils/json_utils.hpp"
333ccb3adbSEd Tanous #include "utils/sw_utils.hpp"
343ccb3adbSEd Tanous 
35de0c960cSJagpal Singh Gill #include <sys/mman.h>
36de0c960cSJagpal Singh Gill 
37e99073f5SGeorge Liu #include <boost/system/error_code.hpp>
38ef4c65b7SEd Tanous #include <boost/url/format.hpp>
391e1e598dSJonathan Doman #include <sdbusplus/asio/property.hpp>
403ccb3adbSEd Tanous #include <sdbusplus/bus/match.hpp>
41d1bde9e5SKrzysztof Grobelny #include <sdbusplus/unpack_properties.hpp>
421214b7e7SGunnar Mills 
432b73119cSGeorge Liu #include <array>
44de0c960cSJagpal Singh Gill #include <cstddef>
450ed80c8cSGeorge Liu #include <filesystem>
46c71b6c99SJagpal Singh Gill #include <functional>
47de0c960cSJagpal Singh Gill #include <iterator>
48ef93eab3SJagpal Singh Gill #include <memory>
497cb59f65SEd Tanous #include <optional>
507cb59f65SEd Tanous #include <string>
512b73119cSGeorge Liu #include <string_view>
52de0c960cSJagpal Singh Gill #include <unordered_map>
53ef93eab3SJagpal Singh Gill #include <vector>
542b73119cSGeorge Liu 
551abe55efSEd Tanous namespace redfish
561abe55efSEd Tanous {
5727826b5fSEd Tanous 
580e7de46fSAndrew Geissler // Match signals added on software path
59cf9e417dSEd Tanous // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
6059d494eeSPatrick Williams static std::unique_ptr<sdbusplus::bus::match_t> fwUpdateMatcher;
61cf9e417dSEd Tanous // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
6259d494eeSPatrick Williams static std::unique_ptr<sdbusplus::bus::match_t> fwUpdateErrorMatcher;
630e7de46fSAndrew Geissler // Only allow one update at a time
64cf9e417dSEd Tanous // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
650e7de46fSAndrew Geissler static bool fwUpdateInProgress = false;
6686adcd6dSAndrew Geissler // Timer for software available
67cf9e417dSEd Tanous // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
68271584abSEd Tanous static std::unique_ptr<boost::asio::steady_timer> fwAvailableTimer;
6986adcd6dSAndrew Geissler 
70de0c960cSJagpal Singh Gill struct MemoryFileDescriptor
71de0c960cSJagpal Singh Gill {
72de0c960cSJagpal Singh Gill     int fd = -1;
73de0c960cSJagpal Singh Gill 
74de0c960cSJagpal Singh Gill     explicit MemoryFileDescriptor(const std::string& filename) :
75de0c960cSJagpal Singh Gill         fd(memfd_create(filename.c_str(), 0))
76de0c960cSJagpal Singh Gill     {}
77de0c960cSJagpal Singh Gill 
78de0c960cSJagpal Singh Gill     MemoryFileDescriptor(const MemoryFileDescriptor&) = default;
79de0c960cSJagpal Singh Gill     MemoryFileDescriptor(MemoryFileDescriptor&& other) noexcept : fd(other.fd)
80de0c960cSJagpal Singh Gill     {
81de0c960cSJagpal Singh Gill         other.fd = -1;
82de0c960cSJagpal Singh Gill     }
83de0c960cSJagpal Singh Gill     MemoryFileDescriptor& operator=(const MemoryFileDescriptor&) = delete;
84de0c960cSJagpal Singh Gill     MemoryFileDescriptor& operator=(MemoryFileDescriptor&&) = default;
85de0c960cSJagpal Singh Gill 
86de0c960cSJagpal Singh Gill     ~MemoryFileDescriptor()
87de0c960cSJagpal Singh Gill     {
88de0c960cSJagpal Singh Gill         if (fd != -1)
89de0c960cSJagpal Singh Gill         {
90de0c960cSJagpal Singh Gill             close(fd);
91de0c960cSJagpal Singh Gill         }
92de0c960cSJagpal Singh Gill     }
93de0c960cSJagpal Singh Gill 
94de0c960cSJagpal Singh Gill     bool rewind() const
95de0c960cSJagpal Singh Gill     {
96de0c960cSJagpal Singh Gill         if (lseek(fd, 0, SEEK_SET) == -1)
97de0c960cSJagpal Singh Gill         {
98de0c960cSJagpal Singh Gill             BMCWEB_LOG_ERROR("Failed to seek to beginning of image memfd");
99de0c960cSJagpal Singh Gill             return false;
100de0c960cSJagpal Singh Gill         }
101de0c960cSJagpal Singh Gill         return true;
102de0c960cSJagpal Singh Gill     }
103de0c960cSJagpal Singh Gill };
104de0c960cSJagpal Singh Gill 
105df254f2cSEd Tanous inline void cleanUp()
10686adcd6dSAndrew Geissler {
10786adcd6dSAndrew Geissler     fwUpdateInProgress = false;
10886adcd6dSAndrew Geissler     fwUpdateMatcher = nullptr;
1094cde5d90SJames Feist     fwUpdateErrorMatcher = nullptr;
11086adcd6dSAndrew Geissler }
111df254f2cSEd Tanous 
112df254f2cSEd Tanous inline void activateImage(const std::string& objPath,
11386adcd6dSAndrew Geissler                           const std::string& service)
11486adcd6dSAndrew Geissler {
11562598e31SEd Tanous     BMCWEB_LOG_DEBUG("Activate image for {} {}", objPath, service);
1169ae226faSGeorge Liu     sdbusplus::asio::setProperty(
1179ae226faSGeorge Liu         *crow::connections::systemBus, service, objPath,
1189ae226faSGeorge Liu         "xyz.openbmc_project.Software.Activation", "RequestedActivation",
1199ae226faSGeorge Liu         "xyz.openbmc_project.Software.Activation.RequestedActivations.Active",
1208b24275dSEd Tanous         [](const boost::system::error_code& ec) {
1218b24275dSEd Tanous         if (ec)
12286adcd6dSAndrew Geissler         {
12362598e31SEd Tanous             BMCWEB_LOG_DEBUG("error_code = {}", ec);
12462598e31SEd Tanous             BMCWEB_LOG_DEBUG("error msg = {}", ec.message());
12586adcd6dSAndrew Geissler         }
1269ae226faSGeorge Liu     });
12786adcd6dSAndrew Geissler }
1280554c984SAndrew Geissler 
129c71b6c99SJagpal Singh Gill inline bool handleCreateTask(const boost::system::error_code& ec2,
130c71b6c99SJagpal Singh Gill                              sdbusplus::message_t& msg,
131c71b6c99SJagpal Singh Gill                              const std::shared_ptr<task::TaskData>& taskData)
132c71b6c99SJagpal Singh Gill {
133c71b6c99SJagpal Singh Gill     if (ec2)
134c71b6c99SJagpal Singh Gill     {
135c71b6c99SJagpal Singh Gill         return task::completed;
136c71b6c99SJagpal Singh Gill     }
137c71b6c99SJagpal Singh Gill 
138c71b6c99SJagpal Singh Gill     std::string iface;
139c71b6c99SJagpal Singh Gill     dbus::utility::DBusPropertiesMap values;
140c71b6c99SJagpal Singh Gill 
141c71b6c99SJagpal Singh Gill     std::string index = std::to_string(taskData->index);
142c71b6c99SJagpal Singh Gill     msg.read(iface, values);
143c71b6c99SJagpal Singh Gill 
144c71b6c99SJagpal Singh Gill     if (iface == "xyz.openbmc_project.Software.Activation")
145c71b6c99SJagpal Singh Gill     {
146c71b6c99SJagpal Singh Gill         const std::string* state = nullptr;
147c71b6c99SJagpal Singh Gill         for (const auto& property : values)
148c71b6c99SJagpal Singh Gill         {
149c71b6c99SJagpal Singh Gill             if (property.first == "Activation")
150c71b6c99SJagpal Singh Gill             {
151c71b6c99SJagpal Singh Gill                 state = std::get_if<std::string>(&property.second);
152c71b6c99SJagpal Singh Gill                 if (state == nullptr)
153c71b6c99SJagpal Singh Gill                 {
154c71b6c99SJagpal Singh Gill                     taskData->messages.emplace_back(messages::internalError());
155c71b6c99SJagpal Singh Gill                     return task::completed;
156c71b6c99SJagpal Singh Gill                 }
157c71b6c99SJagpal Singh Gill             }
158c71b6c99SJagpal Singh Gill         }
159c71b6c99SJagpal Singh Gill 
160c71b6c99SJagpal Singh Gill         if (state == nullptr)
161c71b6c99SJagpal Singh Gill         {
162c71b6c99SJagpal Singh Gill             return !task::completed;
163c71b6c99SJagpal Singh Gill         }
164c71b6c99SJagpal Singh Gill 
165c71b6c99SJagpal Singh Gill         if (state->ends_with("Invalid") || state->ends_with("Failed"))
166c71b6c99SJagpal Singh Gill         {
167c71b6c99SJagpal Singh Gill             taskData->state = "Exception";
168c71b6c99SJagpal Singh Gill             taskData->status = "Warning";
169c71b6c99SJagpal Singh Gill             taskData->messages.emplace_back(messages::taskAborted(index));
170c71b6c99SJagpal Singh Gill             return task::completed;
171c71b6c99SJagpal Singh Gill         }
172c71b6c99SJagpal Singh Gill 
173c71b6c99SJagpal Singh Gill         if (state->ends_with("Staged"))
174c71b6c99SJagpal Singh Gill         {
175c71b6c99SJagpal Singh Gill             taskData->state = "Stopping";
176c71b6c99SJagpal Singh Gill             taskData->messages.emplace_back(messages::taskPaused(index));
177c71b6c99SJagpal Singh Gill 
178c71b6c99SJagpal Singh Gill             // its staged, set a long timer to
179c71b6c99SJagpal Singh Gill             // allow them time to complete the
180c71b6c99SJagpal Singh Gill             // update (probably cycle the
181c71b6c99SJagpal Singh Gill             // system) if this expires then
182c71b6c99SJagpal Singh Gill             // task will be canceled
183c71b6c99SJagpal Singh Gill             taskData->extendTimer(std::chrono::hours(5));
184c71b6c99SJagpal Singh Gill             return !task::completed;
185c71b6c99SJagpal Singh Gill         }
186c71b6c99SJagpal Singh Gill 
187c71b6c99SJagpal Singh Gill         if (state->ends_with("Active"))
188c71b6c99SJagpal Singh Gill         {
189c71b6c99SJagpal Singh Gill             taskData->messages.emplace_back(messages::taskCompletedOK(index));
190c71b6c99SJagpal Singh Gill             taskData->state = "Completed";
191c71b6c99SJagpal Singh Gill             return task::completed;
192c71b6c99SJagpal Singh Gill         }
193c71b6c99SJagpal Singh Gill     }
194c71b6c99SJagpal Singh Gill     else if (iface == "xyz.openbmc_project.Software.ActivationProgress")
195c71b6c99SJagpal Singh Gill     {
196c71b6c99SJagpal Singh Gill         const uint8_t* progress = nullptr;
197c71b6c99SJagpal Singh Gill         for (const auto& property : values)
198c71b6c99SJagpal Singh Gill         {
199c71b6c99SJagpal Singh Gill             if (property.first == "Progress")
200c71b6c99SJagpal Singh Gill             {
201c71b6c99SJagpal Singh Gill                 progress = std::get_if<uint8_t>(&property.second);
202c71b6c99SJagpal Singh Gill                 if (progress == nullptr)
203c71b6c99SJagpal Singh Gill                 {
204c71b6c99SJagpal Singh Gill                     taskData->messages.emplace_back(messages::internalError());
205c71b6c99SJagpal Singh Gill                     return task::completed;
206c71b6c99SJagpal Singh Gill                 }
207c71b6c99SJagpal Singh Gill             }
208c71b6c99SJagpal Singh Gill         }
209c71b6c99SJagpal Singh Gill 
210c71b6c99SJagpal Singh Gill         if (progress == nullptr)
211c71b6c99SJagpal Singh Gill         {
212c71b6c99SJagpal Singh Gill             return !task::completed;
213c71b6c99SJagpal Singh Gill         }
214c71b6c99SJagpal Singh Gill         taskData->percentComplete = *progress;
215c71b6c99SJagpal Singh Gill         taskData->messages.emplace_back(
216c71b6c99SJagpal Singh Gill             messages::taskProgressChanged(index, *progress));
217c71b6c99SJagpal Singh Gill 
218c71b6c99SJagpal Singh Gill         // if we're getting status updates it's
219c71b6c99SJagpal Singh Gill         // still alive, update timer
220c71b6c99SJagpal Singh Gill         taskData->extendTimer(std::chrono::minutes(5));
221c71b6c99SJagpal Singh Gill     }
222c71b6c99SJagpal Singh Gill 
223c71b6c99SJagpal Singh Gill     // as firmware update often results in a
224c71b6c99SJagpal Singh Gill     // reboot, the task  may never "complete"
225c71b6c99SJagpal Singh Gill     // unless it is an error
226c71b6c99SJagpal Singh Gill 
227c71b6c99SJagpal Singh Gill     return !task::completed;
228c71b6c99SJagpal Singh Gill }
229c71b6c99SJagpal Singh Gill 
230c71b6c99SJagpal Singh Gill inline void createTask(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
231c71b6c99SJagpal Singh Gill                        task::Payload&& payload,
232c71b6c99SJagpal Singh Gill                        const sdbusplus::message::object_path& objPath)
233c71b6c99SJagpal Singh Gill {
234c71b6c99SJagpal Singh Gill     std::shared_ptr<task::TaskData> task = task::TaskData::createTask(
235c71b6c99SJagpal Singh Gill         std::bind_front(handleCreateTask),
236c71b6c99SJagpal Singh Gill         "type='signal',interface='org.freedesktop.DBus.Properties',"
237c71b6c99SJagpal Singh Gill         "member='PropertiesChanged',path='" +
238c71b6c99SJagpal Singh Gill             objPath.str + "'");
239c71b6c99SJagpal Singh Gill     task->startTimer(std::chrono::minutes(5));
240c71b6c99SJagpal Singh Gill     task->populateResp(asyncResp->res);
241c71b6c99SJagpal Singh Gill     task->payload.emplace(std::move(payload));
242c71b6c99SJagpal Singh Gill }
243c71b6c99SJagpal Singh Gill 
2440554c984SAndrew Geissler // Note that asyncResp can be either a valid pointer or nullptr. If nullptr
2450554c984SAndrew Geissler // then no asyncResp updates will occur
2468d1b46d7Szhanghch05 static void
2478d1b46d7Szhanghch05     softwareInterfaceAdded(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
24859d494eeSPatrick Williams                            sdbusplus::message_t& m, task::Payload&& payload)
24986adcd6dSAndrew Geissler {
25080f79a40SMichael Shen     dbus::utility::DBusInterfacesMap interfacesProperties;
25186adcd6dSAndrew Geissler 
25286adcd6dSAndrew Geissler     sdbusplus::message::object_path objPath;
25386adcd6dSAndrew Geissler 
25486adcd6dSAndrew Geissler     m.read(objPath, interfacesProperties);
25586adcd6dSAndrew Geissler 
25662598e31SEd Tanous     BMCWEB_LOG_DEBUG("obj path = {}", objPath.str);
257e3eb3d63SEd Tanous     for (const auto& interface : interfacesProperties)
25886adcd6dSAndrew Geissler     {
25962598e31SEd Tanous         BMCWEB_LOG_DEBUG("interface = {}", interface.first);
26086adcd6dSAndrew Geissler 
26186adcd6dSAndrew Geissler         if (interface.first == "xyz.openbmc_project.Software.Activation")
26286adcd6dSAndrew Geissler         {
26386adcd6dSAndrew Geissler             // Retrieve service and activate
2642b73119cSGeorge Liu             constexpr std::array<std::string_view, 1> interfaces = {
2652b73119cSGeorge Liu                 "xyz.openbmc_project.Software.Activation"};
2662b73119cSGeorge Liu             dbus::utility::getDbusObject(
2672b73119cSGeorge Liu                 objPath.str, interfaces,
268a3e65892SEd Tanous                 [objPath, asyncResp, payload(std::move(payload))](
2698b24275dSEd Tanous                     const boost::system::error_code& ec,
270a3e65892SEd Tanous                     const std::vector<
271a3e65892SEd Tanous                         std::pair<std::string, std::vector<std::string>>>&
272a3e65892SEd Tanous                         objInfo) mutable {
2738b24275dSEd Tanous                 if (ec)
27486adcd6dSAndrew Geissler                 {
27562598e31SEd Tanous                     BMCWEB_LOG_DEBUG("error_code = {}", ec);
27662598e31SEd Tanous                     BMCWEB_LOG_DEBUG("error msg = {}", ec.message());
2770554c984SAndrew Geissler                     if (asyncResp)
2780554c984SAndrew Geissler                     {
27986adcd6dSAndrew Geissler                         messages::internalError(asyncResp->res);
2800554c984SAndrew Geissler                     }
28186adcd6dSAndrew Geissler                     cleanUp();
28286adcd6dSAndrew Geissler                     return;
28386adcd6dSAndrew Geissler                 }
28486adcd6dSAndrew Geissler                 // Ensure we only got one service back
28586adcd6dSAndrew Geissler                 if (objInfo.size() != 1)
28686adcd6dSAndrew Geissler                 {
28762598e31SEd Tanous                     BMCWEB_LOG_ERROR("Invalid Object Size {}", objInfo.size());
2880554c984SAndrew Geissler                     if (asyncResp)
2890554c984SAndrew Geissler                     {
29086adcd6dSAndrew Geissler                         messages::internalError(asyncResp->res);
2910554c984SAndrew Geissler                     }
29286adcd6dSAndrew Geissler                     cleanUp();
29386adcd6dSAndrew Geissler                     return;
29486adcd6dSAndrew Geissler                 }
29586adcd6dSAndrew Geissler                 // cancel timer only when
29686adcd6dSAndrew Geissler                 // xyz.openbmc_project.Software.Activation interface
29786adcd6dSAndrew Geissler                 // is added
29886adcd6dSAndrew Geissler                 fwAvailableTimer = nullptr;
29986adcd6dSAndrew Geissler 
30086adcd6dSAndrew Geissler                 activateImage(objPath.str, objInfo[0].first);
3010554c984SAndrew Geissler                 if (asyncResp)
3020554c984SAndrew Geissler                 {
303c71b6c99SJagpal Singh Gill                     createTask(asyncResp, std::move(payload), objPath);
3040554c984SAndrew Geissler                 }
30586adcd6dSAndrew Geissler                 fwUpdateInProgress = false;
3062b73119cSGeorge Liu             });
30762bafc01SPatrick Williams 
30862bafc01SPatrick Williams             break;
30986adcd6dSAndrew Geissler         }
31086adcd6dSAndrew Geissler     }
31186adcd6dSAndrew Geissler }
31286adcd6dSAndrew Geissler 
3138549b951SMyung Bae inline void afterAvailbleTimerAsyncWait(
3148549b951SMyung Bae     const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
3158549b951SMyung Bae     const boost::system::error_code& ec)
3168549b951SMyung Bae {
3178549b951SMyung Bae     cleanUp();
3188549b951SMyung Bae     if (ec == boost::asio::error::operation_aborted)
3198549b951SMyung Bae     {
3208549b951SMyung Bae         // expected, we were canceled before the timer completed.
3218549b951SMyung Bae         return;
3228549b951SMyung Bae     }
3238549b951SMyung Bae     BMCWEB_LOG_ERROR("Timed out waiting for firmware object being created");
3248549b951SMyung Bae     BMCWEB_LOG_ERROR("FW image may has already been uploaded to server");
3258549b951SMyung Bae     if (ec)
3268549b951SMyung Bae     {
3278549b951SMyung Bae         BMCWEB_LOG_ERROR("Async_wait failed{}", ec);
3288549b951SMyung Bae         return;
3298549b951SMyung Bae     }
3308549b951SMyung Bae     if (asyncResp)
3318549b951SMyung Bae     {
3328549b951SMyung Bae         redfish::messages::internalError(asyncResp->res);
3338549b951SMyung Bae     }
3348549b951SMyung Bae }
3358549b951SMyung Bae 
3368549b951SMyung Bae inline void
3378549b951SMyung Bae     handleUpdateErrorType(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
3388549b951SMyung Bae                           const std::string& url, const std::string& type)
3398549b951SMyung Bae {
3408549b951SMyung Bae     if (type == "xyz.openbmc_project.Software.Image.Error.UnTarFailure")
3418549b951SMyung Bae     {
3428549b951SMyung Bae         redfish::messages::invalidUpload(asyncResp->res, url,
3438549b951SMyung Bae                                          "Invalid archive");
3448549b951SMyung Bae     }
3458549b951SMyung Bae     else if (type ==
3468549b951SMyung Bae              "xyz.openbmc_project.Software.Image.Error.ManifestFileFailure")
3478549b951SMyung Bae     {
3488549b951SMyung Bae         redfish::messages::invalidUpload(asyncResp->res, url,
3498549b951SMyung Bae                                          "Invalid manifest");
3508549b951SMyung Bae     }
3518549b951SMyung Bae     else if (type == "xyz.openbmc_project.Software.Image.Error.ImageFailure")
3528549b951SMyung Bae     {
3538549b951SMyung Bae         redfish::messages::invalidUpload(asyncResp->res, url,
3548549b951SMyung Bae                                          "Invalid image format");
3558549b951SMyung Bae     }
3568549b951SMyung Bae     else if (type == "xyz.openbmc_project.Software.Version.Error.AlreadyExists")
3578549b951SMyung Bae     {
3588549b951SMyung Bae         redfish::messages::invalidUpload(asyncResp->res, url,
3598549b951SMyung Bae                                          "Image version already exists");
3608549b951SMyung Bae 
3618549b951SMyung Bae         redfish::messages::resourceAlreadyExists(
3628549b951SMyung Bae             asyncResp->res, "UpdateService", "Version", "uploaded version");
3638549b951SMyung Bae     }
3648549b951SMyung Bae     else if (type == "xyz.openbmc_project.Software.Image.Error.BusyFailure")
3658549b951SMyung Bae     {
3668549b951SMyung Bae         redfish::messages::resourceExhaustion(asyncResp->res, url);
3678549b951SMyung Bae     }
3684034a652SMyung Bae     else if (type == "xyz.openbmc_project.Software.Version.Error.Incompatible")
3698549b951SMyung Bae     {
3704034a652SMyung Bae         redfish::messages::invalidUpload(asyncResp->res, url,
3714034a652SMyung Bae                                          "Incompatible image version");
3724034a652SMyung Bae     }
3734034a652SMyung Bae     else if (type ==
3744034a652SMyung Bae              "xyz.openbmc_project.Software.Version.Error.ExpiredAccessKey")
3754034a652SMyung Bae     {
3764034a652SMyung Bae         redfish::messages::invalidUpload(asyncResp->res, url,
3774034a652SMyung Bae                                          "Update Access Key Expired");
3784034a652SMyung Bae     }
3794034a652SMyung Bae     else if (type ==
3804034a652SMyung Bae              "xyz.openbmc_project.Software.Version.Error.InvalidSignature")
3814034a652SMyung Bae     {
3824034a652SMyung Bae         redfish::messages::invalidUpload(asyncResp->res, url,
3834034a652SMyung Bae                                          "Invalid image signature");
3844034a652SMyung Bae     }
3854034a652SMyung Bae     else if (type ==
3864034a652SMyung Bae                  "xyz.openbmc_project.Software.Image.Error.InternalFailure" ||
3874034a652SMyung Bae              type == "xyz.openbmc_project.Software.Version.Error.HostFile")
3884034a652SMyung Bae     {
3894034a652SMyung Bae         BMCWEB_LOG_ERROR("Software Image Error type={}", type);
3908549b951SMyung Bae         redfish::messages::internalError(asyncResp->res);
3918549b951SMyung Bae     }
3924034a652SMyung Bae     else
3934034a652SMyung Bae     {
3944034a652SMyung Bae         // Unrelated error types. Ignored
3954034a652SMyung Bae         BMCWEB_LOG_INFO("Non-Software-related Error type={}. Ignored", type);
3964034a652SMyung Bae         return;
3974034a652SMyung Bae     }
3984034a652SMyung Bae     // Clear the timer
3994034a652SMyung Bae     fwAvailableTimer = nullptr;
4008549b951SMyung Bae }
4018549b951SMyung Bae 
4028549b951SMyung Bae inline void
4038549b951SMyung Bae     afterUpdateErrorMatcher(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
4048549b951SMyung Bae                             const std::string& url, sdbusplus::message_t& m)
4058549b951SMyung Bae {
40680f79a40SMichael Shen     dbus::utility::DBusInterfacesMap interfacesProperties;
4078549b951SMyung Bae     sdbusplus::message::object_path objPath;
4088549b951SMyung Bae     m.read(objPath, interfacesProperties);
4098549b951SMyung Bae     BMCWEB_LOG_DEBUG("obj path = {}", objPath.str);
4108549b951SMyung Bae     for (const std::pair<std::string, dbus::utility::DBusPropertiesMap>&
4118549b951SMyung Bae              interface : interfacesProperties)
4128549b951SMyung Bae     {
4138549b951SMyung Bae         if (interface.first == "xyz.openbmc_project.Logging.Entry")
4148549b951SMyung Bae         {
4158549b951SMyung Bae             for (const std::pair<std::string, dbus::utility::DbusVariantType>&
4168549b951SMyung Bae                      value : interface.second)
4178549b951SMyung Bae             {
4188549b951SMyung Bae                 if (value.first != "Message")
4198549b951SMyung Bae                 {
4208549b951SMyung Bae                     continue;
4218549b951SMyung Bae                 }
4228549b951SMyung Bae                 const std::string* type =
4238549b951SMyung Bae                     std::get_if<std::string>(&value.second);
4248549b951SMyung Bae                 if (type == nullptr)
4258549b951SMyung Bae                 {
4268549b951SMyung Bae                     // if this was our message, timeout will cover it
4278549b951SMyung Bae                     return;
4288549b951SMyung Bae                 }
4298549b951SMyung Bae                 handleUpdateErrorType(asyncResp, url, *type);
4308549b951SMyung Bae             }
4318549b951SMyung Bae         }
4328549b951SMyung Bae     }
4338549b951SMyung Bae }
4348549b951SMyung Bae 
4350554c984SAndrew Geissler // Note that asyncResp can be either a valid pointer or nullptr. If nullptr
4360554c984SAndrew Geissler // then no asyncResp updates will occur
437f5139334SEd Tanous inline void monitorForSoftwareAvailable(
4388d1b46d7Szhanghch05     const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
4398d1b46d7Szhanghch05     const crow::Request& req, const std::string& url,
4405d138943SGunnar Mills     int timeoutTimeSeconds = 25)
44186adcd6dSAndrew Geissler {
44286adcd6dSAndrew Geissler     // Only allow one FW update at a time
443e05aec50SEd Tanous     if (fwUpdateInProgress)
44486adcd6dSAndrew Geissler     {
4450554c984SAndrew Geissler         if (asyncResp)
4460554c984SAndrew Geissler         {
44786adcd6dSAndrew Geissler             messages::serviceTemporarilyUnavailable(asyncResp->res, "30");
4480554c984SAndrew Geissler         }
44986adcd6dSAndrew Geissler         return;
45086adcd6dSAndrew Geissler     }
45186adcd6dSAndrew Geissler 
4528e8245dbSEd Tanous     if (req.ioService == nullptr)
4538e8245dbSEd Tanous     {
4548e8245dbSEd Tanous         messages::internalError(asyncResp->res);
4558e8245dbSEd Tanous         return;
4568e8245dbSEd Tanous     }
4578e8245dbSEd Tanous 
4580554c984SAndrew Geissler     fwAvailableTimer =
459271584abSEd Tanous         std::make_unique<boost::asio::steady_timer>(*req.ioService);
46086adcd6dSAndrew Geissler 
461271584abSEd Tanous     fwAvailableTimer->expires_after(std::chrono::seconds(timeoutTimeSeconds));
46286adcd6dSAndrew Geissler 
46386adcd6dSAndrew Geissler     fwAvailableTimer->async_wait(
4648549b951SMyung Bae         std::bind_front(afterAvailbleTimerAsyncWait, asyncResp));
4658549b951SMyung Bae 
466a3e65892SEd Tanous     task::Payload payload(req);
46759d494eeSPatrick Williams     auto callback = [asyncResp, payload](sdbusplus::message_t& m) mutable {
46862598e31SEd Tanous         BMCWEB_LOG_DEBUG("Match fired");
469a3e65892SEd Tanous         softwareInterfaceAdded(asyncResp, m, std::move(payload));
47086adcd6dSAndrew Geissler     };
47186adcd6dSAndrew Geissler 
47286adcd6dSAndrew Geissler     fwUpdateInProgress = true;
47386adcd6dSAndrew Geissler 
47459d494eeSPatrick Williams     fwUpdateMatcher = std::make_unique<sdbusplus::bus::match_t>(
47586adcd6dSAndrew Geissler         *crow::connections::systemBus,
47686adcd6dSAndrew Geissler         "interface='org.freedesktop.DBus.ObjectManager',type='signal',"
47786adcd6dSAndrew Geissler         "member='InterfacesAdded',path='/xyz/openbmc_project/software'",
47886adcd6dSAndrew Geissler         callback);
4794cde5d90SJames Feist 
48059d494eeSPatrick Williams     fwUpdateErrorMatcher = std::make_unique<sdbusplus::bus::match_t>(
4814cde5d90SJames Feist         *crow::connections::systemBus,
482e1cc4828SBrian Ma         "interface='org.freedesktop.DBus.ObjectManager',type='signal',"
483e1cc4828SBrian Ma         "member='InterfacesAdded',"
484e1cc4828SBrian Ma         "path='/xyz/openbmc_project/logging'",
4858549b951SMyung Bae         std::bind_front(afterUpdateErrorMatcher, asyncResp, url));
48686adcd6dSAndrew Geissler }
487729dae72SJennifer Lee 
488757178a5SEd Tanous inline std::optional<boost::urls::url>
489757178a5SEd Tanous     parseSimpleUpdateUrl(std::string imageURI,
490f86bcc87SEd Tanous                          std::optional<std::string> transferProtocol,
491f86bcc87SEd Tanous                          crow::Response& res)
492f86bcc87SEd Tanous {
493f86bcc87SEd Tanous     if (imageURI.find("://") == std::string::npos)
494f86bcc87SEd Tanous     {
495f86bcc87SEd Tanous         if (imageURI.starts_with("/"))
496f86bcc87SEd Tanous         {
497f86bcc87SEd Tanous             messages::actionParameterValueTypeError(
498f86bcc87SEd Tanous                 res, imageURI, "ImageURI", "UpdateService.SimpleUpdate");
499f86bcc87SEd Tanous             return std::nullopt;
500f86bcc87SEd Tanous         }
501f86bcc87SEd Tanous         if (!transferProtocol)
502f86bcc87SEd Tanous         {
503f86bcc87SEd Tanous             messages::actionParameterValueTypeError(
504f86bcc87SEd Tanous                 res, imageURI, "ImageURI", "UpdateService.SimpleUpdate");
505f86bcc87SEd Tanous             return std::nullopt;
506f86bcc87SEd Tanous         }
507e5cf777eSEd Tanous         // OpenBMC currently only supports TFTP or HTTPS
508757178a5SEd Tanous         if (*transferProtocol == "TFTP")
509757178a5SEd Tanous         {
510757178a5SEd Tanous             imageURI = "tftp://" + imageURI;
511757178a5SEd Tanous         }
512e5cf777eSEd Tanous         else if (*transferProtocol == "HTTPS")
513e5cf777eSEd Tanous         {
514e5cf777eSEd Tanous             imageURI = "https://" + imageURI;
515e5cf777eSEd Tanous         }
516757178a5SEd Tanous         else
517f86bcc87SEd Tanous         {
518f86bcc87SEd Tanous             messages::actionParameterNotSupported(res, "TransferProtocol",
519f86bcc87SEd Tanous                                                   *transferProtocol);
520f86bcc87SEd Tanous             BMCWEB_LOG_ERROR("Request incorrect protocol parameter: {}",
521f86bcc87SEd Tanous                              *transferProtocol);
522f86bcc87SEd Tanous             return std::nullopt;
523f86bcc87SEd Tanous         }
524f86bcc87SEd Tanous     }
525f86bcc87SEd Tanous 
526f86bcc87SEd Tanous     boost::system::result<boost::urls::url> url =
527f86bcc87SEd Tanous         boost::urls::parse_absolute_uri(imageURI);
528f86bcc87SEd Tanous     if (!url)
529f86bcc87SEd Tanous     {
530f86bcc87SEd Tanous         messages::actionParameterValueTypeError(res, imageURI, "ImageURI",
531f86bcc87SEd Tanous                                                 "UpdateService.SimpleUpdate");
532f86bcc87SEd Tanous 
533f86bcc87SEd Tanous         return std::nullopt;
534f86bcc87SEd Tanous     }
535f86bcc87SEd Tanous     url->normalize();
536f86bcc87SEd Tanous 
537757178a5SEd Tanous     if (url->scheme() == "tftp")
538757178a5SEd Tanous     {
539757178a5SEd Tanous         if (url->encoded_path().size() < 2)
540757178a5SEd Tanous         {
541757178a5SEd Tanous             messages::actionParameterNotSupported(res, "ImageURI",
542757178a5SEd Tanous                                                   url->buffer());
543757178a5SEd Tanous             return std::nullopt;
544757178a5SEd Tanous         }
545757178a5SEd Tanous     }
546e5cf777eSEd Tanous     else if (url->scheme() == "https")
547e5cf777eSEd Tanous     {
548e5cf777eSEd Tanous         // Empty paths default to "/"
549e5cf777eSEd Tanous         if (url->encoded_path().empty())
550e5cf777eSEd Tanous         {
551e5cf777eSEd Tanous             url->set_encoded_path("/");
552e5cf777eSEd Tanous         }
553e5cf777eSEd Tanous     }
554757178a5SEd Tanous     else
555f86bcc87SEd Tanous     {
556f86bcc87SEd Tanous         messages::actionParameterNotSupported(res, "ImageURI", imageURI);
557f86bcc87SEd Tanous         return std::nullopt;
558f86bcc87SEd Tanous     }
559757178a5SEd Tanous 
560757178a5SEd Tanous     if (url->encoded_path().empty())
561f86bcc87SEd Tanous     {
562757178a5SEd Tanous         messages::actionParameterValueTypeError(res, imageURI, "ImageURI",
563757178a5SEd Tanous                                                 "UpdateService.SimpleUpdate");
564f86bcc87SEd Tanous         return std::nullopt;
565f86bcc87SEd Tanous     }
566757178a5SEd Tanous 
567757178a5SEd Tanous     return *url;
568f86bcc87SEd Tanous }
569f86bcc87SEd Tanous 
570e5cf777eSEd Tanous inline void doHttpsUpdate(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
571e5cf777eSEd Tanous                           const boost::urls::url_view_base& url)
572e5cf777eSEd Tanous {
573e5cf777eSEd Tanous     messages::actionParameterNotSupported(asyncResp->res, "ImageURI",
574e5cf777eSEd Tanous                                           url.buffer());
575e5cf777eSEd Tanous }
576e5cf777eSEd Tanous 
5776b0f66bdSEd Tanous inline void doTftpUpdate(const crow::Request& req,
5786b0f66bdSEd Tanous                          const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
579757178a5SEd Tanous                          const boost::urls::url_view_base& url)
5806b0f66bdSEd Tanous {
581c72503f3SEd Tanous     if (!BMCWEB_INSECURE_TFTP_UPDATE)
582c72503f3SEd Tanous     {
5836b0f66bdSEd Tanous         messages::actionParameterNotSupported(asyncResp->res, "ImageURI",
584757178a5SEd Tanous                                               url.buffer());
5856b0f66bdSEd Tanous         return;
586c72503f3SEd Tanous     }
587757178a5SEd Tanous 
588757178a5SEd Tanous     std::string path(url.encoded_path());
589757178a5SEd Tanous     if (path.size() < 2)
590757178a5SEd Tanous     {
591757178a5SEd Tanous         messages::actionParameterNotSupported(asyncResp->res, "ImageURI",
592757178a5SEd Tanous                                               url.buffer());
593757178a5SEd Tanous         return;
594757178a5SEd Tanous     }
595757178a5SEd Tanous     // TFTP expects a path without a /
596757178a5SEd Tanous     path.erase(0, 1);
597757178a5SEd Tanous     std::string host(url.encoded_host_and_port());
598757178a5SEd Tanous     BMCWEB_LOG_DEBUG("Server: {} File: {}", host, path);
5996b0f66bdSEd Tanous 
6006b0f66bdSEd Tanous     // Setup callback for when new software detected
6016b0f66bdSEd Tanous     // Give TFTP 10 minutes to complete
6026b0f66bdSEd Tanous     monitorForSoftwareAvailable(
6036b0f66bdSEd Tanous         asyncResp, req,
6046b0f66bdSEd Tanous         "/redfish/v1/UpdateService/Actions/UpdateService.SimpleUpdate", 600);
6056b0f66bdSEd Tanous 
6066b0f66bdSEd Tanous     // TFTP can take up to 10 minutes depending on image size and
6076b0f66bdSEd Tanous     // connection speed. Return to caller as soon as the TFTP operation
6086b0f66bdSEd Tanous     // has been started. The callback above will ensure the activate
6096b0f66bdSEd Tanous     // is started once the download has completed
6106b0f66bdSEd Tanous     redfish::messages::success(asyncResp->res);
6116b0f66bdSEd Tanous 
6126b0f66bdSEd Tanous     // Call TFTP service
6136b0f66bdSEd Tanous     crow::connections::systemBus->async_method_call(
6146b0f66bdSEd Tanous         [](const boost::system::error_code& ec) {
6156b0f66bdSEd Tanous         if (ec)
6166b0f66bdSEd Tanous         {
6176b0f66bdSEd Tanous             // messages::internalError(asyncResp->res);
6186b0f66bdSEd Tanous             cleanUp();
6196b0f66bdSEd Tanous             BMCWEB_LOG_DEBUG("error_code = {}", ec);
6206b0f66bdSEd Tanous             BMCWEB_LOG_DEBUG("error msg = {}", ec.message());
6216b0f66bdSEd Tanous         }
6226b0f66bdSEd Tanous         else
6236b0f66bdSEd Tanous         {
6246b0f66bdSEd Tanous             BMCWEB_LOG_DEBUG("Call to DownloaViaTFTP Success");
6256b0f66bdSEd Tanous         }
6266b0f66bdSEd Tanous     },
6276b0f66bdSEd Tanous         "xyz.openbmc_project.Software.Download",
6286b0f66bdSEd Tanous         "/xyz/openbmc_project/software", "xyz.openbmc_project.Common.TFTP",
629757178a5SEd Tanous         "DownloadViaTFTP", path, host);
6306b0f66bdSEd Tanous }
6316b0f66bdSEd Tanous 
632f5139334SEd Tanous inline void handleUpdateServiceSimpleUpdateAction(
633f5139334SEd Tanous     crow::App& app, const crow::Request& req,
634f5139334SEd Tanous     const std::shared_ptr<bmcweb::AsyncResp>& asyncResp)
6350554c984SAndrew Geissler {
6363ba00073SCarson Labrado     if (!redfish::setUpRedfishRoute(app, req, asyncResp))
63745ca1b86SEd Tanous     {
63845ca1b86SEd Tanous         return;
63945ca1b86SEd Tanous     }
64045ca1b86SEd Tanous 
6410554c984SAndrew Geissler     std::optional<std::string> transferProtocol;
6420554c984SAndrew Geissler     std::string imageURI;
6430554c984SAndrew Geissler 
64462598e31SEd Tanous     BMCWEB_LOG_DEBUG("Enter UpdateService.SimpleUpdate doPost");
6450554c984SAndrew Geissler 
6460554c984SAndrew Geissler     // User can pass in both TransferProtocol and ImageURI parameters or
6474e0453b1SGunnar Mills     // they can pass in just the ImageURI with the transfer protocol
6484e0453b1SGunnar Mills     // embedded within it.
6490554c984SAndrew Geissler     // 1) TransferProtocol:TFTP ImageURI:1.1.1.1/myfile.bin
6500554c984SAndrew Geissler     // 2) ImageURI:tftp://1.1.1.1/myfile.bin
6510554c984SAndrew Geissler 
652002d39b4SEd Tanous     if (!json_util::readJsonAction(req, asyncResp->res, "TransferProtocol",
653002d39b4SEd Tanous                                    transferProtocol, "ImageURI", imageURI))
6540554c984SAndrew Geissler     {
65562598e31SEd Tanous         BMCWEB_LOG_DEBUG("Missing TransferProtocol or ImageURI parameter");
6560554c984SAndrew Geissler         return;
6570554c984SAndrew Geissler     }
658f5139334SEd Tanous 
659757178a5SEd Tanous     std::optional<boost::urls::url> url =
660757178a5SEd Tanous         parseSimpleUpdateUrl(imageURI, transferProtocol, asyncResp->res);
661757178a5SEd Tanous     if (!url)
6620554c984SAndrew Geissler     {
6630554c984SAndrew Geissler         return;
6640554c984SAndrew Geissler     }
665757178a5SEd Tanous     if (url->scheme() == "tftp")
666757178a5SEd Tanous     {
667757178a5SEd Tanous         doTftpUpdate(req, asyncResp, *url);
668757178a5SEd Tanous     }
669e5cf777eSEd Tanous     else if (url->scheme() == "https")
670e5cf777eSEd Tanous     {
671e5cf777eSEd Tanous         doHttpsUpdate(asyncResp, *url);
672e5cf777eSEd Tanous     }
673757178a5SEd Tanous     else
674757178a5SEd Tanous     {
675757178a5SEd Tanous         messages::actionParameterNotSupported(asyncResp->res, "ImageURI",
676757178a5SEd Tanous                                               url->buffer());
677757178a5SEd Tanous         return;
678757178a5SEd Tanous     }
6790554c984SAndrew Geissler 
68062598e31SEd Tanous     BMCWEB_LOG_DEBUG("Exit UpdateService.SimpleUpdate doPost");
681729dae72SJennifer Lee }
682729dae72SJennifer Lee 
6830ed80c8cSGeorge Liu inline void uploadImageFile(crow::Response& res, std::string_view body)
6840ed80c8cSGeorge Liu {
6852c6ffdb0SEd Tanous     std::filesystem::path filepath("/tmp/images/" + bmcweb::getRandomUUID());
6862c6ffdb0SEd Tanous 
68762598e31SEd Tanous     BMCWEB_LOG_DEBUG("Writing file to {}", filepath.string());
6880ed80c8cSGeorge Liu     std::ofstream out(filepath, std::ofstream::out | std::ofstream::binary |
6890ed80c8cSGeorge Liu                                     std::ofstream::trunc);
6900ed80c8cSGeorge Liu     // set the permission of the file to 640
69189492a15SPatrick Williams     std::filesystem::perms permission = std::filesystem::perms::owner_read |
69289492a15SPatrick Williams                                         std::filesystem::perms::group_read;
6930ed80c8cSGeorge Liu     std::filesystem::permissions(filepath, permission);
6940ed80c8cSGeorge Liu     out << body;
6950ed80c8cSGeorge Liu 
6960ed80c8cSGeorge Liu     if (out.bad())
6970ed80c8cSGeorge Liu     {
6980ed80c8cSGeorge Liu         messages::internalError(res);
6990ed80c8cSGeorge Liu         cleanUp();
7000ed80c8cSGeorge Liu     }
7010ed80c8cSGeorge Liu }
7020ed80c8cSGeorge Liu 
703de0c960cSJagpal Singh Gill // Convert the Request Apply Time to the D-Bus value
704de0c960cSJagpal Singh Gill inline bool convertApplyTime(crow::Response& res, const std::string& applyTime,
705de0c960cSJagpal Singh Gill                              std::string& applyTimeNewVal)
706de0c960cSJagpal Singh Gill {
707de0c960cSJagpal Singh Gill     if (applyTime == "Immediate")
708de0c960cSJagpal Singh Gill     {
709de0c960cSJagpal Singh Gill         applyTimeNewVal =
710049079f6SJagpal Singh Gill             "xyz.openbmc_project.Software.ApplyTime.RequestedApplyTimes.Immediate";
711de0c960cSJagpal Singh Gill     }
712de0c960cSJagpal Singh Gill     else if (applyTime == "OnReset")
713de0c960cSJagpal Singh Gill     {
714de0c960cSJagpal Singh Gill         applyTimeNewVal =
715049079f6SJagpal Singh Gill             "xyz.openbmc_project.Software.ApplyTime.RequestedApplyTimes.OnReset";
716de0c960cSJagpal Singh Gill     }
717de0c960cSJagpal Singh Gill     else
718de0c960cSJagpal Singh Gill     {
719de0c960cSJagpal Singh Gill         BMCWEB_LOG_WARNING(
720de0c960cSJagpal Singh Gill             "ApplyTime value {} is not in the list of acceptable values",
721de0c960cSJagpal Singh Gill             applyTime);
722de0c960cSJagpal Singh Gill         messages::propertyValueNotInList(res, applyTime, "ApplyTime");
723de0c960cSJagpal Singh Gill         return false;
724de0c960cSJagpal Singh Gill     }
725de0c960cSJagpal Singh Gill     return true;
726de0c960cSJagpal Singh Gill }
727de0c960cSJagpal Singh Gill 
7280ed80c8cSGeorge Liu inline void setApplyTime(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
7290ed80c8cSGeorge Liu                          const std::string& applyTime)
7300ed80c8cSGeorge Liu {
7310ed80c8cSGeorge Liu     std::string applyTimeNewVal;
732049079f6SJagpal Singh Gill     if (!convertApplyTime(asyncResp->res, applyTime, applyTimeNewVal))
7330ed80c8cSGeorge Liu     {
7340ed80c8cSGeorge Liu         return;
7350ed80c8cSGeorge Liu     }
7360ed80c8cSGeorge Liu 
737e93abac6SGinu George     setDbusProperty(asyncResp, "ApplyTime", "xyz.openbmc_project.Settings",
738d02aad39SEd Tanous                     sdbusplus::message::object_path(
739d02aad39SEd Tanous                         "/xyz/openbmc_project/software/apply_time"),
740d02aad39SEd Tanous                     "xyz.openbmc_project.Software.ApplyTime",
741e93abac6SGinu George                     "RequestedApplyTime", applyTimeNewVal);
7420ed80c8cSGeorge Liu }
7430ed80c8cSGeorge Liu 
744ef93eab3SJagpal Singh Gill struct MultiPartUpdateParameters
7450ed80c8cSGeorge Liu {
746ef93eab3SJagpal Singh Gill     std::optional<std::string> applyTime;
747ef93eab3SJagpal Singh Gill     std::string uploadData;
748de0c960cSJagpal Singh Gill     std::vector<std::string> targets;
749ef93eab3SJagpal Singh Gill };
750ef93eab3SJagpal Singh Gill 
751de0c960cSJagpal Singh Gill inline std::optional<std::string>
752de0c960cSJagpal Singh Gill     processUrl(boost::system::result<boost::urls::url_view>& url)
753de0c960cSJagpal Singh Gill {
754de0c960cSJagpal Singh Gill     if (!url)
755de0c960cSJagpal Singh Gill     {
756de0c960cSJagpal Singh Gill         return std::nullopt;
757de0c960cSJagpal Singh Gill     }
758de0c960cSJagpal Singh Gill     if (crow::utility::readUrlSegments(*url, "redfish", "v1", "Managers",
759de0c960cSJagpal Singh Gill                                        BMCWEB_REDFISH_MANAGER_URI_NAME))
760de0c960cSJagpal Singh Gill     {
761de0c960cSJagpal Singh Gill         return std::make_optional(std::string(BMCWEB_REDFISH_MANAGER_URI_NAME));
762de0c960cSJagpal Singh Gill     }
763de0c960cSJagpal Singh Gill     if constexpr (!BMCWEB_REDFISH_UPDATESERVICE_USE_DBUS)
764de0c960cSJagpal Singh Gill     {
765de0c960cSJagpal Singh Gill         return std::nullopt;
766de0c960cSJagpal Singh Gill     }
767de0c960cSJagpal Singh Gill     std::string firmwareId;
768de0c960cSJagpal Singh Gill     if (!crow::utility::readUrlSegments(*url, "redfish", "v1", "UpdateService",
769de0c960cSJagpal Singh Gill                                         "FirmwareInventory",
770de0c960cSJagpal Singh Gill                                         std::ref(firmwareId)))
771de0c960cSJagpal Singh Gill     {
772de0c960cSJagpal Singh Gill         return std::nullopt;
773de0c960cSJagpal Singh Gill     }
774de0c960cSJagpal Singh Gill 
775de0c960cSJagpal Singh Gill     return std::make_optional(firmwareId);
776de0c960cSJagpal Singh Gill }
777de0c960cSJagpal Singh Gill 
778ef93eab3SJagpal Singh Gill inline std::optional<MultiPartUpdateParameters>
779ef93eab3SJagpal Singh Gill     extractMultipartUpdateParameters(
780ef93eab3SJagpal Singh Gill         const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
781ef93eab3SJagpal Singh Gill         MultipartParser parser)
782ef93eab3SJagpal Singh Gill {
783ef93eab3SJagpal Singh Gill     MultiPartUpdateParameters multiRet;
784ef93eab3SJagpal Singh Gill     for (FormPart& formpart : parser.mime_fields)
7850ed80c8cSGeorge Liu     {
7860ed80c8cSGeorge Liu         boost::beast::http::fields::const_iterator it =
7870ed80c8cSGeorge Liu             formpart.fields.find("Content-Disposition");
7880ed80c8cSGeorge Liu         if (it == formpart.fields.end())
7890ed80c8cSGeorge Liu         {
79062598e31SEd Tanous             BMCWEB_LOG_ERROR("Couldn't find Content-Disposition");
791ef93eab3SJagpal Singh Gill             return std::nullopt;
7920ed80c8cSGeorge Liu         }
79362598e31SEd Tanous         BMCWEB_LOG_INFO("Parsing value {}", it->value());
7940ed80c8cSGeorge Liu 
7950ed80c8cSGeorge Liu         // The construction parameters of param_list must start with `;`
7960ed80c8cSGeorge Liu         size_t index = it->value().find(';');
7970ed80c8cSGeorge Liu         if (index == std::string::npos)
7980ed80c8cSGeorge Liu         {
7990ed80c8cSGeorge Liu             continue;
8000ed80c8cSGeorge Liu         }
8010ed80c8cSGeorge Liu 
80289492a15SPatrick Williams         for (const auto& param :
8030ed80c8cSGeorge Liu              boost::beast::http::param_list{it->value().substr(index)})
8040ed80c8cSGeorge Liu         {
8050ed80c8cSGeorge Liu             if (param.first != "name" || param.second.empty())
8060ed80c8cSGeorge Liu             {
8070ed80c8cSGeorge Liu                 continue;
8080ed80c8cSGeorge Liu             }
8090ed80c8cSGeorge Liu 
8100ed80c8cSGeorge Liu             if (param.second == "UpdateParameters")
8110ed80c8cSGeorge Liu             {
812ef93eab3SJagpal Singh Gill                 std::vector<std::string> tempTargets;
813ac1e1246SEd Tanous                 nlohmann::json content = nlohmann::json::parse(formpart.content,
814ac1e1246SEd Tanous                                                                nullptr, false);
815ac1e1246SEd Tanous                 if (content.is_discarded())
816ac1e1246SEd Tanous                 {
817ac1e1246SEd Tanous                     return std::nullopt;
818ac1e1246SEd Tanous                 }
8197cb59f65SEd Tanous                 nlohmann::json::object_t* obj =
8207cb59f65SEd Tanous                     content.get_ptr<nlohmann::json::object_t*>();
8217cb59f65SEd Tanous                 if (obj == nullptr)
8227cb59f65SEd Tanous                 {
823ef93eab3SJagpal Singh Gill                     messages::propertyValueTypeError(
824ef93eab3SJagpal Singh Gill                         asyncResp->res, formpart.content, "UpdateParameters");
825ef93eab3SJagpal Singh Gill                     return std::nullopt;
8267cb59f65SEd Tanous                 }
8277cb59f65SEd Tanous 
8287cb59f65SEd Tanous                 if (!json_util::readJsonObject(
829ef93eab3SJagpal Singh Gill                         *obj, asyncResp->res, "Targets", tempTargets,
830ef93eab3SJagpal Singh Gill                         "@Redfish.OperationApplyTime", multiRet.applyTime))
8310ed80c8cSGeorge Liu                 {
832ef93eab3SJagpal Singh Gill                     return std::nullopt;
8330ed80c8cSGeorge Liu                 }
834ef93eab3SJagpal Singh Gill 
835ef93eab3SJagpal Singh Gill                 for (size_t urlIndex = 0; urlIndex < tempTargets.size();
836ef93eab3SJagpal Singh Gill                      urlIndex++)
8370ed80c8cSGeorge Liu                 {
838ef93eab3SJagpal Singh Gill                     const std::string& target = tempTargets[urlIndex];
839ef93eab3SJagpal Singh Gill                     boost::system::result<boost::urls::url_view> url =
840ef93eab3SJagpal Singh Gill                         boost::urls::parse_origin_form(target);
841de0c960cSJagpal Singh Gill                     auto res = processUrl(url);
842de0c960cSJagpal Singh Gill                     if (!res.has_value())
8430ed80c8cSGeorge Liu                     {
844ef93eab3SJagpal Singh Gill                         messages::propertyValueFormatError(
845ef93eab3SJagpal Singh Gill                             asyncResp->res, target,
846ef93eab3SJagpal Singh Gill                             std::format("Targets/{}", urlIndex));
847ef93eab3SJagpal Singh Gill                         return std::nullopt;
8480ed80c8cSGeorge Liu                     }
849de0c960cSJagpal Singh Gill                     multiRet.targets.emplace_back(res.value());
850ef93eab3SJagpal Singh Gill                 }
851ef93eab3SJagpal Singh Gill                 if (multiRet.targets.size() != 1)
852ef93eab3SJagpal Singh Gill                 {
853ef93eab3SJagpal Singh Gill                     messages::propertyValueFormatError(
854ef93eab3SJagpal Singh Gill                         asyncResp->res, multiRet.targets, "Targets");
855ef93eab3SJagpal Singh Gill                     return std::nullopt;
856ef93eab3SJagpal Singh Gill                 }
8570ed80c8cSGeorge Liu             }
8580ed80c8cSGeorge Liu             else if (param.second == "UpdateFile")
8590ed80c8cSGeorge Liu             {
860ef93eab3SJagpal Singh Gill                 multiRet.uploadData = std::move(formpart.content);
8610ed80c8cSGeorge Liu             }
8620ed80c8cSGeorge Liu         }
8630ed80c8cSGeorge Liu     }
8640ed80c8cSGeorge Liu 
865ef93eab3SJagpal Singh Gill     if (multiRet.uploadData.empty())
8660ed80c8cSGeorge Liu     {
86762598e31SEd Tanous         BMCWEB_LOG_ERROR("Upload data is NULL");
8680ed80c8cSGeorge Liu         messages::propertyMissing(asyncResp->res, "UpdateFile");
869ef93eab3SJagpal Singh Gill         return std::nullopt;
8700ed80c8cSGeorge Liu     }
871ef93eab3SJagpal Singh Gill     if (multiRet.targets.empty())
8720ed80c8cSGeorge Liu     {
873ef93eab3SJagpal Singh Gill         messages::propertyMissing(asyncResp->res, "Targets");
874ef93eab3SJagpal Singh Gill         return std::nullopt;
875ef93eab3SJagpal Singh Gill     }
876ef93eab3SJagpal Singh Gill     return multiRet;
8770ed80c8cSGeorge Liu }
8780ed80c8cSGeorge Liu 
879ef93eab3SJagpal Singh Gill inline void
880de0c960cSJagpal Singh Gill     handleStartUpdate(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
881de0c960cSJagpal Singh Gill                       task::Payload payload, const std::string& objectPath,
882de0c960cSJagpal Singh Gill                       const boost::system::error_code& ec,
883de0c960cSJagpal Singh Gill                       const sdbusplus::message::object_path& retPath)
884de0c960cSJagpal Singh Gill {
885de0c960cSJagpal Singh Gill     if (ec)
886de0c960cSJagpal Singh Gill     {
887de0c960cSJagpal Singh Gill         BMCWEB_LOG_ERROR("error_code = {}", ec);
888de0c960cSJagpal Singh Gill         BMCWEB_LOG_ERROR("error msg = {}", ec.message());
889de0c960cSJagpal Singh Gill         messages::internalError(asyncResp->res);
890de0c960cSJagpal Singh Gill         return;
891de0c960cSJagpal Singh Gill     }
892de0c960cSJagpal Singh Gill 
893de0c960cSJagpal Singh Gill     BMCWEB_LOG_INFO("Call to StartUpdate Success, retPath = {}", retPath.str);
894de0c960cSJagpal Singh Gill     createTask(asyncResp, std::move(payload), objectPath);
895de0c960cSJagpal Singh Gill }
896de0c960cSJagpal Singh Gill 
897de0c960cSJagpal Singh Gill inline void startUpdate(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
898de0c960cSJagpal Singh Gill                         task::Payload payload,
899de0c960cSJagpal Singh Gill                         const MemoryFileDescriptor& memfd,
900de0c960cSJagpal Singh Gill                         const std::string& applyTime,
901de0c960cSJagpal Singh Gill                         const std::string& objectPath,
902de0c960cSJagpal Singh Gill                         const std::string& serviceName)
903de0c960cSJagpal Singh Gill {
904de0c960cSJagpal Singh Gill     crow::connections::systemBus->async_method_call(
905de0c960cSJagpal Singh Gill         [asyncResp, payload = std::move(payload),
906de0c960cSJagpal Singh Gill          objectPath](const boost::system::error_code& ec1,
907de0c960cSJagpal Singh Gill                      const sdbusplus::message::object_path& retPath) mutable {
908de0c960cSJagpal Singh Gill         handleStartUpdate(asyncResp, std::move(payload), objectPath, ec1,
909de0c960cSJagpal Singh Gill                           retPath);
910de0c960cSJagpal Singh Gill     },
911de0c960cSJagpal Singh Gill         serviceName, objectPath, "xyz.openbmc_project.Software.Update",
912de0c960cSJagpal Singh Gill         "StartUpdate", sdbusplus::message::unix_fd(memfd.fd), applyTime);
913de0c960cSJagpal Singh Gill }
914de0c960cSJagpal Singh Gill 
91508f61d53SJagpal Singh Gill inline void getSwInfo(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
91608f61d53SJagpal Singh Gill                       task::Payload payload, const MemoryFileDescriptor& memfd,
91708f61d53SJagpal Singh Gill                       const std::string& applyTime, const std::string& target,
918de0c960cSJagpal Singh Gill                       const boost::system::error_code& ec,
919de0c960cSJagpal Singh Gill                       const dbus::utility::MapperGetSubTreeResponse& subtree)
920de0c960cSJagpal Singh Gill {
92108f61d53SJagpal Singh Gill     using SwInfoMap = std::unordered_map<
92208f61d53SJagpal Singh Gill         std::string, std::pair<sdbusplus::message::object_path, std::string>>;
923de0c960cSJagpal Singh Gill     SwInfoMap swInfoMap;
924de0c960cSJagpal Singh Gill 
925de0c960cSJagpal Singh Gill     if (ec)
926de0c960cSJagpal Singh Gill     {
927de0c960cSJagpal Singh Gill         BMCWEB_LOG_ERROR("error_code = {}", ec);
928de0c960cSJagpal Singh Gill         BMCWEB_LOG_ERROR("error msg = {}", ec.message());
929de0c960cSJagpal Singh Gill         messages::internalError(asyncResp->res);
930de0c960cSJagpal Singh Gill         return;
931de0c960cSJagpal Singh Gill     }
932de0c960cSJagpal Singh Gill     BMCWEB_LOG_DEBUG("Found {} software version paths", subtree.size());
933de0c960cSJagpal Singh Gill 
93408f61d53SJagpal Singh Gill     for (const auto& entry : subtree)
935de0c960cSJagpal Singh Gill     {
93608f61d53SJagpal Singh Gill         sdbusplus::message::object_path path(entry.first);
937de0c960cSJagpal Singh Gill         std::string swId = path.filename();
93808f61d53SJagpal Singh Gill         swInfoMap.emplace(swId, make_pair(path, entry.second[0].first));
939de0c960cSJagpal Singh Gill     }
940de0c960cSJagpal Singh Gill 
941de0c960cSJagpal Singh Gill     auto swEntry = swInfoMap.find(target);
942de0c960cSJagpal Singh Gill     if (swEntry == swInfoMap.end())
943de0c960cSJagpal Singh Gill     {
944de0c960cSJagpal Singh Gill         BMCWEB_LOG_WARNING("No valid DBus path for Target URI {}", target);
945de0c960cSJagpal Singh Gill         messages::propertyValueFormatError(asyncResp->res, target, "Targets");
946de0c960cSJagpal Singh Gill         return;
947de0c960cSJagpal Singh Gill     }
948de0c960cSJagpal Singh Gill 
94908f61d53SJagpal Singh Gill     BMCWEB_LOG_DEBUG("Found software version path {} serviceName {}",
95008f61d53SJagpal Singh Gill                      swEntry->second.first.str, swEntry->second.second);
951de0c960cSJagpal Singh Gill 
95208f61d53SJagpal Singh Gill     startUpdate(asyncResp, std::move(payload), memfd, applyTime,
95308f61d53SJagpal Singh Gill                 swEntry->second.first.str, swEntry->second.second);
95408f61d53SJagpal Singh Gill }
95508f61d53SJagpal Singh Gill 
95608f61d53SJagpal Singh Gill inline void
95708f61d53SJagpal Singh Gill     handleBMCUpdate(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
95808f61d53SJagpal Singh Gill                     task::Payload payload, const MemoryFileDescriptor& memfd,
95908f61d53SJagpal Singh Gill                     const std::string& applyTime,
96008f61d53SJagpal Singh Gill                     const boost::system::error_code& ec,
96108f61d53SJagpal Singh Gill                     const dbus::utility::MapperEndPoints& functionalSoftware)
96208f61d53SJagpal Singh Gill {
96308f61d53SJagpal Singh Gill     if (ec)
96408f61d53SJagpal Singh Gill     {
96508f61d53SJagpal Singh Gill         BMCWEB_LOG_ERROR("error_code = {}", ec);
96608f61d53SJagpal Singh Gill         BMCWEB_LOG_ERROR("error msg = {}", ec.message());
96708f61d53SJagpal Singh Gill         messages::internalError(asyncResp->res);
96808f61d53SJagpal Singh Gill         return;
96908f61d53SJagpal Singh Gill     }
97008f61d53SJagpal Singh Gill     if (functionalSoftware.size() != 1)
97108f61d53SJagpal Singh Gill     {
97208f61d53SJagpal Singh Gill         BMCWEB_LOG_ERROR("Found {} functional software endpoints",
97308f61d53SJagpal Singh Gill                          functionalSoftware.size());
97408f61d53SJagpal Singh Gill         messages::internalError(asyncResp->res);
97508f61d53SJagpal Singh Gill         return;
97608f61d53SJagpal Singh Gill     }
97708f61d53SJagpal Singh Gill 
97808f61d53SJagpal Singh Gill     startUpdate(asyncResp, std::move(payload), memfd, applyTime,
97908f61d53SJagpal Singh Gill                 functionalSoftware[0], "xyz.openbmc_project.Software.Manager");
980de0c960cSJagpal Singh Gill }
981de0c960cSJagpal Singh Gill 
982de0c960cSJagpal Singh Gill inline void
983de0c960cSJagpal Singh Gill     processUpdateRequest(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
9849dae4deeSJagpal Singh Gill                          task::Payload&& payload, std::string_view body,
985de0c960cSJagpal Singh Gill                          const std::string& applyTime,
986de0c960cSJagpal Singh Gill                          std::vector<std::string>& targets)
987de0c960cSJagpal Singh Gill {
988de0c960cSJagpal Singh Gill     MemoryFileDescriptor memfd("update-image");
989de0c960cSJagpal Singh Gill     if (memfd.fd == -1)
990de0c960cSJagpal Singh Gill     {
991de0c960cSJagpal Singh Gill         BMCWEB_LOG_ERROR("Failed to create image memfd");
992de0c960cSJagpal Singh Gill         messages::internalError(asyncResp->res);
993de0c960cSJagpal Singh Gill         return;
994de0c960cSJagpal Singh Gill     }
995de0c960cSJagpal Singh Gill     if (write(memfd.fd, body.data(), body.length()) !=
996de0c960cSJagpal Singh Gill         static_cast<ssize_t>(body.length()))
997de0c960cSJagpal Singh Gill     {
998de0c960cSJagpal Singh Gill         BMCWEB_LOG_ERROR("Failed to write to image memfd");
999de0c960cSJagpal Singh Gill         messages::internalError(asyncResp->res);
1000de0c960cSJagpal Singh Gill         return;
1001de0c960cSJagpal Singh Gill     }
1002de0c960cSJagpal Singh Gill     if (!memfd.rewind())
1003de0c960cSJagpal Singh Gill     {
1004de0c960cSJagpal Singh Gill         messages::internalError(asyncResp->res);
1005de0c960cSJagpal Singh Gill         return;
1006de0c960cSJagpal Singh Gill     }
1007de0c960cSJagpal Singh Gill 
1008de0c960cSJagpal Singh Gill     if (!targets.empty() && targets[0] == BMCWEB_REDFISH_MANAGER_URI_NAME)
1009de0c960cSJagpal Singh Gill     {
101008f61d53SJagpal Singh Gill         dbus::utility::getAssociationEndPoints(
101108f61d53SJagpal Singh Gill             "/xyz/openbmc_project/software/bmc/functional",
101208f61d53SJagpal Singh Gill             [asyncResp, payload = std::move(payload), memfd = std::move(memfd),
101308f61d53SJagpal Singh Gill              applyTime](
101408f61d53SJagpal Singh Gill                 const boost::system::error_code& ec,
101508f61d53SJagpal Singh Gill                 const dbus::utility::MapperEndPoints& objectPaths) mutable {
101608f61d53SJagpal Singh Gill             handleBMCUpdate(asyncResp, std::move(payload), memfd, applyTime, ec,
101708f61d53SJagpal Singh Gill                             objectPaths);
101808f61d53SJagpal Singh Gill         });
1019de0c960cSJagpal Singh Gill     }
1020de0c960cSJagpal Singh Gill     else
1021de0c960cSJagpal Singh Gill     {
1022de0c960cSJagpal Singh Gill         constexpr std::array<std::string_view, 1> interfaces = {
1023de0c960cSJagpal Singh Gill             "xyz.openbmc_project.Software.Version"};
102408f61d53SJagpal Singh Gill         dbus::utility::getSubTree(
1025de0c960cSJagpal Singh Gill             "/xyz/openbmc_project/software", 1, interfaces,
1026de0c960cSJagpal Singh Gill             [asyncResp, payload = std::move(payload), memfd = std::move(memfd),
102708f61d53SJagpal Singh Gill              applyTime, targets](const boost::system::error_code& ec,
102808f61d53SJagpal Singh Gill                                  const dbus::utility::MapperGetSubTreeResponse&
1029de0c960cSJagpal Singh Gill                                      subtree) mutable {
103008f61d53SJagpal Singh Gill             getSwInfo(asyncResp, std::move(payload), memfd, applyTime,
103108f61d53SJagpal Singh Gill                       targets[0], ec, subtree);
1032de0c960cSJagpal Singh Gill         });
1033de0c960cSJagpal Singh Gill     }
1034de0c960cSJagpal Singh Gill }
1035de0c960cSJagpal Singh Gill 
1036de0c960cSJagpal Singh Gill inline void
1037ef93eab3SJagpal Singh Gill     updateMultipartContext(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
1038ef93eab3SJagpal Singh Gill                            const crow::Request& req, MultipartParser&& parser)
1039ef93eab3SJagpal Singh Gill {
1040ef93eab3SJagpal Singh Gill     std::optional<MultiPartUpdateParameters> multipart =
1041ef93eab3SJagpal Singh Gill         extractMultipartUpdateParameters(asyncResp, std::move(parser));
1042ef93eab3SJagpal Singh Gill     if (!multipart)
1043ef93eab3SJagpal Singh Gill     {
1044ef93eab3SJagpal Singh Gill         return;
1045ef93eab3SJagpal Singh Gill     }
1046ef93eab3SJagpal Singh Gill     if (!multipart->applyTime)
1047ef93eab3SJagpal Singh Gill     {
1048ef93eab3SJagpal Singh Gill         multipart->applyTime = "OnReset";
1049ef93eab3SJagpal Singh Gill     }
1050ef93eab3SJagpal Singh Gill 
1051de0c960cSJagpal Singh Gill     if constexpr (BMCWEB_REDFISH_UPDATESERVICE_USE_DBUS)
1052de0c960cSJagpal Singh Gill     {
10539dae4deeSJagpal Singh Gill         std::string applyTimeNewVal;
10549dae4deeSJagpal Singh Gill         if (!convertApplyTime(asyncResp->res, *multipart->applyTime,
10559dae4deeSJagpal Singh Gill                               applyTimeNewVal))
10569dae4deeSJagpal Singh Gill         {
10579dae4deeSJagpal Singh Gill             return;
10589dae4deeSJagpal Singh Gill         }
10599dae4deeSJagpal Singh Gill         task::Payload payload(req);
10609dae4deeSJagpal Singh Gill 
10619dae4deeSJagpal Singh Gill         processUpdateRequest(asyncResp, std::move(payload),
10629dae4deeSJagpal Singh Gill                              multipart->uploadData, applyTimeNewVal,
10639dae4deeSJagpal Singh Gill                              multipart->targets);
1064de0c960cSJagpal Singh Gill     }
1065de0c960cSJagpal Singh Gill     else
1066de0c960cSJagpal Singh Gill     {
1067ef93eab3SJagpal Singh Gill         setApplyTime(asyncResp, *multipart->applyTime);
10680ed80c8cSGeorge Liu 
10696b54e4e0SEd Tanous         // Setup callback for when new software detected
1070de0c960cSJagpal Singh Gill         monitorForSoftwareAvailable(asyncResp, req,
1071de0c960cSJagpal Singh Gill                                     "/redfish/v1/UpdateService");
10726b54e4e0SEd Tanous 
1073ef93eab3SJagpal Singh Gill         uploadImageFile(asyncResp->res, multipart->uploadData);
10740ed80c8cSGeorge Liu     }
1075de0c960cSJagpal Singh Gill }
10760ed80c8cSGeorge Liu 
10779dae4deeSJagpal Singh Gill inline void doHTTPUpdate(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
10789dae4deeSJagpal Singh Gill                          const crow::Request& req)
10799dae4deeSJagpal Singh Gill {
10809dae4deeSJagpal Singh Gill     if constexpr (BMCWEB_REDFISH_UPDATESERVICE_USE_DBUS)
10819dae4deeSJagpal Singh Gill     {
10829dae4deeSJagpal Singh Gill         task::Payload payload(req);
10839dae4deeSJagpal Singh Gill         // HTTP push only supports BMC updates (with ApplyTime as immediate) for
10849dae4deeSJagpal Singh Gill         // backwards compatibility. Specific component updates will be handled
10859dae4deeSJagpal Singh Gill         // through Multipart form HTTP push.
10869dae4deeSJagpal Singh Gill         std::vector<std::string> targets;
10879dae4deeSJagpal Singh Gill         targets.emplace_back(BMCWEB_REDFISH_MANAGER_URI_NAME);
10889dae4deeSJagpal Singh Gill 
10899dae4deeSJagpal Singh Gill         processUpdateRequest(
10909dae4deeSJagpal Singh Gill             asyncResp, std::move(payload), req.body(),
10919dae4deeSJagpal Singh Gill             "xyz.openbmc_project.Software.ApplyTime.RequestedApplyTimes.Immediate",
10929dae4deeSJagpal Singh Gill             targets);
10939dae4deeSJagpal Singh Gill     }
10949dae4deeSJagpal Singh Gill     else
10959dae4deeSJagpal Singh Gill     {
10969dae4deeSJagpal Singh Gill         // Setup callback for when new software detected
10979dae4deeSJagpal Singh Gill         monitorForSoftwareAvailable(asyncResp, req,
10989dae4deeSJagpal Singh Gill                                     "/redfish/v1/UpdateService");
10999dae4deeSJagpal Singh Gill 
11009dae4deeSJagpal Singh Gill         uploadImageFile(asyncResp->res, req.body());
11019dae4deeSJagpal Singh Gill     }
11029dae4deeSJagpal Singh Gill }
11039dae4deeSJagpal Singh Gill 
1104c2051d11SEd Tanous inline void
1105c2051d11SEd Tanous     handleUpdateServicePost(App& app, const crow::Request& req,
1106c2051d11SEd Tanous                             const std::shared_ptr<bmcweb::AsyncResp>& asyncResp)
1107c2051d11SEd Tanous {
11083ba00073SCarson Labrado     if (!redfish::setUpRedfishRoute(app, req, asyncResp))
1109c2051d11SEd Tanous     {
1110c2051d11SEd Tanous         return;
1111c2051d11SEd Tanous     }
1112b33a4327SNinad Palsule     std::string_view contentType = req.getHeaderValue("Content-Type");
1113b33a4327SNinad Palsule 
111462598e31SEd Tanous     BMCWEB_LOG_DEBUG("doPost: contentType={}", contentType);
1115b33a4327SNinad Palsule 
1116b33a4327SNinad Palsule     // Make sure that content type is application/octet-stream or
1117b33a4327SNinad Palsule     // multipart/form-data
111818f8f608SEd Tanous     if (bmcweb::asciiIEquals(contentType, "application/octet-stream"))
1119b33a4327SNinad Palsule     {
11209dae4deeSJagpal Singh Gill         doHTTPUpdate(asyncResp, req);
1121b33a4327SNinad Palsule     }
1122b33a4327SNinad Palsule     else if (contentType.starts_with("multipart/form-data"))
1123b33a4327SNinad Palsule     {
1124b33a4327SNinad Palsule         MultipartParser parser;
1125c2051d11SEd Tanous 
11260ed80c8cSGeorge Liu         ParserError ec = parser.parse(req);
11270ed80c8cSGeorge Liu         if (ec != ParserError::PARSER_SUCCESS)
11280ed80c8cSGeorge Liu         {
11290ed80c8cSGeorge Liu             // handle error
113062598e31SEd Tanous             BMCWEB_LOG_ERROR("MIME parse failed, ec : {}",
113162598e31SEd Tanous                              static_cast<int>(ec));
11320ed80c8cSGeorge Liu             messages::internalError(asyncResp->res);
11330ed80c8cSGeorge Liu             return;
11340ed80c8cSGeorge Liu         }
11356b54e4e0SEd Tanous 
1136ef93eab3SJagpal Singh Gill         updateMultipartContext(asyncResp, req, std::move(parser));
1137c2051d11SEd Tanous     }
1138b33a4327SNinad Palsule     else
1139b33a4327SNinad Palsule     {
114062598e31SEd Tanous         BMCWEB_LOG_DEBUG("Bad content type specified:{}", contentType);
1141b33a4327SNinad Palsule         asyncResp->res.result(boost::beast::http::status::bad_request);
1142b33a4327SNinad Palsule     }
1143b33a4327SNinad Palsule }
1144c2051d11SEd Tanous 
1145f5139334SEd Tanous inline void
1146f5139334SEd Tanous     handleUpdateServiceGet(App& app, const crow::Request& req,
1147f5139334SEd Tanous                            const std::shared_ptr<bmcweb::AsyncResp>& asyncResp)
11481abe55efSEd Tanous {
11493ba00073SCarson Labrado     if (!redfish::setUpRedfishRoute(app, req, asyncResp))
115045ca1b86SEd Tanous     {
115145ca1b86SEd Tanous         return;
115245ca1b86SEd Tanous     }
11538d1b46d7Szhanghch05     asyncResp->res.jsonValue["@odata.type"] =
11540ed80c8cSGeorge Liu         "#UpdateService.v1_11_1.UpdateService";
11558d1b46d7Szhanghch05     asyncResp->res.jsonValue["@odata.id"] = "/redfish/v1/UpdateService";
11568d1b46d7Szhanghch05     asyncResp->res.jsonValue["Id"] = "UpdateService";
1157002d39b4SEd Tanous     asyncResp->res.jsonValue["Description"] = "Service for Software Update";
11588d1b46d7Szhanghch05     asyncResp->res.jsonValue["Name"] = "Update Service";
11594dc23f3fSEd Tanous 
11607e860f15SJohn Edward Broadbent     asyncResp->res.jsonValue["HttpPushUri"] =
11614dc23f3fSEd Tanous         "/redfish/v1/UpdateService/update";
11620ed80c8cSGeorge Liu     asyncResp->res.jsonValue["MultipartHttpPushUri"] =
11630ed80c8cSGeorge Liu         "/redfish/v1/UpdateService/update";
11644dc23f3fSEd Tanous 
11650f74e643SEd Tanous     // UpdateService cannot be disabled
11668d1b46d7Szhanghch05     asyncResp->res.jsonValue["ServiceEnabled"] = true;
11671476687dSEd Tanous     asyncResp->res.jsonValue["FirmwareInventory"]["@odata.id"] =
11681476687dSEd Tanous         "/redfish/v1/UpdateService/FirmwareInventory";
1169d61e5194STejas Patil     // Get the MaxImageSizeBytes
117025b54dbaSEd Tanous     asyncResp->res.jsonValue["MaxImageSizeBytes"] = BMCWEB_HTTP_BODY_LIMIT *
1171f5139334SEd Tanous                                                     1024 * 1024;
1172d61e5194STejas Patil 
11730554c984SAndrew Geissler     // Update Actions object.
11740554c984SAndrew Geissler     nlohmann::json& updateSvcSimpleUpdate =
1175002d39b4SEd Tanous         asyncResp->res.jsonValue["Actions"]["#UpdateService.SimpleUpdate"];
11760554c984SAndrew Geissler     updateSvcSimpleUpdate["target"] =
11770554c984SAndrew Geissler         "/redfish/v1/UpdateService/Actions/UpdateService.SimpleUpdate";
1178757178a5SEd Tanous 
1179757178a5SEd Tanous     nlohmann::json::array_t allowed;
1180e5cf777eSEd Tanous     allowed.emplace_back(update_service::TransferProtocolType::HTTPS);
1181757178a5SEd Tanous 
118225b54dbaSEd Tanous     if constexpr (BMCWEB_INSECURE_PUSH_STYLE_NOTIFICATION)
118325b54dbaSEd Tanous     {
1184757178a5SEd Tanous         allowed.emplace_back(update_service::TransferProtocolType::TFTP);
118525b54dbaSEd Tanous     }
1186757178a5SEd Tanous 
1187757178a5SEd Tanous     updateSvcSimpleUpdate["TransferProtocol@Redfish.AllowableValues"] =
1188757178a5SEd Tanous         std::move(allowed);
1189757178a5SEd Tanous 
1190*539d8c6bSEd Tanous     asyncResp->res
1191*539d8c6bSEd Tanous         .jsonValue["HttpPushUriOptions"]["HttpPushUriApplyTime"]["ApplyTime"] =
1192*539d8c6bSEd Tanous         update_service::ApplyTime::Immediate;
1193729dae72SJennifer Lee }
1194729dae72SJennifer Lee 
1195f5139334SEd Tanous inline void handleUpdateServiceFirmwareInventoryCollectionGet(
1196f5139334SEd Tanous     App& app, const crow::Request& req,
1197f5139334SEd Tanous     const std::shared_ptr<bmcweb::AsyncResp>& asyncResp)
11981abe55efSEd Tanous {
11993ba00073SCarson Labrado     if (!redfish::setUpRedfishRoute(app, req, asyncResp))
120045ca1b86SEd Tanous     {
120145ca1b86SEd Tanous         return;
120245ca1b86SEd Tanous     }
12038d1b46d7Szhanghch05     asyncResp->res.jsonValue["@odata.type"] =
12040f74e643SEd Tanous         "#SoftwareInventoryCollection.SoftwareInventoryCollection";
12058d1b46d7Szhanghch05     asyncResp->res.jsonValue["@odata.id"] =
12060f74e643SEd Tanous         "/redfish/v1/UpdateService/FirmwareInventory";
1207002d39b4SEd Tanous     asyncResp->res.jsonValue["Name"] = "Software Inventory Collection";
120808d81adaSJohn Edward Broadbent     const std::array<const std::string_view, 1> iface = {
1209e99073f5SGeorge Liu         "xyz.openbmc_project.Software.Version"};
12106c4eb9deSJennifer Lee 
121108d81adaSJohn Edward Broadbent     redfish::collection_util::getCollectionMembers(
121208d81adaSJohn Edward Broadbent         asyncResp,
1213f5139334SEd Tanous         boost::urls::url("/redfish/v1/UpdateService/FirmwareInventory"), iface,
1214f5139334SEd Tanous         "/xyz/openbmc_project/software");
1215729dae72SJennifer Lee }
1216f5139334SEd Tanous 
121787d84729SAndrew Geissler /* Fill related item links (i.e. bmc, bios) in for inventory */
1218f5139334SEd Tanous inline void getRelatedItems(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
121987d84729SAndrew Geissler                             const std::string& purpose)
122087d84729SAndrew Geissler {
1221eee0013eSWilly Tu     if (purpose == sw_util::bmcPurpose)
122287d84729SAndrew Geissler     {
1223ac106bf6SEd Tanous         nlohmann::json& relatedItem = asyncResp->res.jsonValue["RelatedItem"];
12241476687dSEd Tanous         nlohmann::json::object_t item;
1225253f11b8SEd Tanous         item["@odata.id"] = boost::urls::format(
1226253f11b8SEd Tanous             "/redfish/v1/Managers/{}", BMCWEB_REDFISH_MANAGER_URI_NAME);
1227b2ba3072SPatrick Williams         relatedItem.emplace_back(std::move(item));
1228ac106bf6SEd Tanous         asyncResp->res.jsonValue["RelatedItem@odata.count"] =
1229ac106bf6SEd Tanous             relatedItem.size();
123087d84729SAndrew Geissler     }
1231eee0013eSWilly Tu     else if (purpose == sw_util::biosPurpose)
123287d84729SAndrew Geissler     {
1233ac106bf6SEd Tanous         nlohmann::json& relatedItem = asyncResp->res.jsonValue["RelatedItem"];
12341476687dSEd Tanous         nlohmann::json::object_t item;
1235253f11b8SEd Tanous         item["@odata.id"] = std::format("/redfish/v1/Systems/{}/Bios",
1236253f11b8SEd Tanous                                         BMCWEB_REDFISH_SYSTEM_URI_NAME);
1237b2ba3072SPatrick Williams         relatedItem.emplace_back(std::move(item));
1238ac106bf6SEd Tanous         asyncResp->res.jsonValue["RelatedItem@odata.count"] =
1239ac106bf6SEd Tanous             relatedItem.size();
124087d84729SAndrew Geissler     }
124187d84729SAndrew Geissler     else
124287d84729SAndrew Geissler     {
1243bf2ddedeSCarson Labrado         BMCWEB_LOG_DEBUG("Unknown software purpose {}", purpose);
124487d84729SAndrew Geissler     }
124587d84729SAndrew Geissler }
124687d84729SAndrew Geissler 
1247af24660dSWilly Tu inline void
1248af24660dSWilly Tu     getSoftwareVersion(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
1249af24660dSWilly Tu                        const std::string& service, const std::string& path,
1250af24660dSWilly Tu                        const std::string& swId)
1251af24660dSWilly Tu {
1252d1bde9e5SKrzysztof Grobelny     sdbusplus::asio::getAllProperties(
1253d1bde9e5SKrzysztof Grobelny         *crow::connections::systemBus, service, path,
1254d1bde9e5SKrzysztof Grobelny         "xyz.openbmc_project.Software.Version",
1255af24660dSWilly Tu         [asyncResp,
12568b24275dSEd Tanous          swId](const boost::system::error_code& ec,
1257af24660dSWilly Tu                const dbus::utility::DBusPropertiesMap& propertiesList) {
12588b24275dSEd Tanous         if (ec)
1259af24660dSWilly Tu         {
1260af24660dSWilly Tu             messages::internalError(asyncResp->res);
1261af24660dSWilly Tu             return;
1262af24660dSWilly Tu         }
1263d1bde9e5SKrzysztof Grobelny 
1264af24660dSWilly Tu         const std::string* swInvPurpose = nullptr;
1265af24660dSWilly Tu         const std::string* version = nullptr;
1266d1bde9e5SKrzysztof Grobelny 
1267d1bde9e5SKrzysztof Grobelny         const bool success = sdbusplus::unpackPropertiesNoThrow(
1268d1bde9e5SKrzysztof Grobelny             dbus_utils::UnpackErrorPrinter(), propertiesList, "Purpose",
1269d1bde9e5SKrzysztof Grobelny             swInvPurpose, "Version", version);
1270d1bde9e5SKrzysztof Grobelny 
1271d1bde9e5SKrzysztof Grobelny         if (!success)
1272af24660dSWilly Tu         {
1273d1bde9e5SKrzysztof Grobelny             messages::internalError(asyncResp->res);
1274d1bde9e5SKrzysztof Grobelny             return;
1275af24660dSWilly Tu         }
1276af24660dSWilly Tu 
1277af24660dSWilly Tu         if (swInvPurpose == nullptr)
1278af24660dSWilly Tu         {
127962598e31SEd Tanous             BMCWEB_LOG_DEBUG("Can't find property \"Purpose\"!");
1280af24660dSWilly Tu             messages::internalError(asyncResp->res);
1281af24660dSWilly Tu             return;
1282af24660dSWilly Tu         }
1283af24660dSWilly Tu 
128462598e31SEd Tanous         BMCWEB_LOG_DEBUG("swInvPurpose = {}", *swInvPurpose);
1285af24660dSWilly Tu 
1286af24660dSWilly Tu         if (version == nullptr)
1287af24660dSWilly Tu         {
128862598e31SEd Tanous             BMCWEB_LOG_DEBUG("Can't find property \"Version\"!");
1289af24660dSWilly Tu 
1290af24660dSWilly Tu             messages::internalError(asyncResp->res);
1291af24660dSWilly Tu 
1292af24660dSWilly Tu             return;
1293af24660dSWilly Tu         }
1294af24660dSWilly Tu         asyncResp->res.jsonValue["Version"] = *version;
1295af24660dSWilly Tu         asyncResp->res.jsonValue["Id"] = swId;
1296af24660dSWilly Tu 
1297af24660dSWilly Tu         // swInvPurpose is of format:
1298af24660dSWilly Tu         // xyz.openbmc_project.Software.Version.VersionPurpose.ABC
1299af24660dSWilly Tu         // Translate this to "ABC image"
1300af24660dSWilly Tu         size_t endDesc = swInvPurpose->rfind('.');
1301af24660dSWilly Tu         if (endDesc == std::string::npos)
1302af24660dSWilly Tu         {
1303af24660dSWilly Tu             messages::internalError(asyncResp->res);
1304af24660dSWilly Tu             return;
1305af24660dSWilly Tu         }
1306af24660dSWilly Tu         endDesc++;
1307af24660dSWilly Tu         if (endDesc >= swInvPurpose->size())
1308af24660dSWilly Tu         {
1309af24660dSWilly Tu             messages::internalError(asyncResp->res);
1310af24660dSWilly Tu             return;
1311af24660dSWilly Tu         }
1312af24660dSWilly Tu 
1313af24660dSWilly Tu         std::string formatDesc = swInvPurpose->substr(endDesc);
1314af24660dSWilly Tu         asyncResp->res.jsonValue["Description"] = formatDesc + " image";
1315af24660dSWilly Tu         getRelatedItems(asyncResp, *swInvPurpose);
1316d1bde9e5SKrzysztof Grobelny     });
1317af24660dSWilly Tu }
1318af24660dSWilly Tu 
1319f5139334SEd Tanous inline void handleUpdateServiceFirmwareInventoryGet(
1320f5139334SEd Tanous     App& app, const crow::Request& req,
132145ca1b86SEd Tanous     const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
1322f5139334SEd Tanous     const std::string& param)
1323f5139334SEd Tanous {
13243ba00073SCarson Labrado     if (!redfish::setUpRedfishRoute(app, req, asyncResp))
132545ca1b86SEd Tanous     {
132645ca1b86SEd Tanous         return;
132745ca1b86SEd Tanous     }
1328f5139334SEd Tanous     std::shared_ptr<std::string> swId = std::make_shared<std::string>(param);
1329c711bf86SEd Tanous 
1330ef4c65b7SEd Tanous     asyncResp->res.jsonValue["@odata.id"] = boost::urls::format(
1331ef4c65b7SEd Tanous         "/redfish/v1/UpdateService/FirmwareInventory/{}", *swId);
1332c711bf86SEd Tanous 
1333e99073f5SGeorge Liu     constexpr std::array<std::string_view, 1> interfaces = {
1334e99073f5SGeorge Liu         "xyz.openbmc_project.Software.Version"};
1335e99073f5SGeorge Liu     dbus::utility::getSubTree(
1336e99073f5SGeorge Liu         "/", 0, interfaces,
1337b9d36b47SEd Tanous         [asyncResp,
1338e99073f5SGeorge Liu          swId](const boost::system::error_code& ec,
1339b9d36b47SEd Tanous                const dbus::utility::MapperGetSubTreeResponse& subtree) {
134062598e31SEd Tanous         BMCWEB_LOG_DEBUG("doGet callback...");
13411abe55efSEd Tanous         if (ec)
13421abe55efSEd Tanous         {
1343f12894f8SJason M. Bills             messages::internalError(asyncResp->res);
13446c4eb9deSJennifer Lee             return;
13456c4eb9deSJennifer Lee         }
13466c4eb9deSJennifer Lee 
13476913228dSAndrew Geissler         // Ensure we find our input swId, otherwise return an error
13486913228dSAndrew Geissler         bool found = false;
1349f5139334SEd Tanous         for (const std::pair<
1350f5139334SEd Tanous                  std::string,
1351f5139334SEd Tanous                  std::vector<std::pair<std::string, std::vector<std::string>>>>&
1352002d39b4SEd Tanous                  obj : subtree)
13531abe55efSEd Tanous         {
135411ba3979SEd Tanous             if (!obj.first.ends_with(*swId))
13551abe55efSEd Tanous             {
1356acb7cfb4SJennifer Lee                 continue;
1357acb7cfb4SJennifer Lee             }
1358acb7cfb4SJennifer Lee 
135926f6976fSEd Tanous             if (obj.second.empty())
13601abe55efSEd Tanous             {
1361acb7cfb4SJennifer Lee                 continue;
1362acb7cfb4SJennifer Lee             }
13636c4eb9deSJennifer Lee 
13646913228dSAndrew Geissler             found = true;
1365eee0013eSWilly Tu             sw_util::getSwStatus(asyncResp, swId, obj.second[0].first);
1366af24660dSWilly Tu             getSoftwareVersion(asyncResp, obj.second[0].first, obj.first,
1367af24660dSWilly Tu                                *swId);
13686c4eb9deSJennifer Lee         }
13696913228dSAndrew Geissler         if (!found)
13706913228dSAndrew Geissler         {
137162598e31SEd Tanous             BMCWEB_LOG_WARNING("Input swID {} not found!", *swId);
13726913228dSAndrew Geissler             messages::resourceMissingAtURI(
1373ef4c65b7SEd Tanous                 asyncResp->res,
1374ef4c65b7SEd Tanous                 boost::urls::format(
1375f5139334SEd Tanous                     "/redfish/v1/UpdateService/FirmwareInventory/{}", *swId));
13766913228dSAndrew Geissler             return;
13776913228dSAndrew Geissler         }
13784e68c45bSAyushi Smriti         asyncResp->res.jsonValue["@odata.type"] =
13794e68c45bSAyushi Smriti             "#SoftwareInventory.v1_1_0.SoftwareInventory";
13804e68c45bSAyushi Smriti         asyncResp->res.jsonValue["Name"] = "Software Inventory";
1381*539d8c6bSEd Tanous         asyncResp->res.jsonValue["Status"]["HealthRollup"] =
1382*539d8c6bSEd Tanous             resource::Health::OK;
13833f8a743aSAppaRao Puli 
13843f8a743aSAppaRao Puli         asyncResp->res.jsonValue["Updateable"] = false;
1385eee0013eSWilly Tu         sw_util::getSwUpdatableStatus(asyncResp, swId);
1386e99073f5SGeorge Liu     });
1387f5139334SEd Tanous }
1388f5139334SEd Tanous 
1389f5139334SEd Tanous inline void requestRoutesUpdateService(App& app)
1390f5139334SEd Tanous {
1391f5139334SEd Tanous     BMCWEB_ROUTE(
1392f5139334SEd Tanous         app, "/redfish/v1/UpdateService/Actions/UpdateService.SimpleUpdate/")
1393f5139334SEd Tanous         .privileges(redfish::privileges::postUpdateService)
1394f5139334SEd Tanous         .methods(boost::beast::http::verb::post)(std::bind_front(
1395f5139334SEd Tanous             handleUpdateServiceSimpleUpdateAction, std::ref(app)));
1396f5139334SEd Tanous 
1397f5139334SEd Tanous     BMCWEB_ROUTE(app, "/redfish/v1/UpdateService/FirmwareInventory/<str>/")
1398f5139334SEd Tanous         .privileges(redfish::privileges::getSoftwareInventory)
1399f5139334SEd Tanous         .methods(boost::beast::http::verb::get)(std::bind_front(
1400f5139334SEd Tanous             handleUpdateServiceFirmwareInventoryGet, std::ref(app)));
1401f5139334SEd Tanous 
1402f5139334SEd Tanous     BMCWEB_ROUTE(app, "/redfish/v1/UpdateService/")
1403f5139334SEd Tanous         .privileges(redfish::privileges::getUpdateService)
1404f5139334SEd Tanous         .methods(boost::beast::http::verb::get)(
1405f5139334SEd Tanous             std::bind_front(handleUpdateServiceGet, std::ref(app)));
1406f5139334SEd Tanous 
1407f5139334SEd Tanous     BMCWEB_ROUTE(app, "/redfish/v1/UpdateService/update/")
1408f5139334SEd Tanous         .privileges(redfish::privileges::postUpdateService)
1409f5139334SEd Tanous         .methods(boost::beast::http::verb::post)(
1410f5139334SEd Tanous             std::bind_front(handleUpdateServicePost, std::ref(app)));
1411f5139334SEd Tanous 
1412f5139334SEd Tanous     BMCWEB_ROUTE(app, "/redfish/v1/UpdateService/FirmwareInventory/")
1413f5139334SEd Tanous         .privileges(redfish::privileges::getSoftwareInventoryCollection)
1414f5139334SEd Tanous         .methods(boost::beast::http::verb::get)(std::bind_front(
1415f5139334SEd Tanous             handleUpdateServiceFirmwareInventoryCollectionGet, std::ref(app)));
14166c4eb9deSJennifer Lee }
1417729dae72SJennifer Lee 
1418729dae72SJennifer Lee } // namespace redfish
1419