Searched hist:"283 be5966eb7ec18fda3e95c979be620dfb8c72a" (Results 1 – 1 of 1) sorted by relevance
| /openbmc/qemu/hw/net/ |
| H A D | virtio-net.c | diff 283be5966eb7ec18fda3e95c979be620dfb8c72a Sun Apr 28 02:00:50 CDT 2024 Akihiko Odaki <akihiko.odaki@daynix.com> virtio-net: Do not propagate ebpf-rss-fds errors
Propagating ebpf-rss-fds errors has several problems.
First, it makes device realization fail and disables the fallback to the
conventional eBPF loading.
Second, it leaks memory by making device realization fail without
freeing memory already allocated.
Third, the convention is to set an error when a function returns false,
but virtio_net_load_ebpf_fds() and virtio_net_load_ebpf() returns false
without setting an error, which is confusing.
Remove the propagation to fix these problems.
Fixes: 0524ea0510a3 ("ebpf: Added eBPF initialization by fds.")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
|