Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Id1ca559acc1ae45b4605a1bb9d74ef3d7e5aa1c5
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic0fe1ed7e19cf114b8666d49d4d670c7d9ec595d

show more ...

Start using .clang-format

Used the one from docs/style/cpp.

Change-Id: I3bdc2b353bf18a437266b362d8205b8463a9ce2b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

timer: Remove in favor of sdeventplus/timer

This change removes the ad-hoc timer implementation and uses the common
one that comes with sdeventplus.

Tested: Compiled

Change-Id: Id3b7e464a472a74217

timer: Remove in favor of sdeventplus/timer

This change removes the ad-hoc timer implementation and uses the common
one that comes with sdeventplus.

Tested: Compiled

Change-Id: Id3b7e464a472a7421785601634af58f681ebd3a6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

event: Remove in favor of sdeventplus

Use the new library provided to all openbmc projects instead of rolling
our own managed pointer.

Tested: Compiled

Change-Id: I4993d4340e0e0aa5898e73ef815baa81

event: Remove in favor of sdeventplus

Use the new library provided to all openbmc projects instead of rolling
our own managed pointer.

Tested: Compiled

Change-Id: I4993d4340e0e0aa5898e73ef815baa81b0e8a2bc
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Support for syncing power supply input history

When a power supply is hotplugged the code will toggle
a GPIO to cause the power supplies to sync their
input history collection. This clears out old

Support for syncing power supply input history

When a power supply is hotplugged the code will toggle
a GPIO to cause the power supplies to sync their
input history collection. This clears out old values
and restarts measurement at the same time zero.

An external service handles this during a power on.

It doesn't need to be done when the application first
starts because it will either be with power off with
uninteresting power values, and a sync will occur on a
power on anyway, or it was a reboot at runtime where
the power supplies are still synced up anyway.

Change-Id: Ic8787c05e163e48ed775ea075f241ffd8d65585e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add collection of power history data

On every PowerSupply::analyze() call, read the most recent input
history record and pass it to the RecordManager instance. If it
is one that RecordManager doesn

Add collection of power history data

On every PowerSupply::analyze() call, read the most recent input
history record and pass it to the RecordManager instance. If it
is one that RecordManager doesn't have yet, get the latest maximum
and average properties from RecordManager and update D-Bus.

Change-Id: I42d63e99c7223ba1b8a7f1138657cd505a68e66a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add ability to enable input history collection

Calling the enableHistory() function will create new
RecordManager, Average, and Maximum instances.

Future commits will build on this to do the collec

Add ability to enable input history collection

Calling the enableHistory() function will create new
RecordManager, Average, and Maximum instances.

Future commits will build on this to do the collection
if these classes were created.

Change-Id: I6453d303eb09bdfd1a6f0b520369adb51ca7162c
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add update power supply inventory stubs and calls

This function will read values from the power supply
and put them into the inventory.

This commit doesn't deal with what is written, but it is
prop

Add update power supply inventory stubs and calls

This function will read values from the power supply
and put them into the inventory.

This commit doesn't deal with what is written, but it is
properties like the part and serial numbers.

It needs to be called:
* On startup, regardless of presence state.
* When a power supply is added, after the hwmon directory
has been determined, to read the values for the new unit
* When a power supply is removed.

When the function is called when the unit isn't present,
it will just write empty values to the inventory. This ensures
when a unit is removed that it doesn't contain stale values.

Change-Id: I432a515cf30321d1c9e327fc9c0332d1c724cf94
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add a function for resolving errors

Create a function that will take a callback and message as input
parameters. These will be used to find each error that matches, so that
the Resolved property can

Add a function for resolving errors

Create a function that will take a callback and message as input
parameters. These will be used to find each error that matches, so that
the Resolved property can be set to true.

Change-Id: Icd19e72b3f59c7f7e719d58746c490d8c7e22fad
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Implement de-glitch for input fault

If three consecutive reads in a row, on second apart, show the
INPUT_FAULT_WARN and/or VIN_UV_FAULT on, create and log an error.

Resolves: openbmc/openbmc#2484

Implement de-glitch for input fault

If three consecutive reads in a row, on second apart, show the
INPUT_FAULT_WARN and/or VIN_UV_FAULT on, create and log an error.

Resolves: openbmc/openbmc#2484

Change-Id: I35dedfc6acbb68bd8004c4fd1cc3d6dc799a9a17
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Implement de-glitch for read failures

If three consecutive read failures in a row occur, one second apart,
create and log an error.

Change-Id: Iaed04c307de2419c614b7916a99dd36a6aa2c106
Signed-off-b

Implement de-glitch for read failures

If three consecutive read failures in a row occur, one second apart,
create and log an error.

Change-Id: Iaed04c307de2419c614b7916a99dd36a6aa2c106
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Implement de-glitch for temperature fault or warn

If three consecutive reads in a row, one second apart, show the fault
on, create an log an error.

Change-Id: I9fb1285a01e269beffd2201f5082545748f5b

Implement de-glitch for temperature fault or warn

If three consecutive reads in a row, one second apart, show the fault
on, create an log an error.

Change-Id: I9fb1285a01e269beffd2201f5082545748f5bee3
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Implement de-glitch for fan fault or warn

If three consecutive reads in a row, one second apart, show the fault
on, create and log an error.

Change-Id: Iac7d244b0dc2609c9b499514b88460d653b8d70d
Sig

Implement de-glitch for fan fault or warn

If three consecutive reads in a row, one second apart, show the fault
on, create and log an error.

Change-Id: Iac7d244b0dc2609c9b499514b88460d653b8d70d
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Implement de-glitch for output overvoltage fault

If three consecutive reads in a row, one second apart, show the fault
on, create and log an error.

Change-Id: I4ab029b24f5afd263ade7eeccca00b34efd99

Implement de-glitch for output overvoltage fault

If three consecutive reads in a row, one second apart, show the fault
on, create and log an error.

Change-Id: I4ab029b24f5afd263ade7eeccca00b34efd99d3e
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Implement de-glitch for output overcurrent fault

If three consecutive reads in a row, one second apart, show the fault
on, create and log an error.

Change-Id: I0a51241ac00514c50fac49c050cf5bf086ca9

Implement de-glitch for output overcurrent fault

If three consecutive reads in a row, one second apart, show the fault
on, create and log an error.

Change-Id: I0a51241ac00514c50fac49c050cf5bf086ca9ab4
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Add in a way to check for any fault found

Adding in a variable to indicate that any type of fault has been found.
A number of the faults that can occur during the power on time frame
will eventually

Add in a way to check for any fault found

Adding in a variable to indicate that any type of fault has been found.
A number of the faults that can occur during the power on time frame
will eventually result in the power supply turning off. We do not want
to log multiple faults for something like a fan fault resulting in an
overtemperature fault that then results into the power supply turning
off, generating three error logs that call out the same supply that has
failed due to a bad fan.

The input/undervoltage fault is treated a bit uniquely, if that fault
clears (supply plugged in, different power source, etc.) it will also
clear the indicator that any fault has been found. All other faults will
require a power supply replace or power cycle in order to be cleared.

Resolves: openbmc/openbmc#2516

Change-Id: I32c3f9c4031de5d603aa96e184679c3d7d87a3f1
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Add in a delay before setting present to true

When a power supply is inserted, allow for a time delay before starting
the fault checks. This will give the individual servicing a power supply
some ti

Add in a delay before setting present to true

When a power supply is inserted, allow for a time delay before starting
the fault checks. This will give the individual servicing a power supply
some time to insert the supply and then apply power.

Change-Id: Ic957be927cea26a6c011a0a634f84093e040b454
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Merge VIN_UV_FAULT check with the inputFault

Since VIN_UV_FAULT is for input voltage, and the desired behavior was to
"treat as OR condition if either asserts", this change is removing the
variable

Merge VIN_UV_FAULT check with the inputFault

Since VIN_UV_FAULT is for input voltage, and the desired behavior was to
"treat as OR condition if either asserts", this change is removing the
variable used to track VIN_UV_FAULT, and adding the condition check to
the path that sets inputFault.

Change-Id: Id4451753f6d627a62588b0d2211614174f83abb0
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Implement de-glitch for PGOOD and UNIT_IS_OFF

De-glitch the powerOnFault so that a fault is logged only if the
POWER_GOOD Negated or UNIT_IS_OFF bits are in the wrong state three
times in a row.

Re

Implement de-glitch for PGOOD and UNIT_IS_OFF

De-glitch the powerOnFault so that a fault is logged only if the
POWER_GOOD Negated or UNIT_IS_OFF bits are in the wrong state three
times in a row.

Resolves openbmc/openbmc#2473

Change-Id: Icbb45010f921bd3e11018f5e7bdc2d155242d464
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Add a helper function to capture command metadata

Due to openbmc/openbmc#2364, certain command response files may be
missing. Add a helper function to call the PMBus::exists() function to
skip tryin

Add a helper function to capture command metadata

Due to openbmc/openbmc#2364, certain command response files may be
missing. Add a helper function to call the PMBus::exists() function to
skip trying to read in metadata for missing files.

Change-Id: I101c5ccebe76dd29fb07369fd082072ce94f021b
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Add in support for power supply over-temperature

If a power supply encounters an over-temperature condition, the FAN
FAULT OR WARNING bit of the STATUS_WORD (low byte) command response
should be tur

Add in support for power supply over-temperature

If a power supply encounters an over-temperature condition, the FAN
FAULT OR WARNING bit of the STATUS_WORD (low byte) command response
should be turned on. Ideally, when this is encountered, both power
supplies would be called out, as one condition that could lead to this
is due to the other supply putting out less current. Since each
monitoring application of the power supplies only knows its own
information, just the power supply indicating the condition will be
called out along with metadata containing potentially relevant command
response data.

Change-Id: I8f96828f85161050f73bb080392e1e8fef4a179b
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Add in support for power supply fan fault

If the FAN FAULT OR WARN bit in the STATUS_WORD turns on, log an error
calling out the power supply, include the contents from STATUS_WORD,
MFR_SPECIFIC, ST

Add in support for power supply fan fault

If the FAN FAULT OR WARN bit in the STATUS_WORD turns on, log an error
calling out the power supply, include the contents from STATUS_WORD,
MFR_SPECIFIC, STATUS_TEMPERATURE, and STATUS_FANS_1_2 in the metadata.

Change-Id: Ic9261cf08517344f594a4616a91dbec47bb07d7e
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Add in detection of output overvoltage fault

If bit 5 of the lower byte to STATUS_WORD (STATUS_BYTE) is on when the
power is on, the power supply is indicating that it has detected an
output overvol

Add in detection of output overvoltage fault

If bit 5 of the lower byte to STATUS_WORD (STATUS_BYTE) is on when the
power is on, the power supply is indicating that it has detected an
output overvoltage fault condition. Log an error pointing to the power
supply that is indicating this overvoltage condition.

Change-Id: Ie369a30e6b82be805ae3aafd67812700ce2421f7
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Refactor the analyze() function to be less verbose

Split up the various fault checking sections of code to be there own
separate functions for checking the various fault bits/conditions and
logging

Refactor the analyze() function to be less verbose

Split up the various fault checking sections of code to be there own
separate functions for checking the various fault bits/conditions and
logging of appropriate error with necessary metadata for debug.

Change-Id: I65e54f53b0089d82852bee398ebb7d2303f29b6c
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...