#
de23ea23 |
| 11-Jul-2024 |
Surya V <suryav@ami.com> |
Vuelidate, I18n, and filter are upgraded to vue3
While navigating to the pages i18n, vuelidate, and filters errors occurred. i18n, and vuelidate code changes in each page adapted to vue3. Filter glo
Vuelidate, I18n, and filter are upgraded to vue3
While navigating to the pages i18n, vuelidate, and filters errors occurred. i18n, and vuelidate code changes in each page adapted to vue3. Filter global function for date and time format implemented in the main.js file and those files which as called the filter functions.
Change-Id: If1a2ee22d47750faef1c35ef2c263299067d9a20 Signed-off-by: Surya Venkatesan <suryav@ami.com>
show more ...
|
#
883a0d59 |
| 23-Mar-2024 |
Ed Tanous <ed@tanous.net> |
i18n, vue-router and vuex upgrade
1. Configuration of i18n legacy as false. 2. Translation function t is called using the useI18n. 3. Used the i18n.global.t() function from i18n instead of this.$t()
i18n, vue-router and vuex upgrade
1. Configuration of i18n legacy as false. 2. Translation function t is called using the useI18n. 3. Used the i18n.global.t() function from i18n instead of this.$t() 4. Event bus error that occurred during logout. 5. Implemented vue-router 4.4.0 and vuex upgrade to 4.1.0
Change-Id: I9464d82c76dcc1445ce271983ea3ab9d7b03d265 Signed-off-by: Surya Venkatesan <suryav@ami.com>
show more ...
|
#
7d6b44cb |
| 23-Mar-2024 |
Ed Tanous <ed@tanous.net> |
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, logi
Upgrade vue3 and all dependencies
Start the process of porting everything to Vue 3. I have most things working. npm run-scripts build works, npm install works. prettier passes. Styles load, login works, webui loads.
This was primarily done using the linked documents below. It makes the following design decisions: 1. Vue is put in compat 2 mode, which allows most of the components to work as-is. 2. Bootstrap v4 is used along with bootstrap-vue to keep our components working. 3. Minor changes are made to load the latest versions of vue-router, vuex, and vue-i18n.
I suspect this patchset is good enough to start with, and we can clean up the broken things one patchset at a time. The things that need to happen are:
1. Get remaining features working again. This primiarily is vue-i18n for mixins, and non vue components. This likely needs to be done by not pulling in i18n into the non vue components, then using the .Vue files to do the internationalization in the component context, NOT in the mixin context. Alternatively, we could drop MixIns alltogether. 2. Get custom styles working again. Previously, we used some path hackery in vue.config.js to optionally pre-load styles. This stops working now that we're required to @import our modules. Likely we need some rearangement of the paths such that custom styles are a complete replacement (possibly importing the original) rather than additive with overrides. That's a guess, but I don't really see anyone else doing customization the way we've defined it here. 3. Bootstrap 5 no longer requires ANY custom vue modules, as it has dropped the jquery dependency. We won't be able to pull in bootstrap 5 all at once, so pull in bootstrap 5 under an alias, like "bootstrap5" that we can optionally import 5 or 4. 4. One at a time, start porting components over to Vue3 syntax and bootstrap 5. This will be the bulk of the manual work and review.
The only thing I think left is getting unit tests passing, which I commented out the pre-commit hook to make this PR.
Tested: Code builds. Needs better testing.
[1] https://router.vuejs.org/guide/migration/ [2] https://vue-i18n.intlify.dev/guide/migration/vue3 [3] https://vuelidate-next.netlify.app/migration_guide.html#package-name-and-imports
Change-Id: I5bb3187b9efbf2e4ff63e57994bc528756e2a981 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
#
51abe87f |
| 20-Apr-2024 |
Ed Tanous <ed@tanous.net> |
Inline the header svg
Ideally we wouldn't have to pull down this file on every load, and we could just inline it. This commit implements inlining. Note, that this requires a minor modification to
Inline the header svg
Ideally we wouldn't have to pull down this file on every load, and we could just inline it. This commit implements inlining. Note, that this requires a minor modification to the unit test, as the inline header remains when unit tests are run. It's not clear at this time how to make inlining plugin operate on unit tests, but it doesn't seem terribly important.
Tested: Loading the webui no longer shows a download of logo-header
Change-Id: Iaa5be5b5a84e0ad6e1f430113f929032835c9f1c Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
#
8132399c |
| 27-Feb-2024 |
Ed Tanous <ed@tanous.net> |
Reformat files with new linter
All changes should be whitespace, and were done using npm run-script lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6 Signed-off-by: Ed Tanous <ed@tanous.ne
Reformat files with new linter
All changes should be whitespace, and were done using npm run-script lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
#
fb6c6de9 |
| 14-Jun-2023 |
Konstantin <sulwirld@gmail.com> |
Fix kvm session and add event bus
Bug description: Before this commit KVM window wasn't being closed after logging out
Test: Step1. Launch webui on browser and see KVM page on /#/operations
Fix kvm session and add event bus
Bug description: Before this commit KVM window wasn't being closed after logging out
Test: Step1. Launch webui on browser and see KVM page on /#/operations/kvm. Step2. Open additional window using 'Open in new tab'. Step3. Navigate to another page. For example, /#/operations/key-clear. Step4. Logout. Window is still open.
Change-Id: Ife79ebca41eb4d588c0b8f4fae06135420eda155 Signed-off-by: Konstantin Maskov <sulwirld@gmail.com>
show more ...
|
#
aeb19816 |
| 23-Nov-2022 |
Damian Celico <damianx.celico@intel.com> |
Added route restrictions based on user privilege
This commit allows us to add 'exclusiveToRoles' field to route config files, with the list of roles that can access this resource, if needed. In this
Added route restrictions based on user privilege
This commit allows us to add 'exclusiveToRoles' field to route config files, with the list of roles that can access this resource, if needed. In this case, only Administrator can access Virtual-Media page and SOL console, and it is blocked for other users.
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com> Change-Id: Ibcee18bd92d97c34414ecaf2caf6af28070c5538
show more ...
|
#
00cb42b6 |
| 21-Dec-2021 |
Kenneth Fullbright <kennyneedsmilky@gmail.com> |
Fixed routerKey prop eslint warning
Eslint throws a warning to props that don't have a default value
- Added a default value to the routerKey prop.
Signed-off-by: Kenneth Fullbright <kennyneedsmil
Fixed routerKey prop eslint warning
Eslint throws a warning to props that don't have a default value
- Added a default value to the routerKey prop.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com> Change-Id: I2d9d4abd0512eeadf27f8941a0f391979eb9a80a
show more ...
|
#
14172d74 |
| 10-Nov-2021 |
kennyneedsmilky <kennyneedsmilky@gmail.com> |
Fixed refresh system info on header
The refresh button in the App header previously only re-rendered the main mage section, this change also refreshes the app header and main content.
Signed-off-by
Fixed refresh system info on header
The refresh button in the App header previously only re-rendered the main mage section, this change also refreshes the app header and main content.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com> Change-Id: Iff7f3f14bca8ddfd815ccb1b87dd182c4bfd79ba
show more ...
|
#
932aff93 |
| 26-Aug-2021 |
Derick Montague <derick.montague@ibm.com> |
Update login page layout
This update will:
- Change the positioning of the form to be on the left - Add the built on OpenBMC logo to the bottom right corner of the screen - Add the ability to inclu
Update login page layout
This update will:
- Change the positioning of the form to be on the left - Add the built on OpenBMC logo to the bottom right corner of the screen - Add the ability to include a GUI custom name using a .env variable. If the variable is not present, the login page will not include the <h1> section heading element. - Remove the word "logo" from the alt attribute for the company logo image used in the application header and on the login page.
Github story: https://github.com/openbmc/webui-vue/issues/63
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I83ac5aecff0b3858c3ab5f38ab1aaa603d59acf1
show more ...
|
#
4dd7eabf |
| 16-Aug-2021 |
Sukanya Pandey <sukapan1@in.ibm.com> |
Add system information on Appheader page
- Model type and serial number are newly added system info data on Appheader. - On small screens and below system information(model type, serial number and a
Add system information on Appheader page
- Model type and serial number are newly added system info data on Appheader. - On small screens and below system information(model type, serial number and asset tag) will be hidden. - On large screen and below model type and serial number will be visible but asset tag will be hidden. - For all other screens all the system info will be visible.
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com> Change-Id: Ia844a26f658083cbd5fa9c8f3f6bea8b65ddcd11
show more ...
|
#
68cbbe90 |
| 14-Jul-2021 |
Sandeepa Singh <sandeepa.singh@ibm.com> |
IA update: Update control section to operations
This is the third update to the information architecture changes and has the following changes:
- The control section has been updated to operations
IA update: Update control section to operations
This is the third update to the information architecture changes and has the following changes:
- The control section has been updated to operations - The server led page has been removed - The firmware page is moved to operations section
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com> Change-Id: I2e23da447890d7bee51892e1f782d5f2db6dded4
show more ...
|
#
828dda9b |
| 28-Jun-2021 |
Derick Montague <derick.montague@ibm.com> |
IA update: Add logs and update overview icon
This is the first patchset of the information architecture changes. These changes are the result of several months of design research with users to impro
IA update: Add logs and update overview icon
This is the first patchset of the information architecture changes. These changes are the result of several months of design research with users to improve the existing information architecture (IA). More information can we found in the Github story.
This patchset will add a Logs section and move event logs and dumps from the Health section to the new Logs section. It will also update the icon used for the Overview page.
Github story: https://github.com/openbmc/webui-vue/issues/56
Testing: 1. IBM build: - Logs contained Event logs and dumps - Both pages rendered when clicking link 2. Intel build - Logs contained Event logs only - Logs page rendered when clicking link 3. Tested default build - Logs contained Event logs only - Logs page rendered when clicking link
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I4621837202cf5ad3469d6ea460d9a5bdc79c8816
show more ...
|
#
71114feb |
| 06-May-2021 |
Derick Montague <derick.montague@ibm.com> |
Replace use of the term host with server
This patchset focuses on the global store use for server power operations and impacts several pages in the interface.
For consistency, both in the UI and th
Replace use of the term host with server
This patchset focuses on the global store use for server power operations and impacts several pages in the interface.
For consistency, both in the UI and the code base, we are replacing the term host with server. This change impacts both the user and the developer experience. Maintaining consistency in naming allows both developers and users to form a mental model of the overall system and will help remove confusion when interacting with the UI and editing the interface.
Testing: 1. Tested shutdown, power on, and reboot and verified the icons and page sections in the site header and the server power operations page update as expected during power operations. 2. Verified the one-time boot operations alert is displayed to the user when changing the boot settings on the server power operations page 3 Tested factory reset and validated the correct information message is displayed to the user with the server power off and on when performing the factory reset functions. 4. Verified the SOL Console status icon updates correctly during power operations. 5. Verified the alert message is displayed on the firmware update page when the server is powered on.
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I88499a746364ab80f16a8b350d550407d094e95d
show more ...
|
#
80267970 |
| 16-Feb-2021 |
Derick Montague <derick.montague@ibm.com> |
Fix skip link 404 error on refresh bug
Problem: When a user uses the skip link anchor to skip the navigation, the route was being changed to /#main-content. This route does not exist. If a user were
Fix skip link 404 error on refresh bug
Problem: When a user uses the skip link anchor to skip the navigation, the route was being changed to /#main-content. This route does not exist. If a user were to manually refresh the page, it would return a 404. This link is critical to meet accessibility guidelines and is needed by users that navigate with a keyboard.
The challenge is that we need to mirror a full page refresh on all route changes, so we set focus on the app-header element on each route change. When we click the skip to navigation link, there should not be a route change. All we need is to set focus on the <main> element so that the user can tab to the first tabbable element in the main content section.
Solution: - Use a native <a> element with an attached click event handler - Prevent the default action of adding the hash to the URL - Create a global mixin to reuse for route changes and skip link activation - Emit an event that can be listened for to call the global mixin
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I4c2301b02f608eeb376ed2d1bd809f3d5c1bf545
show more ...
|
#
f92e2969 |
| 09-Feb-2021 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add enhancements to BVToastMixin
Adds ability to create toasts with multi-lined body content and options to include a timestamp and application refresh action.
Signed-off-by: Yoshie Muranaka <yoshi
Add enhancements to BVToastMixin
Adds ability to create toasts with multi-lined body content and options to include a timestamp and application refresh action.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I30b1da04a0e0b5f29a419950462d1ca35e207552
show more ...
|
#
c5c2ae99 |
| 09-Dec-2020 |
Sukanya Pandey <sukapan1@in.ibm.com> |
Show asset name in the app header
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com> Change-Id: If5394604d6c91b3604eaadb33178376fe6da672c
|
#
edb8a774 |
| 29-Oct-2020 |
Sukanya Pandey <sukapan1@in.ibm.com> |
Resolve custom-event-name-casing lint warnings
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com> Change-Id: I9eea4eac3b8cacc216fc9ad1011e51622622e75f
|
#
602e98aa |
| 21-Oct-2020 |
Derick Montague <derick.montague@ibm.com> |
Update linting packages to use latest
- 99% of changes were small syntax changes that were changed by the lint command. There were a couple of small manual changes to meet the property order pattern
Update linting packages to use latest
- 99% of changes were small syntax changes that were changed by the lint command. There were a couple of small manual changes to meet the property order patterns established as part of the vue:recommended guidelines.
There are rules that were set from errors to warnings and new stories are being opened to address those issues.
Testing: - Successfully ran npm run serve - Successfully ran npm run lint - Verified functionality works as expected, e.g. success and failure use cases - Resolved any JavaScript errors thrown to the console
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: Ie082f31c73ccbe8a60afa8f88a9ef6dbf33d9fd2
show more ...
|
#
7d4b53bc |
| 26-Oct-2020 |
Derick Montague <derick.montague@ibm.com> |
Update button focus state for small screen
The focus state uses the box-shadow and two inset values. The first should match the background of the button or link container. The second is the actual c
Update button focus state for small screen
The focus state uses the box-shadow and two inset values. The first should match the background of the button or link container. The second is the actual color of the outline focus state. On smaller viewports, the menu stacks and is a different color.
- Add mixin with optional color param for setting the color of the inset box-shadow that matches the container's background color - Add a focus state for the helper-menu at the smaller breakpoint - Remove the multiple :focus pseudo-selector declarations that remove the outline and set it when we set the initial focus state
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I8eb046f892b395baba41dd62460d2a771bd1f92a
show more ...
|
#
1f8117f8 |
| 22-Sep-2020 |
SurenNeware <sneware9@in.ibm.com> |
Add style to left sidebar and app header
- Updated hover, active and focus state for left sidebar menu items. - Add style guide for top header navigation. - Add new white color logo. - Add focus and
Add style to left sidebar and app header
- Updated hover, active and focus state for left sidebar menu items. - Add style guide for top header navigation. - Add new white color logo. - Add focus and active state to current menu item.
Signed-off-by: Suren Neware <sneware9@in.ibm.com> Change-Id: Ib97df4efda216f653ce0415c3f3ae9ae75bcb9cd
show more ...
|
#
d624dae9 |
| 21-Sep-2020 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add support for mutual TLS
Adding check for 'IsAuthenticated' cookie in AuthenticationStore and adding a check in created hook for AppHeader component because it is visible on all authenticated page
Add support for mutual TLS
Adding check for 'IsAuthenticated' cookie in AuthenticationStore and adding a check in created hook for AppHeader component because it is visible on all authenticated pages.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ic558c9c45fd3f5874c8c516cb6bc005cba4946e2
show more ...
|
#
dd6aa0aa |
| 08-Oct-2020 |
Sukanya Pandey <sukapan1@in.ibm.com> |
Show error toast notification on unauthorized access
-When 403 status code which is an unauthorized access occured -show error toast notification.
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.c
Show error toast notification on unauthorized access
-When 403 status code which is an unauthorized access occured -show error toast notification.
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com> Change-Id: I55fa7052073f87f28c3584b68fd4e84247a4237e
show more ...
|
#
61859097 |
| 30-Sep-2020 |
SurenNeware <sneware9@in.ibm.com> |
Update relative path imports to use '@' alias
- Add '@/' instead of '../../../'
Signed-off-by: Suren Neware <sneware9@in.ibm.com> Change-Id: Ida1dc26f2bd62f38914a74b729ee8fd143c360ac
|
#
a5cbc449 |
| 12-Oct-2020 |
SurenNeware <sneware9@in.ibm.com> |
Add title attribute to header actions
- Add title attrbute to refresh and avatar icons in app header.
Signed-off-by: Suren Neware <sneware9@in.ibm.com> Change-Id: I89629548ecf5141e3c168fe7b5e1a60
Add title attribute to header actions
- Add title attrbute to refresh and avatar icons in app header.
Signed-off-by: Suren Neware <sneware9@in.ibm.com> Change-Id: I89629548ecf5141e3c168fe7b5e1a60d1f86620c
show more ...
|