#
583ba441 |
| 03-Feb-2025 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: Ic2bc1d98d8ad469a3477f9059ec890fc8339907d Signed-off-by: Patrick Williams <p
clang-format: update latest spec and reformat
Copy the latest format file from the docs repository and apply.
Change-Id: Ic2bc1d98d8ad469a3477f9059ec890fc8339907d Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
f535cad6 |
| 16-Aug-2024 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda forma
clang-format: re-format for clang-18
clang-format-18 isn't compatible with the clang-format-17 output, so we need to reformat the code with the latest version. The way clang-18 handles lambda formatting also changed, so we have made changes to the organization default style format to better handle lambda formatting.
See I5e08687e696dd240402a2780158664b7113def0e for updated style. See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.
Change-Id: I956cf3cb1bbfc017c4d4dceb3195c1d0735b0605 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
#
94f71c51 |
| 10-Dec-2021 |
Szymon Dompke <szymon.dompke@intel.com> |
Trigger: make dbus properties writable
This change allows to modify 'Sensors', 'ReportNames' and 'Thresholds' dbus properties of Trigger interface. They are required by Redfish to implement PATCH fu
Trigger: make dbus properties writable
This change allows to modify 'Sensors', 'ReportNames' and 'Thresholds' dbus properties of Trigger interface. They are required by Redfish to implement PATCH functionality for Trigger schema.
Some backend changes were required to enable this functionality, and as such few improvements were made for existing code: - NumericThreshold and DiscreteThreshold now have common implementation where it was possible. - Internal sensor info structure for Trigger is now the same as the one used for Report. This resulted in breaking compatibility with previous Trigger persistency data. - Added getInfo / getParams methods for Sensor and Threshold interfaces. They are used by Trigger dbus getters and persistency mechanism now, instead of storing this data in Trigger object.
Testing done: - Unit tests were expanded and are passing - dbus setters for Sensors and Thresholds are working and modifications are reflected by calling appropriate getters.
Signed-off-by: Szymon Dompke <szymon.dompke@intel.com> Change-Id: I7a14c15a30d78ce872342b5f938aba43c77be9c0
show more ...
|
#
b8cc78dd |
| 29-Nov-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Api changes in AddReportFuture version
Added support for CollectionFunction, CollectionDuration, CollectionTimeScope, ReportUpdates, AppendLimit.
New API separates Id and Name, user can decide to p
Api changes in AddReportFuture version
Added support for CollectionFunction, CollectionDuration, CollectionTimeScope, ReportUpdates, AppendLimit.
New API separates Id and Name, user can decide to pass only Name to auto generate Id or pass Id which needs to be unique.
Tested: - No functional changes to old API, everything works as before - All use cases can be replaced with new API to achieve same results - New features which require new API work as expected
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com> Change-Id: I647efab36d90a548754f89968223e162a087481e
show more ...
|
#
7e098e93 |
| 16-Sep-2021 |
Lukasz Kazmierczak <lukasz.kazmierczak@intel.com> |
Added support for Enabled property
Enabled property is added so that user can select via dbus interface if Readings are updated and signal on Readings update is emitted, moreover Metric calculation
Added support for Enabled property
Enabled property is added so that user can select via dbus interface if Readings are updated and signal on Readings update is emitted, moreover Metric calculation on received sensor data is active only when Enabled is set to true
Tested: - New unit tests were created, ran all new and previous UTs, all passed - Tested under QEMU by adding reports for single and multiple sensors, changing Enabled property and emitting signal of value change for sensors added into the report, checking if Readings is accordingly updated or not updated - Verified persistency, if Enabled property is successfully stored and restored after Telemetry service restart and also checked if after the restart dependencies of Enabled (Readings, Metric calculation) are properly initiated
Signed-off-by: Lukasz Kazmierczak <lukasz.kazmierczak@intel.com> Change-Id: I29cf13693a48d15cb16d2ad6707f483f67f4879b
show more ...
|
#
dcc4e193 |
| 08-Mar-2021 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
created AddReportFutureVersion dbus method
New method will support CollectionTimeScope, CollectionDuration
In order to make not breaking interface changes bmcweb will switch to AddReportFutureVersi
created AddReportFutureVersion dbus method
New method will support CollectionTimeScope, CollectionDuration
In order to make not breaking interface changes bmcweb will switch to AddReportFutureVersion, then AddReport will be changed to match AddReportFutureVersion, then redfish will switch back to use AddReport, then AddReportFutureVersion will be removed.
Tested: - Verified that current version of bmcweb works fine with old API
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com> Change-Id: I51a9b7fb2f4da5b8d2f688ccd5e93710352b1ac7
show more ...
|
#
b5645947 |
| 29-Sep-2020 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Implemented sensor class
Sensor class was introduced, it monitors xyz.openbmc_project.Sensor.Value, for change and notifies all listeners.
Tested: - Unit tested with service stub that provides db
Implemented sensor class
Sensor class was introduced, it monitors xyz.openbmc_project.Sensor.Value, for change and notifies all listeners.
Tested: - Unit tested with service stub that provides dbus interface xyz.openbmc_project.Sensor.Value - All changes are delivered to listeners - All other unit tests are passing
Change-Id: I8c9d58cc986c1fe2a4d2386815d559814016efa6 Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|
#
7f06f613 |
| 24-Sep-2020 |
Krzysztof Grobelny <krzysztof.grobelny@intel.com> |
Created sensor cache class
Created sensor cache and sensor interface that needs to be implemented by sensors.
Tested: - Sensors created by sensor cache are stored and reused if there is try to ac
Created sensor cache class
Created sensor cache and sensor interface that needs to be implemented by sensors.
Tested: - Sensors created by sensor cache are stored and reused if there is try to access same sensor multiple times. - All other units tests are passing
Change-Id: I552b2016bca4688e1b2a223297587826af256b54 Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>
show more ...
|