History log of /openbmc/slpd-lite/main.cpp (Results 1 – 6 of 6)
Revision Date Author Comments
# eebd0815 24-May-2024 Andrew Geissler <geissonator@yahoo.com>

Only allow a maximum packet size of 255 bytes

This code was written with an assumption that the input/output buffer
sizes would not exceed 255 bytes. The assumption can be seen throughout
the code w

Only allow a maximum packet size of 255 bytes

This code was written with an assumption that the input/output buffer
sizes would not exceed 255 bytes. The assumption can be seen throughout
the code where it is using a "uint8_t" for size calculations when doing
offsets into the data buffers.

As this application was written for OpenBMC and the service list
provided by OpenBMC is very minimal, supporting a maximum request
buffer of 255 bytes is a fine assumption. Just need to enforce it.

Without this change, very unexpected things can happen with uint8_t
overflow issues when a packet size greater then 255 bytes is passed in
or created internally.

Tested:
- Verified a request with a packet size over 255 bytes is rejected

Change-Id: Icec15fe100d6514a3309fa89e9f79d565de05553
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...


# 3964d552 04-Apr-2023 Patrick Williams <patrick@stwcx.xyz>

main: fix 'unused-parameter' warnings

Change-Id: I4412ff1707fca77556ca8e3a1b15f912f32f8213
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>


# 537ff140 01-Nov-2018 Patrick Venture <venture@google.com>

add clang-format to repo for style

Add .clang-format to repo for style.

Change-Id: I286b3b245550d6a736d7df797f0ce21b51d7a235
Signed-off-by: Patrick Venture <venture@google.com>


# 908dee3d 21-Mar-2017 Ratan Gupta <ratagupt@in.ibm.com>

Remove unnecessary logs

Change-Id: Ib537f58bc7d5ec5efdada2243952bb868d99ffa1
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>


# 0d3e9e33 10-Feb-2017 Ratan Gupta <ratagupt@in.ibm.com>

Reduced excessive logging to the journal.

Fixes openbmc/openbmc#983

Change-Id: If52055feca8f965162948bd7af710da3ea9257d2
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>


# 309ac445 13-Dec-2016 Ratan Gupta <ratagupt@in.ibm.com>

SLP Server

This contains the entry point for the SLP
and starts the SLP Server.

Change-Id: I5976c8168a1af2703143c9bead61583197949115
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>