pldmtool : Migrate to placement_new from reinterpret casting

reinterpret_cast is prohibited by the C++ core guidelines because
it takes the behavior outside the language definition and gives
problem

pldmtool : Migrate to placement_new from reinterpret casting

reinterpret_cast is prohibited by the C++ core guidelines because
it takes the behavior outside the language definition and gives
problems with type safety. Placement-new on the other-hand allows
to control the object storage while still properly instantiating
an object,keeping the behavior inside the C++ language
specification.

Change-Id: Iaebfaa78c4d3c0c3658dbf9f2f6eaa932b061e83
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I95f756bab7f403af49a94011bbb1fe4e51f985ad
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I95f756bab7f403af49a94011bbb1fe4e51f985ad
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8c84201cb2343a8c8a5507a49de0721a1bee7063
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

pldm: Move off pldm_bios_table_attr_value_entry_encode_integer_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pl

pldm: Move off pldm_bios_table_attr_value_entry_encode_integer_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_value_entry_encode_integer_check.yaml
```

Change-Id: Ifdae4ebf848a43d9bd997292b35426b26dbf558c
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_value_entry_encode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pld

pldm: Move off pldm_bios_table_attr_value_entry_encode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_value_entry_encode_string_check.yaml
```

Change-Id: If3454dc8a7b2036c035d49b1e6d9ba1b23547138
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_value_entry_encode_enum_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_

pldm: Move off pldm_bios_table_attr_value_entry_encode_enum_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_value_entry_encode_enum_check.yaml
```

Change-Id: Id989540d8ad4ea114ee059992be4293254e1ecc2
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_string_decode_def_string_length_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions

pldm: Move off pldm_bios_table_attr_entry_string_decode_def_string_length_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_string_decode_def_string_length_check.yaml
```

gitlint-ignore: T1,B1
Change-Id: Ib7b44820870da32109981c8a8d44657214cf1d61
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pld

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_enum_decode_pv_hdls_check.yaml
```

Change-Id: I6dd0cf34f023aa1d4f806d0a24eb45ce5e822d12
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_enum_decode_def_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pld

pldm: Move off pldm_bios_table_attr_entry_enum_decode_def_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_enum_decode_def_num_check.yaml
```

Change-Id: I4a1777cf6b29ed8f1cf47770d058a3dd0b7c8e7b
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_enum_decode_pv_num_check.yaml
```

Change-Id: I749ac6dd0423a82e16dc1a6d35bfec5a9041b565
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_string_entry_decode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bi

pldm: Move off pldm_bios_table_string_entry_decode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_string_entry_decode_string_check.yaml
```

Change-Id: I085a4b6bbd8a08db19156ab404d5dde6a20d32ba
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I539a0c5baa63be240fc1c76367c0af338dd89c7b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Remove repeated branches

Removes repeated branches in if/else if/else chains,consecutive
repeated branches in switch statements and identical true and
false branches in conditional operators. This a

Remove repeated branches

Removes repeated branches in if/else if/else chains,consecutive
repeated branches in switch statements and identical true and
false branches in conditional operators. This also helps in
clang-tidy checks.

Change-Id: Ia9c27163ae07054fdceb65c14fea13052c5160a4
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

pldm: Migrate to pldm_bios_table_attr_value_entry_encode_integer_check()

pldm_bios_table_attr_value_entry_encode_integer() is deprecated in
libpldm as it uses assert() to sanitize its parameters. Us

pldm: Migrate to pldm_bios_table_attr_value_entry_encode_integer_check()

pldm_bios_table_attr_value_entry_encode_integer() is deprecated in
libpldm as it uses assert() to sanitize its parameters. Use
pldm_bios_table_attr_value_entry_encode_integer_check() instead, which
returns a value indicating success or failure.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ic308d24a83fe3371a7ef074cb1d20092a06a1291

show more ...

clang-error: fix clang-diagnostic-defaulted-function-deleted error

The clang-diagnostic-defaulted-function-deleted error is generated when
explicitly defaulted move assignment operator is implicitly

clang-error: fix clang-diagnostic-defaulted-function-deleted error

The clang-diagnostic-defaulted-function-deleted error is generated when
explicitly defaulted move assignment operator is implicitly deleted.
This commit fixes those errors.

Change-Id: I7a407dd3411b19a73a13b1c1e4805b89fc2ec51a
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

pldm: Migrate off deprecated libpldm BIOS table entry encoding APIs

libpldm has deprecated the affected APIs. Prefer using their `*_check()`
variants as these return an error code rather than preven

pldm: Migrate off deprecated libpldm BIOS table entry encoding APIs

libpldm has deprecated the affected APIs. Prefer using their `*_check()`
variants as these return an error code rather than prevent misbehaviour
with assert().

1. pldm_bios_table_attr_entry_integer_encode()
2. pldm_bios_table_attr_value_entry_encode_enum()
3. pldm_bios_table_attr_value_entry_encode_string()
4. pldm_bios_table_attr_value_entry_encode_integer()

Tested: Successfully booted a p10bmc host, dumped each of the BIOS
tables with pldmtool without issue

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I823b24884e518f8c53fd153b3bc30569595ecd86

show more ...

pldm: Convert to pldm_bios_table_*_check() APIs

The pldm_bios_table_*_check() APIs wrap around unchecked equivalents
that only sanitize their parameters using assert(). The checks included
in the pl

pldm: Convert to pldm_bios_table_*_check() APIs

The pldm_bios_table_*_check() APIs wrap around unchecked equivalents
that only sanitize their parameters using assert(). The checks included
in the pldm_bios_table_*_check() APIs test the same conditions that
would trigger the assert()s in the unchecked APIs but instead return an
error code on failure.

Use of the unchecked APIs has the potential to blow up the pldmd
process, but also requires that libpldm continue to be built with
`-UNDEBUG` to avoid undefined behaviour (by aborting the process). This
impacts the performance of the library in addition to be a bit of a UX
disaster.

The unchecked APIs are deprecated in libpldm as a step improve its
safety and code generation:

https://gerrit.openbmc.org/c/openbmc/libpldm/+/64179

Tested: Booted the host on a p10bmc system with the patch applied.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I9677a7fa5ca59d04865963b367f3bb55c8676cfb

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I61b093f75011417cc9c7acf9605200f4fa429bac
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm succ

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm successfully after enabling ibm-oem

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia1997de7e0f61564055bbd837f4e24c8f14e55a5

show more ...

update clang-format

This commit would update the repo's clang-format file to
the latest of docs/style/cpp/clang-format file.

Following is the new change that is added:
Brad :
clang-format: cpp: r

update clang-format

This commit would update the repo's clang-format file to
the latest of docs/style/cpp/clang-format file.

Following is the new change that is added:
Brad :
clang-format: cpp: remove empty lines

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ieaadd8a1cd779c9c12adf6d065cc1f9e9a8fa37b

show more ...

BIOS: support readonly attributes

Since the P10 system has BMC to manager the BIOS attributes,
and the BMC side does not know the attribute values of the BIOS,
it should allow the OOB interface(Host

BIOS: support readonly attributes

Since the P10 system has BMC to manager the BIOS attributes,
and the BMC side does not know the attribute values of the BIOS,
it should allow the OOB interface(Host) to be able to set BIOS
readOnly attributes, while still preventing the redfish-doPATCH
operation on it.

Tested: if the readOnly attribute of the pvm_system_name is true,
so we can use `pldmtool` to update the BIOS attributes.

pldmtool bios SetBIOSAttributeCurrentValue -a pvm_system_name -d XXX
{
"Response": "SUCCESS"
}

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Iabcb5c2400eb0a5c208cc76180d4b07e02457f44

show more ...

treewide: remove 'using namespace' from headers

Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:

"Doing so takes away an #includer’s abi

treewide: remove 'using namespace' from headers

Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:

"Doing so takes away an #includer’s ability to effectively
disambiguate and to use alternatives. It also makes #included headers
order-dependent as they might have different meaning when included in
different orders."

For further reading:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-using-directive

The guidelines don't call out using using namespace from namespace
scope, but it is only marginally less problematic and still unexpected,
so this patch removes those as well.

The process used to do the update is roughly:

1 - git grep 'using namespace' **.hpp
2 - For each instance, remove the offending 'using namespace' line
3 - build
4 - add 'using namespace' to cpp files or fully resolve types in hpp
files until the project builds again.

Further cleanup is possible - for example cpp files could be scrubbed
for unnecessary namespace qualification - this was not done here to make
review as simple as possible.

Change-Id: I4931f5e78a1b5b74b4a4774c035a549f4d59b91a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Fix potential map::at error

There are some potential errors, when using the map::at method,
the process may hang due to out of bounds. so the exception should
be caught.

Also, use the map::contains

Fix potential map::at error

There are some potential errors, when using the map::at method,
the process may hang due to out of bounds. so the exception should
be caught.

Also, use the map::contains method of C++20 instead of map::find.

Tested: built pldm successfully and worked.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia5d7dea906e5c598072c08b27387195ef1201839

show more ...

pldmtool: Fix confusing attribute name

- The intent behind this commit is to fix the confused attribute
name. when we run `pldmtool bios getBIOSTable -t
1(PLDM_BIOS_ATTR_TABLE)`, we can only get

pldmtool: Fix confusing attribute name

- The intent behind this commit is to fix the confused attribute
name. when we run `pldmtool bios getBIOSTable -t
1(PLDM_BIOS_ATTR_TABLE)`, we can only get the default value and
index.

- Early naming will make the caller mistakenly think that this is
the currect value. In fact, we need to run `pldmtool bios
getBIOSTable -t 2(PLDM_BIOS_ATTR_VAL_TABLE)` to get the currect
value.

Tested:
- pldmtool bios getBIOSTable -t 1
Before:
{
"AttributeHandle": 19,
"AttributeNameHandle": "28(pvm_system_power_off_policy)",
"AttributeType": "BIOSEnumeration",
"NumberOfPossibleValues": 3,
"PossibleValueStringHandle[0]": "12(Power Off)",
"PossibleValueStringHandle[1]": "14(Stay On)",
"PossibleValueStringHandle[2]": "2(Automatic)",
"NumberOfDefaultValues": 1,
"DefaultValueStringHandleIndex[0]": 2,
"StringHandle": "2(Automatic)"
}

After:
{
"AttributeHandle": 19,
"AttributeNameHandle": "28(pvm_system_power_off_policy)",
"AttributeType": "BIOSEnumeration",
"NumberOfPossibleValues": 3,
"PossibleValueStringHandle[0]": "12(Power Off)",
"PossibleValueStringHandle[1]": "14(Stay On)",
"PossibleValueStringHandle[2]": "2(Automatic)",
"NumberOfDefaultValues": 1,
"DefaultValueStringHandleIndex[0]": 2,
"DefaultValueStringHandle": "2(Automatic)"
}

- pldmtool bios getBIOSTable -t 2
{
"AttributeHandle": 19,
"AttributeType": "BIOSEnumeration",
"NumberOfCurrentValues": 1,
"CurrentValueStringHandleIndex[0]": "Automatic"
}

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ib493d80431dad039f264c65cbdcb8bab80ca85f0

show more ...

Display pldmtool Base & Bios command output in JSON.

./pldmtool base GetPLDMTypes
[
{
"PLDM Type": "base",
"PLDM Type Code": 0
},
{
"PLDM Type": "platform",

Display pldmtool Base & Bios command output in JSON.

./pldmtool base GetPLDMTypes
[
{
"PLDM Type": "base",
"PLDM Type Code": 0
},
{
"PLDM Type": "platform",
"PLDM Type Code": 2
},
{
"PLDM Type": "bios",
"PLDM Type Code": 3
},
{
"PLDM Type": "fru",
"PLDM Type Code": 4
},
{
"PLDM Type": "oem-ibm",
"PLDM Type Code": 63
}
]

./pldmtool base GetPLDMVersion -t 0
{
"Response": "1.0.0"
}

./pldmtool base GetTID
{
"Response": 1
}

./pldmtool base GetPLDMCommands -t 0
[
{
"PLDM Command Code": 2,
"PLDM Command": "GetTID"
},
{
"PLDM Command Code": 3,
"PLDM Command": "GetPLDMVersion"
},
{
"PLDM Command Code": 4,
"PLDM Command": "GetPLDMTypes"
},
{
"PLDM Command Code": 5,
"PLDM Command": "GetPLDMCommands"
}
]

./pldmtool bios GetDateTime
{
"Response": "2020-10-15 16:33:55"
}

./pldmtool bios GetBIOSTable -t 0
{
"0": "Allowed",
"1": "Disabled",
"2": "Enabled",
"3": "IPv4DHCP",
"4": "IPv4Static",
"5": "Not Allowed",
"6": "OPAL",
"7": "Perm",
"8": "PowerVM",
"9": "Temp",
"10": "hb-hyp-switch",
"11": "pvm-fw-boot-side",
"12": "pvm-inband-code-update",
"13": "pvm-os-boot-side",
"14": "pvm-pcie-error-inject",
"15": "pvm-stop-at-standby",
"16": "pvm-surveillance",
"17": "pvm-system-name",
"18": "vmi-hostname",
"19": "vmi-if-count",
"20": "vmi-if0-ipv4-ipaddr",
"21": "vmi-if0-ipv4-method",
"22": "vmi-if0-ipv4-prefix-length",
"23": "vmi-if1-ipv4-ipaddr",
"24": "vmi-if1-ipv4-method",
"25": "vmi-if1-ipv4-prefix-length",
"26": "vmi-ipv4-gateway"
}

./pldmtool bios GetBIOSTable -t 1
[
{
"AttributeHandle": 0,
"AttributeNameHandle": "17(pvm-system-name)",
"AttributeType": "BIOSString",
"StringType": "0x01",
"MinimumStringLength": 0,
"MaximumStringLength": 100,
"DefaultStringLength": 0,
"DefaultString": ""
},
...
...
{
"AttributeHandle": 16,
"AttributeNameHandle": "15(pvm-stop-at-standby)",
"AttributeType": "BIOSEnumeration",
"NumberOfPossibleValues": 2,
"PossibleValueStringHandle[0]": "1(Disabled)",
"PossibleValueStringHandle[1]": "2(Enabled)",
"NumberOfDefaultValues": 1,
"DefaultValueStringHandleIndex[0]": 1,
"StringHandle": "2(Enabled)"
}
]

./pldmtool bios GetBIOSTable -t 2
[
{
"AttributeHandle": 0,
"AttributeType": "BIOSString",
"CurrentStringLength": 0,
"CurrentString": ""
},
...
...
{
"AttributeHandle": 16,
"AttributeType": "BIOSEnumeration",
"NumberOfCurrentValues": 1,
"CurrentValueStringHandleIndex[0]": "Enabled"
}
]

./pldmtool bios GetBIOSAttributeCurrentValueByHandle -a pvm-pcie-error-inject
{
"CurrentValue": "Enabled"
}

./pldmtool bios SetBIOSAttributeCurrentValue -a vmi-if0-ipv4-method -d IPv4Static
{
"Response": "SUCCESS"
}

Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>
Change-Id: If58e2ce380efcad228e4440316cd2653eada9e73

show more ...