#
d10511f2 |
| 12-Sep-2020 |
Igor Kononenko <i.kononenko@yadro.com> |
server-overview: supporting all MACs and IPs
Show MAC and IP address information for all the present ethernet interfaces on the server overview page.
Tested: the `webui`-overview page on a system h
server-overview: supporting all MACs and IPs
Show MAC and IP address information for all the present ethernet interfaces on the server overview page.
Tested: the `webui`-overview page on a system having 2 physical ethernet interfaces shows all IP addresses assigned to the interface and also shows MAC addresses for each interface
``` ETH0 IP ADDRESSES IPv4: 172.17.26.67 IPv4: 169.254.28.79 IPv6: FE80::702C:BFFF:FEDE:DEC3
ETH1 IP ADDRESSES IPv4: 169.254.51.25 IPv6: FE80::14B7:7EFF:FEF1:2EF
ETH0 MAC ADDRESS 72:2C:BF:DE:DE:C3
ETH1 MAC ADDRESS 16:B7:7E:F1:02:EF ```
End-user-impact: The server-overview page is now able to display information about each ethernet's MAC, IPv4 and IPv6 adresses.
Signed-off-by: Igor Kononenko <i.kononenko@yadro.com> Change-Id: I677b645cc33bfc49c2dd91f4acc743973dc29998
show more ...
|
#
50c1aa1d |
| 14-Oct-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Fix IE11 icon alignment on header and system overview
Made height and width changes to icons on app header and system overview to properly align icons in IE11. Removes additional space in system ove
Fix IE11 icon alignment on header and system overview
Made height and width changes to icons on app header and system overview to properly align icons in IE11. Removes additional space in system overview quick links.
Tested in Chrome, IE11, Safari, Edge.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I7ae24df3fe73ea3502565ed3ee2ccabb2506e098
show more ...
|
#
30d7c637 |
| 31-Jul-2019 |
Derick Montague <derick.montague@ibm.com> |
Update overview page to use new UI patterns
- Use page, section, list-pair to establish consistent layout - Update header and overview page to use new caret icon - Reordered Server and BMC infor
Update overview page to use new UI patterns
- Use page, section, list-pair to establish consistent layout - Update header and overview page to use new caret icon - Reordered Server and BMC information to accomodate small screen views - Added chevron icons to create consistency between header and server overview page quick links - Changed edit hostname text to use the standard icon - Added OR operator to short circuit the server model, server serial number, and server manufacturer to display N/A if the information is not available
Change-Id: I6619f5369ff290555142e85aa432e901c4f93d2d Signed-off-by: Derick Montague <derick.montague@ibm.com>
show more ...
|
#
c652ed18 |
| 19-Jul-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Update toggle component
- Adds text to indicate the current state of the toggle button to meet accessibility guidelines - Update size, color, and focus of toggle component to fix DAP violations
Update toggle component
- Adds text to indicate the current state of the toggle button to meet accessibility guidelines - Update size, color, and focus of toggle component to fix DAP violations - Add page, section, and list-pair layout patterns established on the power usage page to begin a pattern for consistent page layout - Add form__field and form__actions to help with form layout consistency.
Tested: Verified toggle functions in the GUI and tested with screen reader. Passes DAP.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: Iaa8646b1179cc307971065c455f4b9448095d1ec
show more ...
|
#
c86ce3c9 |
| 05-Jun-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Consolidate button styles
This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes.
This patchset also
Consolidate button styles
This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes.
This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive.
- All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
show more ...
|
#
e4194ce0 |
| 24-May-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add remote logging server
Remote logging enables the user to configure a remote server to stream out local logs. This feature will be available on the Event Log page. The user can add a remote serve
Add remote logging server
Remote logging enables the user to configure a remote server to stream out local logs. This feature will be available on the Event Log page. The user can add a remote server, edit/change an existing server configuration and remove/disable the remote server.
Resolves openbmc/phosphor-webui#68
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I8284cbdbdaaf85f5c95f237efc72290c66904b40
show more ...
|
#
6a3b3b2c |
| 16-May-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix tablet alignment issues for event logs
This will make sure our event log content is properly aligned on tablet and desktop views. It will also make the date/time value on the server overview pag
Fix tablet alignment issues for event logs
This will make sure our event log content is properly aligned on tablet and desktop views. It will also make the date/time value on the server overview page always display underneath the 'BMC time' label in a destkop view–currently the date value will wrap to a new line if the string is too long.
- Update markup to use Foundation grid layout classes on the server overview event log table
Tested: Event log tables on server overview page and event log page
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I7d765ebbe679f954e606d1d25e2182d983a7b3f3
show more ...
|
#
565efda5 |
| 16-Apr-2019 |
dixsie <dixsiew@gmail.com> |
Fix system overview edit hostname form validation
- Add pattern for no spaces - Fix character count - Prepopulate hostname in input field - Show error for invalid input - Improve form accessibility
Fix system overview edit hostname form validation
- Add pattern for no spaces - Fix character count - Prepopulate hostname in input field - Show error for invalid input - Improve form accessibility - Correct global disabled primary button style
Resolves openbmc/phosphor-webui#71
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: Ia0601ac7c52229d0606dc5b13397b468fa81426d
show more ...
|
#
1ffa209e |
| 01-Apr-2019 |
Derick Montague <derick.montague@ibm.com> |
Resolve accessibility isssues
- Remove unecessary aria-roles - Associate label elements with form elements - Remove extraneous markup on Network settings page - Update generic markup to use definiti
Resolve accessibility isssues
- Remove unecessary aria-roles - Associate label elements with form elements - Remove extraneous markup on Network settings page - Update generic markup to use definition list when appropriate - Add aria-labels and aria-expanded to accordion triggers
Tested: Accessibility issues tested in using Lighthouse in Chrome Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels set focus on the form elements. Visually tested of the Network Settings page in Chrome, Firefox, and Safari to verify layout changes.
Resolves openbmc/phosphor-webui#76
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a
show more ...
|
#
edf1ab46 |
| 15-Feb-2019 |
beccabroek <beccabroek@gmail.com> |
Clean up headers
Updates headers to match style guide and makes them consistent throughout pages in the GUI. Removes instances where a header element existed and a different header style was being a
Clean up headers
Updates headers to match style guide and makes them consistent throughout pages in the GUI. Removes instances where a header element existed and a different header style was being applied. For example, <h2 class="h4">
Tested: Ran GUI locally and verified that headers look consistent and have the appropriate sizing while using Chrome, Firefox and Safari.
Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56 Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
#
dbf04811 |
| 16-Nov-2018 |
Alexander Filippov <a.filippov@yadro.com> |
fix date/time representation in national locales
Added "localeDate" filter to present date and time in preferred format: - the date will be displayed as: 'Dec 3, 2018' - the time will be displayed
fix date/time representation in national locales
Added "localeDate" filter to present date and time in preferred format: - the date will be displayed as: 'Dec 3, 2018' - the time will be displayed in locale preferred format. - the timezone will be displayed as abbrev or GMT+/-offset.
At the 'Date and Time setting' the time zone name will displayed in long format if it is possible.
All text parts of date/time representation will be in English.
Resolves: openbmc/phosphor-webui#42
Change-Id: I2fdbb47c62dfc5000039b0c00a20f64a9a389fc6 Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
show more ...
|
#
84e114a4 |
| 14-Nov-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Move to Bootstrap 4
Bootstrap < 4.1.2 has the following CVE: https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional theme with configurab
Move to Bootstrap 4
Bootstrap < 4.1.2 has the following CVE: https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional theme with configurable options via SCSS variables (e.g., $enable-gradients: true)."
Added "width: 100%" to a few places where width 100% was no longer getting inherited. Moved a few elements and adjusted styles to get the same look as before.
See https://getbootstrap.com/docs/4.0/migration/ for more information.
Tested: Manually on a Witherspoon. Change-Id: I0a72665ac1ca6eacd0b553a585b1fb15e14ae62c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
569ccf66 |
| 29-Oct-2018 |
beccabroek <beccabroek@gmail.com> |
Display log events in user time
Allows user to display events in their timezone or in UTC. Previously allowed either ETC or UTC, but listed ETC as 'user timezone'. Updates date time page from GMT o
Display log events in user time
Allows user to display events in their timezone or in UTC. Previously allowed either ETC or UTC, but listed ETC as 'user timezone'. Updates date time page from GMT offset to UTC offset for overall consistency. Also updates overview page to list critical events in user timezone
Resolves openbmc/phosphor-webui#36
Tested: changed timezone settings locally and validated that correct timezone and UTC offset was presented in the UI.
Change-Id: I89ca5045eeb789527aa07f5b1baebaa3fbd6b1fa Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
#
d7557e5c |
| 16-Oct-2018 |
beccabroek <beccabroek@gmail.com> |
Consistent date time format
Format on event log page and overview page of date and time should match the format of 'data last refreshed' with the exception of the timezone being listed with the even
Consistent date time format
Format on event log page and overview page of date and time should match the format of 'data last refreshed' with the exception of the timezone being listed with the event log.
Resolves openbmc/phosphor-webui#21
Change-Id: I21d43e45f45d2f9eebc7c08f4345201bef354a06 Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
#
335ac344 |
| 13-Oct-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Capitalize "Edit" hostname
To match other links, capitalize the first letter of "Edit".
Resolves openbmc/phosphor-webui#25
Change-Id: I6da98358c68223b7a70e5500f3a83a6cd57a5f32 Signed-off-by: Gunna
Capitalize "Edit" hostname
To match other links, capitalize the first letter of "Edit".
Resolves openbmc/phosphor-webui#25
Change-Id: I6da98358c68223b7a70e5500f3a83a6cd57a5f32 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
5f0b7767 |
| 25-Sep-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Remove tabs from HTML files
From https://google.github.io/styleguide/htmlcssguide.html "Indentation Indent by 2 spaces at a time.
Don't use tabs or mix tabs and spaces for indentation."
Tested: Ma
Remove tabs from HTML files
From https://google.github.io/styleguide/htmlcssguide.html "Indentation Indent by 2 spaces at a time.
Don't use tabs or mix tabs and spaces for indentation."
Tested: Manual regression testing on a Witherspoon. Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
4129f402 |
| 11-Jul-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Rename Server LED files
The menu item is called "Server LED". The title is called "Server LED". The route is server-control/server-led.
Tested: Verified server LED still works. Change-Id: I1c70cfb6
Rename Server LED files
The menu item is called "Server LED". The title is called "Server LED". The route is server-control/server-led.
Tested: Verified server LED still works. Change-Id: I1c70cfb6cd36868a191aa51363437dcdcc6d9a6b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
10ed3760 |
| 05-Jun-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Fix event log sorting
The error logs were ordered "81, 80, 8, 79 ..." sortAscending was causing this, remove it and switch "+Id" to "-Id" which is the correct way to do descending ordering. http://w
Fix event log sorting
The error logs were ordered "81, 80, 8, 79 ..." sortAscending was causing this, remove it and switch "+Id" to "-Id" which is the correct way to do descending ordering. http://www.tutorialspark.com/AngularJS/AngularJS_Filter_orderBy.php
Resolves openbmc/openbmc#3233
Tested: Server Overview page and event log page both show correct order now. Change-Id: Ie1aee542cec8a6157c538838037ce82fc2525e46 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
845acdc5 |
| 01-May-2018 |
Matt Spinler <spinler@us.ibm.com> |
Display event log ID and description if present
If the Event ID and Description event log properties are present, display the error log title as <ID>: <Desc> and move the Message property down into
Display event log ID and description if present
If the Event ID and Description event log properties are present, display the error log title as <ID>: <Desc> and move the Message property down into the box with the other additional data fields.
If they aren't present, or not filled in (which in the case of the event ID is a value of 'None'), leave the title as it currently is, which is the Message property.
Tested: Verify UI fields when the event ID is valid, when it's still in the event data but not valid, and when it isn't in the event data at all.
Resolves openbmc/openbmc#3056
Change-Id: I455fc257b7d3713aceee2975d5240fb226cfa87e Signed-off-by: Matt Spinler <spinler@us.ibm.com>
show more ...
|
#
60921bc5 |
| 29-May-2018 |
Jayashankar Padath <jayashankar.padath@in.ibm.com> |
Server overview: Limit the number of event logs
Restrict the number of high priority event logs to the 5 newest on the server overview page. All the event logs can still be viewed on the event log p
Server overview: Limit the number of event logs
Restrict the number of high priority event logs to the 5 newest on the server overview page. All the event logs can still be viewed on the event log page. The server overview page should just show a summary and not show all the high priority event logs, which could number as high as 200.
Resolves openbmc/openbmc#3160
Tested: Running GUI locally and verified the number of high priority events as 4, 5, 6 and 10.
Change-Id: I3fc22c8d13eb66a6b045d46180f1d195d74e67c3 Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
show more ...
|
#
e56bb445 |
| 18-May-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Change text to edit hostname
Before this text was "edit server name". On the Network page we call it "hostname" and the rest call is "Hostname". To be consistent change to "edit hostname".
Change-I
Change text to edit hostname
Before this text was "edit server name". On the Network page we call it "hostname" and the rest call is "Hostname". To be consistent change to "edit hostname".
Change-Id: I0042f56cc77180dbb0cc51f7e955762f1eeafb4d Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
f61ce091 |
| 18-May-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Make "high priority" lowercase
High should not be capitalized. This follows the other options in the box: "Turn on server LED", "Edit network settings", and "Serial over LAN console" Before: "View x
Make "high priority" lowercase
High should not be capitalized. This follows the other options in the box: "Turn on server LED", "Edit network settings", and "Serial over LAN console" Before: "View x High priority events" After: "View x high priority events"
Change-Id: I11b8487881cff9da4e6de58871204125045bbea8 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
c66c97e0 |
| 14-May-2018 |
Jayashankar Padath <jayashankar.padath@in.ibm.com> |
Display event logs in ascending order
Reversed the event log order to show the newest event first
Resolves openbmc/openbmc#3161
Tested: Running GUI locally and verified the order in both Server ov
Display event logs in ascending order
Reversed the event log order to show the newest event first
Resolves openbmc/openbmc#3161
Tested: Running GUI locally and verified the order in both Server overview page and in Server health -> Event log page
Change-Id: I1f1265332bb426d3f2a13932cfd5445740c3f49b Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
show more ...
|
#
ff2313db |
| 03-May-2018 |
Andrew Geissler <geissonator@yahoo.com> |
Allow user to modify hostname in overview page
Testing: Verified edit button correctly updates hostname on BMC and it is correctly refreshed in the web interface.
Resolves openbmc/openbmc#3104
Cha
Allow user to modify hostname in overview page
Testing: Verified edit button correctly updates hostname on BMC and it is correctly refreshed in the web interface.
Resolves openbmc/openbmc#3104
Change-Id: I28eb6366bde7c01b84d2fab54317aaf69ec2dba8 Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
#
9f8af0c8 |
| 01-May-2018 |
Andrew Geissler <geissonator@yahoo.com> |
Revert "Do not display the 'edit' hostname"
This reverts commit 7a3928da6aecfa20d6676150d978bca8eba62ab5.
Commits coming on top of this to add the required function in.
Change-Id: I5fe903f33de6657
Revert "Do not display the 'edit' hostname"
This reverts commit 7a3928da6aecfa20d6676150d978bca8eba62ab5.
Commits coming on top of this to add the required function in.
Change-Id: I5fe903f33de66577a807a391227dabaea0ddd69d Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
show more ...
|