clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ic16d6d63213bbdd91fcb8f5aa986b66865efda2f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-tidy: Enable readability checks on repo

The readability-* checks in Clang-Tidy focus on improving code
readability by enforcing guidelines and suggesting improvements
that can enhance the clar

clang-tidy: Enable readability checks on repo

The readability-* checks in Clang-Tidy focus on improving code
readability by enforcing guidelines and suggesting improvements
that can enhance the clarity and maintainability of C++ code.
This enables readability-const-return-type check.

Change-Id: I4737f07188f6a173678dbe0192914dd5df0dd338
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

treewide: Remove uses of bind

Bind is less compatible with function wrappers like function2 and more
terse to read.

Change-Id: I34474b71758db1ffee301729c585c4d555df2064
Signed-off-by: William A. Ke

treewide: Remove uses of bind

Bind is less compatible with function wrappers like function2 and more
terse to read.

Change-Id: I34474b71758db1ffee301729c585c4d555df2064
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I41103c892db258a85640aa1442acd9a295c8a847

show more ...

make bmc dump creation a utility function

Other parts of the code have a need for this function so put it in utils

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I223d9142e7d6ffe

make bmc dump creation a utility function

Other parts of the code have a need for this function so put it in utils

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I223d9142e7d6ffe12ec3d59d42e848c2c859e3ce

show more ...

crit-service: start bmc quiesce target on fail

This target will be monitored by the BMC state target and used to tell
external clients when the BMC is in a bad state due to a critical
service failin

crit-service: start bmc quiesce target on fail

This target will be monitored by the BMC state target and used to tell
external clients when the BMC is in a bad state due to a critical
service failing

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ibf0460bef9b3ac2a96e8a294e6de122463530713

show more ...

crit-service: create bmc dump on failure

When a critical service fails, request a BMC dump to assist in debug of
why the service failed.

Tested:
- Caused critical service to fail and verified bmc d

crit-service: create bmc dump on failure

When a critical service fails, request a BMC dump to assist in debug of
why the service failed.

Tested:
- Caused critical service to fail and verified bmc dump was created

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I2f56af0ee43b84e4142cc29f3c9ddbec053b8334

show more ...

crit-service: add failed unit to error log

Whether it's a systemd target or a service, they are both units. Log
that unit name to both error logs so it's easy to tell what failed.

Signed-off-by: An

crit-service: add failed unit to error log

Whether it's a systemd target or a service, they are both units. Log
that unit name to both error logs so it's easy to tell what failed.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I32fc45ece1e9ca9b986ead3c9675cf71857b7fcd

show more ...

crit-service: create error on failed service

This enhances the existing code to support logging an error when a
monitored service fails. The same systemd event is triggered for a
target failure and

crit-service: create error on failed service

This enhances the existing code to support logging an error when a
monitored service fails. The same systemd event is triggered for a
target failure and a service failure so no new logic is needed in
that area.

Tested:
- Repeatedly killed the host-state service until its unit went into the
failed state. Verified this was detected and the expected log was
created.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I459dd8c35ceddec986336fee635fdf691257f758

show more ...

clang-format: update to latest from docs repo

This is from openbmc/docs/style/cpp/.clang-format

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I5b80bb568451706afb6d268b41e1a5357a

clang-format: update to latest from docs repo

This is from openbmc/docs/style/cpp/.clang-format

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I5b80bb568451706afb6d268b41e1a5357a2ca6db

show more ...

meson: fix up compile errors found by meson

meson enables more error checking by default so in preperation for
moving to it, fix all errors in the code it has found.

This breaks down into the follo

meson: fix up compile errors found by meson

meson enables more error checking by default so in preperation for
moving to it, fix all errors in the code it has found.

This breaks down into the following issues:
- Unused variables: remove where applicable, otherwise void out
- Extra ';'
- Local includes need to use ""

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I94d9b4d2ffc85ae46d941e1a190fafd4ba5bd893

show more ...

monitor: support systemd delay getting on dbus

Testing has shown that systemd does not always get registered on dbus
before the phosphor-systemd-target-monitor application starts up and
calls into s

monitor: support systemd delay getting on dbus

Testing has shown that systemd does not always get registered on dbus
before the phosphor-systemd-target-monitor application starts up and
calls into systemd dbus interfaces. The code in this commit ensures the
application handles both the scenario where it is available on startup
and the scenario where the interfaces becomes available after startup.

Tested:
Verified application started and subscribed to systemd signals in both
scenarios described above.

Resolves openbmc/phosphor-state-manager#10
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I6594466681cd66f90ae27a6e935085a17120457a

show more ...

monitor: refactor systemd signal monitor variable

A new systemd signal monitor will be required so make the variable name
more specific

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change

monitor: refactor systemd signal monitor variable

A new systemd signal monitor will be required so make the variable name
more specific

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I4b48d7f2ade7c81e72c788b3af8fb30a33cae9ef

show more ...

sysd_monitor: Monitor and log errors

Note some aspects of the code are non-optimal to allow better unit
testing.

Tested:
- Verified failure detected and correct error created in qemu

Change-Id: I1

sysd_monitor: Monitor and log errors

Note some aspects of the code are non-optimal to allow better unit
testing.

Tested:
- Verified failure detected and correct error created in qemu

Change-Id: I1d4c9638fc13147508168278cc5ab90c37e1fb8e
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...