clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ic16d6d63213bbdd91fcb8f5aa986b66865efda2f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

reduce dbus string constants

There are a large number of dbus constants scattered throughout the
code that could/should be obtained from phosphor-dbus-interface values.
Perform minor refactoring to

reduce dbus string constants

There are a large number of dbus constants scattered throughout the
code that could/should be obtained from phosphor-dbus-interface values.
Perform minor refactoring to greatly reduce the number of string
constants.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie8700bc90611d21eee7160f4686bc978fe0a0eb4

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I2612058799afbcd10f98bd32d2e191b0be7e437b
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I41103c892db258a85640aa1442acd9a295c8a847

show more ...

discover-system-state: add multi-host support

Add HostObjects class to fetch paths of settings d-bus objects under
/xyz/openbmc_project/control/hostX .

Signed-off-by: Potin Lai <potin.lai@quantatw.

discover-system-state: add multi-host support

Add HostObjects class to fetch paths of settings d-bus objects under
/xyz/openbmc_project/control/hostX .

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I1dc55ec389e94e6c85aa7031b304f8c4ed15dc71

show more ...

lg2: convert state-manager

This converts the rest of phosphor-state-manager over to the lg2
interface.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I3878ec950b6a2b1ada93544cc02

lg2: convert state-manager

This converts the rest of phosphor-state-manager over to the lg2
interface.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I3878ec950b6a2b1ada93544cc021cecf14edfb46

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ifa2391f2f582cb2cf16dc85012a05e1f4f6659fd

show more ...

power-restore: one-time support

The one_time PowerRestorePolicy property was introduced so system owners
could utilize the feature for one time type scenarios without rewriting
all of the logic on t

power-restore: one-time support

The one_time PowerRestorePolicy property was introduced so system owners
could utilize the feature for one time type scenarios without rewriting
all of the logic on their own.

IBM wishes to utilize the one_time power restore policy to cause an
automatic power on after an in-band firmware update.

The one_time setting is defined by default within meta-phosphor here:
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/40948

Testing:
- Set one time and verify it's the one used and then reset to default
busctl set-property xyz.openbmc_project.Settings /xyz/openbmc_project/control/host0/power_restore_policy/one_time xyz.openbmc_project.Control.Power.RestorePolicy PowerRestorePolicy s xyz.openbmc_project.Control.Power.RestorePolicy.Policy.AlwaysOff

busctl get-property xyz.openbmc_project.Settings /xyz/openbmc_project/control/host0/power_restore_policy/one_time xyz.openbmc_project.Control.Power.RestorePolicy PowerRestorePolicy
s "xyz.openbmc_project.Control.Power.RestorePolicy.Policy.AlwaysOff"

phosphor-discover-system-state

Feb 25 19:44:11 witherspoon phosphor-discover-system-state[495]: One time set, use it and reset to default

busctl get-property xyz.openbmc_project.Settings /xyz/openbmc_project/control/host0/power_restore_policy/one_time xyz.openbmc_project.Control.Power.RestorePolicy PowerRestorePolicy
s "xyz.openbmc_project.Control.Power.RestorePolicy.Policy.None"

- Verify when one time setting is at default it is ignored
busctl get-property xyz.openbmc_project.Settings /xyz/openbmc_project/control/host0/power_restore_policy/one_time xyz.openbmc_project.Control.Power.RestorePolicy PowerRestorePolicy
s "xyz.openbmc_project.Control.Power.RestorePolicy.Policy.None"

phosphor-discover-system-state

Feb 25 19:47:08 witherspoon phosphor-discover-system-state[498]: One time not set, check user setting of power policy
Feb 25 19:47:08 witherspoon phosphor-discover-system-state[498]: Host power is off, processing power policy

- Verify the one time power on path
busctl get-property xyz.openbmc_project.Settings /xyz/openbmc_project/control/host0/power_restore_policy/one_time xyz.openbmc_project.Control.Power.RestorePolicy PowerRestorePolicy
s "xyz.openbmc_project.Control.Power.RestorePolicy.Policy.AlwaysOn"

phosphor-discover-system-state

Feb 25 20:14:15 witherspoon phosphor-discover-system-state[504]: One time set, use it and reset to default
Feb 25 20:14:15 witherspoon phosphor-discover-system-state[504]: Host power is off, processing power policy
Feb 25 20:14:15 witherspoon phosphor-discover-system-state[504]: power_policy=ALWAYS_POWER_ON, powering host on

busctl get-property xyz.openbmc_project.Settings /xyz/openbmc_project/control/host0/power_restore_policy/one_time xyz.openbmc_project.Control.Power.RestorePolicy PowerRestorePolicy
s "xyz.openbmc_project.Control.Power.RestorePolicy.Policy.None"

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I13715ad2fda1f7aa0d170e506570e85f1cef8722

show more ...

autoreboot: one-time object support

The new one_time D-Bus object is utilized for setting RebootPolicy for a
single boot. phosphor-state-manager will always look at this object
first for reboot poli

autoreboot: one-time object support

The new one_time D-Bus object is utilized for setting RebootPolicy for a
single boot. phosphor-state-manager will always look at this object
first for reboot policy, if it is the default of true, then
phosphor-state-manager will then look at the persistent user setting
under the non one_time object path.

See the following commit for more info:
https://github.com/openbmc/meta-phosphor/commit/7d29e7a2c135e91b222c57c66bb7ca61aae6398e

Tested:
Via some debug statements, confirmed that Path variables are both
updated with correct settings object.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I8ef882633237529e03070607542b9acc218dffc6

show more ...

clang-format: update to latest from docs repo

This is from openbmc/docs/style/cpp/.clang-format

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I5b80bb568451706afb6d268b41e1a5357a

clang-format: update to latest from docs repo

This is from openbmc/docs/style/cpp/.clang-format

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I5b80bb568451706afb6d268b41e1a5357a2ca6db

show more ...

Update error handling on sdbusplus calls

Error handling was added to the bus.call() routine,
which effectively deprecated the is_method_error()
check. Errors should now be handled in a try/catch
blo

Update error handling on sdbusplus calls

Error handling was added to the bus.call() routine,
which effectively deprecated the is_method_error()
check. Errors should now be handled in a try/catch
block.

Change-Id: I1dcbbaa91db443445ef6bb2f616bd37f06731d36
Signed-off-by: Anthony Wilson <wilsonan@us.ibm.com>

show more ...

Traverse full GetSubTree output

It isn't safe to assume that the interface passed in to
GetSubtree will be the first one in the output, so need
to traverse the whole structure.

Tested: phosphor-di

Traverse full GetSubTree output

It isn't safe to assume that the interface passed in to
GetSubtree will be the first one in the output, so need
to traverse the whole structure.

Tested: phosphor-discover-system-state was failing with the
C++ mapper, but works with this fix.

Change-Id: Ibc29280f9d51d8067e764da1745d30378bf7068d
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Apply clang code format to this state repo

Change-Id: I232af39d8ded90fa3eb37b74d1435ddbf19fffb1
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

Add API to retrieve settings

Add API to retrieve all settings objects of interest to this repo, in
one shot.

Change-Id: Ie74d39f4d6b1d262e6e5721208efc94003eee46c
Signed-off-by: Deepak Kodihalli <dk

Add API to retrieve settings

Add API to retrieve all settings objects of interest to this repo, in
one shot.

Change-Id: Ie74d39f4d6b1d262e6e5721208efc94003eee46c
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...