#
2eb6029c |
| 13-Aug-2024 |
Amithash Prasasd <amithash@meta.com> |
Fix getManagedObjects on ObjectManager returning no objects
Currently, when calling getManagedObjects ``` busctl call xyz.openbmc_project.State.Host \ /xyz/openbmc_project/state/host0 org.freedeskto
Fix getManagedObjects on ObjectManager returning no objects
Currently, when calling getManagedObjects ``` busctl call xyz.openbmc_project.State.Host \ /xyz/openbmc_project/state/host0 org.freedesktop.DBus.ObjectManager \ GetManagedObjects ``` we end up getting no objects `a{oa{sa{sv}}} 0`. This is incorrect and we technically should return the managed objects. Looking further at the spec: ``` All returned object paths are children of the object path implementing this interface, i.e. their object paths start with the ObjectManager's object path plus '/'. ``` This implies that the the path owned by the object manager should not be the hostX sub-entries but `/xyz/openbmc_project/state`
Tested by building a harma image and in qemu calling introspect on each of the object paths and ensuring that we get the correct responses ``` busctl introspect xyz.openbmc_project.State.BMC \ /xyz/openbmc_project/state busctl introspect xyz.openbmc_project.State.BMC \ /xyz/openbmc_project/state/bmc0 busctl introspect xyz.openbmc_project.State.Host \ /xyz/openbmc_project/state busctl introspect xyz.openbmc_project.State.Host \ /xyz/openbmc_project/state/host0 busctl introspect xyz.openbmc_project.State.Chassis \ /xyz/openbmc_project/state busctl introspect xyz.openbmc_project.State.Chassis \ /xyz/openbmc_project/state/chassis0 ``` Also tested that we get the correct managed object ``` busctl call xyz.openbmc_project.State.Host /xyz/openbmc_project/state \ org.freedesktop.DBus.ObjectManager GetManagedObjects busctl call xyz.openbmc_project.State.BMC /xyz/openbmc_project/state \ org.freedesktop.DBus.ObjectManager GetManagedObjects busctl call xyz.openbmc_project.State.Chassis \ /xyz/openbmc_project/state \ org.freedesktop.DBus.ObjectManager GetManagedObjects ```
Change-Id: I525c8719c326cfbbe568c4f1f7fe95e3aa13c660 Signed-off-by: Amithash Prasad <amithash@meta.com>
show more ...
|
#
f566c964 |
| 22-Jul-2024 |
Amithash Prasasd <amithash@meta.com> |
Switch to Use phosphor-dbus-interface defined constants
We are redefining a lot of the constants which are already defined in the phosphor-dbus-interface auto-generated headers. This change switches
Switch to Use phosphor-dbus-interface defined constants
We are redefining a lot of the constants which are already defined in the phosphor-dbus-interface auto-generated headers. This change switches the code to use those instead of allowing compile time definition of those.
Allowing for compile time definition would probably break clients who are not aware of the new paths anyway.
Tested by build a harma image and loading in qemu to test the added interfaces are unchanged. ``` busctl introspect xyz.openbmc_project.State.BMC \ /xyz/openbmc_project/state/bmc0 busctl introspect xyz.openbmc_project.State.Host \ /xyz/openbmc_project/state/host0 busctl introspect xyz.openbmc_project.State.Chassis \ /xyz/openbmc_project/state/chassis0 ```
Change-Id: Ib4c77d2789c13f509b75a2b1837ea454e53e8ae9 Signed-off-by: Amithash Prasasd <amithash@meta.com>
show more ...
|
#
f053e6fe |
| 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are for: * bus_t * exception_t * manager_t * match_t * message_t * object_t * slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I41103c892db258a85640aa1442acd9a295c8a847
show more ...
|
#
e426b589 |
| 28-May-2020 |
Andrew Geissler <geissonator@yahoo.com> |
clang-format: update to latest from docs repo
This is from openbmc/docs/style/cpp/.clang-format
Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: I5b80bb568451706afb6d268b41e1a5357a
clang-format: update to latest from docs repo
This is from openbmc/docs/style/cpp/.clang-format
Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: I5b80bb568451706afb6d268b41e1a5357a2ca6db
show more ...
|
#
769a62f1 |
| 06-Dec-2019 |
Andrew Geissler <geissonator@yahoo.com> |
meson: fix up compile errors found by meson
meson enables more error checking by default so in preperation for moving to it, fix all errors in the code it has found.
This breaks down into the follo
meson: fix up compile errors found by meson
meson enables more error checking by default so in preperation for moving to it, fix all errors in the code it has found.
This breaks down into the following issues: - Unused variables: remove where applicable, otherwise void out - Extra ';' - Local includes need to use ""
Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: I94d9b4d2ffc85ae46d941e1a190fafd4ba5bd893
show more ...
|
#
58a18013 |
| 19-Jan-2018 |
Andrew Geissler <geissonator@yahoo.com> |
Apply clang code format to this state repo
Change-Id: I232af39d8ded90fa3eb37b74d1435ddbf19fffb1 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
#
bdd9cb71 |
| 19-Dec-2016 |
Josh D. King <jdking@us.ibm.com> |
Add base support for BMC state management
This is the starting code needing to build the application. Still more to do, this is just the layout for the additional commits that will be done for the
Add base support for BMC state management
This is the starting code needing to build the application. Still more to do, this is just the layout for the additional commits that will be done for the state management.
Change-Id: Ief1dc96c84b34630e60ef40c99d4faf5b6f6e02e Signed-off-by: Josh D. King <jdking@us.ibm.com>
show more ...
|