Fix deleteSNMPClient method in Unit Test file

The previous method can only delete one piece of data, and if the
last piece of data is deleted, an error will be reported and the UT
will fail.

Tested

Fix deleteSNMPClient method in Unit Test file

The previous method can only delete one piece of data, and if the
last piece of data is deleted, an error will be reported and the UT
will fail.

Tested: UT passed.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: If1e0b4170a0a58fb30d4e28c55fed68b0d0f5e28

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib15ce49ac136da396084ab09972dd132f02beeea

show more ...

Make test code use the correct signed types

There were a number of comparisons in the tests that were comparing
signed ints to unsigned ints. This lead to compiler errors in some
cases.

../../../.

Make test code use the correct signed types

There were a number of comparisons in the tests that were comparing
signed ints to unsigned ints. This lead to compiler errors in some
cases.

../../../../../../workspace/sources/phosphor-snmp/test/test_error_notification.cpp:35:5:
required from here
| /usr/src/gtest/include/gtest/gtest.h:1545:11:
error: comparison of integer expressions of different signedness: 'const
int' and 'const unsigned int' [-Werror=sign-compare]
| if (lhs == rhs) {

This commit fixes it.

Tested: Code compiles, unit test changes only.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ib6dd2afced3672ec1f7096ade07b36d53049cf1a

show more ...

Resolve Meson issues

This commit includes fixes in the repo:

1. Moving experimental filesystem to filesystem
2. Errors that meson identified

Signed-off-by: Ratan Gupta <ratankgupta31@gmail.com>
Ch

Resolve Meson issues

This commit includes fixes in the repo:

1. Moving experimental filesystem to filesystem
2. Errors that meson identified

Signed-off-by: Ratan Gupta <ratankgupta31@gmail.com>
Change-Id: I93c77c2a434275c4da3ca4549919eaa55b57f481

show more ...

clang-format-11: reformat

The .clang-format file here is an old version of the common one.
Upgrade to the latest and reformat.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic87853

clang-format-11: reformat

The .clang-format file here is an old version of the common one.
Upgrade to the latest and reformat.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic87853e6004d2d5ad6645a3ece8c0c87ccc96efd

show more ...

Add the check for the existense of the client

Don't add the client if it is already configured.

Change-Id: Ib0c64e2eb73b272a290599e1b83630a8ab5709ec
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.

Add the check for the existense of the client

Don't add the client if it is already configured.

Change-Id: Ib0c64e2eb73b272a290599e1b83630a8ab5709ec
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>

show more ...

Change the logic of generating the D-Bus object identifier

Presently D-Bus object identifier is generated with the hash of
D-Bus properties, as a result of this if the value of D-Bus property
gets c

Change the logic of generating the D-Bus object identifier

Presently D-Bus object identifier is generated with the hash of
D-Bus properties, as a result of this if the value of D-Bus property
gets change the D-Bus object identifier will get change.

This commit fixes this problem by keeping the last identifier
value in the manager object so whenever user creates new snmp
manager object it is incremented by 1, hence the object path
becomes unique.

This commit also takes care of that if at any point of time
if snmp manager app restart it gets the same D-Bus identifier
as it was before the restart.

Change-Id: I456c11f7824ff678ae470bc6641f0e0cc7c1f6bc
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>

show more ...

Fix spelling errors

Change-Id: I60d7f1974dc665647115bbeb9d8172b8790e9c92
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

Persist the snmp manager configuration

This commit persist the manager configuration D-Bus objects
and restores it once service starts.

This commit also deletes the associated persistent file whene

Persist the snmp manager configuration

This commit persist the manager configuration D-Bus objects
and restores it once service starts.

This commit also deletes the associated persistent file whenever
snmp client D-Bus object gets deleted.

Change-Id: I1526b52870ee5dfea30e6527bad3fd12d1191a13
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Implement the Client create interface

This commit also implement the D-Bus service which would be
used for snmp client configuration and would add the
snmp manager/trap receiver D-Bus objects under

Implement the Client create interface

This commit also implement the D-Bus service which would be
used for snmp client configuration and would add the
snmp manager/trap receiver D-Bus objects under
namespace /xyz/openbmc_project/network/snmp/manager/

It implements the delete interface for SNMP client D-Bus Object.

Resolves openbmc/openbmc#3057

Change-Id: I0df7b1475f81325b9ac497c1fb350c3f62329686
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...