clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: If66f68c96df4baf8dc07abf8729a3cb7657e932d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ief05bd757cffb1453e058a719ee4b060861752e7

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If6aba71f482f75143e6d669763b8853db22318cf

clang updates

The openbmc CI was recently updated to clang-12 which requires some
formatting updates to the code:
https://github.com/openbmc/openbmc-build-scripts/commit/4569bf49daaebff06be048242690

clang updates

The openbmc CI was recently updated to clang-12 which requires some
formatting updates to the code:
https://github.com/openbmc/openbmc-build-scripts/commit/4569bf49daaebff06be0482426908bb5497fad08

Make those updates and refresh the clang-format file with the one from
docs:
https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format

Change-Id: Ieb3626526373a053ec84431e7560003f229f338d
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Update .clang-format to latest version from docs

Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
Change-Id: Ie6e7f43e7554429704dca86b21320c90aed18791

Refactor: rename namespace witherspoon to phosphor

This repo now becomes phosphor-power, rename namespace witherspoon to
phosphor to make it generic.

Signed-off-by: Lei YU <mine260309@gmail.com>
Ch

Refactor: rename namespace witherspoon to phosphor

This repo now becomes phosphor-power, rename namespace witherspoon to
phosphor to make it generic.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: Icb9f8a7c33065add99f2bf42ed55745a28fa0424

show more ...

Don't try to read GPIOs when no device path

For certain PGOOD faults, the code may try to read a GPIO off of an IO
expander to further isolate the error. If there was a problem with the
device driv

Don't try to read GPIOs when no device path

For certain PGOOD faults, the code may try to read a GPIO off of an IO
expander to further isolate the error. If there was a problem with the
device driver detecting that IO expander, then the code was running down
a path where it would still try to read that IO expander, but using an
empty device path which would just generate extra error traces in the
journal. Avoid this by checking for this empty path and then not
reading those GPIOs.

Change-Id: I40a3e0c13e392fa58d87f53c8911eb96c9cd7f2c
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add YAML and error function for MEM_GOODx faults

Add a section to the error and metadata YAML files for the MEM_GOODx
faults. Use that to update/generate a new elog-errors.hpp include file.

Update

Add YAML and error function for MEM_GOODx faults

Add a section to the error and metadata YAML files for the MEM_GOODx
faults. Use that to update/generate a new elog-errors.hpp include file.

Update the power sequencer source to have a memGoodFault function for
handling callouts for MEM_GOODx type errors.

Change-Id: Ia08dc88f29f00f749e7995f97f37647b02135a2b
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Cleanup: Use filesystem instead of experimental

The GCC version bump in Yocto 2.6 allows for use of std::filesystem
instead of std::experimental::filesystem.

Change-Id: Ibfd6c285bcbd6695e5cd4e3090f

Cleanup: Use filesystem instead of experimental

The GCC version bump in Yocto 2.6 allows for use of std::filesystem
instead of std::experimental::filesystem.

Change-Id: Ibfd6c285bcbd6695e5cd4e3090ffa214fc861499
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Start using .clang-format

Used the one from docs/style/cpp.

Change-Id: I3bdc2b353bf18a437266b362d8205b8463a9ce2b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

Handle new UCD90160 MFR_STATUS sysfs location

The 4.13 UCD90160 device driver moved the sysfs location
of the mfr_status register from
/sys/kernel/debug/ucd9000.0/mfr_status
to
/sys/kernel/debug

Handle new UCD90160 MFR_STATUS sysfs location

The 4.13 UCD90160 device driver moved the sysfs location
of the mfr_status register from
/sys/kernel/debug/ucd9000.0/mfr_status
to
/sys/kernel/debug/pmbus/hwmonN/ucd90160/mfr_status

The PMBus class can already handle this, just need to
change the enum to tell it where to look.

MFR_STATUS is only read when collecting metadata
on fails.

Change-Id: If4338516400f7d7acab6ec0d550417db106eea64
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Still report errors when metadata capture fails

In the very unlikely scenario that a PMBus command
fails while trying to collect error log metadata,
don't let the thrown exception break the code out

Still report errors when metadata capture fails

In the very unlikely scenario that a PMBus command
fails while trying to collect error log metadata,
don't let the thrown exception break the code out
of creating the error log.

Change-Id: I3ca057cdc6656a8585f49ee2216f5ef13f134360
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Call out GPUs using their inventory path

The existing code was calling out GPUs in the metadata
with 'GPU=GPUn' because at the time the GPUs were not
in the inventory.

Now that the GPUs are in the

Call out GPUs using their inventory path

The existing code was calling out GPUs in the metadata
with 'GPU=GPUn' because at the time the GPUs were not
in the inventory.

Now that the GPUs are in the inventory, they can be called
out using their inventory objects which is the correct
way to do it.

Resolves openbmc/openbmc#2869

Change-Id: Ic7b3ac465d482aade532f75ef10cc05df4928767
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Don't log errors for voltage warnings

Some of the bits in the STATUS_VOUT command response
are just warnings, as defined by the PMBUS spec.

Previously the code would create voltage fault errors
if

Don't log errors for voltage warnings

Some of the bits in the STATUS_VOUT command response
are just warnings, as defined by the PMBUS spec.

Previously the code would create voltage fault errors
if any bits were on in that response, and this change
is to check for the actual fault (non-warning) bits only
before creating error logs.

Also, the code will throw the response value into the journal
now if any bits are on at all because warnings are still
useful when getting a full picture of fault conditions.

Resolves openbmc/openbmc#2714

Change-Id: I51692ced4ce03bb05d64e7a90f88bd6586897942
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Pass error to log into shutdown function

Changing the power off utility function to take a
template parameter that specifies the error to log
before the shutdown instead of hardcoding it in
the func

Pass error to log into shutdown function

Changing the power off utility function to take a
template parameter that specifies the error to log
before the shutdown instead of hardcoding it in
the function.

Also change the 2 callers of this function to pass
in the error type.

Change-Id: Ic83d87d5000f881ed9832092be207e91adf81c0c
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Use Common.Device.Error for device failures

The ReadFailure and WriteFailure errors are now
available in Common.Device, and code will now use
those instead of the ones in Sensor.Device and
Control.D

Use Common.Device.Error for device failures

The ReadFailure and WriteFailure errors are now
available in Common.Device, and code will now use
those instead of the ones in Sensor.Device and
Control.Device, which were meant for sensor errors.

Change-Id: Id15b56ab56f3ee4acee024941840a17b9f5bf9c6
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Move power errors to org.open_power.witherspoon

Move xyz.openbmc_project.Power to org.open_power.Witherspoon.
This repo is Witherspoon specific, so moving to specific tree to have
its own namespace.

Move power errors to org.open_power.witherspoon

Move xyz.openbmc_project.Power to org.open_power.Witherspoon.
This repo is Witherspoon specific, so moving to specific tree to have
its own namespace. Update generated file, and corresponding namespace
statements in the source files.

Change-Id: I10bd1eeeac5b5f391ca54bf361b249b7ad531852
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>

show more ...

Shutdown system on GPU over-temps

Resolves openbmc/openbmc#1726

Change-Id: If3263678bc03df7714f31aa097f38ee6c09389f4
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

Find and call out faulted GPUs

Isolate down to the GPU that caused the GPU PGOOD or
overtemp summary fault bit to turn on. On Witherspoon
this involves reading GPIOs on a pca9552 device to find
the

Find and call out faulted GPUs

Isolate down to the GPU that caused the GPU PGOOD or
overtemp summary fault bit to turn on. On Witherspoon
this involves reading GPIOs on a pca9552 device to find
the GPU signaling the fault.

GPUs are not currently in the inventory, so the code
isn't doing the standard callout by adding a certain
metadata field. The GPU number that failed will just
be added to the error log metadata, and work will be done
with support to make sure that is documented. Also, the
other power fault callouts don't use the standard inventory
callouts either as they are more complicated than just a single
FRU, so this method is consistent with that.

Note that these faults do not cause the system to
power off automatically like other power faults, though
a future commit will power off the system on a GPU overtemp.

Change-Id: If4053f32a06a335a6612a04a8164d34306530b22
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add GPU error logging functions

Add functions to log the GPU PGOOD and overtemp
errors.

Change-Id: I6f58d76883f8a78a3301481dbacd111c74b396d4
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

Refactor findGPIODevice

Update findGPIODevice() to work on the path passed
into it instead of just on the gpioDevice member
variable.

Now it can be called both for finding the path for
the UCD chip

Refactor findGPIODevice

Update findGPIODevice() to work on the path passed
into it instead of just on the gpioDevice member
variable.

Now it can be called both for finding the path for
the UCD chip as well as for the device that has the
GPIOs used for GPU isolation.

Change-Id: I01b93ece63cf28a11f0b438741689823280c7e2f
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Remove clearFaults calls

The community wasn't thrilled with the device driver
providing the clear_logged_faults command. As it isn't
absolutely necessary for this code to do now, it is being
remove

Remove clearFaults calls

The community wasn't thrilled with the device driver
providing the clear_logged_faults command. As it isn't
absolutely necessary for this code to do now, it is being
removed.

Note: Currently Device::clearFaults is a pure virtual function
so it still needs to be defined in the UCD90160 class.

A future commit may also remove these.

Change-Id: I0b3a33d56987dd97ab7253eb6b5d3b5afd835d67
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Fill in the createPowerFaultLog function

Only PGOOD and voltage faults are expected to occur
during normal operation, but when the system PGOOD is lost
and one of those 2 errors wasn't found, we wil

Fill in the createPowerFaultLog function

Only PGOOD and voltage faults are expected to occur
during normal operation, but when the system PGOOD is lost
and one of those 2 errors wasn't found, we will log a generic
power fault log that captures the status_word and mfr_status
registers.

Change-Id: I583c5f6c825adce00ac1b458444fcb8e05900c91
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Fill in PGOOD fault checking code

Fill in the code to check for a PGOOD fault. This is where
the power sequencer device detects that one of its child devices
lost PGOOD. A separate error log will

Fill in PGOOD fault checking code

Fill in the code to check for a PGOOD fault. This is where
the power sequencer device detects that one of its child devices
lost PGOOD. A separate error log will be created for each input
that has a fault. Each input will only have an error logged against
it once for the lifetime of the object.

Errors are detected by reading the real time status of the PGOOD input,
which is exposed as a GPIO by the device driver.

Ideally we would be able to use a summary bit in the status_word
register to see if there is an error before doing any GPIO reads,
but as the device drivers sends a clear faults every time we read
that register, and the GPI fault bits are edge triggered in the
mfr_status register that feeds status_word, we would never detect
any failures. If this was ever fixed in the core PMBus device
driver code, we could add this functionality in and save some
CPU cycles.

Change-Id: I5000f2ebc2b22dcca946154afd2405b29734ccaf
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Find the path for the GPIO device

This path is required to access a GPIO later.

Change-Id: I4ec64adbf939c5f0eaa12b7e18345d0fa2247a7d
Signed-off-by: Matt Spinler <spinler@us.ibm.com>