regulators: Retry failed sensor monitoring

If a failure occurs while trying to read voltage regulator sensors,
retry the operation 5 times before logging an error.

This provides "de-glitching" to i

regulators: Retry failed sensor monitoring

If a failure occurs while trying to read voltage regulator sensors,
retry the operation 5 times before logging an error.

This provides "de-glitching" to ignore transient hardware problems.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I310c15eb0f0d36d938057d6280a12b5aef854d20

show more ...

regulators: Add PhaseFaultDetection to Device

Add a PhaseFaultDetection data member to the Device class. This is the
first step in enabling phase fault detection for Device objects.

Create and mod

regulators: Add PhaseFaultDetection to Device

Add a PhaseFaultDetection data member to the Device class. This is the
first step in enabling phase fault detection for Device objects.

Create and modify gtest test cases to exercise new code.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Icc771eda5c79ace854acb1d7c395b82b34213996

show more ...

regulators: Add clearErrorHistory to Rail class

Add a clearErrorHistory() method to the Rail class. The method should
clear all data on previously logged errors. If the error occurs again
in the f

regulators: Add clearErrorHistory to Rail class

Add a clearErrorHistory() method to the Rail class. The method should
clear all data on previously logged errors. If the error occurs again
in the future, it will be logged again.

This method is normally called when the system is being powered on. For
code that runs repeatedly, errors are only logged once per boot.

When the system is powered off, hardware may be replaced that fixes the
problem. Thus, errors are cleared during power on.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I41e56162165186acb7a7872a288f0582874aa87d

show more ...

regulators: Complete SensorMonitoring class

Complete the SensorMonitoring class. This class implements the
"sensor_monitoring" object in the JSON config file.

Add calls to the startRail() and endR

regulators: Complete SensorMonitoring class

Complete the SensorMonitoring class. This class implements the
"sensor_monitoring" object in the JSON config file.

Add calls to the startRail() and endRail() methods of the Sensors
service.

Add ErrorHistory data member so that errors are only logged once per
boot since sensor monitoring occurs repeatedly once per second.

Add error count data member to limit the number of error messages
written to the journal since monitoring occurs repeatedly.

Update all affected test cases.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I0bd20d03ccea9e15cd0f97529f6ccdad2fa015c8

show more ...

regulators: Add inventory path to Chassis class

A previous commit added the "inventory_path" property to the "chassis"
object in the JSON configuration file.

This commit adds that new property to t

regulators: Add inventory path to Chassis class

A previous commit added the "inventory_path" property to the "chassis"
object in the JSON configuration file.

This commit adds that new property to the C++ implementation:
* Chassis class and associated gtests
* JSON configuration file parser functions and associated gtests
* Other gtests affected by the change to the Chassis constructor

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I7406f874263d01e6faa2b8c333cb1baf915cf2ac

show more ...

regulators: Convert to new SensorType enumeration

There are several types of voltage regulator sensors, such as vout,
iout, and temperature.

The sensor types were previously defined by the enumerat

regulators: Convert to new SensorType enumeration

There are several types of voltage regulator sensors, such as vout,
iout, and temperature.

The sensor types were previously defined by the enumeration
pmbus_utils::SensorValueType. This enumeration should not have been
placed in the pmbus_utils namespace because it is not specific to PMBus.

A new enumeration with the simpler name SensorType was created in
sensors.hpp in a previous commit.

Remove the old enumeration from pmbus_utils. Convert affected files to
use the new enumeration.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I4136b392b104edd3eee41ec29c779ad084c7c4de

show more ...

regulators: Enhance config file parser

Enhance JSON config file parser to convert relative inventory paths to
absolute form.

Tested:
Run local CI with -Dlong-tests=enabled to enable tests for
valid

regulators: Enhance config file parser

Enhance JSON config file parser to convert relative inventory paths to
absolute form.

Tested:
Run local CI with -Dlong-tests=enabled to enable tests for
validate-regulators-config.py.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I80237a673f9c5918898db15363847722141388e6

show more ...

regulators: Modify monitorSensors() to use Services

Modify the monitorSensors() method in the System, Chassis, Device, and
Rail classes to have a new first parameter: Services& services.

Modify Sen

regulators: Modify monitorSensors() to use Services

Modify the monitorSensors() method in the System, Chassis, Device, and
Rail classes to have a new first parameter: Services& services.

Modify SensorMonitoring::execute() to log messages using the new
Journal interface.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I05820cfa94bc3d15dee7a1714a3d253720aa7f92

show more ...

regulators: Modify Configuration to use Journal

Modify Configuration::execute() to log messages using
the new Journal interface.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: If7dee12ca

regulators: Modify Configuration to use Journal

Modify Configuration::execute() to log messages using
the new Journal interface.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: If7dee12ca064147386fc076223474f004281d7ec

show more ...

regulators: Add Services& services to classes

Modify the configure() method in the System, Chassis, Device, and Rail
classes to have a new first parameter: Services& services.

Fix mock_services.hpp

regulators: Add Services& services to classes

Modify the configure() method in the System, Chassis, Device, and Rail
classes to have a new first parameter: Services& services.

Fix mock_services.hpp bug.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I6ef41de65d2c5b68c55edb42189ba9c0f2e436ed

show more ...

regulators: Add monitorSensors support to Rail

Implemented the monitorSensors() method in the Rail class. This method
reads the sensors for a voltage rail.

Signed-off-by: Bob King <Bob_King@wistro

regulators: Add monitorSensors support to Rail

Implemented the monitorSensors() method in the Rail class. This method
reads the sensors for a voltage rail.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: Ifbe6461349d20fee1eba233844c95c1046e1a54a

show more ...

regulators: Add configure support to Device class

Implemented the configure() method in the Device class. This method
applies any configuration changes that are defined for the device. Also
config

regulators: Add configure support to Device class

Implemented the configure() method in the Device class. This method
applies any configuration changes that are defined for the device. Also
configures all rails within the device.

Also added a missing #include to rail_tests.cpp.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I2faceb7d968b6bb01ee7e1116367afee5864ca28

show more ...

regulators: Add configure support to Rail class

Implemented the configure() method in the Rail class. This method
applies any configuration changes that are defined for the rail.

Also added a few

regulators: Add configure support to Rail class

Implemented the configure() method in the Rail class. This method
applies any configuration changes that are defined for the rail.

Also added a few missing #includes in the configuration_tests.cpp file.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I4164621f6d599bbf1417ebb9328a35bd2b2d656e

show more ...

regulators: Add remaining properties to Rail class

Enhance the C++ Rail class by adding the remaining properties from the
JSON config file:
* configuration
* sensor_monitoring

See rail.md for more

regulators: Add remaining properties to Rail class

Enhance the C++ Rail class by adding the remaining properties from the
JSON config file:
* configuration
* sensor_monitoring

See rail.md for more information.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I9c2e46fe8bec39454b0ad3f703eee3b497efd82a

show more ...

Conform regulator methods to acronym conventions

Change regulator class methods to conform to OpenBMC capitalization
conventions for acronyms.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Cha

Conform regulator methods to acronym conventions

Change regulator class methods to conform to OpenBMC capitalization
conventions for acronyms.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I1eb5202685796cbc2d45cb6368ee4dbd4706e504

show more ...

Create stubs for regulator Device, Rail, and Rule

Create stub versions of the Device, Rail, and Rule classes for the
phosphor-regulators application. Having a stub version of these classes
is a pre

Create stubs for regulator Device, Rail, and Rule

Create stub versions of the Device, Rail, and Rule classes for the
phosphor-regulators application. Having a stub version of these classes
is a pre-requisite for implementing the action framework.

Also updated the top level meson.build file to build the
phosphor-regulators directory. Created new meson.build files for
several phosphor-regulators sub-directories.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I50b018db744191acd1e473652019906a8506745f

show more ...