clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I7b90380845efee6bf6a1fe342a793d71aa9ff181
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: If66f68c96df4baf8dc07abf8729a3cb7657e932d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

regulators: Remove monitoring freq from comments

Update doxygen comments to remove the exact frequency of sensor
monitoring and phase fault detection.

Currently sensors are monitored every second a

regulators: Remove monitoring freq from comments

Update doxygen comments to remove the exact frequency of sensor
monitoring and phase fault detection.

Currently sensors are monitored every second and phase faults are
detected every 15 seconds. However, that could change in the future.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I3ac39955721fde98dfe9e6059693ceeea7e504c2

show more ...

clang updates

The openbmc CI was recently updated to clang-12 which requires some
formatting updates to the code:
https://github.com/openbmc/openbmc-build-scripts/commit/4569bf49daaebff06be048242690

clang updates

The openbmc CI was recently updated to clang-12 which requires some
formatting updates to the code:
https://github.com/openbmc/openbmc-build-scripts/commit/4569bf49daaebff06be0482426908bb5497fad08

Make those updates and refresh the clang-format file with the one from
docs:
https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format

Change-Id: Ieb3626526373a053ec84431e7560003f229f338d
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

regulators: Add detectPhaseFaults() to Device

Add a detectPhaseFaults() method to the Device class. This method
executes the PhaseFaultDetection data member added in a previous commit.

Add a gtest

regulators: Add detectPhaseFaults() to Device

Add a detectPhaseFaults() method to the Device class. This method
executes the PhaseFaultDetection data member added in a previous commit.

Add a gtest test case to exercise the new code.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Ie8a2bf7d1b60ebc29c256e8563e3e4808bb6a20e

show more ...

regulators: Add PhaseFaultDetection to Device

Add a PhaseFaultDetection data member to the Device class. This is the
first step in enabling phase fault detection for Device objects.

Create and mod

regulators: Add PhaseFaultDetection to Device

Add a PhaseFaultDetection data member to the Device class. This is the
first step in enabling phase fault detection for Device objects.

Create and modify gtest test cases to exercise new code.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Icc771eda5c79ace854acb1d7c395b82b34213996

show more ...

regulators: Add clearErrorHistory to Device class

Add a clearErrorHistory() method to the Device class. The method should
clear all data on previously logged errors. If the error occurs again
in t

regulators: Add clearErrorHistory to Device class

Add a clearErrorHistory() method to the Device class. The method should
clear all data on previously logged errors. If the error occurs again
in the future, it will be logged again.

This method is normally called when the system is being powered on. For
code that runs repeatedly, errors are only logged once per boot.

When the system is powered off, hardware may be replaced that fixes the
problem. Thus, errors are cleared during power on.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I6683b0c7b9abd61748ccb3512dda9111daed4929

show more ...

regulators: Only configure/monitor if present

Enhance the configure and monitor operations to only be performed if the
device is present.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-I

regulators: Only configure/monitor if present

Enhance the configure and monitor operations to only be performed if the
device is present.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I57fed4f92937b808ac6f8c37899e28d6009747e6

show more ...

regulators: Clear cached hardware data during boot

Clear cached data about hardware devices when the system is powering on
(booting).

While the system was powered off, hardware devices containing v

regulators: Clear cached hardware data during boot

Clear cached data about hardware devices when the system is powering on
(booting).

While the system was powered off, hardware devices containing voltage
regulators could have been added, removed, or replaced. Cached hardware
data might now be invalid.

Tested:
* Ran automated test cases
* Verified that cached data is cleared without errors during boot
* When config file was found and loaded
* When no config file was found

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Ief45fe32ddcb122847d201e89ca1267526a87e3c

show more ...

regulators: Modify close() to use services

Modify the Device::close() method in the Device class to have a new
first parameter: Services& services.

Modify Device::close() to log messages using the

regulators: Modify close() to use services

Modify the Device::close() method in the Device class to have a new
first parameter: Services& services.

Modify Device::close() to log messages using the new Journal
interface.

Modify the Chassis::closeDevices() method in the Chassis class to
have a new first parameter: Services& services.

Modify Chassis::closeDevices() to log messages using the new
Journal interface.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I2a07417d6f7470685f2c27c878ef7936e9f1aa8a

show more ...

regulators: Modify monitorSensors() to use Services

Modify the monitorSensors() method in the System, Chassis, Device, and
Rail classes to have a new first parameter: Services& services.

Modify Sen

regulators: Modify monitorSensors() to use Services

Modify the monitorSensors() method in the System, Chassis, Device, and
Rail classes to have a new first parameter: Services& services.

Modify SensorMonitoring::execute() to log messages using the new
Journal interface.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I05820cfa94bc3d15dee7a1714a3d253720aa7f92

show more ...

regulators: Add Services& services to classes

Modify the configure() method in the System, Chassis, Device, and Rail
classes to have a new first parameter: Services& services.

Fix mock_services.hpp

regulators: Add Services& services to classes

Modify the configure() method in the System, Chassis, Device, and Rail
classes to have a new first parameter: Services& services.

Fix mock_services.hpp bug.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I6ef41de65d2c5b68c55edb42189ba9c0f2e436ed

show more ...

regulators: Add monitorSensors support to Device

Implemented the monitorSensors() method in the Device class. This method
reads the sensors for the voltage rails produced by the device.

Signed-off

regulators: Add monitorSensors support to Device

Implemented the monitorSensors() method in the Device class. This method
reads the sensors for the voltage rails produced by the device.

Signed-off-by: Bob King <Bob_King@wistron.com>
Change-Id: I5ca48ba8d6ab2019c1840f3905d9603233b1881a

show more ...

regulators: Add close method to Device class

Add a close method to the Device class. This will be used to close all
devices in the system when monitoring is disabled. Monitoring is
disabled when t

regulators: Add close method to Device class

Add a close method to the Device class. This will be used to close all
devices in the system when monitoring is disabled. Monitoring is
disabled when the system is being powered off.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I0712ad698ebbcac5d7b17a822443b94dda230429

show more ...

regulators: Add configure support to Device class

Implemented the configure() method in the Device class. This method
applies any configuration changes that are defined for the device. Also
config

regulators: Add configure support to Device class

Implemented the configure() method in the Device class. This method
applies any configuration changes that are defined for the device. Also
configures all rails within the device.

Also added a missing #include to rail_tests.cpp.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I2faceb7d968b6bb01ee7e1116367afee5864ca28

show more ...

regulators: Build IDMap for system

The IDMap class is used to map string IDs to the corresponding C++
Device, Rail, and Rule objects.

The IDMap class is complete and tested, but it was not previous

regulators: Build IDMap for system

The IDMap class is used to map string IDs to the corresponding C++
Device, Rail, and Rule objects.

The IDMap class is complete and tested, but it was not previously being
populated except in testcases.

Add new methods to the System, Chassis, and Device classes to populate
the IDMap with all the ID -> object mappings in the system.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I80f39b663b011ca643c91f7281ff50c956631331

show more ...

regulators: Add remaining props to Device class

Enhance the C++ Device class by adding the remaining properties from the
JSON config file:
* presence_detection
* configuration
* rails

See device.md

regulators: Add remaining props to Device class

Enhance the C++ Device class by adding the remaining properties from the
JSON config file:
* presence_detection
* configuration
* rails

See device.md for more information.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Id5973da1e0f4f73145f0eb0d34a4c157e828b06e

show more ...

Add I2C interface to Device class

Add an I2C interface to the phosphor-regulators C++ Device class.

Use the I2CInterface class from the tools/i2c directory of this
repository.

Also add the other r

Add I2C interface to Device class

Add an I2C interface to the phosphor-regulators C++ Device class.

Use the I2CInterface class from the tools/i2c directory of this
repository.

Also add the other required properties of the JSON "device" object to
the C++ Device class.

The JSON "device" object is in the phosphor-regulators config file. For
more information, see phosphor-regulators/docs/config_file/device.md.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Idc780b1a11372d6597762cfb6540fa44f1cfb64e

show more ...

Use C++17 format for nested namespace definitions

Use the new C++17 format for defining nested namespaces in the
phosphor-regulators application.

The definition
namespace A::B::C
{
...
}

i

Use C++17 format for nested namespace definitions

Use the new C++17 format for defining nested namespaces in the
phosphor-regulators application.

The definition
namespace A::B::C
{
...
}

is now equivalent to
namespace A
{
namespace B
{
namespace C
{
...
}
}
}

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I284055bc94578a45d04d3561f511c0e347a8ecef

show more ...

Add explicit keyword to regulator constructors

Add the 'explicit' keyword to regulator constructors. This prevents
automatic, unintended type promotions from occurring.

Signed-off-by: Shawn McCarn

Add explicit keyword to regulator constructors

Add the 'explicit' keyword to regulator constructors. This prevents
automatic, unintended type promotions from occurring.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: Ice9983093114192c33d083b58cf85247d29792a8

show more ...

Conform regulator methods to acronym conventions

Change regulator class methods to conform to OpenBMC capitalization
conventions for acronyms.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Cha

Conform regulator methods to acronym conventions

Change regulator class methods to conform to OpenBMC capitalization
conventions for acronyms.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I1eb5202685796cbc2d45cb6368ee4dbd4706e504

show more ...

Create stubs for regulator Device, Rail, and Rule

Create stub versions of the Device, Rail, and Rule classes for the
phosphor-regulators application. Having a stub version of these classes
is a pre

Create stubs for regulator Device, Rail, and Rule

Create stub versions of the Device, Rail, and Rule classes for the
phosphor-regulators application. Having a stub version of these classes
is a pre-requisite for implementing the action framework.

Also updated the top level meson.build file to build the
phosphor-regulators directory. Created new meson.build files for
several phosphor-regulators sub-directories.

Signed-off-by: Shawn McCarney <shawnmm@us.ibm.com>
Change-Id: I50b018db744191acd1e473652019906a8506745f

show more ...