| #
22579ca4 |
| 07-Nov-2022 |
Harvey Wu <Harvey.Wu@quantatw.com> |
fix cppcheck warning
- Fix warnings:
[noExplicitConstructor]
ipmi/manualcmds.hpp:20:5: style: Class 'ZoneControlIpmiHandler' has a
constructor with 1 argument that is not explicit.
[red
fix cppcheck warning
- Fix warnings:
[noExplicitConstructor]
ipmi/manualcmds.hpp:20:5: style: Class 'ZoneControlIpmiHandler' has a
constructor with 1 argument that is not explicit.
[redundantInitialization]
dbus/dbusutil.cpp:96:15: style: Redundant initialization for 'layer'.
The initialized value is overwritten before it is read.
[uninitMemberVar]
pid/pidcontroller.hpp:23:5: warning: Member variable
'PIDController::_pid_info' is not initialized in the constructor.
[memsetClassFloat]
pid/util.cpp:29:10: portability: Using memset() on struct which
contains a floating point number.
[constParameter]
ipmi/manualcmds.cpp:108:72: style: Parameter 'dataLen' can be
declared as pointer to const
Signed-off-by: Harvey Wu <Harvey.Wu@quantatw.com>
Change-Id: Ib368c6e3a609e446529573cd0b9fa03858232db1
show more ...
|
| #
09334bbe |
| 16-Aug-2020 |
Patrick Venture <venture@google.com> |
ipmi: add zone controller interface
Implementations of this interface can make the library mode testable and
work in environments other than dbus.
The main entry point to the IPMI handler now expec
ipmi: add zone controller interface
Implementations of this interface can make the library mode testable and
work in environments other than dbus.
The main entry point to the IPMI handler now expects to receive a
handler pointer. The handler itself is implemented to process IPMI
requests and responses in the expected way. The default object receives
a dbus implementation for the zone controls.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I6d7be871bdc5cce3c3cc53c16d80b501aaaafc7d
show more ...
|
| #
9bf5cef4 |
| 16-Aug-2020 |
Patrick Venture <venture@google.com> |
ipmi: split library constructor
Split out the library constuctor so that the code can be built into
separate library modules.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I70ac51a
ipmi: split library constructor
Split out the library constuctor so that the code can be built into
separate library modules.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I70ac51aaea200d4634f9220a642b0e2bef6748bd
show more ...
|
| #
1277543a |
| 04-Aug-2020 |
Patrick Venture <venture@google.com> |
ipmi/manualcmds: fixup style for enum
Fixup the style for the enum.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I7eaf9337373a1f0a7d6fd0422d38364370249cf0
|
| #
36ab6f6e |
| 03-Aug-2020 |
Patrick Venture <venture@google.com> |
move ipmi handler into namespace
Add a namespace for the ipmi code to enable re-use through linking into
other libraries that may have similar object names.
Signed-off-by: Patrick Venture <venture@
move ipmi handler into namespace
Add a namespace for the ipmi code to enable re-use through linking into
other libraries that may have similar object names.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I002b9bf84d5bc6cbe06b9dc8f41cb4532ec50927
show more ...
|
| #
da4a5dd1 |
| 31-Aug-2018 |
Patrick Venture <venture@google.com> |
add .clang-format
Change-Id: I6627b5569c2e0f730be7331403218b823a2c622f
Signed-off-by: Patrick Venture <venture@google.com>
|
| #
391b8b0f |
| 08-Mar-2018 |
Patrick Venture <venture@google.com> |
The OEM IPMI interface for status
This lets one get/set various aspects of the control daemon,
including whether it's fallen into fail-safe mode, or whether a
zone is in manual mode. Manual mode in
The OEM IPMI interface for status
This lets one get/set various aspects of the control daemon,
including whether it's fallen into fail-safe mode, or whether a
zone is in manual mode. Manual mode in this implementation is
zone specific and not fan specific.
Change-Id: I1611fefad198b64c28a780073674896d6efbf877
Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|