History log of /openbmc/phosphor-pid-control/ipmi/dbus_mode.cpp (Results 1 – 5 of 5)
Revision Date Author Comments
# 7f1253cd 08-Dec-2024 Jayanth Othayoth <ojayanth@gmail.com>

clang-tidy: Fix Unused Variable Warnings

The following errors were reported during clang-tidy enablement due
to multiple unused variables.

'''
ipmi/dbus_mode.cpp:37:23: error: unused variable 'fail

clang-tidy: Fix Unused Variable Warnings

The following errors were reported during clang-tidy enablement due
to multiple unused variables.

'''
ipmi/dbus_mode.cpp:37:23: error: unused variable 'failsafeProperty' [-Werror
ipmi/dbus_mode.cpp:36:23: error: unused variable 'manualProperty' [-Werror
'''

This fix removes the unused variables to resolve the warnings.

Tested: Build and unit testing verified.

Change-Id: I3abf76b57b939df5cbeb4c71b7063705fe0ff3a8
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

show more ...


# b228bc30 22-Jul-2022 Patrick Williams <patrick@stwcx.xyz>

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie36d234f4580029a7832a0cd179f3bb78a1a403f

show more ...


# e7507a8b 02-Sep-2021 Patrick Williams <patrick@stwcx.xyz>

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I16eeca31de290221c7a9184ee0c48cc923466832

show more ...


# 09334bbe 16-Aug-2020 Patrick Venture <venture@google.com>

ipmi: add zone controller interface

Implementations of this interface can make the library mode testable and
work in environments other than dbus.

The main entry point to the IPMI handler now expec

ipmi: add zone controller interface

Implementations of this interface can make the library mode testable and
work in environments other than dbus.

The main entry point to the IPMI handler now expects to receive a
handler pointer. The handler itself is implemented to process IPMI
requests and responses in the expected way. The default object receives
a dbus implementation for the zone controls.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I6d7be871bdc5cce3c3cc53c16d80b501aaaafc7d

show more ...


# d82d0b7d 16-Aug-2020 Patrick Venture <venture@google.com>

ipmi: split dbus get property into separate file

This is a step towards handling getting/setting dbus properties as an
implementation of an interface, de-coupling from dbus.

Signed-off-by: Patrick

ipmi: split dbus get property into separate file

This is a step towards handling getting/setting dbus properties as an
implementation of an interface, de-coupling from dbus.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I81a2c5100833235811d4b7e59152d70585c7abaf

show more ...