clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I0f105c3310e87172c65a09a8787a2db5a4041cc0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Icbc50d46e84ee7ef756705e2b19741439a325074
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie36d234f4580029a7832a0cd179f3bb78a1a403f

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I16eeca31de290221c7a9184ee0c48cc923466832

show more ...

dbuswrite: Add another write() form to WriteInterface

Adding another form of the write() call,
which takes 3 arguments instead of 1,
providing an alternate interface for caller to use.

A compatibil

dbuswrite: Add another write() form to WriteInterface

Adding another form of the write() call,
which takes 3 arguments instead of 1,
providing an alternate interface for caller to use.

A compatibility function is provided,
which simply calls write(), so no API breakage.

The additional arguments to write() allow caller
to force the write to happen even if old value same,
and/or to learn the actual raw value written.

Adding boilerplate to Sensor and PluggableSensor,
to also pass the 3-argument write() through.

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Iaf35f674ef9ce38b56017f6cb0f821df6c789649

show more ...

dbushelper: drop obsolete parameter from interface

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Idebae41e021f54c3670cc22aa6c784549a361c23

Make the dbushelper own its own bus handle.

The dbushelper implements an interface that should not be sdbusplus
specific. By making the implementation own the sdbusplus aspects, an
alternate impleme

Make the dbushelper own its own bus handle.

The dbushelper implements an interface that should not be sdbusplus
specific. By making the implementation own the sdbusplus aspects, an
alternate implementation can be swapped in.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I4109772499421e2e6497a0fcad663ebbd1210a7c

show more ...

move dbus helper interface into its own file

This is step 1 to improving the interface to be more generic and drop
requirements on dbus.

Signed-off-by: Patrick Venture <venture@google.com>
Change-I

move dbus helper interface into its own file

This is step 1 to improving the interface to be more generic and drop
requirements on dbus.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I7835ea8242bfb7189cabc1a4084e5f84143d40f6

show more ...

sensors/zones: place in namespace and cleanup

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I527dbc8477a232945f696227a7b0b2adbee45175

update clang-format from Latest in docs

Updates the clang-format file and then applies it.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ia9faf13ce171f90bf07547efd781139bee23e8c7

ensure proper data type for variant

gcc10 is more strict on variant usage

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I906d1710312cad907ed5db5c04d9b1aec101fca4

Move all variant usage to std

This just a style change, remove variant_ns
in favor of std.

Tested-by: it built

Change-Id: Id5a075e8b73a7724cbc5153fb7dfcf369e79c483
Signed-off-by: James Feist <jame

Move all variant usage to std

This just a style change, remove variant_ns
in favor of std.

Tested-by: it built

Change-Id: Id5a075e8b73a7724cbc5153fb7dfcf369e79c483
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Change all default_bus back to new_system bus

new_default now returns a reference to a single bus,
phosphor-pid-control uses multiple busses so we do not
want that. This was the way it was implement

Change all default_bus back to new_system bus

new_default now returns a reference to a single bus,
phosphor-pid-control uses multiple busses so we do not
want that. This was the way it was implemented prior to
https://github.com/openbmc/sdbusplus/commit/8ca6025eed193c252149b2908c3d5e37b00b0107

Tested-by: swampd ran normally

These errors go away:

Jan 28 18:28:45 swampd[1760]: terminate called after throwing an instance of 'sdbusplus::exception::SdBusError'
Jan 28 18:28:45 swampd[1760]: what(): sd_bus_request_name: org.freedesktop.DBus.Error.InconsistentMessage: Bad message

Change-Id: I708cd5e6c45509f27d4fe783c0b0cfb52ff10336
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Remove singleton from dbuswriter

When you create multiple zones, they are added to multiple
threads. Doing so causes multiple threads to access the
single bus object, which is illegal in sd_bus and

Remove singleton from dbuswriter

When you create multiple zones, they are added to multiple
threads. Doing so causes multiple threads to access the
single bus object, which is illegal in sd_bus and
occasionally causes a crash on start like the below.

Assertion 'IN_SET(bus->state, BUS_RUNNING, BUS_HELLO)' failed at
../git/src/libsystemd/sd-bus/sd-bus.c:1720, function dispatch_wqueue().
Aborting.
Aborted (core dumped)

Tested-by: Started swampd multiple times and crash went away.

Change-Id: Ic44b93e51ecf3d39cd8b846bb3003516cdaf7816
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Move all floats to doubles

The code was developed initially around a pid loop implemented using
floats. Therefore, the code was converting back and forth between
double for sensor values as inputs

Move all floats to doubles

The code was developed initially around a pid loop implemented using
floats. Therefore, the code was converting back and forth between
double for sensor values as inputs and outputs from this PID loop.

Change-Id: I2d2919e1165103040729c9f16bb84fde3dd6b81b
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

dbus: dbuswrite: add try/catch block on calls

The dbus calls can now except, therefore add try/catch blocks and report
the errors.

Change-Id: I8cae2576922fa9316065ef048e674beb48a58e88
Signed-off-by

dbus: dbuswrite: add try/catch block on calls

The dbus calls can now except, therefore add try/catch blocks and report
the errors.

Change-Id: I8cae2576922fa9316065ef048e674beb48a58e88
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

dbus: dbuswrite: use factory to catch errors

Add factories for creating DbusWrite and DbusWritePercent objects and
use these factories.

Change-Id: Iad222d4bf6c1fdf561daa4ba9d88a6644c0a5965
Signed-o

dbus: dbuswrite: use factory to catch errors

Add factories for creating DbusWrite and DbusWritePercent objects and
use these factories.

Change-Id: Iad222d4bf6c1fdf561daa4ba9d88a6644c0a5965
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

[dbus-writer] limit d-bus traffic

Limit d-bus traffic by only sending updates, instead
of every value.

Tested-by: used d-bus monitor and noticed significantly
reduced messages.

Change-Id: Ie677fea

[dbus-writer] limit d-bus traffic

Limit d-bus traffic by only sending updates, instead
of every value.

Tested-by: used d-bus monitor and noticed significantly
reduced messages.

Change-Id: Ie677feaedab4e9ebb14950392b9588d4d82c0058
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

add .clang-format

Change-Id: I6627b5569c2e0f730be7331403218b823a2c622f
Signed-off-by: Patrick Venture <venture@google.com>

Add ability to configure from dbus

This allows configuration of PID control from dbus using
entity manager. Sample configuration will be pushed to
entity-manager repo shortly.

Tested-by: Used yaml

Add ability to configure from dbus

This allows configuration of PID control from dbus using
entity manager. Sample configuration will be pushed to
entity-manager repo shortly.

Tested-by: Used yaml configuration and dbus / entity-manager
based configuration and pid seemed to work the same.
Verified printout of configuration matched generated
cpp files.

Change-Id: Ia7b016e53262791ffcccdb9b21c1ccddae2926bc
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...