meson: switch code dependency to libsystemd

For a while now systemd has packaged a separate `libsystemd`. For
meson dependency, `systemd` should be used when looking for systemd
service file paths

meson: switch code dependency to libsystemd

For a while now systemd has packaged a separate `libsystemd`. For
meson dependency, `systemd` should be used when looking for systemd
service file paths and `libsystemd` should be used for `sd_*` functions.

Update the dependency accordingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iff3e5cc93a503e7391e4eea9624b04069135a42a

show more ...

meson: Declare a find_program() override for mapperx

If phosphor-objmgr is used as a subproject, allow discovery of its
mapperx program for use in the parent project.

Change-Id: I1cb448500cab015b8b

meson: Declare a find_program() override for mapperx

If phosphor-objmgr is used as a subproject, allow discovery of its
mapperx program for use in the parent project.

Change-Id: I1cb448500cab015b8b309979ab26f7e51f03e8ea
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: Disable tests build for tinyxml2 dependency

Currently local meson build breaks on tinyxml2 since the code from
this package produces a warning and all warnings are treated as errors:
"""
../s

meson: Disable tests build for tinyxml2 dependency

Currently local meson build breaks on tinyxml2 since the code from
this package produces a warning and all warnings are treated as errors:
"""
../subprojects/tinyxml2-9.0.0/xmltest.cpp:711:38: error: ignoring
return value of ‘char* fgets(char*, int, FILE*)’ declared with
attribute ‘warn_unused_result’ [-Werror=unused-result]
"""
The warning above comes from the compilation of the tinyxml2 unit tests.
Since we don't really need them, disable 'tests' option for tinyxml2
dependency to fix the meson build.

Tested:
Locally executed "meson setup build && cd build && meson compile" now
finishes successfully.

Change-Id: Ib35fef4e515df22c7b82a6f379689d4672059099
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I2ce48ae6fe133c0b355672b5bb7d7c27bc6b3702
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ifabec573b184316716aa6

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ifabec573b184316716aa692598caba26fb5857b3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: Idff7506a1f897993ba350fdc31ce5103c8a9e998
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

unit-fail-monitor: add meson option to disable

Add an option to disable this feature.

Change-Id: Ifc953ad4bec492f7c6ca8190e4c6a0820b12630a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

mapper: install systemd unit, dbus conf files

The same systemd and dbus unit/configuration files can work for everyone
now, so ship them. Enable dbus activation, add unit file templates, and
move m

mapper: install systemd unit, dbus conf files

The same systemd and dbus unit/configuration files can work for everyone
now, so ship them. Enable dbus activation, add unit file templates, and
move mapperx to libexec where it belongs.

Change-Id: Ieb021889605767ffdb9d72faad5f5b856312b935
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

test: Add dbus handler unit tests

Created unit tests for all of the object mapper dbus handlers.

Refactor the handlers to handler.cpp to allow unit testing.
Also updated to use std::set_intersectio

test: Add dbus handler unit tests

Created unit tests for all of the object mapper dbus handlers.

Refactor the handlers to handler.cpp to allow unit testing.
Also updated to use std::set_intersection.

Change-Id: Ib87ab81f949d27f7dab55899d3e8d380e43bda04
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

monitor: add cli11 argument parsing

Replace our custom argument parser with one from CLIUtils.

This results in a number of minor behavioral differences.
- The -? option is no longer recognized as

monitor: add cli11 argument parsing

Replace our custom argument parser with one from CLIUtils.

This results in a number of minor behavioral differences.
- The -? option is no longer recognized as an alias for -h/--help.
- The original parser returned EXIT_FAILURE in all cases, but CLIUtils
uses different non-zero error codes in different situations.
- Minor changes to help text descriptions:
----new----
Usage: build/phosphor-unit-failure-monitor.new [OPTIONS]

Options:
-h,--help Print this help message and exit
-s,--source TEXT REQUIRED
-t,--target TEXT REQUIRED
-a,--action ENUM:value in {start->0,stop->1} OR {0,1} REQUIRED

----old----
Usage: build/phosphor-unit-failure-monitor [options]
Options:
--help Print this menu
--source=<source> The source unit to monitor
--target=<target> The target unit to start or stop
--action=<action> Target unit action - start or stop

- The original parser displays the full help text on error, CLIUtils
does not:

----new----
$ phosphor-unit-failure-monitor
--source is required
Run with --help for more information.

----old----
$ phosphor-unit-failure-monitor
ERROR: Source not specified
Usage: build/phosphor-unit-failure-monitor [options]
Options:
--help Print this menu
--source=<source> The source unit to monitor
--target=<target> The target unit to start or stop
--action=<action> Target unit action - start or stop

Change-Id: I2417d9c857c6d8fc04807fe4729d2fa154e746a3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

mapper: remove configurable service allowlists

Remove the ability to specify an allow list at runtime. Instead,
introspect any DBus service except those that start with
org.freedesktop. This remov

mapper: remove configurable service allowlists

Remove the ability to specify an allow list at runtime. Instead,
introspect any DBus service except those that start with
org.freedesktop. This removes the need for argument parsing code and
complex bitbake metadata.

Skip org.freedesktop because applications (OpenBMC or otherwise) should
access org.freedesktop services directly and not indirectly via the
OpenBMC mapper.

Change-Id: I83038a121580dcde2a2b3b1f994b3066cc9d955f
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Add boost wrap file

Recent changes make us incompatible with older versions of boost (1.74
in my testing). Like we do elsewhere, add a wrapfile for boost.

At the same time, the tests were missing

Add boost wrap file

Recent changes make us incompatible with older versions of boost (1.74
in my testing). Like we do elsewhere, add a wrapfile for boost.

At the same time, the tests were missing an explicit #include for boost,
so even when the above patch was applied, it still doesn't build. Add
an explicit dependency.

Tested:
meson buildlocal --buildtype=debug && ninja -C buildlocal

Succeeds. Should have no impact to yocto builds.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I20543fd184491dc138a2e145945eb71051c4cd52

show more ...

meson: add dependency for libmapper

In order to allow 'libmapper' to be picked up as a meson subproject,
we need to declare the dependency. Enabling this allows a trivial
wrap file such as the foll

meson: add dependency for libmapper

In order to allow 'libmapper' to be picked up as a meson subproject,
we need to declare the dependency. Enabling this allows a trivial
wrap file such as the following to allow `dependency('mapper')` to
resolve in a wrap-build:

```
$ cat subprojects/phosphor-objmgr.wrap
[wrap-git]
url = https://github.com/openbmc/phosphor-objmgr
revision = HEAD

[provide]
mapper = mapper_dep
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I45d8d3f69fd284bfe727e1b8e94fb42a6158a1b5

show more ...

meson: add support for debug

Automatically enable the debugging code when doing debug build types,
and enable that by default, so the code is built by default.

Change-Id: I17b1dbb79ba7ca85d9be65d1c

meson: add support for debug

Automatically enable the debugging code when doing debug build types,
and enable that by default, so the code is built by default.

Change-Id: I17b1dbb79ba7ca85d9be65d1c6f0004abdcd88d6
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

meson: Add phosphor-dbus-interfaces dependency

This dependency was added with b15df6b2 but not added to meson.build,
which prevents the project from building in meson subproject mode.

Fixes: b15df6

meson: Add phosphor-dbus-interfaces dependency

This dependency was added with b15df6b2 but not added to meson.build,
which prevents the project from building in meson subproject mode.

Fixes: b15df6b28b97a0887e52d5f5e5899b10475943e1
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I0653d6c7599cfcfc3d66c9e326a0a691bc6f978e

show more ...

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39d423

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39d423dad8a08949317c991b845aaa5fc23969a4

show more ...

meson.build: drop config.h

These DBus things (service, interface, path) are not intended to be
configurable in any way. Try to discourage them from being changed by
removing them from meson.build j

meson.build: drop config.h

These DBus things (service, interface, path) are not intended to be
configurable in any way. Try to discourage them from being changed by
removing them from meson.build just in case that suggests that perhaps
they are meant to be overriden.

As the DBus names are the only content in config.h, config.h can be
removed completely.

Change-Id: I654473333932a8626a0ace5ee5a865dd14aaf296
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: switch to c++20

Change-Id: Ibe16889749f6b61a3bc8d9a2979b0f7a789cbc24
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

build: Add meson support

Add support for buildling with meson.

Support for --enable-oe-sdk is dropped because running unit tests on the
build system is now supported directly with meson subprojects

build: Add meson support

Add support for buildling with meson.

Support for --enable-oe-sdk is dropped because running unit tests on the
build system is now supported directly with meson subprojects:

meson buildir && ninja -C buildir test

I tested this by building a witherspoon image and booting it to
multi-user and verifying the mapper-wait functionality works correctly.

Change-Id: I86e5efc7b7c89183219a4c890ad658e334765fc1
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...