libmapper: format code using c++ clang-format

Remove libmapper/.clang-fromat and format code using c++ clang-format

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I62781743b03fa1e806

libmapper: format code using c++ clang-format

Remove libmapper/.clang-fromat and format code using c++ clang-format

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I62781743b03fa1e806f51f4844c93aaf4cdfac4f

show more ...

mapper-wait: increase polling speed

5 seconds is a really long time for one daemon to be waiting for
another to start up. Decrease the polling interval to 1s and increase
the number of retries corr

mapper-wait: increase polling speed

5 seconds is a really long time for one daemon to be waiting for
another to start up. Decrease the polling interval to 1s and increase
the number of retries correspondingly.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id27bfbe22c566b3aa057d4692778d6c0244722c1

show more ...

meson.build: drop config.h

These DBus things (service, interface, path) are not intended to be
configurable in any way. Try to discourage them from being changed by
removing them from meson.build j

meson.build: drop config.h

These DBus things (service, interface, path) are not intended to be
configurable in any way. Try to discourage them from being changed by
removing them from meson.build just in case that suggests that perhaps
they are meant to be overriden.

As the DBus names are the only content in config.h, config.h can be
removed completely.

Change-Id: I654473333932a8626a0ace5ee5a865dd14aaf296
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

libmapper: allow use of session bus for non-root

sd_bus_default will automatically pick the system bus when run as root
as intended. By using sd_bus_default instead of sd_bus_default_system
we can

libmapper: allow use of session bus for non-root

sd_bus_default will automatically pick the system bus when run as root
as intended. By using sd_bus_default instead of sd_bus_default_system
we can connect to a mapper daemon running on the session bus.

https://www.freedesktop.org/software/systemd/man/sd_bus_open_user.html

Change-Id: I7accd6119bfd84351f9a99af7cdd0dc6bf29a83c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

mapper: Retry if mapper is unavailable

Sometimes mapper waits begin executing before the mapper is available to
respond to requests. This will result in a EHOSTUNREACH being returned
by the broker.

mapper: Retry if mapper is unavailable

Sometimes mapper waits begin executing before the mapper is available to
respond to requests. This will result in a EHOSTUNREACH being returned
by the broker. We always want to retry and see if the broker becomes
available in these cases.

Change-Id: Id3576ddc7e82904bb55062e63506042bec826983
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

libmapper: Retry on wait timeouts

At times, early in the boot process, the async GetObject call used in
'mapper wait' can fail with an ETIMEDOUT, probably because the mapper
daemon is so busy intros

libmapper: Retry on wait timeouts

At times, early in the boot process, the async GetObject call used in
'mapper wait' can fail with an ETIMEDOUT, probably because the mapper
daemon is so busy introspecting new processes. If this happens, retry
after a 5s wait. Also get a new connection to the bus and event loop
since when this wasn't done the retried method call would fail
immediately.

I first tried to put the ETIMEDOUT check in
async_wait_getobject_callback, but that caused hundreds of more retries
across all the mapper waits in use.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I7175e958fb633b2ecb7479a3307d6918ab29b9f7

show more ...

mapper: Handle the expected GetSubTreePaths fails

The 'mapper subtree-remove' command calls GetSubTreePaths
when it starts up to check if a certain interface currently
exists on a certain path. If

mapper: Handle the expected GetSubTreePaths fails

The 'mapper subtree-remove' command calls GetSubTreePaths
when it starts up to check if a certain interface currently
exists on a certain path. If that interface does not exist
on that path, the current ObjectMapper implementation would
just return an empty list, and the program would exit.

The new ObjectMapper implementation will fail the GetSubTreePaths
call in that case, causing an ENXIO inside of sd_event_loop().

This commit checks for the ENXIO and then just exits immediately
with a return code of 0, as this is the case where the interface
had been removed before the program was started.

Change-Id: Iaeb908ee9a0db8952ef77cc63675e0f7abe3b6c7
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

clang-format updates

Pick up latest clang-format from the docs repo and rerun
with clang-format-6.0

Change-Id: I2f0411bb01d78f096563d63b197ce12daf43bcbd
Signed-off-by: Matt Spinler <spinler@us.ibm.

clang-format updates

Pick up latest clang-format from the docs repo and rerun
with clang-format-6.0

Change-Id: I2f0411bb01d78f096563d63b197ce12daf43bcbd
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

app: Drop mapper call subcommand

Equivalent function can be simulated with busctl call and mapper
get-service _and_ doesn't rely on systemd patches.

Change-Id: Ia0c3c8d7d0290de2b6e79f18df72cac97f2b

app: Drop mapper call subcommand

Equivalent function can be simulated with busctl call and mapper
get-service _and_ doesn't rely on systemd patches.

Change-Id: Ia0c3c8d7d0290de2b6e79f18df72cac97f2b14fa
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

clang-format this repo

Use the proper-clang-format file on this repository as required by
the openbmc documentation.

Change-Id: I4f1e0d707388605f1e818dfdc647533a335e5f2d
Signed-off-by: Ed Tanous <e

clang-format this repo

Use the proper-clang-format file on this repository as required by
the openbmc documentation.

Change-Id: I4f1e0d707388605f1e818dfdc647533a335e5f2d
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Create libmapper subtree function and call it in event loop

Call a new mapper subtree interface in an event loop.
Create an enum to specify the mapper action, in this case
wait for an interface to b

Create libmapper subtree function and call it in event loop

Call a new mapper subtree interface in an event loop.
Create an enum to specify the mapper action, in this case
wait for an interface to be removed. This allows to later
add other operations like wait for an interface to be added
since the logic would be different.

Change-Id: I8330852d47185c3c4e40e994c6e4719054a9fc06
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

app: Split subtree argument

Split the argument string on the first colon (:) character
to get the namespace and interface.

Change-Id: Ia9c67bd149c23e68945fd80252a93a2f1fe78382
Signed-off-by: Adrian

app: Split subtree argument

Split the argument string on the first colon (:) character
to get the namespace and interface.

Change-Id: Ia9c67bd149c23e68945fd80252a93a2f1fe78382
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

app: Add subtree-remove option

New mapper option to wait until a specified interface is not
present in any of the subtrees of the specified namespace.
Usage:
mapper subtree-remove <NAMESPACE>:<INT

app: Add subtree-remove option

New mapper option to wait until a specified interface is not
present in any of the subtrees of the specified namespace.
Usage:
mapper subtree-remove <NAMESPACE>:<INTERFACE>
mapper subtree-remove /foo/namespace:bar.interface

A future change could add an additional option to wait for
interfaces to appear in a subtree of the specified path.

Note that the subtree option will look for the interface in
the subtree paths, not on the specified base namespace path.
So in order to find an interface in /base/level1/level2,
then the specified namespace path should be /base/level1/.

Change-Id: I862310d819c505c59161adcce338041a08e1218c
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Revert "Add mapper-wait-until-removed"

This reverts commit 9f4c3c7c408a5f84a52416da99d0dd8035f1ae5a.

After further design discussions, the new wait until
removed implementation should be a new API.

Revert "Add mapper-wait-until-removed"

This reverts commit 9f4c3c7c408a5f84a52416da99d0dd8035f1ae5a.

After further design discussions, the new wait until
removed implementation should be a new API. Reverting this
change to put back the original wait interfaces since new
ones will be created instead of modifying the existing ones.

Change-Id: I605439dcb24c6dca7f394325afc6587eacf417f1
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Revert "wait-until-removed: Add Interface parameter"

This reverts commit e4d6c79030ad7b7638d0fc5ea09cf13afe224cda.

The commit had incomplete changes, reverting it since the
implementation is changi

Revert "wait-until-removed: Add Interface parameter"

This reverts commit e4d6c79030ad7b7638d0fc5ea09cf13afe224cda.

The commit had incomplete changes, reverting it since the
implementation is changing per feedback from code reviews.

Change-Id: Ia99b9ae57cda805d419f3ed0e326c09154335051
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

wait-until-removed: Add Interface parameter

The additional interface parameter can be a string
(ex. "intf" "obj1"), or be in a single string with
the obj parameter (ex. "intf obj1 obj2..."). The
lat

wait-until-removed: Add Interface parameter

The additional interface parameter can be a string
(ex. "intf" "obj1"), or be in a single string with
the obj parameter (ex. "intf obj1 obj2..."). The
latter is used when passing the parameters from
a systemd unit.
The wait-until-removed option will block until the
requested interface is not present in the specified
dbus object.

Change-Id: Ia935af5721e2aec8c271eff483cff9c3a1f1fa24
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Add mapper-wait-until-removed

This option will do the opposite of mapper wait
by blocking if a dbus object exists until that
object is removed.

Change-Id: Ia460b1ffdb912ba475b15ae5f8499a177e801dfd

Add mapper-wait-until-removed

This option will do the opposite of mapper wait
by blocking if a dbus object exists until that
object is removed.

Change-Id: Ia460b1ffdb912ba475b15ae5f8499a177e801dfd
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Add get-service option to mapper tool

Adding this feature will allow services to use the
busctl command without hard coding the dbus service
information

Change-Id: Ibdfb2e0dce97486ad4dd6784257fa81c

Add get-service option to mapper tool

Adding this feature will allow services to use the
busctl command without hard coding the dbus service
information

Change-Id: Ibdfb2e0dce97486ad4dd6784257fa81c1122dba2
Signed-off-by: Andrew Geissler <andrewg@us.ibm.com>

show more ...

Workaround sd_bus_message_append_cmdline

Unable to get libmapper built without systemd being patched with the
sd_bus_message_append_cmdline function. Until it is pushed upstream,
this is a workaroun

Workaround sd_bus_message_append_cmdline

Unable to get libmapper built without systemd being patched with the
sd_bus_message_append_cmdline function. Until it is pushed upstream,
this is a workaround to get the available systemd install built for unit
testing.

Change-Id: Ieca78955a4182eebd469a860c37ccaedfe75d323
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add path information on service lookup failure

Change-Id: Ie180b5a206eeb55c02149e5201c381652759bbdc
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

sdbus client: add retries

Handle busy responses from the server with retries.

Change-Id: I8c13faddec1bfaffe702609f2e682e8b1181946d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

mapper-cli: rewrite with sdbus

There are too many instances of the wait/call applications
spawned during BMC startup. Re-write using sdbus.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

mapper-cli: rewrite with sdbus

There are too many instances of the wait/call applications
spawned during BMC startup. Re-write using sdbus.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Ia6fb3b74cb70f93cfd5cc57c1a8b7a9aa2d944c4

show more ...