treewide: Convert most fmt::format -> std::format

Change-Id: I3c9ac1eed1c86c6cd9f7fd3a1ba356734e79f937
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Remove uses of FMT_COMPILE

We can use stdplus::strCat which takes even less code space.

Change-Id: I91185afa7f5d9041ca7477eb19d5d53755ed329d
Signed-off-by: William A. Kennington III <wak@

treewide: Remove uses of FMT_COMPILE

We can use stdplus::strCat which takes even less code space.

Change-Id: I91185afa7f5d9041ca7477eb19d5d53755ed329d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

treewide: Replace fmt::print with stdplus::print

Change-Id: I9b6ea48931496bf2ca6ab480e3a3795488f2ff61
Signed-off-by: William A. Kennington III <wak@google.com>

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia4966a0790437eb0fc011c747f3be2a52884e4d8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

config_parser: Add support for checking file existence

This will be used to reduce the number of config parser errors printed
to the logs.

Change-Id: Ia0337da386bc5dbe32c04bf2c3264997a9ad6da1
Signe

config_parser: Add support for checking file existence

This will be used to reduce the number of config parser errors printed
to the logs.

Change-Id: Ia0337da386bc5dbe32c04bf2c3264997a9ad6da1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add function for writing files

This will be used by the configuration writers shortly.

Change-Id: I6e72b181e365e34808c8e5e4790c446124dc13a3
Signed-off-by: William A. Kennington III <

config_parser: Add function for writing files

This will be used by the configuration writers shortly.

Change-Id: I6e72b181e365e34808c8e5e4790c446124dc13a3
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Allow modifying Parser map

This makes it possible to mutate the map owned by the parser. This will
eventually be used for implementing write updates.

Change-Id: I89deb4073a0a3bd59528

config_parser: Allow modifying Parser map

This makes it possible to mutate the map owned by the parser. This will
eventually be used for implementing write updates.

Change-Id: I89deb4073a0a3bd59528c6b70fc55b49bc6cd944
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add type checking to config map

In order to guarantee the output file is consistent, the
constructed values are checked for safety.

Change-Id: Ib70e369471e9f2f47a1cdb5522f4a3bebc3780

config_parser: Add type checking to config map

In order to guarantee the output file is consistent, the
constructed values are checked for safety.

Change-Id: Ib70e369471e9f2f47a1cdb5522f4a3bebc37805e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Split up sections

We can't always combine sections together in network files as sections
like

[Address]
Address=::1/128
Peer=fe80::1
[Address]
Address=::2/128
Peer=fe80::2

Require t

config_parser: Split up sections

We can't always combine sections together in network files as sections
like

[Address]
Address=::1/128
Peer=fe80::1
[Address]
Address=::2/128
Peer=fe80::2

Require that they are grouped accordingly. Rewrite the storage logic of
the config parser to support this logical organization.

Change-Id: I34ae1523202f8770fe3dcac010fb6226dd28b9ec
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Reduce number of file reads

This changes focuses on reducing the number of Parser() constructions to
limit the number of duplicate file reads.

Change-Id: I05df943844c70dc6aa729ab744d

config_parser: Reduce number of file reads

This changes focuses on reducing the number of Parser() constructions to
limit the number of duplicate file reads.

Change-Id: I05df943844c70dc6aa729ab744d2d405cbfe2c76
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add common boolean parser

This more accurately parses systemd values instead of just comparing to
"false" or "true".

Change-Id: I0d70ef418075d555bf6f090fefa0b34332491ed0
Signed-off-b

config_parser: Add common boolean parser

This more accurately parses systemd values instead of just comparing to
"false" or "true".

Change-Id: I0d70ef418075d555bf6f090fefa0b34332491ed0
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add parser warnings

This makes it possible to determine if the file had formatting issues
and should be rewritten.

Change-Id: I1a1fd683b5733bff1841703dcd7be99688b66c54
Signed-off-by:

config_parser: Add parser warnings

This makes it possible to determine if the file had formatting issues
and should be rewritten.

Change-Id: I1a1fd683b5733bff1841703dcd7be99688b66c54
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Rewrite file parsing logic

This grealty improves the correctness of the config parser to
better match the way systemd parses config files. It also allows us to
provide errors / warnin

config_parser: Rewrite file parsing logic

This grealty improves the correctness of the config parser to
better match the way systemd parses config files. It also allows us to
provide errors / warnings when the file format doesn't match
expectations.

Tested: On an existing BMC system to verify NTP / DHCP settings were
still parsed as expected.

Change-Id: I1f0cb631f680f5957a29accaa749d491e6f68faf
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Add performance measuring test code

Disabled by default for CI performance, but it always compiles in order
to prevent staleness.

Change-Id: I8a981404e19892bdd710cb7db53941c510285ee5

config_parser: Add performance measuring test code

Disabled by default for CI performance, but it always compiles in order
to prevent staleness.

Change-Id: I8a981404e19892bdd710cb7db53941c510285ee5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

config_parser: Cleanups and modern c++ standards

This was exposing many functions and semantics that are unused by the
application. The goal is to simplify the interface and convert to using
types l

config_parser: Cleanups and modern c++ standards

This was exposing many functions and semantics that are unused by the
application. The goal is to simplify the interface and convert to using
types like `string_view` and referenceable lists where possible.

Change-Id: I4cba6326f9a96a943d384165e656f8589f931959
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: Always create unique tmpdirs

This ensures our tests always have clear temporary directories to store
their files.

Change-Id: Ib755c4a9407b1e1925b34ae1537eb234542133b0
Signed-off-by: William A

test: Always create unique tmpdirs

This ensures our tests always have clear temporary directories to store
their files.

Change-Id: Ib755c4a9407b1e1925b34ae1537eb234542133b0
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: use system-first search for dbus interfaces

Use system-first search for inclusion of dbus interface headers.

Change-Id: I9953ca047c09c1003c86b1ffaf929698c157139c
Signed-off-by: Patrick Ventur

test: use system-first search for dbus interfaces

Use system-first search for inclusion of dbus interface headers.

Change-Id: I9953ca047c09c1003c86b1ffaf929698c157139c
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

clang-format: Update to match docs repo

Update the .clang-format file and run clang-format-6.0.
This .clang-format matches the example one in
https://github.com/openbmc/docs/blob/master/cpp-style-an

clang-format: Update to match docs repo

Update the .clang-format file and run clang-format-6.0.
This .clang-format matches the example one in
https://github.com/openbmc/docs/blob/master/cpp-style-and-conventions.md#clang-formatting

Change-Id: Ia331c9a5b040e1a3c45a0ebf1b8d776d93b05ae5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Reduce journal logs

Presently the code was creating the elog during reading of
the values from the config parser which creates
the journal log internally("Internal error Occured")

Apart from creati

Reduce journal logs

Presently the code was creating the elog during reading of
the values from the config parser which creates
the journal log internally("Internal error Occured")

Apart from creating elog,Code also logs into the journal
more descriptive message saying which section and key
was not found.

The code which catches the exception that also logs
into the journal.

In the changed approach instead of throwing exception
we are returning the return code as not finding a section
or key in the network config file is not an error.

Change-Id: Ib89a3af6541fdf93fb5fa9a8e583d6c6ed88da79
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...

Implement the INI config parser

Parse the systemd.network file
to get the configuration parameter.

Change-Id: Ic9c15a46158d2f1c0948e6eca729663e87051491
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.c

Implement the INI config parser

Parse the systemd.network file
to get the configuration parameter.

Change-Id: Ic9c15a46158d2f1c0948e6eca729663e87051491
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>

show more ...