clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I335e0c726360eaae85b9b54c16b5dcbe4a3f182e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Handle InvalidArgument error for hostname

Systemd throws InvalidArgument error for hostname with special
characters.

This commit handles InvalidArgument error.

Tested By:
verified by passing hostn

Handle InvalidArgument error for hostname

Systemd throws InvalidArgument error for hostname with special
characters.

This commit handles InvalidArgument error.

Tested By:
verified by passing hostname with special char

Change-Id: I732ce9705044d45a25c05f0164bfa5e47e03f025
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ief40c08041429a57684a6debd84eecea2a298dff
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia4966a0790437eb0fc011c747f3be2a52884e4d8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

logging: switch networkd static_library to lg2

This commit switches logging to lg2 in the following files -
1. src/dhcp_configuration.cpp
2. src/dhcp_configuration.cpp
3. src/ipaddress.cpp
4. src/sy

logging: switch networkd static_library to lg2

This commit switches logging to lg2 in the following files -
1. src/dhcp_configuration.cpp
2. src/dhcp_configuration.cpp
3. src/ipaddress.cpp
4. src/system_configuration.cpp
5. src/system_queries.cpp

Tested: Build passes with "ninja -C build".

Change-Id: I492c7579c968810b783836b652e450ff89b8cd4b
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

treewide: Codify memory pinning

This enforces movability constraints.

Change-Id: I49dbd43a791c1d70eb7e97f30708231c053901d9
Signed-off-by: William A. Kennington III <wak@google.com>

system_configuration: Fix new hostname updates

This allows changes outside of phosphor-networkd to be processed and
handled correctly.

Change-Id: I0bb8e90fe502a6d69f451a45cfecbee1bc89eb66
Signed-of

system_configuration: Fix new hostname updates

This allows changes outside of phosphor-networkd to be processed and
handled correctly.

Change-Id: I0bb8e90fe502a6d69f451a45cfecbee1bc89eb66
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

treewide: Cleanup signal emission

Don't emit properties changed prior to interfaces added.

Change-Id: I7f88b8052a323ca49ce9f16fe446596213e3fdb5
Signed-off-by: William A. Kennington III <wak@google.

treewide: Cleanup signal emission

Don't emit properties changed prior to interfaces added.

Change-Id: I7f88b8052a323ca49ce9f16fe446596213e3fdb5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

treewide: Clean up string parameters

Change-Id: I0d3ea6a83465181d3edec1587ff824103489072e
Signed-off-by: William A. Kennington III <wak@google.com>

treewide: Cleanup unused includes

Change-Id: Ied2a0d97d2c31dc2b370452768a7f41d9ecf07f3
Signed-off-by: William A. Kennington III <wak@google.com>

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ief1b330c4f623ecc1be771f36083780a12260834

show more ...

Remove gateway properties in SystemConfiguration

Now default gateway are per-interface properties, the system-wide one
in the SystemConfiguration interface is deprecated. Updating the value
also mak

Remove gateway properties in SystemConfiguration

Now default gateway are per-interface properties, the system-wide one
in the SystemConfiguration interface is deprecated. Updating the value
also makes no difference, it will never be written to configuration.
This patch removes the code of initializing and updating them.

Change #52785 removes the properties in phosphor-dbus-interfaces yaml,
it is recommended to be merged after this change.

Tested:
In SystemConfiguration interface, DefaultGateway and DefaultGateway6 are
still there, but writing them only updates the displayed value on DBus.
No code in phosphor-networkd is called.

Change-Id: I58ac52c5318943941dcc92abede7763bddbca596
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Change-Id: I2e7ce5e279d65d101e1249f2b41f126143d3f03d
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

routing_table: Deduplicate rebuilds

We don't need to rebuild the routing table for every single interface
and system configuration object. It now only rebuilds the table once
every refresh of the ob

routing_table: Deduplicate rebuilds

We don't need to rebuild the routing table for every single interface
and system configuration object. It now only rebuilds the table once
every refresh of the object tree.

Change-Id: I6cc1cfa1ee6ad17307e3e9c7a2eaa352675ba7e8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Convert all systemd-networkd service restarts to reloads

This removes all of the current invocations of managed service
restarting, and instead opts for targeted reloading of
configuration files.

I

Convert all systemd-networkd service restarts to reloads

This removes all of the current invocations of managed service
restarting, and instead opts for targeted reloading of
configuration files.

It also happens to fix some bugs around NIC enabled setting, as the
systemd-networkd service now has up to date runtime configurations at
the time that objects are refreshed.

Change-Id: I64cd4f3fcd66eb2ad23b973eb86a71606e528e37
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I69bd31eba7b09cf49a3a2cdce94c978b1ce3fa4d

show more ...

build: Split c++ sources into a subdirectory

Change-Id: Iedea50c688189ae4953195105e323f7173d17a4b
Signed-off-by: William A. Kennington III <wak@google.com>